Passed
Pull Request — master (#204)
by
unknown
23:41
created
lib/org/openpsa/relatedto/plugin.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -106,7 +106,8 @@
 block discarded – undo
106 106
     {
107 107
         $ret = ['org_openpsa_relatedto' => []];
108 108
         foreach ($array as $rel) {
109
-            if (!midcom::get()->dbfactory->is_a($rel, org_openpsa_relatedto_dba::class)) { //Matches also 'org_openpsa_relatedto'
109
+            if (!midcom::get()->dbfactory->is_a($rel, org_openpsa_relatedto_dba::class)) {
110
+//Matches also 'org_openpsa_relatedto'
110 111
                 //Wrong type of object found in array, cruelly abort the whole procedure
111 112
                 return false;
112 113
             }
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@
 block discarded – undo
31 31
      */
32 32
     public static function create($from_obj, $from_component, $to_obj, $to_component, $status = null, array $extra = [])
33 33
     {
34
-        if (   !is_object($from_obj)
34
+        if (!is_object($from_obj)
35 35
             || !is_object($to_obj)) {
36 36
             return false;
37 37
         }
Please login to merge, or discard this patch.
lib/org/openpsa/core/siteconfig.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -174,7 +174,7 @@
 block discarded – undo
174 174
         }
175 175
         if (!midcom::get()->auth->admin) {
176 176
             $user_id = midcom::get()->auth->acl->get_user_id();
177
-            if (   !$this->data[$type . '_guid']
177
+            if (!$this->data[$type . '_guid']
178 178
                 || !midcom::get()->auth->acl->can_do_byguid('midgard:read', $this->data[$type . '_guid'], midcom_db_topic::class, $user_id)) {
179 179
                 return null;
180 180
             }
Please login to merge, or discard this patch.
lib/org/openpsa/widgets/ui.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -39,8 +39,8 @@  discard block
 block discarded – undo
39 39
             $config = array_merge($defaults, $config);
40 40
 
41 41
             $node_url = $siteconfig->get_node_full_url($component);
42
-            if (   $node_url
43
-                && (   !$user_id
42
+            if ($node_url
43
+                && (!$user_id
44 44
                     || midcom::get()->auth->acl->can_do_byguid('midgard:read', $siteconfig->get_node_guid($component), midcom_db_topic::class, $user_id))) {
45 45
                 $providers[] = [
46 46
                     'placeholder' => midcom::get()->i18n->get_string('search title', $component),
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
         echo '<div id="tabs">';
116 116
         echo "\n<ul>\n";
117 117
         foreach ($tabdata as $key => $tab) {
118
-            echo "<li><a id='key_" . $key ."' class='tabs_link' href='" . $prefix . $tab['url'] . "' ><span> " . $tab['title'] . "</span></a></li>";
118
+            echo "<li><a id='key_" . $key . "' class='tabs_link' href='" . $prefix . $tab['url'] . "' ><span> " . $tab['title'] . "</span></a></li>";
119 119
         }
120 120
         echo "\n</ul>\n";
121 121
         echo "</div>\n";
Please login to merge, or discard this patch.
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -103,12 +103,12 @@
 block discarded – undo
103 103
         if (!empty($guid)) {
104 104
             //pass the urls & titles for the tabs
105 105
             $tabdata[] = [
106
-               'url' => '__mfa/org.openpsa.relatedto/journalentry/' . $guid . '/',
107
-               'title' => midcom::get()->i18n->get_string('journal entries', 'org.openpsa.relatedto'),
106
+                'url' => '__mfa/org.openpsa.relatedto/journalentry/' . $guid . '/',
107
+                'title' => midcom::get()->i18n->get_string('journal entries', 'org.openpsa.relatedto'),
108 108
             ];
109 109
             $tabdata[] = [
110
-               'url' => '__mfa/org.openpsa.relatedto/render/' . $guid . '/both/',
111
-               'title' => midcom::get()->i18n->get_string('related objects', 'org.openpsa.relatedto'),
110
+                'url' => '__mfa/org.openpsa.relatedto/render/' . $guid . '/both/',
111
+                'title' => midcom::get()->i18n->get_string('related objects', 'org.openpsa.relatedto'),
112 112
             ];
113 113
         }
114 114
 
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/plugin.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
         }
147 147
         $data['default_mode'] = 'view';
148 148
 
149
-        if (   !self::get_preference('edit_mode')
149
+        if (!self::get_preference('edit_mode')
150 150
             && midcom_baseclasses_components_configuration::get('midgard.admin.asgard', 'config')->get('edit_mode') == 1) {
151 151
             $data['default_mode'] = 'edit';
152 152
         } elseif (self::get_preference('edit_mode') == 1) {
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
 
186 186
         $parent = $object->get_parent();
187 187
 
188
-        if (   is_a($object, midcom_db_parameter::class)
188
+        if (is_a($object, midcom_db_parameter::class)
189 189
             && !empty($parent->guid)) {
190 190
             // Add "parameters" list to breadcrumb if we're in a param
191 191
             $breadcrumb[] = [
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
         }
196 196
 
197 197
         $i = 0;
198
-        while (   !empty($parent->guid)
198
+        while (!empty($parent->guid)
199 199
                && $i < 10) {
200 200
             $i++;
201 201
             $parent_reflector = midcom_helper_reflector::get($parent);
Please login to merge, or discard this patch.
lib/midgard/admin/user/style/midgard-admin-user-group-folders.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,8 @@
 block discarded – undo
20 20
                 if (!is_a($object, midcom_db_topic::class)) {
21 21
                     continue;
22 22
                 }
23
-            } catch (midcom_error $e) {
23
+            }
24
+            catch (midcom_error $e) {
24 25
                 continue;
25 26
             }
26 27
             echo "<tr>\n";
Please login to merge, or discard this patch.
lib/org/openpsa/products/viewer.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -32,11 +32,11 @@
 block discarded – undo
32 32
         $object = $dm->get_storage()->get_value();
33 33
 
34 34
         $document = $indexer->new_document($dm);
35
-        if (   $config->get('enable_scheduling')
35
+        if ($config->get('enable_scheduling')
36 36
             && is_a($object, org_openpsa_products_product_dba::class)) {
37 37
             // Check start/end for products
38
-            if (   $object->start > time()
39
-                || (   $object->end != 0
38
+            if ($object->start > time()
39
+                || ($object->end != 0
40 40
                     && $object->end < time())) {
41 41
                 // Not in market, remove from index
42 42
                 $indexer->delete($document->RI);
Please login to merge, or discard this patch.
lib/org/openpsa/reports/viewer.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -103,7 +103,8 @@
 block discarded – undo
103 103
             try {
104 104
                 midcom_db_topic::get_cached($node_guid);
105 105
                 $available_generators[$component] = midcom::get()->i18n->get_string($component, $component);
106
-            } catch (midcom_error $e) {
106
+            }
107
+            catch (midcom_error $e) {
107 108
                 debug_add("topic for component '{$component}' not found or accessible");
108 109
             }
109 110
         }
Please login to merge, or discard this patch.
lib/net/nehmer/comments/handler.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@
 block discarded – undo
17 17
     {
18 18
         $toolbar = new midcom_helper_toolbar();
19 19
         $buttons = [];
20
-        if (   midcom::get()->auth->user
20
+        if (midcom::get()->auth->user
21 21
             && $comment->status < net_nehmer_comments_comment::MODERATED) {
22 22
             if (!$comment->can_do('net.nehmer.comments:moderation')) {
23 23
                 // Regular users can only report abuse
Please login to merge, or discard this patch.
lib/net/nemein/wiki/handler/create.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -76,7 +76,8 @@
 block discarded – undo
76 76
             } else {
77 77
                 try {
78 78
                     $this->initialize_index_article($topic);
79
-                } catch (midcom_error $e) {
79
+                }
80
+                catch (midcom_error $e) {
80 81
                     // Could not create index
81 82
                     $topic->delete();
82 83
                     throw $e;
Please login to merge, or discard this patch.