Passed
Pull Request — master (#204)
by
unknown
23:41
created
lib/org/openpsa/reports/style/projects_report-basic-header.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@
 block discarded – undo
23 23
                         <th><?php echo $data['l10n']->get('type'); ?></th>
24 24
 <?php
25 25
         }   ?>
26
-<?php   if (   array_key_exists('invoiceable_filter', $query_data)) {
26
+<?php   if (array_key_exists('invoiceable_filter', $query_data)) {
27 27
             ?>
28 28
                         <th><?php echo midcom::get()->i18n->get_string('invoiceable', 'org.openpsa.projects'); ?></th>
29 29
 <?php
Please login to merge, or discard this patch.
lib/org/openpsa/sales/handler/deliverable/admin.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@
 block discarded – undo
40 40
         $at_entries = $mc->get_related_objects();
41 41
 
42 42
         if (empty($at_entries)) {
43
-            if (   (   $this->_deliverable->continuous
43
+            if (($this->_deliverable->continuous
44 44
                     || $this->_deliverable->end > time())
45 45
                 && $this->_deliverable->state == org_openpsa_sales_salesproject_deliverable_dba::STATE_STARTED) {
46 46
                 $schema->get_field('next_cycle')['hidden'] = false;
Please login to merge, or discard this patch.
lib/org/openpsa/contacts/person.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
 
44 44
     public function __construct($identifier = null)
45 45
     {
46
-        if (   midcom::get()->config->get('person_class') != 'midgard_person'
46
+        if (midcom::get()->config->get('person_class') != 'midgard_person'
47 47
             && midcom::get()->config->get('person_class') != 'openpsa_person') {
48 48
             $this->__mgdschema_class_name__ = midcom::get()->config->get('person_class');
49 49
         }
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
 
53 53
     public function __set($name, $value)
54 54
     {
55
-        if (   $name == 'homepage'
55
+        if ($name == 'homepage'
56 56
             && !empty($value)
57 57
             && $value != $this->homepage) {
58 58
             $this->_register_prober = true;
Please login to merge, or discard this patch.
lib/midcom/helper/reflector/copy.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -278,7 +278,7 @@  discard block
 block discarded – undo
278 278
         }
279 279
 
280 280
         // Override requested root object properties
281
-        if (   !empty($this->target->guid)
281
+        if (!empty($this->target->guid)
282 282
             && $target->guid === $this->target->guid) {
283 283
             foreach ($this->root_object_values as $name => $value) {
284 284
                 $target->$name = $value;
@@ -320,7 +320,7 @@  discard block
 block discarded – undo
320 320
             return false;
321 321
         }
322 322
 
323
-        if (   !$this->_copy_data('parameters', $source, $target)
323
+        if (!$this->_copy_data('parameters', $source, $target)
324 324
             || !$this->_copy_data('metadata', $source, $target)
325 325
             || !$this->_copy_data('attachments', $source, $target)
326 326
             || !$this->_copy_data('privileges', $source, $target)) {
@@ -342,7 +342,7 @@  discard block
 block discarded – undo
342 342
     {
343 343
         if ($this->$type) {
344 344
             $method = 'copy_' . $type;
345
-            if (   !$this->$method($source, $target)
345
+            if (!$this->$method($source, $target)
346 346
                 && $this->halt_on_errors) {
347 347
                 $this->errors[] = $this->_l10n->get('failed to copy ' . $type);
348 348
                 return false;
Please login to merge, or discard this patch.
src/midcom/workflow/delete.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@
 block discarded – undo
88 88
             ])
89 89
             ->setRequired('object')
90 90
             ->setAllowedTypes('object', midcom_core_dbaobject::class)
91
-            ->setNormalizer('label', function ($options, $value) {
91
+            ->setNormalizer('label', function($options, $value) {
92 92
                 if ($value === null) {
93 93
                     return midcom_helper_reflector::get_object_title($options['object']);
94 94
                 }
Please login to merge, or discard this patch.
src/midcom/datamanager/extension/transformer/imageTransformer.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@
 block discarded – undo
36 36
         }
37 37
         $result = [];
38 38
 
39
-        if (   !empty($array['file'])
39
+        if (!empty($array['file'])
40 40
             || !empty($array['identifier']) && substr($array['identifier'], 0, 8) === 'tmpfile-') {
41 41
             $result['file'] = parent::reverseTransform($array);
42 42
         } elseif (!empty($array['objects'])) {
Please login to merge, or discard this patch.
src/midcom/datamanager/extension/transformer/attachmentTransformer.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
             return null;
31 31
         }
32 32
 
33
-        if (! $input instanceof midcom_db_attachment) {
33
+        if (!$input instanceof midcom_db_attachment) {
34 34
             throw new UnexpectedTypeException($input, midcom_db_attachment::class);
35 35
         }
36 36
 
Please login to merge, or discard this patch.
src/midcom/datamanager/schema.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
             'customdata' => []
161 161
         ], $config));
162 162
 
163
-        $normalize_widget = function (Options $options, $value) {
163
+        $normalize_widget = function(Options $options, $value) {
164 164
             if ($value == 'text') {
165 165
                 if (!empty($options['widget_config']['hideinput'])) {
166 166
                     return PasswordType::class;
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
             return $value;
186 186
         };
187 187
 
188
-        $normalize_storage = function (Options $options, $value) use ($name) {
188
+        $normalize_storage = function(Options $options, $value) use ($name) {
189 189
             $default = [
190 190
                 'location' => 'parameter',
191 191
                 'domain' => 'midcom.helper.datamanager2',
@@ -227,7 +227,7 @@  discard block
 block discarded – undo
227 227
             return $value;
228 228
         };
229 229
 
230
-        $normalize_validation = function (Options $options, $value) {
230
+        $normalize_validation = function(Options $options, $value) {
231 231
             $validation = [];
232 232
 
233 233
             foreach ((array) $value as $key => $rule) {
@@ -239,7 +239,7 @@  discard block
 block discarded – undo
239 239
                     $rule = ['type' => $rule];
240 240
                 } elseif (!array_key_exists('type', $rule)) {
241 241
                     throw new midcom_error("Missing validation rule type for rule {$key} on field {$options['name']}, this is a required option.");
242
-                } elseif (   $rule['type'] == 'compare'
242
+                } elseif ($rule['type'] == 'compare'
243 243
                           && !array_key_exists('compare_with', $rule)) {
244 244
                     throw new midcom_error("Missing compare_with option for compare type rule {$key} on field {$options['name']}, this is a required option.");
245 245
                 }
Please login to merge, or discard this patch.
src/midcom/datamanager/extension/type/jsdateType.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
                 'later_than' => null
49 49
             ]
50 50
         ]);
51
-        $resolver->setNormalizer('widget_config', function (Options $options, $value) {
51
+        $resolver->setNormalizer('widget_config', function(Options $options, $value) {
52 52
             $widget_defaults = [
53 53
                 'showOn' => 'both',
54 54
                 'format' => '%Y-%m-%d %H:%M',
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
             ];
60 60
             return helper::normalize($widget_defaults, $value);
61 61
         });
62
-        $resolver->setNormalizer('constraints', function (Options $options, $value) {
62
+        $resolver->setNormalizer('constraints', function(Options $options, $value) {
63 63
             if ($options['type_config']['later_than']) {
64 64
                 $value[] = new laterthan($options['type_config']['later_than']);
65 65
             }
Please login to merge, or discard this patch.