flack / openpsa

web/rootfile.php

Spacing +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
     include dirname(__DIR__) . '/config-default.inc.php';
 }
 
-if (! defined('MIDCOM_STATIC_URL')) {
+if (!defined('MIDCOM_STATIC_URL')) {
     define('MIDCOM_STATIC_URL', '/midcom-static');
 }
 

lib/org/openpsa/invoices/billing/data.php

Braces +6 added lines, -3 removed lines

@@ -77,7 +77,8 @@ 
             // if the property useContactAddress is set
             $billing_data[0]->set_address();
             return $billing_data[0];
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
             return false;
         }
@@ -122,10 +123,12 @@ 
     {
         try {
             return new org_openpsa_contacts_person_dba($this->linkGuid);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             try {
                 return new org_openpsa_contacts_group_dba($this->linkGuid);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 debug_add("Failed to load contact with GUID: " . $this->linkGuid . " - last error:" . $e->getMessage(), MIDCOM_LOG_ERROR);
                 return false;
             }

Indentation +1 added lines, -1 removed lines

@@ -61,7 +61,7 @@
     public static function get_by_object(org_openpsa_invoices_interfaces_customer $object) : self
     {
         if (   !($bd = self::get_billing_data(org_openpsa_contacts_group_dba::class, $object->customer))
-               // check if the customerContact is set and has invoice_data
+                // check if the customerContact is set and has invoice_data
             && !($bd = self::get_billing_data(org_openpsa_contacts_person_dba::class, $object->customerContact))) {
             $bd = new self();
             $due = midcom_baseclasses_components_configuration::get('org.openpsa.invoices', 'config')->get('default_due_days');

Spacing +1 added lines, -1 removed lines

@@ -60,7 +60,7 @@
      */
     public static function get_by_object(org_openpsa_invoices_interfaces_customer $object) : self
     {
-        if (   !($bd = self::get_billing_data(org_openpsa_contacts_group_dba::class, $object->customer))
+        if (!($bd = self::get_billing_data(org_openpsa_contacts_group_dba::class, $object->customer))
                // check if the customerContact is set and has invoice_data
             && !($bd = self::get_billing_data(org_openpsa_contacts_person_dba::class, $object->customerContact))) {
             $bd = new self();

lib/org/openpsa/invoices/handler/invoice/action.php

Braces +2 added lines, -1 removed lines

@@ -48,7 +48,8 @@
         try {
             $pdf_helper->render_and_attach();
             return $this->reply(true, $this->_l10n->get('pdf created'));
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             return $this->reply(false, $this->_l10n->get('pdf creation failed') . ': ' . $e->getMessage());
         }
     }

lib/org/openpsa/calendar/event/member.php

Braces +2 added lines, -1 removed lines

@@ -152,7 +152,8 @@
                 debug_add('person #' . $person->id . 'has no email address, aborting');
                 return false;
             }
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             return false;
         }
 

Spacing +5 added lines, -5 removed lines

@@ -68,7 +68,7 @@ 
             $event = new org_openpsa_calendar_event_dba($this->eid);
         }
 
-        if (    $recipient->id == midcom_connection::get_user()
+        if ($recipient->id == midcom_connection::get_user()
              && !$event->send_notify_me) {
             //Do not send notification to current user
             debug_add('event->send_notify_me is false and recipient is current user, aborting notify');
@@ -203,12 +203,12 @@ 
             $workday_starts = 8;
             $workday_ends = 16;
 
-            $workday_starts_ts = mktime($workday_starts, 0, 0, (int)$ymd_matches[2], (int)$ymd_matches[3], (int)$ymd_matches[1]);
-            $workday_ends_ts = mktime($workday_ends, 0, 0, (int)$ymd_matches[2], (int)$ymd_matches[3], (int)$ymd_matches[1]);
+            $workday_starts_ts = mktime($workday_starts, 0, 0, (int) $ymd_matches[2], (int) $ymd_matches[3], (int) $ymd_matches[1]);
+            $workday_ends_ts = mktime($workday_ends, 0, 0, (int) $ymd_matches[2], (int) $ymd_matches[3], (int) $ymd_matches[1]);
             $last_end_time = false;
             $last_event = false;
             foreach ($events as $event) {
-                if (   $event->end <= $workday_starts_ts
+                if ($event->end <= $workday_starts_ts
                     || $event->start >= $workday_ends_ts) {
                     // We need not to consider this event, it is outside the defined workday
                     continue;
@@ -238,7 +238,7 @@ 
             if ($last_end_time === false) {
                 $last_end_time = $workday_starts_ts;
             }
-            if (   $last_end_time < $workday_ends_ts
+            if ($last_end_time < $workday_ends_ts
                 && (($workday_ends_ts - $last_end_time) >= $amount)) {
                 $slots[] = self::_create_slot($last_end_time, $workday_ends_ts, $last_event);
             }

lib/midcom/core/query.php

Spacing +2 added lines, -2 removed lines

@@ -128,7 +128,7 @@ 
 
     protected function _add_visibility_checks()
     {
-        if (   $this->hide_invisible
+        if ($this->hide_invisible
             && !$this->_visibility_checks_added) {
             if (!midcom::get()->config->get('show_hidden_objects')) {
                 $this->add_constraint('metadata.hidden', '=', false);
@@ -194,7 +194,7 @@ 
         // Deal with empty arrays, which would produce invalid queries
         // This is done here to avoid repetitive code in callers, and because
         // it's easy enough to generalize: IN empty set => always false, NOT IN empty set => always true
-        if (   is_array($value)
+        if (is_array($value)
             && empty($value)) {
             if ($operator == 'NOT IN') {
                 return true;

lib/midcom/core/querybuilder.php

Spacing +2 added lines, -2 removed lines

@@ -105,7 +105,7 @@ 
 
         $this->_add_visibility_checks();
 
-        if (   empty($this->_limit)
+        if (empty($this->_limit)
             && empty($this->_offset)) {
             // No point to do windowing
             $newresult = $this->_execute_and_check_privileges();
@@ -150,7 +150,7 @@ 
         }
         $this->_query->set_limit($window_size);
 
-        while (    ($resultset = $this->_execute_and_check_privileges())
+        while (($resultset = $this->_execute_and_check_privileges())
                 || $this->denied > $denied) {
             $size = count($resultset);
             $total_size = $size + ($this->denied - $denied);

Braces +2 added lines, -1 removed lines

@@ -57,7 +57,8 @@
             $classname = $this->_real_class;
             try {
                 $result[] = new $classname($object);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 if ($e->getCode() == MIDCOM_ERRFORBIDDEN) {
                     $this->denied++;
                 }

lib/net/nemein/rss/manage.php

Braces +2 added lines, -1 removed lines

@@ -25,7 +25,8 @@
     {
         try {
             $viewer->register_plugin_namespace('__feeds', ['rss' => ['class' => __CLASS__]]);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
         }
     }

lib/net/nehmer/blog/navigation.php

Spacing +6 added lines, -6 removed lines

@@ -41,7 +41,7 @@ 
 
         // Hide the articles that have the publish time in the future and if
         // the user is not administrator
-        if (   $this->_config->get('enable_scheduled_publishing')
+        if ($this->_config->get('enable_scheduled_publishing')
             && !midcom::get()->auth->admin) {
             // Show the article only if the publishing time has passed or the viewer
             // is the author
@@ -83,14 +83,14 @@ 
 
     private function _add_pseudo_leaves(array &$leaves)
     {
-        if (   $this->_config->get('archive_enable')
+        if ($this->_config->get('archive_enable')
             && $this->_config->get('archive_in_navigation')) {
             $leaves["{$this->_topic->id}_ARCHIVE"] = [
                 MIDCOM_NAV_URL => "archive/",
                 MIDCOM_NAV_NAME => $this->_l10n->get('archive'),
             ];
         }
-        if (   $this->_config->get('rss_enable')
+        if ($this->_config->get('rss_enable')
             && $this->_config->get('feeds_in_navigation')) {
             $leaves[self::LEAFID_FEEDS] = [
                 MIDCOM_NAV_URL => "feeds/",
@@ -98,7 +98,7 @@ 
             ];
         }
 
-        if (   $this->_config->get('categories_in_navigation')
+        if ($this->_config->get('categories_in_navigation')
             && $this->_config->get('categories') != '') {
             $categories = explode(',', $this->_config->get('categories'));
             foreach ($categories as $category) {
@@ -109,14 +109,14 @@ 
             }
         }
 
-        if (   $this->_config->get('archive_years_in_navigation')
+        if ($this->_config->get('archive_years_in_navigation')
             && $this->_config->get('archive_years_enable')) {
             $qb = midcom_db_article::new_query_builder();
             $qb->add_constraint('topic', '=', $this->_topic->id);
 
             // Hide the articles that have the publish time in the future and if
             // the user is not administrator
-            if (   $this->_config->get('enable_scheduled_publishing')
+            if ($this->_config->get('enable_scheduled_publishing')
                 && !midcom::get()->auth->admin) {
                 // Show the article only if the publishing time has passed or the viewer
                 // is the author

lib/net/nehmer/static/viewer.php

Spacing +1 added lines, -1 removed lines

@@ -73,7 +73,7 @@
             }
         }
 
-        if (   $this->_topic->can_do('midgard:update')
+        if ($this->_topic->can_do('midgard:update')
             && $this->_topic->can_do('midcom:component_config')) {
             $buttons[] = $workflow->get_button('config/', [
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n_midcom->get('component configuration'),