flack / openpsa

lib/org/openpsa/contacts/handler/person/view.php

Braces +2 added lines, -1 removed lines

@@ -192,7 +192,8 @@
         foreach ($this->$identifier as $member) {
             try {
                 $this->_request_data['group'] = org_openpsa_contacts_group_dba::get_cached($member->gid);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
                 continue;
             }

Spacing +3 added lines, -3 removed lines

@@ -105,7 +105,7 @@ 
         $invoices_url = $siteconfig->get_node_full_url('org.openpsa.invoices');
         $user_url = $siteconfig->get_node_full_url('org.openpsa.user');
 
-        if (   $invoices_url
+        if ($invoices_url
             && midcom::get()->auth->can_user_do('midgard:create', null, org_openpsa_invoices_invoice_dba::class)
             && $this->_contact->can_do('midgard:update')) {
             $buttons[] = $workflow->get_button($invoices_url . "billingdata/" . $this->_contact->guid . '/', [
@@ -114,8 +114,8 @@ 
             ]);
         }
 
-        if (   $user_url
-            && (   midcom::get()->auth->user->guid == $this->_contact->guid
+        if ($user_url
+            && (midcom::get()->auth->user->guid == $this->_contact->guid
                 || midcom::get()->auth->can_user_do('org.openpsa.user:access', null, org_openpsa_user_interface::class))) {
             $buttons[] = [
                 MIDCOM_TOOLBAR_URL => $user_url . "view/{$this->_contact->guid}/",

lib/org/openpsa/directmarketing/handler/message/send.php

Spacing +1 added lines, -1 removed lines

@@ -114,7 +114,7 @@
     {
         $nap = new midcom_helper_nav();
         $node = $nap->get_node($nap->get_current_node());
-        $compose_url = $node[MIDCOM_NAV_RELATIVEURL] . 'message/compose/' . $data['message']->guid .'/';
+        $compose_url = $node[MIDCOM_NAV_RELATIVEURL] . 'message/compose/' . $data['message']->guid . '/';
         $this->batch_url_base_full = $node[MIDCOM_NAV_RELATIVEURL] . 'message/send_bg/' . $data['message']->guid . '/';
         debug_add("compose_url: {$compose_url}");
         debug_add("batch_url base: {$this->batch_url_base_full}");

lib/org/openpsa/contacts/person.php

Spacing +1 added lines, -1 removed lines

@@ -59,7 +59,7 @@
 
     public function __set($name, $value)
     {
-        if (   $name == 'homepage'
+        if ($name == 'homepage'
             && !empty($value)
             && $value != $this->homepage) {
             $this->_register_prober = true;

src/midcom/templating/dbloader.php

Braces +2 added lines, -1 removed lines

@@ -51,7 +51,8 @@
                 if ($root_topic->style) {
                     $scope = midcom_db_style::id_from_path($root_topic->style);
                 }
-            } catch (midcom_error_forbidden $e) {
+            }
+            catch (midcom_error_forbidden $e) {
                 $e->log();
             }
         }

lib/net/nehmer/blog/handler/view.php

Spacing +2 added lines, -2 removed lines

@@ -48,7 +48,7 @@ 
             ]);
         }
 
-        if (   $this->_article->topic === $this->_topic->id
+        if ($this->_article->topic === $this->_topic->id
             && $this->_article->can_do('midgard:delete')) {
             $delete = $this->get_workflow('delete', ['object' => $this->_article]);
             $buttons[] = $delete->get_button("delete/{$this->_article->guid}/");
@@ -83,7 +83,7 @@ 
         if ($this->_config->get('comments_enable')) {
             if ($node = net_nehmer_comments_interface::get_node($this->_topic, $this->_config->get('comments_topic'))) {
                 $data['comments_url'] = $node[MIDCOM_NAV_RELATIVEURL] . "comment/{$this->_article->guid}";
-                if (   $this->_topic->can_do('midgard:update')
+                if ($this->_topic->can_do('midgard:update')
                     && $this->_topic->can_do('net.nehmer.comments:moderation')) {
                     net_nehmer_comments_viewer::add_head_elements();
                 }

lib/errors.php

Spacing +1 added lines, -1 removed lines

@@ -140,7 +140,7 @@
             return;
         }
 
-        if (   !is_writable($config['filename'])
+        if (!is_writable($config['filename'])
             && !is_writable(dirname($config['filename']))) {
             debug_add("Error logging file {$config['filename']} is not writable", MIDCOM_LOG_WARN);
             return;

lib/midcom/admin/folder/handler/move.php

Braces +2 added lines, -1 removed lines

@@ -47,7 +47,8 @@
                 $target = new midcom_db_topic($request->request->getInt('move_to'));
                 $this->_move_object($target);
                 midcom::get()->uimessages->add($this->_l10n->get($this->_component), sprintf($this->_l10n->get('moved %s to %s'), $this->_topic->get_label(), $target->get_label()));
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 midcom::get()->uimessages->add($this->_l10n->get($this->_component), $e->getMessage(), 'error');
             }
         }

Spacing +3 added lines, -3 removed lines

@@ -33,7 +33,7 @@ 
     {
         $this->_object = midcom::get()->dbfactory->get_object_by_guid($guid);
 
-        if (   !($this->_object instanceof midcom_db_topic)
+        if (!($this->_object instanceof midcom_db_topic)
             && !($this->_object instanceof midcom_db_article)) {
             throw new midcom_error_notfound("Moving only topics and articles is supported.");
         }
@@ -74,7 +74,7 @@ 
             $folder = midcom_core_context::get()->get_key(MIDCOM_CONTEXT_ROOTTOPIC);
         }
 
-        if (   $this->_object instanceof midcom_db_topic
+        if ($this->_object instanceof midcom_db_topic
             && $folder->up == $this->_object->id) {
             $tree_disabled = true;
         }
@@ -87,7 +87,7 @@ 
             $selected = ' checked="checked"';
         }
 
-        if (   !($this->_object instanceof midcom_db_topic)
+        if (!($this->_object instanceof midcom_db_topic)
             && $folder->component !== $this->current_folder->component) {
             // Non-topic objects may only be moved under folders of same component
             $class = 'wrong_component';

lib/org/openpsa/user/validator.php

Spacing +3 added lines, -3 removed lines

@@ -47,7 +47,7 @@ 
         $result = $this->is_username_available($fields);
 
         $accounthelper = new org_openpsa_user_accounthelper();
-        if ($fields['password']['switch'] && !$accounthelper->check_password_strength($fields['password']['password'])){
+        if ($fields['password']['switch'] && !$accounthelper->check_password_strength($fields['password']['password'])) {
             $result = ['password' => midcom::get()->i18n->get_string('password weak', 'org.openpsa.user')];
         }
 
@@ -149,10 +149,10 @@ 
         $user = new midcom_db_person($fields["person"]);
 
         $accounthelper = new org_openpsa_user_accounthelper($user);
-        if (!$accounthelper->check_password_reuse($fields['new_password'])){
+        if (!$accounthelper->check_password_reuse($fields['new_password'])) {
             $result['password'] = midcom::get()->i18n->get_string('password was already used', 'org.openpsa.user');
         }
-        if (!$accounthelper->check_password_strength($fields['new_password'])){
+        if (!$accounthelper->check_password_strength($fields['new_password'])) {
             $result['password'] = midcom::get()->i18n->get_string('password weak', 'org.openpsa.user');
         }
         return $result ?: true;

Braces +3 added lines, -3 removed lines

@@ -47,7 +47,7 @@ 
         $result = $this->is_username_available($fields);
 
         $accounthelper = new org_openpsa_user_accounthelper();
-        if ($fields['password']['switch'] && !$accounthelper->check_password_strength($fields['password']['password'])){
+        if ($fields['password']['switch'] && !$accounthelper->check_password_strength($fields['password']['password'])) {
             $result = ['password' => midcom::get()->i18n->get_string('password weak', 'org.openpsa.user')];
         }
 
@@ -149,10 +149,10 @@ 
         $user = new midcom_db_person($fields["person"]);
 
         $accounthelper = new org_openpsa_user_accounthelper($user);
-        if (!$accounthelper->check_password_reuse($fields['new_password'])){
+        if (!$accounthelper->check_password_reuse($fields['new_password'])) {
             $result['password'] = midcom::get()->i18n->get_string('password was already used', 'org.openpsa.user');
         }
-        if (!$accounthelper->check_password_strength($fields['new_password'])){
+        if (!$accounthelper->check_password_strength($fields['new_password'])) {
             $result['password'] = midcom::get()->i18n->get_string('password weak', 'org.openpsa.user');
         }
         return $result ?: true;

lib/org/openpsa/products/product/group.php

Spacing +1 added lines, -1 removed lines

@@ -74,7 +74,7 @@
         }
 
         $result_cache[$cache_key] = [];
-        $ret =& $result_cache[$cache_key];
+        $ret = & $result_cache[$cache_key];
 
         if (empty($up)) {
             // TODO: use reflection to see what kind of property this is ?