flack / openpsa

lib/net/nehmer/static/handler/admin.php

Spacing +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
 
     private function load_controller() : controller
     {
-        if (    $this->_config->get('simple_name_handling')
+        if ($this->_config->get('simple_name_handling')
              && !midcom::get()->auth->admin) {
             foreach ($this->_request_data['schemadb']->all() as $schema) {
                 $schema->get_field('name')['readonly'] = true;

lib/midcom/services/toolbars.php

Spacing +1 added lines, -1 removed lines

@@ -314,7 +314,7 @@
 
     private function add_head_elements(bool $centralized = false) : bool
     {
-        if (   !midcom::get()->auth->user
+        if (!midcom::get()->auth->user
             || !midcom::get()->config->get('toolbars_enable_centralized')
             || !midcom::get()->auth->can_user_do('midcom:centralized_toolbar', null, __CLASS__)) {
             return false;

lib/midcom/services/metadata.php

Spacing +4 added lines, -4 removed lines

@@ -109,20 +109,20 @@ 
         }
 
         // Approval attributes
-        if (   midcom::get()->config->get('metadata_approval')
+        if (midcom::get()->config->get('metadata_approval')
             && !$object->metadata->is_approved()) {
             $css_classes[] = 'unapproved';
         }
 
         // Hiding and scheduling attributes
-        if (   (   !midcom::get()->config->get('show_hidden_objects')
+        if ((!midcom::get()->config->get('show_hidden_objects')
                 || midcom::get()->config->get('metadata_scheduling'))
             && !$object->metadata->is_visible()) {
             $css_classes[] = 'hidden';
         }
 
         // Folder's class
-        if (   $object instanceof midcom_db_topic
+        if ($object instanceof midcom_db_topic
             && $page_class = $object->get_parameter('midcom.services.metadata', 'page_class')) {
             $css_classes[] = $page_class;
         }
@@ -193,7 +193,7 @@ 
     private function _add_opengraph_metadata(midcom_helper_metadata $view_metadata)
     {
         $opengraph_type = $view_metadata->object->get_parameter('midcom.helper.metadata', 'opengraph_type');
-        if (   $opengraph_type
+        if ($opengraph_type
             && $opengraph_type != 'none') {
             $request_metadata = $this->get_request_metadata();
 

lib/midcom/baseclasses/core/dbobject.php

Spacing +4 added lines, -4 removed lines

@@ -133,14 +133,14 @@ 
         if ($parent !== null) {
             // Attachments are a special case
             if ($object instanceof midcom_db_attachment) {
-                if (   !$parent->can_do('midgard:attachments')
+                if (!$parent->can_do('midgard:attachments')
                     || !$parent->can_do('midgard:update')) {
                     debug_add("Failed to create attachment, update or attachments privilege on the parent " . get_class($parent) . " {$parent->guid} not granted for the current user.",
                         MIDCOM_LOG_ERROR);
                     midcom_connection::set_error(MGD_ERR_ACCESS_DENIED);
                     return false;
                 }
-            } elseif (   !$parent->can_do('midgard:create')
+            } elseif (!$parent->can_do('midgard:create')
                       && !midcom::get()->auth->can_user_do('midgard:create', null, get_class($object))) {
                 debug_add("Failed to create object, create privilege on the parent " . get_class($parent) . " {$parent->guid} or the actual object class not granted for the current user.",
                     MIDCOM_LOG_ERROR);
@@ -263,7 +263,7 @@ 
             }
 
             // Default the owner to first group of current user
-            if (   empty($object->metadata->owner)
+            if (empty($object->metadata->owner)
                 && $first_group = midcom::get()->auth->user->get_first_group_guid()) {
                 $object->metadata->set('owner', $first_group);
             }
@@ -720,7 +720,7 @@ 
      */
     public static function get_by_guid(midcom_core_dbaobject $object, string $guid) : bool
     {
-        if (   !midcom::get()->auth->admin
+        if (!midcom::get()->auth->admin
             && !midcom::get()->auth->acl->can_do_byguid('midgard:read', $guid, get_class($object), midcom::get()->auth->acl->get_user_id())) {
             debug_add("Failed to load object, read privilege on the " . get_class($object) . " {$guid} not granted for the current user.", MIDCOM_LOG_ERROR);
             return false;

Braces +2 added lines, -1 removed lines

@@ -673,7 +673,8 @@
          */
         try {
             return $object->get_by_id($object->id);
-        } catch (Exception $e) {
+        }
+        catch (Exception $e) {
             return false;
         }
     }

lib/net/nehmer/comments/handler/admin.php

Spacing +1 added lines, -1 removed lines

@@ -111,7 +111,7 @@
      */
     public function _handler_moderate_ajax(Request $request, string $status, array &$data)
     {
-        if (   !$request->request->has('action')
+        if (!$request->request->has('action')
             || !$request->request->has('guid')) {
             throw new midcom_error_notfound('Incomplete POST data');
         }

lib/org/openpsa/sales/handler/deliverable/add.php

Spacing +1 added lines, -1 removed lines

@@ -86,7 +86,7 @@
      */
     public function _handler_add(Request $request, string $guid, array &$data)
     {
-        if (   !$request->request->has('product')
+        if (!$request->request->has('product')
             && !$request->request->has('org_openpsa_sales')) {
             throw new midcom_error('No product specified, aborting.');
         }

lib/midcom/admin/folder/handler/approvals.php

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
      */
     public function _handler_approval(Request $request, string $handler_id)
     {
-        if (   !$request->request->has('guid')
+        if (!$request->request->has('guid')
             || !$request->request->has('return_to')) {
             throw new midcom_error('Cannot process approval request, request is incomplete.');
         }

lib/midcom/helper/nav/backend.php

Spacing +2 added lines, -2 removed lines

@@ -279,7 +279,7 @@ 
             }
 
             $this->_leaves[$id] = $leaf;
-            $this->_loaded_leaves[$node->id][$id] =& $this->_leaves[$id];
+            $this->_loaded_leaves[$node->id][$id] = & $this->_leaves[$id];
         }
     }
 
@@ -337,7 +337,7 @@ 
                     continue;
                 }
 
-                if (   !$show_noentry
+                if (!$show_noentry
                     && self::$_nodes[$id]->noentry) {
                     // Hide "noentry" items
                     continue;

lib/midcom/core/context.php

Braces +2 added lines, -1 removed lines

@@ -165,7 +165,8 @@
                 try {
                     self::$root_topic = midcom_db_topic::get_cached($guid);
                     return self::$root_topic;
-                } catch (midcom_error $e) {
+                }
+                catch (midcom_error $e) {
                     if ($e instanceof midcom_error_forbidden) {
                         throw $e;
                     }

Spacing +1 added lines, -1 removed lines

@@ -254,7 +254,7 @@
      */
     public function set_custom_key($key, &$value)
     {
-        $this->_data[MIDCOM_CONTEXT_CUSTOMDATA][$key] =& $value;
+        $this->_data[MIDCOM_CONTEXT_CUSTOMDATA][$key] = & $value;
     }
 
     public function show()