Passed
Push — master ( 0ab4bc...d2b377 )
by Andreas
25:09 queued 04:16
created
lib/midcom/helper/reflector/nameresolver.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
         if ($name_property === null) {
37 37
             $name_property = midcom_helper_reflector::get_name_property($this->_object);
38 38
         }
39
-        if (    empty($name_property)
39
+        if (empty($name_property)
40 40
             || !midcom_helper_reflector::get($this->_object)->property_exists($name_property)) {
41 41
             // Could not resolve valid property
42 42
             return null;
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
 
133 133
             $qb->add_constraint($child_name_property, '=', $name);
134 134
             if ($qb->count()) {
135
-                debug_add("Name clash in sibling class {$schema_type} for " . get_class($this->_object) . " #{$this->_object->id} (path '" . midcom_helper_reflector_tree::resolve_path($this->_object, '/') . "')" );
135
+                debug_add("Name clash in sibling class {$schema_type} for " . get_class($this->_object) . " #{$this->_object->id} (path '" . midcom_helper_reflector_tree::resolve_path($this->_object, '/') . "')");
136 136
                 return false;
137 137
             }
138 138
         }
@@ -209,7 +209,7 @@  discard block
 block discarded – undo
209 209
         } while (!$this->name_is_unique());
210 210
 
211 211
         // Get a copy of the current, usable name
212
-        $ret = (string)$this->_object->{$name_prop};
212
+        $ret = (string) $this->_object->{$name_prop};
213 213
         // Restore the original name
214 214
         $this->_object->{$name_prop} = $original_name;
215 215
         return $ret;
Please login to merge, or discard this patch.
lib/midcom/application.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -97,7 +97,7 @@
 block discarded – undo
97 97
             $loader->load($this->getProjectDir() . '/config/services.yml');
98 98
         }
99 99
         if ($classes = midcom::get_registered_service_classes()) {
100
-            $loader->load(function (ContainerBuilder $container) use ($classes) {
100
+            $loader->load(function(ContainerBuilder $container) use ($classes) {
101 101
                 foreach ($classes as $id => $class) {
102 102
                     $container->findDefinition($id)->setClass($class);
103 103
                 }
Please login to merge, or discard this patch.
lib/midcom/helper/style.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -152,7 +152,7 @@
 block discarded – undo
152 152
         $preparsed = midcom_helper_formatter::compile($style);
153 153
 
154 154
         if (midcom_core_context::get()->has_custom_key('request_data')) {
155
-            $data =& midcom_core_context::get()->get_custom_key('request_data');
155
+            $data = & midcom_core_context::get()->get_custom_key('request_data');
156 156
         }
157 157
 
158 158
         try {
Please login to merge, or discard this patch.
src/midcom/templating/loader.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -196,7 +196,7 @@
 block discarded – undo
196 196
 
197 197
     private function resolve_includes(string $content) : string
198 198
     {
199
-        return preg_replace_callback("/<\\(([a-zA-Z0-9 _-]+)\\)>/", function (array $matches) {
199
+        return preg_replace_callback("/<\\(([a-zA-Z0-9 _-]+)\\)>/", function(array $matches) {
200 200
             $element = $matches[1];
201 201
 
202 202
             switch ($element) {
Please login to merge, or discard this patch.
lib/midcom/services/cache/main.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -98,7 +98,7 @@
 block discarded – undo
98 98
     {
99 99
         if (!isset($this->_modules[$name])) {
100 100
             $this->_modules[$name] = $module;
101
-            $this->$name =& $this->_modules[$name];
101
+            $this->$name = & $this->_modules[$name];
102 102
         }
103 103
     }
104 104
 
Please login to merge, or discard this patch.
lib/net/nehmer/comments/comment.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -218,8 +218,8 @@  discard block
 block discarded – undo
218 218
     {
219 219
         $config = midcom_baseclasses_components_configuration::get('net.nehmer.comments', 'config');
220 220
 
221
-        if (   $config->get('ratings_enable')
222
-            && (    $config->get('ratings_cache_to_object')
221
+        if ($config->get('ratings_enable')
222
+            && ($config->get('ratings_cache_to_object')
223 223
                  || $config->get('comment_count_cache_to_object'))) {
224 224
             // Handle ratings
225 225
             $comments = self::list_by_objectguid($this->objectguid);
@@ -268,7 +268,7 @@  discard block
 block discarded – undo
268 268
 
269 269
     private function _send_notifications()
270 270
     {
271
-        if (   empty($this->title)
271
+        if (empty($this->title)
272 272
             && empty($this->content)) {
273 273
             // No need to send notifications about empty rating entries
274 274
             return;
Please login to merge, or discard this patch.
lib/net/nehmer/comments/handler/view.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -98,8 +98,8 @@  discard block
 block discarded – undo
98 98
         if (!$this->_schemadb) {
99 99
             $this->_schemadb = schemadb::from_path($this->_config->get('schemadb'));
100 100
 
101
-            if (   $this->_config->get('use_captcha')
102
-                || (   !midcom::get()->auth->user
101
+            if ($this->_config->get('use_captcha')
102
+                || (!midcom::get()->auth->user
103 103
                     && $this->_config->get('use_captcha_if_anonymous'))) {
104 104
                 $fields = $this->_schemadb->get('comment')->get('fields');
105 105
                 $fields['captcha'] = [
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
                 $this->_schemadb->get('comment')->set('fields', $fields);
113 113
             }
114 114
 
115
-            if (   $this->_config->get('ratings_enable')
115
+            if ($this->_config->get('ratings_enable')
116 116
                 && $this->_schemadb->get('comment')->has_field('rating')) {
117 117
                 $this->_schemadb->get('comment')->get_field('rating')['hidden'] = false;
118 118
             }
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
             $this->_comments = $this->_comments->execute();
192 192
         }
193 193
 
194
-        if (   midcom::get()->auth->user
194
+        if (midcom::get()->auth->user
195 195
             || $this->_config->get('allow_anonymous')) {
196 196
             $this->_init_post_controller($request);
197 197
             if ($response = $this->_process_post($request)) {
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
      */
223 223
     private function _process_post(Request $request)
224 224
     {
225
-        if (   !midcom::get()->auth->user
225
+        if (!midcom::get()->auth->user
226 226
             && !midcom::get()->auth->request_sudo('net.nehmer.comments')) {
227 227
             throw new midcom_error('We were anonymous but could not acquire SUDO privileges, aborting');
228 228
         }
@@ -235,7 +235,7 @@  discard block
 block discarded – undo
235 235
                 }
236 236
 
237 237
                 $formdata = $this->_post_controller->get_form_values();
238
-                if (   $formdata['subscribe']
238
+                if ($formdata['subscribe']
239 239
                     && midcom::get()->auth->user) {
240 240
                     // User wants to subscribe to receive notifications about this comments thread
241 241
 
@@ -269,7 +269,7 @@  discard block
 block discarded – undo
269 269
      */
270 270
     private function _get_last_modified() : int
271 271
     {
272
-        return array_reduce($this->_comments, function ($carry, net_nehmer_comments_comment $item) {
272
+        return array_reduce($this->_comments, function($carry, net_nehmer_comments_comment $item) {
273 273
             return max($item->metadata->revised, $carry);
274 274
         }, 0);
275 275
     }
@@ -291,8 +291,8 @@  discard block
 block discarded – undo
291 291
                 $data['comment_toolbar'] = $this->populate_post_toolbar($comment);
292 292
                 midcom_show_style('comments-item');
293 293
 
294
-                if (   midcom::get()->auth->admin
295
-                    || (   midcom::get()->auth->user
294
+                if (midcom::get()->auth->admin
295
+                    || (midcom::get()->auth->user
296 296
                         && $comment->can_do('midgard:delete'))) {
297 297
                     midcom_show_style('comments-admintoolbar');
298 298
                 }
@@ -302,7 +302,7 @@  discard block
 block discarded – undo
302 302
             midcom_show_style('comments-nonefound');
303 303
         }
304 304
 
305
-        if (   midcom::get()->auth->user
305
+        if (midcom::get()->auth->user
306 306
             || $this->_config->get('allow_anonymous')) {
307 307
             midcom_show_style('post-comment');
308 308
         } else {
Please login to merge, or discard this patch.
lib/net/nehmer/comments/handler/moderate.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@
 block discarded – undo
54 54
         $message['content'] = '';
55 55
         $logs = $comment->get_logs();
56 56
         if (!empty($logs)) {
57
-            $message['content'] .= $this->_l10n->get('moderation history').":\n\n";
57
+            $message['content'] .= $this->_l10n->get('moderation history') . ":\n\n";
58 58
             foreach ($logs as $time => $log) {
59 59
                 $reported = $this->_l10n->get_formatter()->datetime(strtotime("{$time}Z"));
60 60
                 $message['content'] .= $this->_l10n->get(sprintf('%s: %s by %s (from %s)', "$reported:\n", $this->_l10n->get($log['action']), $log['reporter'], $log['ip'])) . "\n\n";
Please login to merge, or discard this patch.
lib/org/openpsa/directmarketing/importer/csv.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -55,11 +55,11 @@
 block discarded – undo
55 55
         foreach (array_filter($csv_line) as $field => $value) {
56 56
             // Process the row accordingly
57 57
             $field_matching = $this->_settings['fields'][$field];
58
-            if (   $field_matching
58
+            if ($field_matching
59 59
                 && strstr($field_matching, ':')) {
60 60
                 [$schemadb, $schema_field] = explode(':', $field_matching);
61 61
 
62
-                if (   !array_key_exists($schemadb, $this->_schemadbs)
62
+                if (!array_key_exists($schemadb, $this->_schemadbs)
63 63
                     || !$this->_schemadbs[$schemadb]->get('default')->has_field($schema_field)) {
64 64
                     // Invalid matching, skip
65 65
                     continue;
Please login to merge, or discard this patch.