Passed
Push — master ( 0ab4bc...d2b377 )
by Andreas
25:09 queued 04:16
created
lib/org/openpsa/directmarketing/handler/import.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -151,7 +151,7 @@  discard block
 block discarded – undo
151 151
         $contacts = $importer->parse($input);
152 152
         if (!empty($contacts)) {
153 153
             $this->_request_data['import_status'] = $importer->import_subscribers($contacts, $this->_request_data['campaign']);
154
-            if (   $this->_request_data['import_status']['subscribed_new'] > 0
154
+            if ($this->_request_data['import_status']['subscribed_new'] > 0
155 155
                 || $this->_request_data['import_status']['already_subscribed'] > 0) {
156 156
                 $this->_import_success = true;
157 157
             }
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
         // Update the breadcrumb line
190 190
         $this->_update_breadcrumb($handler_id, $guid);
191 191
 
192
-        if (   $request->request->has('org_openpsa_directmarketing_import')
192
+        if ($request->request->has('org_openpsa_directmarketing_import')
193 193
             && is_uploaded_file($_FILES['org_openpsa_directmarketing_import_upload']['tmp_name'])) {
194 194
             $importer = new org_openpsa_directmarketing_importer_vcards($this->_schemadbs);
195 195
             $this->_run_import($importer, $_FILES['org_openpsa_directmarketing_import_upload']['tmp_name']);
@@ -244,7 +244,7 @@  discard block
 block discarded – undo
244 244
                 $read_rows = 0;
245 245
                 $handle = fopen($data['tmp_file'], 'r');
246 246
                 $total_columns = 0;
247
-                while (   $read_rows < 2
247
+                while ($read_rows < 2
248 248
                        && $csv_line = fgetcsv($handle, 1000, $data['separator'])) {
249 249
                     if ($total_columns == 0) {
250 250
                         $total_columns = count($csv_line);
Please login to merge, or discard this patch.
lib/org/openpsa/contacts/group.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@
 block discarded – undo
59 59
 
60 60
     public function __set($name, $value)
61 61
     {
62
-        if (   $name == 'homepage'
62
+        if ($name == 'homepage'
63 63
             && !empty($value)
64 64
             && $value != $this->homepage) {
65 65
             $this->_register_prober = true;
Please login to merge, or discard this patch.
src/midcom/datamanager/indexer/document.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
             $this->content .= "{$this->abstract}\n";
135 135
         }
136 136
 
137
-        if (! $this->title) {
137
+        if (!$this->title) {
138 138
             $this->title = $this->document_url;
139 139
         }
140 140
     }
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
                     if (!empty($field->vars['value'])) {
174 174
                         //only index the first attachment for now
175 175
                         $attachment = array_shift($field->vars['value']);
176
-                        if (   !$attachment instanceof \midcom_db_attachment
176
+                        if (!$attachment instanceof \midcom_db_attachment
177 177
                             && !empty($attachment['object'])) {
178 178
                             //This is the form edit case
179 179
                             //@todo: In create case, nothing is found currently
Please login to merge, or discard this patch.
src/midcom/datamanager/extension/transformer/multipleTransformer.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -98,7 +98,7 @@
 block discarded – undo
98 98
 
99 99
     public function reverseTransform($array)
100 100
     {
101
-        if (!is_array($array) ) {
101
+        if (!is_array($array)) {
102 102
             throw new TransformationFailedException('Expected an array.');
103 103
         }
104 104
 
Please login to merge, or discard this patch.
lib/midcom/core/privilege.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
      */
247 247
     public function set_assignee($assignee) : bool
248 248
     {
249
-        if (   is_a($assignee, midcom_core_user::class)
249
+        if (is_a($assignee, midcom_core_user::class)
250 250
             || is_a($assignee, midcom_core_group::class)) {
251 251
             $this->assignee = $assignee->id;
252 252
         } elseif (is_string($assignee)) {
@@ -305,12 +305,12 @@  discard block
 block discarded – undo
305 305
             }
306 306
         }
307 307
 
308
-        if (   !$this->is_magic_assignee()
308
+        if (!$this->is_magic_assignee()
309 309
             && !$this->get_assignee()) {
310 310
             debug_add("The assignee identifier '{$this->assignee}' is invalid.", MIDCOM_LOG_INFO);
311 311
             return false;
312 312
         }
313
-        if (   $this->assignee == 'OWNER'
313
+        if ($this->assignee == 'OWNER'
314 314
             && $this->privilegename == 'midgard:owner') {
315 315
             debug_add("Tried to assign midgard:owner to the OWNER magic assignee, this is invalid.", MIDCOM_LOG_INFO);
316 316
             return false;
@@ -322,7 +322,7 @@  discard block
 block discarded – undo
322 322
                 MIDCOM_LOG_INFO);
323 323
             return false;
324 324
         }
325
-        if (   !$object->can_do('midgard:update')
325
+        if (!$object->can_do('midgard:update')
326 326
             || !$object->can_do('midgard:privileges')) {
327 327
             debug_add("Insufficient privileges on the content object with the GUID '{$this->__guid}', midgard:update and midgard:privileges required.",
328 328
                 MIDCOM_LOG_INFO);
Please login to merge, or discard this patch.
src/midcom/grid/provider.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -239,7 +239,7 @@  discard block
 block discarded – undo
239 239
 
240 240
     private function _convert_to_localdata() : string
241 241
     {
242
-        return "var " . $this->_grid->get_identifier() . '_entries = ' .  json_encode($this->get_rows()) . ";\n";
242
+        return "var " . $this->_grid->get_identifier() . '_entries = ' . json_encode($this->get_rows()) . ";\n";
243 243
     }
244 244
 
245 245
     private function _render_json()
@@ -272,7 +272,7 @@  discard block
 block discarded – undo
272 272
             $this->_sort_field = $query['sidx'];
273 273
             $this->_sort_direction = strtoupper($query['sord']);
274 274
         }
275
-        if (   !empty($query['_search'])
275
+        if (!empty($query['_search'])
276 276
             && $query['_search'] === 'true') {
277 277
             foreach ($query as $field => $value) {
278 278
                 if (in_array($field, ['_search', 'nd', 'page', 'rows', 'sidx', 'sord'])) {
@@ -297,7 +297,7 @@  discard block
 block discarded – undo
297 297
 
298 298
         $this->_total_rows = $qb->count();
299 299
 
300
-        if (   $this->_datatype == 'json'
300
+        if ($this->_datatype == 'json'
301 301
             && !empty($this->_results_per_page)) {
302 302
             $qb->set_limit($this->_results_per_page);
303 303
             if (!empty($this->_offset)) {
Please login to merge, or discard this patch.
src/midcom/datamanager/storage/blobs.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -143,7 +143,7 @@
 block discarded – undo
143 143
     protected function save_attachment_list() : bool
144 144
     {
145 145
         if (!empty($this->config['widget_config']['sortable'])) {
146
-            uasort($this->map, function ($a, $b) {
146
+            uasort($this->map, function($a, $b) {
147 147
                 if ($a->metadata->score == $b->metadata->score) {
148 148
                     return strnatcasecmp($a->name, $b->name);
149 149
                 }
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/toolbar.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
             ];
148 148
         }
149 149
 
150
-        if (   midcom::get()->config->get('midcom_services_rcs_enable')
150
+        if (midcom::get()->config->get('midcom_services_rcs_enable')
151 151
             && $object->can_do('midgard:update')
152 152
             && $object->_use_rcs) {
153 153
             $buttons[] = [
@@ -208,7 +208,7 @@  discard block
 block discarded – undo
208 208
     private function get_toolbar_update_items($object) : array
209 209
     {
210 210
         $buttons = [];
211
-        if (   is_a($object, midcom_db_topic::class)
211
+        if (is_a($object, midcom_db_topic::class)
212 212
             && $object->component
213 213
             && $object->can_do('midcom:component_config')) {
214 214
             $buttons[] = [
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
             MIDCOM_TOOLBAR_ENABLED => $object->can_do('midgard:privileges'),
247 247
         ];
248 248
 
249
-        if (   midcom::get()->componentloader->is_installed('midcom.helper.replicator')
249
+        if (midcom::get()->componentloader->is_installed('midcom.helper.replicator')
250 250
             && midcom::get()->auth->admin) {
251 251
             $buttons[] = [
252 252
                 MIDCOM_TOOLBAR_URL => "__mfa/asgard_midcom.helper.replicator/object/{$object->guid}/",
Please login to merge, or discard this patch.
lib/net/nehmer/blog/viewer.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
             net_nemein_rss_manage::add_toolbar_buttons($this->_node_toolbar, $this->_topic->can_do('midgard:create'));
85 85
         }
86 86
 
87
-        if (   $this->_topic->can_do('midgard:update')
87
+        if ($this->_topic->can_do('midgard:update')
88 88
             && $this->_topic->can_do('midcom:component_config')) {
89 89
             $buttons[] = $workflow->get_button('config/', [
90 90
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n_midcom->get('component configuration'),
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
             $this->_request_data['categories'] = explode(',', $this->_config->get('categories'));
115 115
 
116 116
             foreach ($this->_request_data['schemadb']->all() as $schema) {
117
-                if (   $schema->has_field('categories')
117
+                if ($schema->has_field('categories')
118 118
                     && $schema->get_field('categories')['type'] == 'select') {
119 119
                     // TODO: Merge schema local and component config categories?
120 120
                     $options = array_combine($this->_request_data['categories'], $this->_request_data['categories']);
Please login to merge, or discard this patch.