Passed
Push — master ( 0ab4bc...d2b377 )
by Andreas
25:09 queued 04:16
created
lib/org/openpsa/calendar/conflictmanager.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
         }
126 126
         // TODO: Shared tasks need a separate check (different member object)
127 127
 
128
-        if (   !empty($this->busy_members)
128
+        if (!empty($this->busy_members)
129 129
             || !empty($this->busy_resources)) {
130 130
             //Unresolved conflicts (note return value is for conflicts not lack of them)
131 131
             midcom::get()->auth->drop_sudo();
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
         }
189 189
 
190 190
         if (array_key_exists($member->event, $modified_events)) {
191
-            $event =& $modified_events[$member->event];
191
+            $event = & $modified_events[$member->event];
192 192
             $set_as_modified = false;
193 193
         } else {
194 194
             try {
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
         }
203 203
         debug_add("overlap found in event {$event->title} (#{$event->id})");
204 204
 
205
-        if (   $event->tentative
205
+        if ($event->tentative
206 206
             && $rob_tentative) {
207 207
             debug_add('event is tentative, robbing resources');
208 208
             $event->resources = array_diff_key($event->resources, $this->_event->resources);
@@ -229,7 +229,7 @@  discard block
 block discarded – undo
229 229
         }
230 230
         debug_add("overlap found in event {$event->title} (#{$event->id})");
231 231
 
232
-        if (   $event->tentative
232
+        if ($event->tentative
233 233
             && $rob_tentative) {
234 234
             debug_add('event is tentative, robbing participants');
235 235
             $event->participants = array_diff_key($event->participants, $this->_event->participants);
Please login to merge, or discard this patch.
lib/org/openpsa/notifications/main.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -102,7 +102,7 @@
 block discarded – undo
102 102
 
103 103
         // If user has preference for this message, we use that
104 104
         $personal_preferences = $recipient->list_parameters('org.openpsa.notifications');
105
-        if (   !empty($personal_preferences)
105
+        if (!empty($personal_preferences)
106 106
             && array_key_exists("{$component}:{$action}", $personal_preferences)) {
107 107
             return $personal_preferences[$action];
108 108
         }
Please login to merge, or discard this patch.
lib/org/openpsa/projects/project.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -249,7 +249,7 @@
 block discarded – undo
249 249
             $new_status = $this->_find_status($this->_status_map[$this->status_type], $status_types);
250 250
         }
251 251
 
252
-        if (   $new_status !== null
252
+        if ($new_status !== null
253 253
             && $this->status != $new_status) {
254 254
             $this->status = $new_status;
255 255
             $update_required = true;
Please login to merge, or discard this patch.
lib/midcom/baseclasses/components/handler/dataexport.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
         foreach ($this->_datamanagers as $type => $datamanager) {
128 128
             foreach ($datamanager->get_schema($this->schemas[$type])->get('fields') as $name => $config) {
129 129
                 $title = $config['title'];
130
-                if (   $this->include_totals
130
+                if ($this->include_totals
131 131
                     && $config['type'] == 'number') {
132 132
                     $this->_totals[$type . '-' . $name] = 0;
133 133
                 }
@@ -194,18 +194,18 @@  discard block
 block discarded – undo
194 194
                     $data = array_pad($data, $target_size, '');
195 195
                     continue;
196 196
                 }
197
-                $object =& $row[$type];
197
+                $object = & $row[$type];
198 198
 
199 199
                 $datamanager->set_storage($object, $this->schemas[$type]);
200 200
 
201
-                if (   $this->include_guid
201
+                if ($this->include_guid
202 202
                     && $type == $first_type) {
203 203
                     $data[] = $object->guid;
204 204
                 }
205 205
 
206 206
                 $csvdata = $datamanager->get_content_csv();
207 207
                 foreach ($datamanager->get_schema()->get('fields') as $fieldname => $config) {
208
-                    if (   $this->include_totals
208
+                    if ($this->include_totals
209 209
                         && $config['type'] == 'number') {
210 210
                         $this->_totals[$type . '-' . $fieldname] += $csvdata[$fieldname];
211 211
                     }
@@ -233,7 +233,7 @@  discard block
 block discarded – undo
233 233
         if (empty($this->csv['charset'])) {
234 234
             // Default to ISO-LATIN-15 (Latin-1 with EURO sign etc)
235 235
             $this->csv['charset'] = 'ISO-8859-15';
236
-            if (   isset($_SERVER['HTTP_USER_AGENT'])
236
+            if (isset($_SERVER['HTTP_USER_AGENT'])
237 237
                 && !preg_match('/Windows/i', $_SERVER['HTTP_USER_AGENT'])) {
238 238
                 // Except when not on windows, then default to UTF-8
239 239
                 $this->csv['charset'] = 'UTF-8';
Please login to merge, or discard this patch.
src/midcom/httpkernel/subscriber.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@
 block discarded – undo
100 100
         foreach ($arguments as $i => $argument) {
101 101
             if ($argument === '__request_data__') {
102 102
                 $context = $event->getRequest()->attributes->get('context');
103
-                $arguments[$i] =& $context->get_custom_key('request_data');
103
+                $arguments[$i] = & $context->get_custom_key('request_data');
104 104
             }
105 105
         }
106 106
         $event->setArguments($arguments);
Please login to merge, or discard this patch.
lib/midcom/connection.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -261,7 +261,7 @@
 block discarded – undo
261 261
             if ($part === '') {
262 262
                 continue;
263 263
             }
264
-            if (    midcom::get()->config->get('theme')
264
+            if (midcom::get()->config->get('theme')
265 265
                  && !$args_started
266 266
                  && self::check_page_exists($part)) {
267 267
                 $page_style .= '/' . $part;
Please login to merge, or discard this patch.
lib/midcom/services/uimessages.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -162,7 +162,7 @@
 block discarded – undo
162 162
         if (!$this->_message_stack) {
163 163
             return;
164 164
         }
165
-        if (   $show_simple
165
+        if ($show_simple
166 166
             || !midcom::get()->auth->can_user_do('midcom:ajax', null, static::class)) {
167 167
             $this->show_simple();
168 168
             return;
Please login to merge, or discard this patch.
lib/midcom/admin/help/style/midcom_admin_help_mgdschemas.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@
 block discarded – undo
15 15
 
16 16
         foreach ($properties as $propname => $val) {
17 17
             $description = preg_replace('/ *\n */', "\n", $val['value']);
18
-            if (   $val['link']
18
+            if ($val['link']
19 19
                 && $linked_component = midcom::get()->dbclassloader->get_component_for_class($val['link_name'])) {
20 20
                 $proplink = $data['router']->generate('help', ['component' => $linked_component, 'help_id' => 'mgdschemas']);
21 21
                 $proplink = "<a href='{$proplink}#{$val['link_name']}' title='{$linked_component}/{$val['link_name']}::{$val['link_target']}'>{$val['link_name']}:{$val['link_target']}</a>";
Please login to merge, or discard this patch.
lib/org/openpsa/projects/task.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -110,7 +110,7 @@
 block discarded – undo
110 110
     public function _on_updated()
111 111
     {
112 112
         // Sync the object's ACL properties into MidCOM ACL system
113
-        if (   !$this->_skip_acl_refresh) {
113
+        if (!$this->_skip_acl_refresh) {
114 114
             if ($this->orgOpenpsaAccesstype && $this->orgOpenpsaOwnerWg) {
115 115
                 debug_add("Synchronizing task ACLs to MidCOM");
116 116
                 $sync = new org_openpsa_core_acl_synchronizer();
Please login to merge, or discard this patch.