flack / openpsa

lib/org/openpsa/documents/elFinderVolumeOpenpsa.php

Braces +10 added lines, -5 removed lines

@@ -85,7 +85,8 @@ 
 
         $this->clearcache();
 
-        if ($file && $file['name'] === $name) { // file exists and check filename for item ID based filesystem
+        if ($file && $file['name'] === $name) {
+// file exists and check filename for item ID based filesystem
             if ($this->uploadOverwrite) {
                 if (!$file['write']) {
                     return $this->setError(elFinder::ERROR_PERM_DENIED);
@@ -142,11 +143,13 @@ 
     {
         try {
             return org_openpsa_documents_document_dba::get_cached($path);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
             try {
                 return org_openpsa_documents_directory::get_cached($path);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
         }
@@ -282,7 +285,8 @@ 
         $object = midcom::get()->dbfactory->get_object_by_guid($path);
         try {
             $parentdir = org_openpsa_documents_directory::get_cached($parent);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
             return false;
         }
@@ -579,7 +583,8 @@ 
         try {
             $doc = new org_openpsa_documents_document_dba($path);
             return $doc->delete();
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             return false;
         }
     }

Spacing +7 added lines, -7 removed lines

@@ -67,7 +67,7 @@ 
             return $this->setError(elFinder::ERROR_UPLOAD_FILE_MIME, '(' . $mime . ')');
         }
 
-        $tmpsize = (int)sprintf('%u', filesize($tmpname));
+        $tmpsize = (int) sprintf('%u', filesize($tmpname));
         if ($this->uploadMaxSize > 0 && $tmpsize > $this->uploadMaxSize) {
             return $this->setError(elFinder::ERROR_UPLOAD_FILE_SIZE);
         }
@@ -250,7 +250,7 @@ 
         $output = [$object->get_label()];
 
         $parent = $object->get_parent();
-        while (   $parent
+        while ($parent
                && $parent->component == 'org.openpsa.documents') {
             $output[] = $parent->extra;
             $parent = $parent->get_parent();
@@ -347,12 +347,12 @@ 
             $data['mime'] = 'directory';
         }
 
-        if (   $owner
+        if ($owner
             && $group = midcom::get()->auth->get_assignee($owner)) {
             $data['group'] = $group->name;
         }
 
-        if (   $this->root !== $path
+        if ($this->root !== $path
             && $parent = $object->get_parent()) {
             $data['phash'] = $this->encode($parent->guid);
         }
@@ -411,7 +411,7 @@ 
      * @param  string $mode open mode
      * @return resource|false
      */
-    protected function _fopen($path, $mode="rb")
+    protected function _fopen($path, $mode = "rb")
     {
         $document = org_openpsa_documents_document_dba::get_cached($path);
         $attachments = blobs::get_attachments($document, 'document');
@@ -429,7 +429,7 @@ 
      * @param  string    $path  file path
      * @return bool
      */
-    protected function _fclose($fp, $path='')
+    protected function _fclose($fp, $path = '')
     {
         fclose($fp);
         return true;
@@ -611,7 +611,7 @@ 
     {
         $filename = midcom_db_attachment::safe_filename($name, true);
         $att = $doc->create_attachment($filename, $name, $mimetype);
-        if (   !$att
+        if (!$att
             || !$att->copy_from_handle($fp)) {
             return false;
         }

lib/org/openpsa/reports/style/projects_report-basic-header.php

Spacing +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
                         <th><?php echo $data['l10n']->get('type'); ?></th>
 <?php
         }   ?>
-<?php   if (   array_key_exists('invoiceable_filter', $query_data)) {
+<?php   if (array_key_exists('invoiceable_filter', $query_data)) {
             ?>
                         <th><?php echo midcom::get()->i18n->get_string('invoiceable', 'org.openpsa.projects'); ?></th>
 <?php

lib/org/openpsa/sales/handler/deliverable/admin.php

Spacing +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
         $at_entries = $mc->get_related_objects();
 
         if (empty($at_entries)) {
-            if (   (   $this->_deliverable->continuous
+            if (($this->_deliverable->continuous
                     || $this->_deliverable->end > time())
                 && $this->_deliverable->state == org_openpsa_sales_salesproject_deliverable_dba::STATE_STARTED) {
                 $schema->get_field('next_cycle')['hidden'] = false;

src/midcom/workflow/delete.php

Spacing +1 added lines, -1 removed lines

@@ -88,7 +88,7 @@
             ])
             ->setRequired('object')
             ->setAllowedTypes('object', midcom_core_dbaobject::class)
-            ->setNormalizer('label', function ($options, $value) {
+            ->setNormalizer('label', function($options, $value) {
                 if ($value === null) {
                     return midcom_helper_reflector::get_object_title($options['object']);
                 }

src/midcom/datamanager/extension/transformer/attachmentTransformer.php

Spacing +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
             return null;
         }
 
-        if (! $input instanceof midcom_db_attachment) {
+        if (!$input instanceof midcom_db_attachment) {
             throw new UnexpectedTypeException($input, midcom_db_attachment::class);
         }
 

src/midcom/datamanager/schema.php

Spacing +4 added lines, -4 removed lines

@@ -160,7 +160,7 @@ 
             'customdata' => []
         ], $config));
 
-        $normalize_widget = function (Options $options, $value) {
+        $normalize_widget = function(Options $options, $value) {
             if ($value == 'text') {
                 if (!empty($options['widget_config']['hideinput'])) {
                     return PasswordType::class;
@@ -185,7 +185,7 @@ 
             return $value;
         };
 
-        $normalize_storage = function (Options $options, $value) use ($name) {
+        $normalize_storage = function(Options $options, $value) use ($name) {
             $default = [
                 'location' => 'parameter',
                 'domain' => 'midcom.helper.datamanager2',
@@ -227,7 +227,7 @@ 
             return $value;
         };
 
-        $normalize_validation = function (Options $options, $value) {
+        $normalize_validation = function(Options $options, $value) {
             $validation = [];
 
             foreach ((array) $value as $key => $rule) {
@@ -239,7 +239,7 @@ 
                     $rule = ['type' => $rule];
                 } elseif (!array_key_exists('type', $rule)) {
                     throw new midcom_error("Missing validation rule type for rule {$key} on field {$options['name']}, this is a required option.");
-                } elseif (   $rule['type'] == 'compare'
+                } elseif ($rule['type'] == 'compare'
                           && !array_key_exists('compare_with', $rule)) {
                     throw new midcom_error("Missing compare_with option for compare type rule {$key} on field {$options['name']}, this is a required option.");
                 }

src/midcom/datamanager/extension/type/jsdateType.php

Spacing +2 added lines, -2 removed lines

@@ -48,7 +48,7 @@ 
                 'later_than' => null
             ]
         ]);
-        $resolver->setNormalizer('widget_config', function (Options $options, $value) {
+        $resolver->setNormalizer('widget_config', function(Options $options, $value) {
             $widget_defaults = [
                 'showOn' => 'both',
                 'format' => '%Y-%m-%d %H:%M',
@@ -59,7 +59,7 @@ 
             ];
             return helper::normalize($widget_defaults, $value);
         });
-        $resolver->setNormalizer('constraints', function (Options $options, $value) {
+        $resolver->setNormalizer('constraints', function(Options $options, $value) {
             if ($options['type_config']['later_than']) {
                 $value[] = new laterthan($options['type_config']['later_than']);
             }

src/midcom/datamanager/extension/helper.php

Spacing +1 added lines, -1 removed lines

@@ -16,7 +16,7 @@
     public static function add_normalizers(OptionsResolver $resolver, array $defaults)
     {
         foreach ($defaults as $key => $values) {
-            $resolver->setNormalizer($key, function (Options $options, $value) use ($values) {
+            $resolver->setNormalizer($key, function(Options $options, $value) use ($values) {
                 return self::normalize($values, $value);
             });
         }

src/midcom/datamanager/extension/choicelist/loader.php

Spacing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
             $converted = [];
             foreach ($options as $key => $label) {
                 // symfony expects only strings
-                $converted[(string)$label] = (string)$key;
+                $converted[(string) $label] = (string) $key;
             }
 
             $this->choice_list = new ArrayChoiceList($converted, $value);