flack / openpsa

lib/midcom/helper/_dbfactory.php

Spacing +4 added lines, -4 removed lines

@@ -68,7 +68,7 @@ 
 
             throw new midcom_error_midgard($e, $guid);
         }
-        if (   get_class($tmp) == 'midgard_person'
+        if (get_class($tmp) == 'midgard_person'
             && $this->person_class != 'midgard_person') {
             $tmp = new $this->person_class($guid);
         }
@@ -98,7 +98,7 @@ 
         }
         $object = new $classname($src);
         $cache[$classname][$object->guid] = $object;
-        $cache[$classname][$object->id] =& $cache[$classname][$object->guid];
+        $cache[$classname][$object->id] = & $cache[$classname][$object->guid];
         return $cache[$classname][$object->guid];
     }
 
@@ -145,7 +145,7 @@ 
             return true;
         }
 
-        if (   isset($object->__object)
+        if (isset($object->__object)
             && is_object($object->__object)
             && $object->__object instanceof $class) {
             // Decorator whose MgdSchema object matches
@@ -168,7 +168,7 @@ 
             return $this->get_parent_data_uncached($object);
         });
 
-        if (   empty($parent_guid)
+        if (empty($parent_guid)
             || $parent_guid === $object->guid) {
             return null;
         }

lib/org/openpsa/user/style/show-person-account.php

Spacing +4 added lines, -4 removed lines

@@ -16,7 +16,7 @@ 
             echo '<p>' . sprintf($data['l10n']->get('account blocked %s minutes'), $data['config']->get('password_block_timeframe_min')) . '</p>';
         }
 
-        if (   $data['person']->guid == midcom::get()->auth->user->guid
+        if ($data['person']->guid == midcom::get()->auth->user->guid
             || midcom::get()->auth->can_user_do('org.openpsa.user:manage', null, org_openpsa_user_interface::class)) {
             $workflow = new midcom\workflow\datamanager;
             echo '<ul class="area_toolbar">';
@@ -25,9 +25,9 @@ 
                 'object' => $data['person'],
                 'label' => $data['l10n']->get('account')
             ]);
-            echo '<li><a href="' . $data['router']->generate('account_delete', ['guid' => $data['person']->guid]). '" ' . $workflow->render_attributes() . ' class="button">';
+            echo '<li><a href="' . $data['router']->generate('account_delete', ['guid' => $data['person']->guid]) . '" ' . $workflow->render_attributes() . ' class="button">';
             echo '<span class="toolbar_label">' . $data['l10n_midcom']->get('delete') . '</span></a></li>';
-            if (    midcom::get()->config->get('auth_allow_trusted') === true
+            if (midcom::get()->config->get('auth_allow_trusted') === true
                  && $data['person']->can_do('org.openpsa.user:su')) {
                  echo '<li><a class="button" href="' . $data['router']->generate('account_su', ['guid' => $data['person']->guid]) . '">' . $data['l10n']->get('switch to user') . "</a></li>\n";
             }
@@ -35,7 +35,7 @@ 
         }
     } else {
         echo '<p><span class="metadata">' . $data['l10n']->get("no account") . '</span></p>';
-        if (   $data['person']->guid == midcom::get()->auth->user->guid
+        if ($data['person']->guid == midcom::get()->auth->user->guid
             || midcom::get()->auth->can_user_do('org.openpsa.user:manage', null, org_openpsa_user_interface::class)) {
             $workflow = new midcom\workflow\datamanager;
             echo '<ul class="area_toolbar">';

lib/midgard/admin/asgard/toolbar.php

Spacing +3 added lines, -3 removed lines

@@ -142,7 +142,7 @@ 
             ];
         }
 
-        if (   midcom::get()->config->get('midcom_services_rcs_enable')
+        if (midcom::get()->config->get('midcom_services_rcs_enable')
             && $object->can_do('midgard:update')
             && $object->_use_rcs) {
             $buttons[] = [
@@ -203,7 +203,7 @@ 
     private function get_toolbar_update_items(midcom_core_dbaobject $object) : array
     {
         $buttons = [];
-        if (   $object instanceof midcom_db_topic
+        if ($object instanceof midcom_db_topic
             && $object->component
             && $object->can_do('midcom:component_config')) {
             $buttons[] = [
@@ -241,7 +241,7 @@ 
             MIDCOM_TOOLBAR_ENABLED => $object->can_do('midgard:privileges'),
         ];
 
-        if (   midcom::get()->componentloader->is_installed('midcom.helper.replicator')
+        if (midcom::get()->componentloader->is_installed('midcom.helper.replicator')
             && midcom::get()->auth->admin) {
             $buttons[] = [
                 MIDCOM_TOOLBAR_URL => "__mfa/asgard_midcom.helper.replicator/object/{$object->guid}/",

src/midcom/httpkernel/subscriber.php

Spacing +1 added lines, -1 removed lines

@@ -90,7 +90,7 @@
         $i = array_search('__request_data__', $arguments, true);
         if ($i !== false) {
             $context = $event->getRequest()->attributes->get('context');
-            $arguments[$i] =& $context->get_custom_key('request_data');
+            $arguments[$i] = & $context->get_custom_key('request_data');
             $event->setArguments($arguments);
         }
     }

lib/midcom/baseclasses/components/viewer.php

Spacing +1 added lines, -1 removed lines

@@ -246,7 +246,7 @@
      */
     public function prepare_handler(midcom_baseclasses_components_handler $handler, array &$parameters)
     {
-        $this->parameters =& $parameters;
+        $this->parameters = & $parameters;
 
         $parameters['handler'] = explode('::', $parameters['_controller'], 2);
 

lib/org/openpsa/projects/handler/task/resourcing.php

Spacing +2 added lines, -2 removed lines

@@ -58,7 +58,7 @@ 
             return new midcom_response_relocate($this->router->generate('task_view', ['guid' => $guid]));
         }
 
-        if (   $request->request->has('save')
+        if ($request->request->has('save')
             && $prospects = $request->request->all('org_openpsa_projects_prospects')) {
             $qb = org_openpsa_projects_task_resource_dba::new_query_builder();
             $qb->add_constraint('guid', 'IN', array_keys($prospects));
@@ -89,7 +89,7 @@ 
                     // create relatedto
                     org_openpsa_relatedto_plugin::create($event, 'org.openpsa.calendar', $this->_task, 'org.openpsa.projects');
                 }
-                if (   $update_prospect
+                if ($update_prospect
                     && !$prospect->update()) {
                     debug_add('Failed to update prospect: ' . midcom_connection::get_error_string(), MIDCOM_LOG_ERROR);
                 }

lib/midcom/helper/metadata.php

Spacing +8 added lines, -8 removed lines

@@ -262,7 +262,7 @@ 
     {
         if (in_array($key, $this->field_config['timebased'])) {
             // This is ugly, but seems the only possible way...
-            if (   isset($this->__metadata->$key)
+            if (isset($this->__metadata->$key)
                 && (string) $this->__metadata->$key !== "0001-01-01T00:00:00+00:00") {
                 return (int) $this->__metadata->$key->format('U');
             }
@@ -323,11 +323,11 @@ 
         }
 
         $now = time();
-        if (   $this->get('schedulestart')
+        if ($this->get('schedulestart')
             && $this->get('schedulestart') > $now) {
             return false;
         }
-        if (   $this->get('scheduleend')
+        if ($this->get('scheduleend')
             && $this->get('scheduleend') < $now) {
             return false;
         }
@@ -343,9 +343,9 @@ 
     public function is_object_visible_onsite() : bool
     {
         return
-        (   (   midcom::get()->config->get('show_hidden_objects')
+        ((midcom::get()->config->get('show_hidden_objects')
              || $this->is_visible())
-         && (   midcom::get()->config->get('show_unapproved_objects')
+         && (midcom::get()->config->get('show_unapproved_objects')
              || $this->is_approved())
         );
     }
@@ -402,7 +402,7 @@ 
             $guid = $source;
         }
 
-        if (   $object === null
+        if ($object === null
             && mgd_is_guid($guid)) {
             try {
                 $object = midcom::get()->dbfactory->get_object_by_guid($guid);
@@ -435,7 +435,7 @@ 
         }
 
         // Lock was created by the user, return "not locked"
-        if (   !empty(midcom::get()->auth->user->guid)
+        if (!empty(midcom::get()->auth->user->guid)
             && $this->get('locker') === midcom::get()->auth->user->guid) {
             return false;
         }
@@ -462,7 +462,7 @@ 
      */
     public function can_unlock() : bool
     {
-        return (   $this->__object->can_do('midcom:unlock')
+        return ($this->__object->can_do('midcom:unlock')
                 || midcom::get()->auth->can_user_do('midcom:unlock', null, midcom_services_auth::class));
     }
 

lib/org/openpsa/invoices/scheduler.php

Spacing +2 added lines, -2 removed lines

@@ -95,7 +95,7 @@ 
         }
 
         // TODO: Warehouse management: create new order
-        if (   $this->_deliverable->end < $next_cycle_start
+        if ($this->_deliverable->end < $next_cycle_start
             && $this->_deliverable->end != 0) {
             debug_add('Do not register next cycle, the contract ends before');
             return $this->_deliverable->end_subscription();
@@ -328,7 +328,7 @@ 
         }
 
         //If previous cycle was run at the end of the month, the new one should be at the end of the month as well
-        if (   $date->format('t') == $date->format('j')
+        if ($date->format('t') == $date->format('j')
             && $new_date->format('t') != $new_date->format('j')) {
             $new_date->setDate((int) $new_date->format('Y'), (int) $new_date->format('m'), (int) $new_date->format('t'));
         }

src/midcom/grid/provider.php

Spacing +3 added lines, -3 removed lines

@@ -236,7 +236,7 @@ 
 
     private function _convert_to_localdata() : string
     {
-        return "var " . $this->_grid->get_identifier() . '_entries = ' .  json_encode($this->get_rows()) . ";\n";
+        return "var " . $this->_grid->get_identifier() . '_entries = ' . json_encode($this->get_rows()) . ";\n";
     }
 
     private function _render_json()
@@ -269,7 +269,7 @@ 
             $this->_sort_field = $query['sidx'];
             $this->_sort_direction = strtoupper($query['sord'] ?? 'ASC');
         }
-        if (   !empty($query['_search'])
+        if (!empty($query['_search'])
             && $query['_search'] === 'true') {
             foreach ($query as $field => $value) {
                 if (in_array($field, ['_search', 'nd', 'page', 'rows', 'sidx', 'sord'])) {
@@ -294,7 +294,7 @@ 
 
         $this->_total_rows = $query->count();
 
-        if (   $this->_datatype == 'json'
+        if ($this->_datatype == 'json'
             && !empty($this->_results_per_page)) {
             $query->set_limit($this->_results_per_page);
             if (!empty($this->_offset)) {