Passed
Push — master ( d76e03...3657f2 )
by Andreas
19:39
created
lib/net/nehmer/comments/comment.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -409,7 +409,8 @@
 block discarded – undo
409 409
         //Get the parent object
410 410
         try {
411 411
             $parent = midcom::get()->dbfactory->get_object_by_guid($this->objectguid);
412
-        } catch (midcom_error $e) {
412
+        }
413
+        catch (midcom_error $e) {
413 414
             $e->log();
414 415
             return;
415 416
         }
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -218,8 +218,8 @@  discard block
 block discarded – undo
218 218
     {
219 219
         $config = midcom_baseclasses_components_configuration::get('net.nehmer.comments', 'config');
220 220
 
221
-        if (   $config->get('ratings_enable')
222
-            && (    $config->get('ratings_cache_to_object')
221
+        if ($config->get('ratings_enable')
222
+            && ($config->get('ratings_cache_to_object')
223 223
                  || $config->get('comment_count_cache_to_object'))) {
224 224
             // Handle ratings
225 225
             $comments = self::list_by_objectguid($this->objectguid);
@@ -268,7 +268,7 @@  discard block
 block discarded – undo
268 268
 
269 269
     private function _send_notifications()
270 270
     {
271
-        if (   empty($this->title)
271
+        if (empty($this->title)
272 272
             && empty($this->content)) {
273 273
             // No need to send notifications about empty rating entries
274 274
             return;
Please login to merge, or discard this patch.
lib/net/nehmer/blog/viewer.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
             net_nemein_rss_manage::add_toolbar_buttons($this->_node_toolbar, $this->_topic->can_do('midgard:create'));
85 85
         }
86 86
 
87
-        if (   $this->_topic->can_do('midgard:update')
87
+        if ($this->_topic->can_do('midgard:update')
88 88
             && $this->_topic->can_do('midcom:component_config')) {
89 89
             $buttons[] = $workflow->get_button('config/', [
90 90
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n_midcom->get('component configuration'),
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
             $this->_request_data['categories'] = explode(',', $this->_config->get('categories'));
115 115
 
116 116
             foreach ($this->_request_data['schemadb']->all() as $schema) {
117
-                if (   $schema->has_field('categories')
117
+                if ($schema->has_field('categories')
118 118
                     && $schema->get_field('categories')['type'] == 'select') {
119 119
                     // TODO: Merge schema local and component config categories?
120 120
                     $options = array_combine($this->_request_data['categories'], $this->_request_data['categories']);
Please login to merge, or discard this patch.
lib/org/openpsa/sales/calculator/default.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@
 block discarded – undo
62 62
 
63 63
     private function get_units($units = false) : float
64 64
     {
65
-        if (   $this->_deliverable->invoiceByActualUnits
65
+        if ($this->_deliverable->invoiceByActualUnits
66 66
             || $this->_deliverable->plannedUnits == 0) {
67 67
             // In most cases we calculate the price based on the actual units entered
68 68
             return $units ?: $this->_deliverable->units;
Please login to merge, or discard this patch.
lib/org/openpsa/invoices/billing/data.php 3 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@
 block discarded – undo
61 61
     public static function get_by_object(org_openpsa_invoices_interfaces_customer $object) : self
62 62
     {
63 63
         if (   !($bd = self::get_billing_data(org_openpsa_contacts_group_dba::class, $object->customer))
64
-               // check if the customerContact is set and has invoice_data
64
+                // check if the customerContact is set and has invoice_data
65 65
             && !($bd = self::get_billing_data(org_openpsa_contacts_person_dba::class, $object->customerContact))) {
66 66
             $bd = new self();
67 67
             $due = midcom_baseclasses_components_configuration::get('org.openpsa.invoices', 'config')->get('default_due_days');
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@
 block discarded – undo
60 60
      */
61 61
     public static function get_by_object(org_openpsa_invoices_interfaces_customer $object) : self
62 62
     {
63
-        if (   !($bd = self::get_billing_data(org_openpsa_contacts_group_dba::class, $object->customer))
63
+        if (!($bd = self::get_billing_data(org_openpsa_contacts_group_dba::class, $object->customer))
64 64
                // check if the customerContact is set and has invoice_data
65 65
             && !($bd = self::get_billing_data(org_openpsa_contacts_person_dba::class, $object->customerContact))) {
66 66
             $bd = new self();
Please login to merge, or discard this patch.
Braces   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -96,7 +96,8 @@  discard block
 block discarded – undo
96 96
             // if the property useContactAddress is set
97 97
             $billing_data[0]->set_address();
98 98
             return $billing_data[0];
99
-        } catch (midcom_error $e) {
99
+        }
100
+        catch (midcom_error $e) {
100 101
             $e->log();
101 102
             return null;
102 103
         }
@@ -141,10 +142,12 @@  discard block
 block discarded – undo
141 142
     {
142 143
         try {
143 144
             return new org_openpsa_contacts_person_dba($this->linkGuid);
144
-        } catch (midcom_error $e) {
145
+        }
146
+        catch (midcom_error $e) {
145 147
             try {
146 148
                 return new org_openpsa_contacts_group_dba($this->linkGuid);
147
-            } catch (midcom_error $e) {
149
+            }
150
+            catch (midcom_error $e) {
148 151
                 debug_add("Failed to load contact with GUID: " . $this->linkGuid . " - last error:" . $e->getMessage(), MIDCOM_LOG_ERROR);
149 152
                 return false;
150 153
             }
Please login to merge, or discard this patch.
lib/org/openpsa/projects/task/resource.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -27,12 +27,12 @@
 block discarded – undo
27 27
     private function find_duplicates() : bool
28 28
     {
29 29
         $qb = self::new_query_builder();
30
-        $qb->add_constraint('person', '=', (int)$this->person);
31
-        $qb->add_constraint('task', '=', (int)$this->task);
32
-        $qb->add_constraint('orgOpenpsaObtype', '=', (int)$this->orgOpenpsaObtype);
30
+        $qb->add_constraint('person', '=', (int) $this->person);
31
+        $qb->add_constraint('task', '=', (int) $this->task);
32
+        $qb->add_constraint('orgOpenpsaObtype', '=', (int) $this->orgOpenpsaObtype);
33 33
 
34 34
         if ($this->id) {
35
-            $qb->add_constraint('id', '<>', (int)$this->id);
35
+            $qb->add_constraint('id', '<>', (int) $this->id);
36 36
         }
37 37
 
38 38
         return $qb->count() > 0;
Please login to merge, or discard this patch.
lib/midcom/baseclasses/components/handler/rest.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -197,7 +197,8 @@
 block discarded – undo
197 197
             if ($this->_response === null) {
198 198
                 $this->_stop('Could not handle request, unknown method', 405);
199 199
             }
200
-        } catch (midcom_error $e) {
200
+        }
201
+        catch (midcom_error $e) {
201 202
             $this->_responseStatus = $e->getCode();
202 203
             return $this->_send_response($e->getMessage());
203 204
         }
Please login to merge, or discard this patch.
lib/net/nehmer/static/handler/admin.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
 
27 27
     private function load_controller() : controller
28 28
     {
29
-        if (    $this->_config->get('simple_name_handling')
29
+        if ($this->_config->get('simple_name_handling')
30 30
              && !midcom::get()->auth->admin) {
31 31
             foreach ($this->_request_data['schemadb']->all() as $schema) {
32 32
                 $schema->get_field('name')['readonly'] = true;
Please login to merge, or discard this patch.
lib/midcom/services/toolbars.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -314,7 +314,7 @@
 block discarded – undo
314 314
 
315 315
     private function add_head_elements(bool $centralized = false) : bool
316 316
     {
317
-        if (   !midcom::get()->auth->user
317
+        if (!midcom::get()->auth->user
318 318
             || !midcom::get()->config->get('toolbars_enable_centralized')
319 319
             || !midcom::get()->auth->can_user_do('midcom:centralized_toolbar', null, __CLASS__)) {
320 320
             return false;
Please login to merge, or discard this patch.
lib/midcom/services/metadata.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -109,20 +109,20 @@  discard block
 block discarded – undo
109 109
         }
110 110
 
111 111
         // Approval attributes
112
-        if (   midcom::get()->config->get('metadata_approval')
112
+        if (midcom::get()->config->get('metadata_approval')
113 113
             && !$object->metadata->is_approved()) {
114 114
             $css_classes[] = 'unapproved';
115 115
         }
116 116
 
117 117
         // Hiding and scheduling attributes
118
-        if (   (   !midcom::get()->config->get('show_hidden_objects')
118
+        if ((!midcom::get()->config->get('show_hidden_objects')
119 119
                 || midcom::get()->config->get('metadata_scheduling'))
120 120
             && !$object->metadata->is_visible()) {
121 121
             $css_classes[] = 'hidden';
122 122
         }
123 123
 
124 124
         // Folder's class
125
-        if (   $object instanceof midcom_db_topic
125
+        if ($object instanceof midcom_db_topic
126 126
             && $page_class = $object->get_parameter('midcom.services.metadata', 'page_class')) {
127 127
             $css_classes[] = $page_class;
128 128
         }
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
193 193
     private function _add_opengraph_metadata(midcom_helper_metadata $view_metadata)
194 194
     {
195 195
         $opengraph_type = $view_metadata->object->get_parameter('midcom.helper.metadata', 'opengraph_type');
196
-        if (   $opengraph_type
196
+        if ($opengraph_type
197 197
             && $opengraph_type != 'none') {
198 198
             $request_metadata = $this->get_request_metadata();
199 199
 
Please login to merge, or discard this patch.