Passed
Push — master ( 610387...8b4fac )
by Andreas
36:07 queued 17:03
created

midcom_helper_reflector_tree   F

Complexity

Total Complexity 82

Size/Duplication

Total Lines 476
Duplicated Lines 0 %

Test Coverage

Coverage 63.49%

Importance

Changes 4
Bugs 0 Features 0
Metric Value
eloc 240
c 4
b 0
f 0
dl 0
loc 476
ccs 153
cts 241
cp 0.6349
rs 2
wmc 82

17 Methods

Rating   Name   Duplication   Size   Complexity  
B _root_objects_qb() 0 34 8
A resolve_path() 0 4 1
A _check_permissions() 0 10 4
A resolve_path_parts() 0 24 3
C _child_objects_type_qb() 0 72 15
A get_parent_class() 0 8 2
A add_schema_sorts_to_qb() 0 10 3
A get_child_objects() 0 14 4
A _get_child_objects_type() 0 12 2
A _resolve_child_classes() 0 27 6
A is_link_to_current_class() 0 13 4
B get_tree() 0 33 6
A _get_type_qb() 0 20 4
A get_child_classes() 0 7 2
B _resolve_root_classes() 0 51 9
B _get_link_fields() 0 35 7
A get_root_classes() 0 7 2

How to fix   Complexity   

Complex Class

Complex classes like midcom_helper_reflector_tree often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use midcom_helper_reflector_tree, and based on these observations, apply Extract Interface, too.

1
<?php
2
/**
3
 * @package midcom.helper.reflector
4
 * @author The Midgard Project, http://www.midgard-project.org
5
 * @copyright The Midgard Project, http://www.midgard-project.org
6
 * @license http://www.gnu.org/licenses/lgpl.html GNU Lesser General Public License
7
 */
8
9
/**
10
 * The Grand Unified Reflector, Tree information
11
 *
12
 * @package midcom.helper.reflector
13
 */
14
class midcom_helper_reflector_tree extends midcom_helper_reflector
15
{
16
    /**
17
     * Creates a QB instance for root objects
18
     */
19 5
    public function _root_objects_qb(bool $deleted)
20
    {
21 5
        $schema_type = $this->mgdschema_class;
22 5
        $root_classes = self::get_root_classes();
23 5
        if (!in_array($schema_type, $root_classes)) {
24
            debug_add("Type {$schema_type} is not a \"root\" type", MIDCOM_LOG_ERROR);
25
            return false;
26
        }
27
28 5
        $qb = $this->_get_type_qb($schema_type, $deleted);
0 ignored issues
show
Bug introduced by
It seems like $schema_type can also be of type null; however, parameter $schema_type of midcom_helper_reflector_tree::_get_type_qb() does only seem to accept string, maybe add an additional type check? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

28
        $qb = $this->_get_type_qb(/** @scrutinizer ignore-type */ $schema_type, $deleted);
Loading history...
29 5
        if (!$qb) {
30
            debug_add("Could not get QB for type '{$schema_type}'", MIDCOM_LOG_ERROR);
31
            return false;
32
        }
33
34
        // Figure out constraint to use to get root level objects
35 5
        $upfield = midgard_object_class::get_property_up($schema_type);
0 ignored issues
show
Bug introduced by
It seems like $schema_type can also be of type null; however, parameter $classname of midgard_object_class::get_property_up() does only seem to accept string, maybe add an additional type check? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

35
        $upfield = midgard_object_class::get_property_up(/** @scrutinizer ignore-type */ $schema_type);
Loading history...
36 5
        if (!empty($upfield)) {
37 5
            $uptype = $this->_mgd_reflector->get_midgard_type($upfield);
38 5
            switch ($uptype) {
39
                case MGD_TYPE_STRING:
40
                case MGD_TYPE_GUID:
41
                    $qb->add_constraint($upfield, '=', '');
42
                    break;
43
                case MGD_TYPE_INT:
44
                case MGD_TYPE_UINT:
45 5
                    $qb->add_constraint($upfield, '=', 0);
46 5
                    break;
47
                default:
48
                    debug_add("Do not know how to handle upfield '{$upfield}' has type {$uptype}", MIDCOM_LOG_ERROR);
49
                    return false;
50
            }
51
        }
52 5
        return $qb;
53
    }
54
55
    /**
56
     * Get rendered path for object
57
     *
58
     * @param midgard\portable\api\mgdobject $object The object to get path for
59
     * @param string $separator the string used to separate path components
60
     */
61 1
    public static function resolve_path($object, string $separator = ' &gt; ') : string
62
    {
63 1
        $parts = self::resolve_path_parts($object);
64 1
        return implode($separator, array_column($parts, 'label'));
65
    }
66
67
    /**
68
     * Get path components for object
69
     *
70
     * @param midgard\portable\api\mgdobject $object The object to get path for
71
     */
72 3
    public static function resolve_path_parts($object) : array
73
    {
74 3
        static $cache = [];
75 3
        if (isset($cache[$object->guid])) {
76 1
            return $cache[$object->guid];
77
        }
78
79 2
        $ret = [];
80 2
        $ret[] = [
81 2
            'object' => $object,
82 2
            'label' => parent::get($object)->get_object_label($object),
83
        ];
84
85 2
        $parent = $object->get_parent();
86 2
        while (is_object($parent)) {
87 1
            $ret[] = [
88 1
                'object' => $parent,
89 1
                'label' => parent::get($parent)->get_object_label($parent),
90
            ];
91 1
            $parent = $parent->get_parent();
92
        }
93
94 2
        $cache[$object->guid] = array_reverse($ret);
95 2
        return $cache[$object->guid];
96
    }
97
98 20
    private static function _check_permissions(bool $deleted) : bool
99
    {
100
        // PONDER: Check for some generic user privilege instead  ??
101 20
        if (   $deleted
102 20
            && !midcom_connection::is_admin()
103 20
            && !midcom::get()->auth->is_component_sudo()) {
104
            debug_add('Non-admins are not allowed to list deleted objects', MIDCOM_LOG_ERROR);
105
            return false;
106
        }
107 20
        return true;
108
    }
109
110
    /**
111
     * Get children of given object
112
     *
113
     * @param midgard\portable\api\mgdobject $object object to get children for
114
     * @param boolean $deleted whether to get (only) deleted or not-deleted objects
115
     * @return array multidimensional array (keyed by classname) of objects
116
     */
117 20
    public static function get_child_objects($object, bool $deleted = false) : array
118
    {
119 20
        if (!self::_check_permissions($deleted)) {
120
            return [];
121
        }
122 20
        $resolver = new self($object);
123
124 20
        $child_objects = [];
125 20
        foreach ($resolver->get_child_classes() as $schema_type) {
126 20
            if ($type_children = $resolver->_get_child_objects_type($schema_type, $object, $deleted)) {
127 1
                $child_objects[$schema_type] = $type_children;
128
            }
129
        }
130 20
        return $child_objects;
131
    }
132
133 95
    private function _get_type_qb(string $schema_type, bool $deleted)
134
    {
135 95
        if (empty($schema_type)) {
136
            debug_add('Passed schema_type argument is empty, this is fatal', MIDCOM_LOG_ERROR);
137
            return false;
138
        }
139 95
        if ($deleted) {
140
            $qb = new midgard_query_builder($schema_type);
141
            $qb->include_deleted();
142
            $qb->add_constraint('metadata.deleted', '<>', 0);
143
            return $qb;
144
        }
145
        // Figure correct MidCOM DBA class to use and get midcom QB
146 95
        $midcom_dba_classname = midcom::get()->dbclassloader->get_midcom_class_name_for_mgdschema_object($schema_type);
147 95
        if (empty($midcom_dba_classname)) {
148
            debug_add("MidCOM DBA does not know how to handle {$schema_type}", MIDCOM_LOG_ERROR);
149
            return false;
150
        }
151
152 95
        return $midcom_dba_classname::new_query_builder();
153
    }
154
155
    /**
156
     * Figure out constraint(s) to use to get child objects
157
     */
158 93
    private function _get_link_fields(string $schema_type, $classname) : array
159
    {
160 93
        static $cache = [];
161 93
        $cache_key = $schema_type . '-' . $classname;
162 93
        if (empty($cache[$cache_key])) {
163 6
            $ref = new midgard_reflection_property($schema_type);
164
165
            $linkfields = [
166 6
                'up' => midgard_object_class::get_property_up($schema_type),
167 6
                'parent' => midgard_object_class::get_property_parent($schema_type)
168
            ];
169 6
            $linkfields = array_filter($linkfields);
170 6
            $data = [];
171 6
            foreach ($linkfields as $link_type => $field) {
172
                $info = [
173 6
                    'name' => $field,
174 6
                    'type' => $ref->get_midgard_type($field),
175 6
                    'target' => $ref->get_link_target($field)
176
                ];
177 6
                $linked_class = $ref->get_link_name($field);
178 6
                if (   empty($linked_class)
179 6
                    && $info['type'] === MGD_TYPE_GUID) {
180
                    // Guid link without class specification, valid for all classes
181 6
                    if (empty($info['target'])) {
182 6
                        $info['target'] = 'guid';
183
                    }
184 4
                } elseif (!self::is_same_class($linked_class, $classname)) {
185
                    // This link points elsewhere
186 2
                    continue;
187
                }
188 6
                $data[$link_type] = $info;
189
            }
190 6
            $cache[$cache_key] = $data;
191
        }
192 93
        return $cache[$cache_key];
193
    }
194
195
    /**
196
     * Creates a QB instance for _get_child_objects_type
197
     */
198 93
    public function _child_objects_type_qb(string $schema_type, object $for_object, bool $deleted)
199
    {
200 93
        $qb = $this->_get_type_qb($schema_type, $deleted);
201 93
        if (!$qb) {
202
            debug_add("Could not get QB for type '{$schema_type}'", MIDCOM_LOG_ERROR);
203
            return false;
204
        }
205
206 93
        $linkfields = $this->_get_link_fields($schema_type, get_class($for_object));
207
208 93
        if (empty($linkfields)) {
209
            debug_add("Class '{$schema_type}' has no valid link properties pointing to class '" . get_class($for_object) . "', this should not happen here", MIDCOM_LOG_ERROR);
210
            return false;
211
        }
212
213 93
        $multiple_links = false;
214 93
        if (count($linkfields) > 1) {
215
            $multiple_links = true;
216
            $qb->begin_group('OR');
217
        }
218
219 93
        foreach ($linkfields as $link_type => $field_data) {
220 93
            $field_target = $field_data['target'];
221 93
            $field_type = $field_data['type'];
222 93
            $field = $field_data['name'];
223
224 93
            if (   !$field_target
225 93
                || !isset($for_object->$field_target)) {
226
                // Why return false ???
227
                return false;
228
            }
229 93
            switch ($field_type) {
230
                case MGD_TYPE_STRING:
231
                case MGD_TYPE_GUID:
232 93
                    $qb->add_constraint($field, '=', (string) $for_object->$field_target);
233 93
                    break;
234
                case MGD_TYPE_INT:
235
                case MGD_TYPE_UINT:
236 90
                    if ($link_type == 'up') {
237 90
                        $qb->add_constraint($field, '=', (int) $for_object->$field_target);
238 84
                    } elseif ($link_type == 'parent') {
239 84
                        $up_property = midgard_object_class::get_property_up($schema_type);
240 84
                        if (!empty($up_property)) {
241
                            //we only return direct children (otherwise they would turn up twice in recursive queries)
242 84
                            $qb->begin_group('AND');
243 84
                            $qb->add_constraint($field, '=', (int) $for_object->$field_target);
244 84
                            $qb->add_constraint($up_property, '=', 0);
245 84
                            $qb->end_group();
246
                        } else {
247 84
                            $qb->add_constraint($field, '=', (int) $for_object->$field_target);
248
                        }
249
                    } else {
250
                        $qb->begin_group('AND');
251
                        $qb->add_constraint($field, '=', (int) $for_object->$field_target);
252
                        // make sure we don't accidentally find other objects with the same id
253
                        $qb->add_constraint($field . '.guid', '=', (string) $for_object->guid);
254
                        $qb->end_group();
255
                    }
256 90
                    break;
257
                default:
258
                    debug_add("Do not know how to handle linked field '{$field}', has type {$field_type}", MIDCOM_LOG_INFO);
259
260
                    // Why return false ???
261
                    return false;
262
            }
263
        }
264
265 93
        if ($multiple_links) {
266
            $qb->end_group();
267
        }
268
269 93
        return $qb;
270
    }
271
272
    /**
273
     * Used by get_child_objects
274
     *
275
     * @return array of objects
276
     */
277 20
    public function _get_child_objects_type(string $schema_type, $for_object, bool $deleted) : array
278
    {
279 20
        $qb = $this->_child_objects_type_qb($schema_type, $for_object, $deleted);
280 20
        if (!$qb) {
281
            debug_add('Could not get QB instance', MIDCOM_LOG_ERROR);
282
            return [];
283
        }
284
285
        // Sort by title and name if available
286 20
        self::add_schema_sorts_to_qb($qb, $schema_type);
287
288 20
        return $qb->execute();
289
    }
290
291
    /**
292
     * Get the parent class of the class this reflector was instantiated for
293
     *
294
     * @return string class name (or false if the type has no parent)
295
     */
296 2
    public function get_parent_class() : ?string
297
    {
298 2
        $parent_property = midgard_object_class::get_property_parent($this->mgdschema_class);
0 ignored issues
show
Bug introduced by
It seems like $this->mgdschema_class can also be of type null; however, parameter $classname of midgard_object_class::get_property_parent() does only seem to accept string, maybe add an additional type check? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

298
        $parent_property = midgard_object_class::get_property_parent(/** @scrutinizer ignore-type */ $this->mgdschema_class);
Loading history...
299 2
        if (!$parent_property) {
300 2
            return null;
301
        }
302
        $ref = new midgard_reflection_property($this->mgdschema_class);
303
        return $ref->get_link_name($parent_property);
304
    }
305
306
    /**
307
     * Get the child classes of the class this reflector was instantiated for
308
     */
309 94
    public function get_child_classes() : array
310
    {
311 94
        static $child_classes_all = [];
312 94
        if (!isset($child_classes_all[$this->mgdschema_class])) {
313 4
            $child_classes_all[$this->mgdschema_class] = $this->_resolve_child_classes();
314
        }
315 94
        return $child_classes_all[$this->mgdschema_class];
316
    }
317
318
    /**
319
     * Resolve the child classes of the class this reflector was instantiated for, used by get_child_classes()
320
     */
321 4
    private function _resolve_child_classes() : array
322
    {
323 4
        $child_class_exceptions_neverchild = $this->_config->get('child_class_exceptions_neverchild');
324
325
        // Safety against misconfiguration
326 4
        if (!is_array($child_class_exceptions_neverchild)) {
327
            debug_add("config->get('child_class_exceptions_neverchild') did not return array, invalid configuration ??", MIDCOM_LOG_ERROR);
328
            $child_class_exceptions_neverchild = [];
329
        }
330 4
        $child_classes = [];
331 4
        $types = array_diff(midcom_connection::get_schema_types(), $child_class_exceptions_neverchild);
332 4
        foreach ($types as $schema_type) {
333 4
            $parent_property = midgard_object_class::get_property_parent($schema_type);
334 4
            $up_property = midgard_object_class::get_property_up($schema_type);
335
336 4
            if (   $this->is_link_to_current_class($parent_property, $schema_type)
337 4
                || $this->is_link_to_current_class($up_property, $schema_type)) {
338 4
                $child_classes[] = $schema_type;
339
            }
340
        }
341
342
        //make sure children of the same type come out on top
343 4
        if ($key = array_search($this->mgdschema_class, $child_classes)) {
344 1
            unset($child_classes[$key]);
345 1
            array_unshift($child_classes, $this->mgdschema_class);
346
        }
347 4
        return $child_classes;
348
    }
349
350 4
    private function is_link_to_current_class($property, string $prospect_type) : bool
351
    {
352 4
        if (empty($property)) {
353 4
            return false;
354
        }
355
356 4
        $ref = new midgard_reflection_property($prospect_type);
357 4
        $link_class = $ref->get_link_name($property);
358 4
        if (   empty($link_class)
359 4
            && $ref->get_midgard_type($property) === MGD_TYPE_GUID) {
360 4
            return true;
361
        }
362 4
        return self::is_same_class($link_class, $this->mgdschema_class);
363
    }
364
365
    /**
366
     * Get an array of "root level" classes
367
     */
368 12
    public static function get_root_classes() : array
369
    {
370 12
        static $root_classes = false;
371 12
        if (empty($root_classes)) {
372
            $root_classes = self::_resolve_root_classes();
373
        }
374 12
        return $root_classes;
375
    }
376
377
    /**
378
     * Resolves the "root level" classes, used by get_root_classes()
379
     */
380
    private static function _resolve_root_classes() : array
381
    {
382
        $root_exceptions_notroot = midcom_baseclasses_components_configuration::get('midcom.helper.reflector', 'config')->get('root_class_exceptions_notroot');
383
        // Safety against misconfiguration
384
        if (!is_array($root_exceptions_notroot)) {
385
            debug_add("config->get('root_class_exceptions_notroot') did not return array, invalid configuration ??", MIDCOM_LOG_ERROR);
386
            $root_exceptions_notroot = [];
387
        }
388
        $root_classes = [];
389
        $types = array_diff(midcom_connection::get_schema_types(), $root_exceptions_notroot);
390
        foreach ($types as $schema_type) {
391
            // Class extensions mapping
392
            $schema_type = self::class_rewrite($schema_type);
393
394
            // Make sure we only add classes once
395
            if (in_array($schema_type, $root_classes)) {
396
                // Already listed
397
                continue;
398
            }
399
400
            if (midgard_object_class::get_property_parent($schema_type)) {
401
                // type has parent set, thus cannot be root type
402
                continue;
403
            }
404
405
            if (!midcom::get()->dbclassloader->get_midcom_class_name_for_mgdschema_object($schema_type)) {
406
                // Not a MidCOM DBA object, skip
407
                continue;
408
            }
409
410
            $root_classes[] = $schema_type;
411
        }
412
413
        $root_exceptions_forceroot = midcom_baseclasses_components_configuration::get('midcom.helper.reflector', 'config')->get('root_class_exceptions_forceroot');
414
        // Safety against misconfiguration
415
        if (!is_array($root_exceptions_forceroot)) {
416
            debug_add("config->get('root_class_exceptions_forceroot') did not return array, invalid configuration ??", MIDCOM_LOG_ERROR);
417
            $root_exceptions_forceroot = [];
418
        }
419
        $root_exceptions_forceroot = array_diff($root_exceptions_forceroot, $root_classes);
420
        foreach ($root_exceptions_forceroot as $schema_type) {
421
            if (!class_exists($schema_type)) {
422
                // Not a valid class
423
                debug_add("Type {$schema_type} has been listed to always be root class, but the class does not exist", MIDCOM_LOG_WARN);
424
                continue;
425
            }
426
            $root_classes[] = $schema_type;
427
        }
428
429
        usort($root_classes, 'strnatcmp');
430
        return $root_classes;
431
    }
432
433
    /**
434
     * Add default ("title" and "name") sorts to a QB instance
435
     *
436
     * @param midgard_query_builder $qb QB instance
437
     * @param string $schema_type valid mgdschema class name
438
     */
439 20
    public static function add_schema_sorts_to_qb($qb, string $schema_type)
440
    {
441
        // Sort by "title" and "name" if available
442 20
        $ref = self::get($schema_type);
443 20
        $dummy = new $schema_type();
444 20
        if ($title_property = $ref->get_title_property($dummy)) {
445 20
            $qb->add_order($title_property);
446
        }
447 20
        if ($name_property = $ref->get_name_property($dummy)) {
448 15
            $qb->add_order($name_property);
449
        }
450 20
    }
451
452
    /**
453
     * List object children
454
     *
455
     * @param midcom_core_dbaobject $parent
456
     */
457
    public static function get_tree(midcom_core_dbaobject $parent) : array
458
    {
459
        static $shown_guids = [];
460
        $tree = [];
461
        try {
462
            $children = self::get_child_objects($parent);
0 ignored issues
show
Bug introduced by
$parent of type midcom_core_dbaobject is incompatible with the type midgard\portable\api\mgdobject expected by parameter $object of midcom_helper_reflector_tree::get_child_objects(). ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

462
            $children = self::get_child_objects(/** @scrutinizer ignore-type */ $parent);
Loading history...
463
        } catch (midcom_error $e) {
464
            return $tree;
465
        }
466
467
        foreach ($children as $class => $objects) {
468
            $reflector = parent::get($class);
469
470
            foreach ($objects as $object) {
471
                if (array_key_exists($object->guid, $shown_guids)) {
472
                    //we might see objects twice if they have both up and parent
473
                    continue;
474
                }
475
                $shown_guids[$object->guid] = true;
476
477
                $leaf = [
478
                    'title' => $reflector->get_object_label($object),
479
                    'icon' => $reflector->get_object_icon($object),
480
                    'class' => $class
481
                ];
482
                $grandchildren = self::get_tree($object);
483
                if (!empty($grandchildren)) {
484
                    $leaf['children'] = $grandchildren;
485
                }
486
                $tree[] = $leaf;
487
            }
488
        }
489
        return $tree;
490
    }
491
}
492