Passed
Push — master ( bc24ea...ec5c87 )
by Andreas
26:16
created
lib/org/openpsa/directmarketing/style/show-campaign.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -50,14 +50,14 @@
 block discarded – undo
50 50
     </div>
51 51
 
52 52
     <script type="text/javascript">
53
-    $('#<?php echo $grid->get_identifier();?>').on('click', 'td.delete i', function(event) {
53
+    $('#<?php echo $grid->get_identifier(); ?>').on('click', 'td.delete i', function(event) {
54 54
         var guid = $(event.target).data('person-guid'),
55 55
             member_guid = $(event.target).data('member-guid'),
56 56
             post_data = {org_openpsa_ajax_mode: 'unsubscribe', org_openpsa_ajax_person_guid: guid};
57 57
 
58 58
         $(event.target).removeClass('fa-trash').addClass('fa-spin fa-spinner');
59 59
         $.post('&(node[MIDCOM_NAV_ABSOLUTEURL]);campaign/unsubscribe/ajax/' + member_guid + '/', post_data, function() {
60
-            $('#<?php echo $grid->get_identifier();?>').trigger('reloadGrid');
60
+            $('#<?php echo $grid->get_identifier(); ?>').trigger('reloadGrid');
61 61
             $('#org_openpsa_widgets_contact-' + guid).fadeOut('fast', function() {
62 62
                 $('#org_openpsa_widgets_contact-' + guid).remove();
63 63
             });
Please login to merge, or discard this patch.
src/midcom/datamanager/extension/type/urlnameType.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
      */
23 23
     public function configureOptions(OptionsResolver $resolver)
24 24
     {
25
-        $resolver->setNormalizer('write_privilege', function (Options $options, $value) {
25
+        $resolver->setNormalizer('write_privilege', function(Options $options, $value) {
26 26
             return (array) $value + ['privilege' => 'midcom:urlname'];
27 27
         });
28 28
 
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
             ]
37 37
         ]);
38 38
 
39
-        $resolver->setNormalizer('constraints', function (Options $options, $value) {
39
+        $resolver->setNormalizer('constraints', function(Options $options, $value) {
40 40
             $validator_options = [
41 41
                 'allow_catenate' => $options['type_config']['allow_catenate'],
42 42
                 'allow_unclean' => $options['type_config']['allow_unclean'],
Please login to merge, or discard this patch.
src/midcom/datamanager/storage/container/dbacontainer.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@
 block discarded – undo
36 36
             }
37 37
             $config['name'] = $name;
38 38
             $field = $this->prepare_field($config);
39
-            if (   isset($config['default'])
39
+            if (isset($config['default'])
40 40
                 && (!$this->object->id || $field instanceof transientnode)) {
41 41
                 $field->set_value($config['default']);
42 42
             }
Please login to merge, or discard this patch.
lib/midcom/response/styled.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@
 block discarded – undo
55 55
 
56 56
     private function set_context(midcom_core_context $context)
57 57
     {
58
-        if (   $context->get_key(MIDCOM_CONTEXT_PERMALINKGUID) === null
58
+        if ($context->get_key(MIDCOM_CONTEXT_PERMALINKGUID) === null
59 59
             || $context->get_key(MIDCOM_CONTEXT_PAGETITLE) == '') {
60 60
             // Retrieve Metadata
61 61
             $nav = new midcom_helper_nav();
Please login to merge, or discard this patch.
lib/midcom/baseclasses/core/dbobject.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -673,7 +673,8 @@
 block discarded – undo
673 673
          */
674 674
         try {
675 675
             return $object->get_by_id($object->id);
676
-        } catch (Exception $e) {
676
+        }
677
+        catch (Exception $e) {
677 678
             return false;
678 679
         }
679 680
     }
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -119,14 +119,14 @@  discard block
 block discarded – undo
119 119
         if ($parent = $object->get_parent()) {
120 120
             // Attachments are a special case
121 121
             if ($object instanceof midcom_db_attachment) {
122
-                if (   !$parent->can_do('midgard:attachments')
122
+                if (!$parent->can_do('midgard:attachments')
123 123
                     || !$parent->can_do('midgard:update')) {
124 124
                     debug_add("Failed to create attachment, update or attachments privilege on the parent " . get_class($parent) . " {$parent->guid} not granted for the current user.",
125 125
                         MIDCOM_LOG_ERROR);
126 126
                     midcom_connection::set_error(MGD_ERR_ACCESS_DENIED);
127 127
                     return false;
128 128
                 }
129
-            } elseif (   !$parent->can_do('midgard:create')
129
+            } elseif (!$parent->can_do('midgard:create')
130 130
                       && !midcom::get()->auth->can_user_do('midgard:create', null, get_class($object))) {
131 131
                 debug_add("Failed to create object, create privilege on the parent " . get_class($parent) . " {$parent->guid} or the actual object class not granted for the current user.",
132 132
                     MIDCOM_LOG_ERROR);
@@ -238,7 +238,7 @@  discard block
 block discarded – undo
238 238
             }
239 239
 
240 240
             // Default the owner to first group of current user
241
-            if (   empty($object->metadata->owner)
241
+            if (empty($object->metadata->owner)
242 242
                 && $first_group = midcom::get()->auth->user->get_first_group_guid()) {
243 243
                 $object->metadata->set('owner', $first_group);
244 244
             }
@@ -462,7 +462,7 @@  discard block
 block discarded – undo
462 462
      */
463 463
     public static function get_by_guid(midcom_core_dbaobject $object, string $guid) : bool
464 464
     {
465
-        if (   !midcom::get()->auth->admin
465
+        if (!midcom::get()->auth->admin
466 466
             && !midcom::get()->auth->acl->can_do_byguid('midgard:read', $guid, get_class($object), midcom::get()->auth->acl->get_user_id())) {
467 467
             debug_add("Failed to load object, read privilege on the " . get_class($object) . " {$guid} not granted for the current user.", MIDCOM_LOG_ERROR);
468 468
             return false;
Please login to merge, or discard this patch.
src/midcom/datamanager/validation/imageValidator.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -12,10 +12,10 @@
 block discarded – undo
12 12
 {
13 13
     public function validate($value, Constraint $constraint)
14 14
     {
15
-        if (   empty($value)
15
+        if (empty($value)
16 16
             || !empty($value['delete'])
17
-            || (   empty($value['file'])
18
-                && (   (empty($constraint->config['do_not_save_archival']) && empty($value['archival']))
17
+            || (empty($value['file'])
18
+                && ((empty($constraint->config['do_not_save_archival']) && empty($value['archival']))
19 19
                     || (!empty($constraint->config['do_not_save_archival']) && empty($value['main']))))) {
20 20
             $this->context->buildViolation('This value should not be blank.')
21 21
                 ->addViolation();
Please login to merge, or discard this patch.
lib/org/openpsa/calendar/handler/event/create.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
         if ($query->has('start')) {
46 46
             $defaults['start'] = strtotime(substr($query->get('start'), 0, 19)) + 1;
47 47
             if ($query->has('end')) {
48
-                $defaults['end']= strtotime(substr($query->get('end'), 0, 19));
48
+                $defaults['end'] = strtotime(substr($query->get('end'), 0, 19));
49 49
             } else {
50 50
                 $defaults['end'] = $defaults['start'] + 3600;
51 51
             }
Please login to merge, or discard this patch.
src/midcom/routing/resolver.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -138,7 +138,7 @@
 block discarded – undo
138 138
         $prefix = $this->context->get_key(MIDCOM_CONTEXT_ANCHORPREFIX);
139 139
 
140 140
         // Check if we need to start up a plugin.
141
-        if (   count($argv) > 1
141
+        if (count($argv) > 1
142 142
             && $config = plugin::get_config($argv[0], $argv[1])) {
143 143
             $namespace = array_shift($argv);
144 144
             $name = array_shift($argv);
Please login to merge, or discard this patch.
Braces   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -69,7 +69,8 @@  discard block
 block discarded – undo
69 69
 
70 70
             try {
71 71
                 $result = $router->match($url);
72
-            } catch (ResourceNotFoundException $e) {
72
+            }
73
+            catch (ResourceNotFoundException $e) {
73 74
                 throw new midcom_error_notfound('This URL method is unknown.');
74 75
             }
75 76
             $this->request->attributes->add($result);
@@ -151,11 +152,13 @@  discard block
 block discarded – undo
151 152
 
152 153
         try {
153 154
             $result = $router->match($url);
154
-        } catch (ResourceNotFoundException $e) {
155
+        }
156
+        catch (ResourceNotFoundException $e) {
155 157
             // No match
156 158
             debug_add("Component {$viewer->_component} in {$viewer->_topic->name} declared unable to handle request.", MIDCOM_LOG_INFO);
157 159
             throw new midcom_error_notfound("This page is not available on this server.");
158
-        } catch (MethodNotAllowedException $e) {
160
+        }
161
+        catch (MethodNotAllowedException $e) {
159 162
             debug_add("Component {$viewer->_component} in {$viewer->_topic->name} declared unable to handle request (method not allowed).", MIDCOM_LOG_INFO);
160 163
             throw new midcom_error_forbidden($e->getMessage(), Response::HTTP_METHOD_NOT_ALLOWED);
161 164
         }
Please login to merge, or discard this patch.
src/midcom/console/command/exec.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -80,7 +80,8 @@
 block discarded – undo
80 80
 
81 81
         try {
82 82
             require $basedir . $file;
83
-        } catch (\midcom_error_forbidden $e) {
83
+        }
84
+        catch (\midcom_error_forbidden $e) {
84 85
             $dialog = $this->getHelperSet()->get('question');
85 86
             $this->login($dialog, $input, $output);
86 87
             require $basedir . $file;
Please login to merge, or discard this patch.