flack / openpsa

lib/net/nehmer/blog/viewer.php

Spacing +2 added lines, -2 removed lines

@@ -84,7 +84,7 @@ 
             net_nemein_rss_manage::add_toolbar_buttons($this->_node_toolbar, $this->_topic->can_do('midgard:create'));
         }
 
-        if (   $this->_topic->can_do('midgard:update')
+        if ($this->_topic->can_do('midgard:update')
             && $this->_topic->can_do('midcom:component_config')) {
             $buttons[] = $workflow->get_button('config/', [
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n_midcom->get('component configuration'),
@@ -114,7 +114,7 @@ 
             $this->_request_data['categories'] = explode(',', $this->_config->get('categories'));
 
             foreach ($this->_request_data['schemadb']->all() as $schema) {
-                if (   $schema->has_field('categories')
+                if ($schema->has_field('categories')
                     && $schema->get_field('categories')['type'] == 'select') {
                     // TODO: Merge schema local and component config categories?
                     $options = array_combine($this->_request_data['categories'], $this->_request_data['categories']);

lib/org/openpsa/invoices/billing/data.php

Indentation +1 added lines, -1 removed lines

@@ -61,7 +61,7 @@
     public static function get_by_object(org_openpsa_invoices_interfaces_customer $object) : self
     {
         if (   !($bd = self::get_billing_data(org_openpsa_contacts_group_dba::class, $object->customer))
-               // check if the customerContact is set and has invoice_data
+                // check if the customerContact is set and has invoice_data
             && !($bd = self::get_billing_data(org_openpsa_contacts_person_dba::class, $object->customerContact))) {
             $bd = new self();
             $due = midcom_baseclasses_components_configuration::get('org.openpsa.invoices', 'config')->get('default_due_days');

Spacing +1 added lines, -1 removed lines

@@ -60,7 +60,7 @@
      */
     public static function get_by_object(org_openpsa_invoices_interfaces_customer $object) : self
     {
-        if (   !($bd = self::get_billing_data(org_openpsa_contacts_group_dba::class, $object->customer))
+        if (!($bd = self::get_billing_data(org_openpsa_contacts_group_dba::class, $object->customer))
                // check if the customerContact is set and has invoice_data
             && !($bd = self::get_billing_data(org_openpsa_contacts_person_dba::class, $object->customerContact))) {
             $bd = new self();

Braces +6 added lines, -3 removed lines

@@ -96,7 +96,8 @@ 
             // if the property useContactAddress is set
             $billing_data[0]->set_address();
             return $billing_data[0];
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
             return null;
         }
@@ -141,10 +142,12 @@ 
     {
         try {
             return new org_openpsa_contacts_person_dba($this->linkGuid);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             try {
                 return new org_openpsa_contacts_group_dba($this->linkGuid);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 debug_add("Failed to load contact with GUID: " . $this->linkGuid . " - last error:" . $e->getMessage(), MIDCOM_LOG_ERROR);
                 return false;
             }

lib/net/nehmer/static/handler/admin.php

Spacing +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
 
     private function load_controller() : controller
     {
-        if (    $this->_config->get('simple_name_handling')
+        if ($this->_config->get('simple_name_handling')
              && !midcom::get()->auth->admin) {
             foreach ($this->_request_data['schemadb']->all() as $schema) {
                 $schema->get_field('name')['readonly'] = true;

lib/midcom/services/toolbars.php

Spacing +1 added lines, -1 removed lines

@@ -314,7 +314,7 @@
 
     private function add_head_elements(bool $centralized = false) : bool
     {
-        if (   !midcom::get()->auth->user
+        if (!midcom::get()->auth->user
             || !midcom::get()->config->get('toolbars_enable_centralized')
             || !midcom::get()->auth->can_user_do('midcom:centralized_toolbar', null, __CLASS__)) {
             return false;

lib/midcom/services/metadata.php

Spacing +4 added lines, -4 removed lines

@@ -109,20 +109,20 @@ 
         }
 
         // Approval attributes
-        if (   midcom::get()->config->get('metadata_approval')
+        if (midcom::get()->config->get('metadata_approval')
             && !$object->metadata->is_approved()) {
             $css_classes[] = 'unapproved';
         }
 
         // Hiding and scheduling attributes
-        if (   (   !midcom::get()->config->get('show_hidden_objects')
+        if ((!midcom::get()->config->get('show_hidden_objects')
                 || midcom::get()->config->get('metadata_scheduling'))
             && !$object->metadata->is_visible()) {
             $css_classes[] = 'hidden';
         }
 
         // Folder's class
-        if (   $object instanceof midcom_db_topic
+        if ($object instanceof midcom_db_topic
             && $page_class = $object->get_parameter('midcom.services.metadata', 'page_class')) {
             $css_classes[] = $page_class;
         }
@@ -193,7 +193,7 @@ 
     private function _add_opengraph_metadata(midcom_helper_metadata $view_metadata)
     {
         $opengraph_type = $view_metadata->object->get_parameter('midcom.helper.metadata', 'opengraph_type');
-        if (   $opengraph_type
+        if ($opengraph_type
             && $opengraph_type != 'none') {
             $request_metadata = $this->get_request_metadata();
 

lib/net/nehmer/comments/handler/admin.php

Spacing +1 added lines, -1 removed lines

@@ -111,7 +111,7 @@
      */
     public function _handler_moderate_ajax(Request $request, string $status, array &$data)
     {
-        if (   !$request->request->has('action')
+        if (!$request->request->has('action')
             || !$request->request->has('guid')) {
             throw new midcom_error_notfound('Incomplete POST data');
         }

lib/org/openpsa/sales/handler/deliverable/add.php

Spacing +1 added lines, -1 removed lines

@@ -86,7 +86,7 @@
      */
     public function _handler_add(Request $request, string $guid, array &$data)
     {
-        if (   !$request->request->has('product')
+        if (!$request->request->has('product')
             && !$request->request->has('org_openpsa_sales')) {
             throw new midcom_error('No product specified, aborting.');
         }

lib/midcom/admin/folder/handler/approvals.php

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
      */
     public function _handler_approval(Request $request, string $handler_id)
     {
-        if (   !$request->request->has('guid')
+        if (!$request->request->has('guid')
             || !$request->request->has('return_to')) {
             throw new midcom_error('Cannot process approval request, request is incomplete.');
         }

lib/midcom/helper/nav/backend.php

Spacing +2 added lines, -2 removed lines

@@ -279,7 +279,7 @@ 
             }
 
             $this->_leaves[$id] = $leaf;
-            $this->_loaded_leaves[$node->id][$id] =& $this->_leaves[$id];
+            $this->_loaded_leaves[$node->id][$id] = & $this->_leaves[$id];
         }
     }
 
@@ -337,7 +337,7 @@ 
                     continue;
                 }
 
-                if (   !$show_noentry
+                if (!$show_noentry
                     && self::$_nodes[$id]->noentry) {
                     // Hide "noentry" items
                     continue;