flack / openpsa

web/rootfile.php

Spacing +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
     include dirname(__DIR__) . '/config-default.inc.php';
 }
 
-if (! defined('MIDCOM_STATIC_URL')) {
+if (!defined('MIDCOM_STATIC_URL')) {
     define('MIDCOM_STATIC_URL', '/midcom-static');
 }
 

lib/org/openpsa/invoices/handler/invoice/action.php

Braces +2 added lines, -1 removed lines

@@ -48,7 +48,8 @@
         try {
             $pdf_helper->render_and_attach();
             return $this->reply(true, $this->_l10n->get('pdf created'));
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             return $this->reply(false, $this->_l10n->get('pdf creation failed') . ': ' . $e->getMessage());
         }
     }

lib/midcom/core/querybuilder.php

Spacing +2 added lines, -2 removed lines

@@ -105,7 +105,7 @@ 
 
         $this->_add_visibility_checks();
 
-        if (   empty($this->_limit)
+        if (empty($this->_limit)
             && empty($this->_offset)) {
             // No point to do windowing
             $newresult = $this->_execute_and_check_privileges();
@@ -150,7 +150,7 @@ 
         }
         $this->_query->set_limit($window_size);
 
-        while (    ($resultset = $this->_execute_and_check_privileges())
+        while (($resultset = $this->_execute_and_check_privileges())
                 || $this->denied > $denied) {
             $size = count($resultset);
             $total_size = $size + ($this->denied - $denied);

lib/net/nemein/rss/manage.php

Braces +2 added lines, -1 removed lines

@@ -25,7 +25,8 @@
     {
         try {
             $viewer->register_plugin_namespace('__feeds', ['rss' => ['class' => __CLASS__]]);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
         }
     }

lib/net/nehmer/static/viewer.php

Spacing +1 added lines, -1 removed lines

@@ -73,7 +73,7 @@
             }
         }
 
-        if (   $this->_topic->can_do('midgard:update')
+        if ($this->_topic->can_do('midgard:update')
             && $this->_topic->can_do('midcom:component_config')) {
             $buttons[] = $workflow->get_button('config/', [
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n_midcom->get('component configuration'),

lib/midgard/admin/asgard/stylehelper.php

Indentation +1 added lines, -1 removed lines

@@ -94,7 +94,7 @@
                 'midcom' => [
                     'style-init' => '',
                     'style-finish' => '',
-                 ]
+                    ]
             ],
             'nodes' => [],
         ];

Spacing +5 added lines, -5 removed lines

@@ -22,7 +22,7 @@ 
 
     public function __construct(array &$data)
     {
-        $this->_data =& $data;
+        $this->_data = & $data;
         midcom::get()->head->enable_jquery_ui(['accordion']);
     }
 
@@ -32,14 +32,14 @@ 
             return;
         }
 
-        if (   midcom::get()->dbfactory->is_a($this->_data['object'], 'midgard_style')
-            && (   $this->_data['handler_id'] !== 'object_create'
+        if (midcom::get()->dbfactory->is_a($this->_data['object'], 'midgard_style')
+            && ($this->_data['handler_id'] !== 'object_create'
                 || $this->_data['current_type'] == 'midgard_element')) {
             // Suggest element names to create under a style
             $this->_data['help_style_elementnames'] = $this->_get_style_elements_and_nodes($this->_data['object']->id);
             midcom_show_style('midgard_admin_asgard_stylehelper_elementnames');
 
-        } elseif (   midcom::get()->dbfactory->is_a($this->_data['object'], 'midgard_element')
+        } elseif (midcom::get()->dbfactory->is_a($this->_data['object'], 'midgard_element')
                   && $this->_get_help_element()) {
             midcom_show_style('midgard_admin_asgard_stylehelper_element');
         }
@@ -47,7 +47,7 @@ 
 
     private function _get_help_element() : bool
     {
-        if (   empty($this->_data['object']->name)
+        if (empty($this->_data['object']->name)
             || empty($this->_data['object']->style)) {
             // We cannot help with empty elements
             return false;

lib/midcom/helper/toolbar/view.php

Spacing +2 added lines, -2 removed lines

@@ -54,7 +54,7 @@ 
             ]);
         }
 
-        if (   midcom::get()->config->get('midcom_services_rcs_enable')
+        if (midcom::get()->config->get('midcom_services_rcs_enable')
             && $object->can_do('midgard:update')
             && $object->_use_rcs) {
             $buttons[] = [
@@ -84,7 +84,7 @@ 
             }
 
             $icon = 'stock-icons/16x16/page-' . $icontype . '.png';
-            if (   !midcom::get()->config->get('show_hidden_objects')
+            if (!midcom::get()->config->get('show_hidden_objects')
                 && !$object->metadata->is_visible()) {
                 // Take scheduling into account
                 $icon = 'stock-icons/16x16/page-' . $icontype . '-notpublished.png';

lib/org/openpsa/reports/handler/projects/report.php

Braces +2 added lines, -1 removed lines

@@ -123,7 +123,8 @@
             $row = [];
             try {
                 $row['person'] = org_openpsa_contacts_person_dba::get_cached($hour->person);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
                 continue;
             }

Spacing +4 added lines, -4 removed lines

@@ -47,12 +47,12 @@ 
         $qb_hr = org_openpsa_expenses_hour_report_dba::new_query_builder();
         $qb_hr->add_constraint('date', '<=', (int) $query_data['end']);
         $qb_hr->add_constraint('date', '>=', (int) $query_data['start']);
-        if (   array_key_exists('invoiceable_filter', $query_data)
+        if (array_key_exists('invoiceable_filter', $query_data)
             && $query_data['invoiceable_filter'] != -1) {
             $qb_hr->add_constraint('invoiceable', '=', (bool) $query_data['invoiceable_filter']);
         }
 
-        if (   array_key_exists('invoiced_filter', $query_data)
+        if (array_key_exists('invoiced_filter', $query_data)
             && $query_data['invoiced_filter'] != -1) {
             if ((int) $query_data['invoiced_filter']) {
                 debug_add('invoiced_filter parsed as ONLY, adding constraint');
@@ -71,7 +71,7 @@ 
             $tasks = $this->_expand_task($query_data['task']);
             $qb_hr->add_constraint('task', 'IN', $tasks);
         }
-        if (   array_key_exists('hour_type_filter', $query_data)
+        if (array_key_exists('hour_type_filter', $query_data)
             && $query_data['hour_type_filter'] != 'builtin:all') {
             $qb_hr->add_constraint('reportType', '=', $query_data['hour_type_filter']);
         }
@@ -140,7 +140,7 @@ 
 
     private function add_to_group(array $new_row, string $matching, string $sort, string $title)
     {
-        $rows =& $this->_request_data['report']['rows'];
+        $rows = & $this->_request_data['report']['rows'];
         if (array_key_exists($matching, $rows)) {
             $rows[$matching]['rows'][] = $new_row;
             $rows[$matching]['total_hours'] += $new_row['hour']->hours;

lib/org/openpsa/directmarketing/sender.php

Braces +4 added lines, -2 removed lines

@@ -222,7 +222,8 @@ 
             $this->_backend->send($person, $member, $token, $subject, $content, $from);
             self::$_messages_sent++;
             $status = org_openpsa_directmarketing_campaign_messagereceipt_dba::SENT;
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $status = org_openpsa_directmarketing_campaign_messagereceipt_dba::FAILURE;
             if (!$this->test_mode) {
                 $params[] = [
@@ -279,7 +280,8 @@ 
     {
         try {
             $person = org_openpsa_contacts_person_dba::get_cached($member->person);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             debug_add("Person #{$member->person} deleted or missing, removing member (member #{$member->id})");
             $member->orgOpenpsaObtype = org_openpsa_directmarketing_campaign_member_dba::UNSUBSCRIBED;
             $member->delete();

Spacing +3 added lines, -3 removed lines

@@ -75,7 +75,7 @@ 
         $this->from = $from;
         $this->subject = $subject;
 
-        if (   $message->orgOpenpsaObtype != org_openpsa_directmarketing_campaign_message_dba::EMAIL_TEXT
+        if ($message->orgOpenpsaObtype != org_openpsa_directmarketing_campaign_message_dba::EMAIL_TEXT
             && $message->orgOpenpsaObtype != org_openpsa_directmarketing_campaign_message_dba::EMAIL_HTML) {
             throw new midcom_error('unsupported message type');
         }
@@ -219,7 +219,7 @@ 
         $token .= midcom_helper_misc::random_string($this->token_size - 1, 'abcdefghijklmnopqrstuvwxyz0123456789');
 
         //If token is not free or (very, very unlikely) matches our dummy token, recurse.
-        if (   $token === 'dummy'
+        if ($token === 'dummy'
             || !org_openpsa_directmarketing_campaign_messagereceipt_dba::token_is_free($token)) {
             return $this->_create_token();
         }
@@ -240,7 +240,7 @@ 
             return null;
         }
         $type = $this->_backend->get_type();
-        if (   $person->get_parameter('org.openpsa.directmarketing', "send_all_denied")
+        if ($person->get_parameter('org.openpsa.directmarketing', "send_all_denied")
             || $person->get_parameter('org.openpsa.directmarketing', "send_{$type}_denied")) {
             debug_add("Sending {$type} messages to person {$person->rname} is denied, unsubscribing member (member #{$member->id})");
             $member->orgOpenpsaObtype = org_openpsa_directmarketing_campaign_member_dba::UNSUBSCRIBED;