Passed
Push — master ( 5c5891...b14765 )
by Andreas
09:36
created
lib/midgard/admin/user/style/midgard-admin-user-group-folders.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,8 @@
 block discarded – undo
17 17
         foreach ($data['objects'] as $guid => $privs) {
18 18
             try {
19 19
                 $object = new midcom_db_topic($guid);
20
-            } catch (midcom_error $e) {
20
+            }
21
+            catch (midcom_error $e) {
21 22
                 continue;
22 23
             }
23 24
             echo "<tr>\n";
Please login to merge, or discard this patch.
lib/org/openpsa/calendar/event/member.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
             $event = new org_openpsa_calendar_event_dba($this->eid);
69 69
         }
70 70
 
71
-        if (    $recipient->id == midcom_connection::get_user()
71
+        if ($recipient->id == midcom_connection::get_user()
72 72
              && !$event->send_notify_me) {
73 73
             //Do not send notification to current user
74 74
             debug_add('event->send_notify_me is false and recipient is current user, aborting notify');
@@ -194,7 +194,7 @@  discard block
 block discarded – undo
194 194
 
195 195
             if (isset($events_by_date[$ymd])) {
196 196
                 foreach ($events_by_date[$ymd] as $event) {
197
-                    if (   $event->end <= $workday_starts_ts
197
+                    if ($event->end <= $workday_starts_ts
198 198
                         || $event->start >= $workday_ends_ts) {
199 199
                         // We need not consider this event, it is outside the defined workday
200 200
                         continue;
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
212 212
                 }
213 213
             }
214 214
             // End of day slot
215
-            if (   $last_end_time < $workday_ends_ts
215
+            if ($last_end_time < $workday_ends_ts
216 216
                 && (($workday_ends_ts - $last_end_time) >= $amount)) {
217 217
                 $slots[] = self::_create_slot($last_end_time, $workday_ends_ts, $last_event);
218 218
             }
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -143,7 +143,8 @@
 block discarded – undo
143 143
                 debug_add('person #' . $person->id . 'has no email address, aborting');
144 144
                 return null;
145 145
             }
146
-        } catch (midcom_error $e) {
146
+        }
147
+        catch (midcom_error $e) {
147 148
             return null;
148 149
         }
149 150
 
Please login to merge, or discard this patch.
lib/org/openpsa/invoices/handler/billingdata.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
     private function load_controller(org_openpsa_invoices_billing_data_dba $bd) : controller
31 31
     {
32 32
         $schemadb = schemadb::from_path($this->_config->get('schemadb_billing_data'));
33
-        $vat =& $schemadb->get('default')->get_field('vat');
33
+        $vat = & $schemadb->get('default')->get_field('vat');
34 34
         // Fill VAT select
35 35
         if ($options = $this->get_vat_options($this->_config->get('vat_percentages'))) {
36 36
             $vat['type_config']['options'] = $options;
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
         $data['controller'] = $this->load_controller($bd);
69 69
 
70 70
         $workflow = $this->get_workflow('datamanager', ['controller' => $data['controller']]);
71
-        if (   $mode == 'edit'
71
+        if ($mode == 'edit'
72 72
             && $bd->can_do('midgard:delete')) {
73 73
             $delete = $this->get_workflow('delete', [
74 74
                 'object' => $bd,
Please login to merge, or discard this patch.
lib/org/openpsa/products/midcom/interfaces.php 2 patches
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -79,7 +79,8 @@  discard block
 block discarded – undo
79 79
                 try {
80 80
                     $dms['group']->set_storage($group);
81 81
                     org_openpsa_products_viewer::index($dms['group'], $indexer, $topic, $config);
82
-                } catch (midcom_error $e) {
82
+                }
83
+                catch (midcom_error $e) {
83 84
                     $e->log(MIDCOM_LOG_WARN);
84 85
                 }
85 86
             }
@@ -91,7 +92,8 @@  discard block
 block discarded – undo
91 92
                     try {
92 93
                         $dms['product']->set_storage($product);
93 94
                         org_openpsa_products_viewer::index($dms['product'], $indexer, $topic, $config);
94
-                    } catch (midcom_error $e) {
95
+                    }
96
+                    catch (midcom_error $e) {
95 97
                         $e->log(MIDCOM_LOG_WARN);
96 98
                     }
97 99
                 }
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
      */
53 53
     public function _on_reindex($topic, midcom_helper_configuration $config, midcom_services_indexer $indexer)
54 54
     {
55
-        if (   !$config->get('index_products')
55
+        if (!$config->get('index_products')
56 56
             && !$config->get('index_groups')) {
57 57
             debug_add("No indexing to groups and products, skipping", MIDCOM_LOG_WARN);
58 58
             return true;
Please login to merge, or discard this patch.
lib/org/openpsa/notifications/notifier/email.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@
 block discarded – undo
38 38
             $mail->from = $config->get('default_sender') ?: '"OpenPSA Notifier" <noreply@' . $_SERVER['SERVER_NAME'] . '>';
39 39
         }
40 40
 
41
-        $mail->subject = $message['title'] ??  'org.openpsa.notifications message (no title provided)';
41
+        $mail->subject = $message['title'] ?? 'org.openpsa.notifications message (no title provided)';
42 42
         if (array_key_exists('attachments', $message)) {
43 43
             $mail->attachments = $message['attachments'];
44 44
         }
Please login to merge, or discard this patch.
lib/org/openpsa/documents/midcom/interfaces.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@
 block discarded – undo
40 40
 
41 41
     public function resolve_object_link(midcom_db_topic $topic, midcom_core_dbaobject $object) : ?string
42 42
     {
43
-        if (   $object instanceof org_openpsa_documents_document_dba
43
+        if ($object instanceof org_openpsa_documents_document_dba
44 44
             && $object->topic == $topic->id) {
45 45
             return "document/{$object->guid}/";
46 46
         }
Please login to merge, or discard this patch.
lib/net/nemein/wiki/style/view-wikipage-raw.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -6,6 +6,6 @@
 block discarded – undo
6 6
     &(view["content"]:h);
7 7
     <?php
8 8
 } else {
9
-    echo "<p class=\"stub\">" . $data['l10n']->get('this page is stub')."</p>";
9
+    echo "<p class=\"stub\">" . $data['l10n']->get('this page is stub') . "</p>";
10 10
 }
11 11
 ?>
12 12
\ No newline at end of file
Please login to merge, or discard this patch.
lib/org/openpsa/invoices/style/admin-read.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
         <div class="value"><?php echo $formatter->date($invoice->deliverydate); ?></div></div>
35 35
     <?php } ?>
36 36
 
37
-    <div class="field"><div class="title"><?php echo $data['l10n_midcom']->get('description');?>: </div>
37
+    <div class="field"><div class="title"><?php echo $data['l10n_midcom']->get('description'); ?>: </div>
38 38
     <div class="description value">&(view['description']:h);</div></div>
39 39
 
40 40
     <?php
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -8,7 +8,8 @@
 block discarded – undo
8 8
     if ($customer->orgOpenpsaObtype < org_openpsa_contacts_group_dba::ORGANIZATION) {
9 9
         $customer = false;
10 10
     }
11
-} catch (midcom_error $e) {
11
+}
12
+catch (midcom_error $e) {
12 13
     $customer = false;
13 14
 }
14 15
 
Please login to merge, or discard this patch.
lib/org/openpsa/relatedto/style/show_entries_html.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
             <?php
47 47
             //index is needed for sorting
48 48
             echo "'index_name',";
49
-            echo "'" . $data['l10n']->get('entry title') ."',";
49
+            echo "'" . $data['l10n']->get('entry title') . "',";
50 50
             echo "'" . $data['l10n']->get('entry text') . "',";
51 51
             echo "'" . $data['l10n']->get('entry created') . "',";
52 52
             echo "'index_creator', '" . $data['l10n_midcom']->get('creator') . "',";
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,8 @@
 block discarded – undo
25 25
             $row['creator_index'] = $creator->rname;
26 26
             $creator_card = org_openpsa_widgets_contact::get($entry->metadata->creator);
27 27
             $row['creator'] = $creator_card->show_inline();
28
-        } catch (midcom_error $e) {
28
+        }
29
+        catch (midcom_error $e) {
29 30
             $row['creator_index'] = '';
30 31
             $row['creator'] = '';
31 32
         }
Please login to merge, or discard this patch.