net_nemein_wiki_handler_create

Complexity

Total Complexity

16

Size/Duplication

Total Lines	140
Duplicated Lines	0 %

Test Coverage

Coverage

74.65%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	save_callback()	0	8	1
B	check_unique_wikiword()	0	60	9
B	_handler_create()	0	44	6

<?php
/**
 * @package net.nemein.wiki
 * @author The Midgard Project, http://www.midgard-project.org
 * @copyright The Midgard Project, http://www.midgard-project.org
 * @license http://www.gnu.org/licenses/lgpl.html GNU Lesser General Public License
 */

use midcom\datamanager\schemadb;
use midcom\datamanager\datamanager;
use midcom\datamanager\controller;
use Symfony\Component\HttpFoundation\Request;

/**
 * Wikipage creation handler
 *
 * @package net.nemein.wiki
 */
class net_nemein_wiki_handler_create extends midcom_baseclasses_components_handler
{
    use net_nemein_wiki_handler;

The trait net_nemein_wiki_handler requires the property $id which is not provided by net_nemein_wiki_handler_create.

    /**
     * Wiki word we're creating page for
     *
     * @var string
     */
    private $_wikiword = '';

    /**
     * The wikipage we're creating
     *
     * @var net_nemein_wiki_wikipage
     */
    private $_page;

    private function check_unique_wikiword($wikiword, $schema)
    {
        $resolver = new net_nemein_wiki_resolver($this->_topic->id);
        $resolved = $resolver->path_to_wikipage($wikiword, true, true);

        if (!empty($resolved['latest_parent'])) {
            $to_node = $resolved['latest_parent'];
        } else {
            $to_node = $resolved['folder'];
        }
        if (strstr($resolved['remaining_path'], '/')) {
            // One or more namespaces left, find first, create it and recurse
            $paths = explode('/', $resolved['remaining_path']);
            $folder_title = array_shift($paths);
            $topic = new midcom_db_topic();
            $topic->up = $to_node[MIDCOM_NAV_ID];
            $topic->extra = trim($folder_title);
            $topic->title = $topic->extra;
            $topic->name = midcom_helper_misc::urlize($folder_title);
            $topic->component = 'net.nemein.wiki';
            if (!$topic->create()) {
                throw new midcom_error("Could not create wiki namespace '{$folder_title}', last Midgard error was: " . midcom_connection::get_error_string());
            }
            // refresh
            $topic = new midcom_db_topic($topic->id);

            // See if we have article with same title in immediate parent
            $qb = net_nemein_wiki_wikipage::new_query_builder();
            $qb->add_constraint('title', '=', $folder_title);
            $qb->add_constraint('topic', '=', $topic->up);
            $results = $qb->execute();

            if (count($results) == 1) {
                $article = $results[0];
                $article->name = 'index';

The property name does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

                $article->topic = $topic->id;

The property topic does not exist on midcom_core_dbaobject. Since you implemented __set, consider adding a @property annotation.

                if (!$article->update()) {
                    // Could not move article, do something ?
                }
            } else {
                try {
                    $this->initialize_index_article($topic);
                } catch (midcom_error $e) {
                    // Could not create index
                    $topic->delete();
                    throw $e;
                }
            }
            // We have created a new topic, now recurse to create the rest of the path.
            return $this->check_unique_wikiword($wikiword, $schema);
        }
        if (is_object($resolved['wikipage'])) {
            // Page exists
            throw new midcom_error('Wiki page with that name already exists.');
        }
        // No more namespaces left, create the page to latest parent
        if ($to_node[MIDCOM_NAV_ID] != $this->_topic->id) {
            // Last parent is not this topic, redirect there
            $wikiword_url = rawurlencode($resolved['remaining_path']);
            return new midcom_response_relocate($to_node[MIDCOM_NAV_ABSOLUTEURL] . "create/{$schema}/?wikiword={$wikiword_url}");
        }
    }

    /**
     * @param Request $request The request object
     * @param array $data The local request data.
     * @param string $schema The DM schema
     */
    public function _handler_create(Request $request, array &$data, $schema = null)
    {
        // Initialize sessioning first
        $data['session'] = new midcom_services_session();

        if (!$request->query->has('wikiword')) {
            if (!$data['session']->exists('wikiword')) {
                throw new midcom_error_notfound('No wiki word given');
            }
            $this->_wikiword = $data['session']->get('wikiword');
        } else {
            $this->_wikiword = $request->query->get('wikiword');
            $data['session']->set('wikiword', $this->_wikiword);
        }

        $this->_topic->require_do('midgard:create');

        $schema = $schema ?: $this->_config->get('default_schema');

        $schemadb = schemadb::from_path($this->_config->get('schemadb'));
        if (!$schemadb->has($schema)) {
            throw new midcom_error_notfound('Schema ' . $schema . ' not found in schemadb');

Are you sure $schema of type false|mixed|string can be used in concatenation?

        }
        if ($response = $this->check_unique_wikiword($this->_wikiword, $schema)) {
            return $response;
        }

        $this->_page = new net_nemein_wiki_wikipage();
        $this->_page->topic = $this->_topic->id;
        $this->_page->title = $this->_wikiword;
        $this->_page->author = midcom_connection::get_user();

The property author does not exist on net_nemein_wiki_wikipage. Since you implemented __set, consider adding a @property annotation.

        $dm = new datamanager($schemadb);
        $data['controller'] = $dm
            ->set_storage($this->_page)
            ->get_controller();

        midcom::get()->head->set_pagetitle(sprintf($this->_l10n->get('create wikipage %s'), $this->_wikiword));

        $workflow = $this->get_workflow('datamanager', [
            'controller' => $data['controller'],
            'save_callback' => [$this, 'save_callback']
        ]);
        return $workflow->run($request);
    }

    public function save_callback(controller $controller)
    {
        $indexer = midcom::get()->indexer;
        net_nemein_wiki_viewer::index($controller->get_datamanager(), $indexer, $this->_topic);

        midcom::get()->uimessages->add($this->_l10n->get('net.nemein.wiki'), sprintf($this->_l10n->get('page %s added'), $this->_wikiword));

        return "{$this->_page->name}/";
    }
}