Passed
Push — master ( 4c3b5f...efb535 )
by Andreas
27:22 queued 17:13
created
lib/net/nemein/wiki/parser.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
                 return $this->render_link($parts[1], $parts[2]) . $after;
224 224
 
225 225
             // Macro [something: <data>] (for example [abbr: BOFH - Bastard Operator From Hell] or [photo: <GUID>])
226
-            case (   preg_match('/^(.*?): (.*)/', $fulltext, $macro_parts)
226
+            case (preg_match('/^(.*?): (.*)/', $fulltext, $macro_parts)
227 227
                   && method_exists($this, "_run_macro_{$macro_parts[1]}")):
228 228
                 $method = "_run_macro_{$macro_parts[1]}";
229 229
                 return $this->$method($macro_parts[2], $match[0], $after);
@@ -256,7 +256,7 @@  discard block
 block discarded – undo
256 256
                 $folder = $wikipage_match['latest_parent'];
257 257
             }
258 258
 
259
-            if (   isset($folder[MIDCOM_NAV_OBJECT])
259
+            if (isset($folder[MIDCOM_NAV_OBJECT])
260 260
                 && $folder[MIDCOM_NAV_OBJECT]->can_do('midgard:create')) {
261 261
                 $workflow = $this->get_workflow('datamanager');
262 262
                 return "<a href=\"{$folder[MIDCOM_NAV_ABSOLUTEURL]}create/?wikiword={$wikipage_match['remaining_path']}\" " . $workflow->render_attributes() . " class=\"wiki_missing\" title=\"" . $this->_l10n->get('click to create') . "\">{$text}</a>";
@@ -291,7 +291,7 @@  discard block
 block discarded – undo
291 291
                     $links[$parts[1]] = $parts[2];
292 292
                 }
293 293
                 // Ignore macros [something: <data>] (for example [abbr: BOFH - Bastard Operator From Hell] or [photo: <GUID>])
294
-                elseif (   !preg_match('/^(.*?): (.*)/', $fulltext, $macro_parts)
294
+                elseif (!preg_match('/^(.*?): (.*)/', $fulltext, $macro_parts)
295 295
                         || !method_exists($this, "_run_macro_{$macro_parts[1]}")) {
296 296
                     // MediaWiki-style link [wikipage] (no text)
297 297
                     $links[$fulltext] = $fulltext;
Please login to merge, or discard this patch.
lib/org/openpsa/sales/style/show-deliverable.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
 $state = $data['deliverable']->get_state();
4 4
 $formatter = $data['l10n']->get_formatter();
5 5
 $per_unit = $data['l10n']->get('per unit');
6
-if (   $data['product']
6
+if ($data['product']
7 7
     && $unit_option = org_openpsa_sales_viewer::get_unit_option($data['product']->unit)) {
8 8
     $per_unit = sprintf($data['l10n']->get('per %s'), $unit_option);
9 9
 }
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
 	    </div>
116 116
      <?php
117 117
     $tabs = [];
118
-    if (   $data['invoices_url']
118
+    if ($data['invoices_url']
119 119
         && $data['deliverable']->invoiced > 0) {
120 120
         $tabs[] = [
121 121
             'url' => $data['invoices_url'] . "list/deliverable/{$data['deliverable']->guid}/",
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
         ];
124 124
     }
125 125
 
126
-    if (   $data['projects_url']
126
+    if ($data['projects_url']
127 127
         && $data['deliverable']->state >= org_openpsa_sales_salesproject_deliverable_dba::STATE_ORDERED
128 128
         && $data['product']
129 129
         && $data['product']->orgOpenpsaObtype == org_openpsa_products_product_dba::TYPE_SERVICE) {
Please login to merge, or discard this patch.
lib/net/nemein/redirector/viewer.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -19,8 +19,8 @@
 block discarded – undo
19 19
     public function _on_initialize()
20 20
     {
21 21
         // Match /
22
-        if (   $this->_config->get('redirection_type') === null
23
-            || (   $this->_topic->can_do('net.nemein.redirector:noredirect')
22
+        if ($this->_config->get('redirection_type') === null
23
+            || ($this->_topic->can_do('net.nemein.redirector:noredirect')
24 24
                 && !$this->_config->get('admin_redirection'))) {
25 25
             $this->_request_switch['redirect'] = [
26 26
                 'handler' => [net_nemein_redirector_handler_tinyurl::class, 'list'],
Please login to merge, or discard this patch.
lib/net/nemein/wiki/resolver.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
             $localpath = $path;
159 159
             $matches['latest_parent'] = $folder_tree['/'];
160 160
             $missing_levels = 0;
161
-            while (   $localpath
161
+            while ($localpath
162 162
                    && $localpath != '/') {
163 163
                 $localpath = dirname($localpath);
164 164
                 $missing_levels++;
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
 
186 186
         $root_folder = $folder;
187 187
         $max = 100;
188
-        while (   $folder[MIDCOM_NAV_COMPONENT] == 'net.nemein.wiki'
188
+        while ($folder[MIDCOM_NAV_COMPONENT] == 'net.nemein.wiki'
189 189
                && (($parent = $nap->get_node_uplink($folder[MIDCOM_NAV_ID])) != -1)
190 190
                && $max > 0) {
191 191
             $root_folder = $folder;
Please login to merge, or discard this patch.
lib/org/openpsa/calendar/conflictmanager.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
         }
126 126
         // TODO: Shared tasks need a separate check (different member object)
127 127
 
128
-        if (   !empty($this->busy_members)
128
+        if (!empty($this->busy_members)
129 129
             || !empty($this->busy_resources)) {
130 130
             //Unresolved conflicts (note return value is for conflicts not lack of them)
131 131
             midcom::get()->auth->drop_sudo();
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
         }
189 189
 
190 190
         if (array_key_exists($member->event, $modified_events)) {
191
-            $event =& $modified_events[$member->event];
191
+            $event = & $modified_events[$member->event];
192 192
             $set_as_modified = false;
193 193
         } else {
194 194
             try {
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
         }
203 203
         debug_add("overlap found in event {$event->title} (#{$event->id})");
204 204
 
205
-        if (   $event->tentative
205
+        if ($event->tentative
206 206
             && $rob_tentative) {
207 207
             debug_add('event is tentative, robbing resources');
208 208
             $event->resources = array_diff_key($event->resources, $this->_event->resources);
@@ -229,7 +229,7 @@  discard block
 block discarded – undo
229 229
         }
230 230
         debug_add("overlap found in event {$event->title} (#{$event->id})");
231 231
 
232
-        if (   $event->tentative
232
+        if ($event->tentative
233 233
             && $rob_tentative) {
234 234
             debug_add('event is tentative, robbing participants');
235 235
             $event->participants = array_diff_key($event->participants, $this->_event->participants);
Please login to merge, or discard this patch.
lib/org/openpsa/notifications/main.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -102,7 +102,7 @@
 block discarded – undo
102 102
 
103 103
         // If user has preference for this message, we use that
104 104
         $personal_preferences = $recipient->list_parameters('org.openpsa.notifications');
105
-        if (   !empty($personal_preferences)
105
+        if (!empty($personal_preferences)
106 106
             && array_key_exists("{$component}:{$action}", $personal_preferences)) {
107 107
             return $personal_preferences[$action];
108 108
         }
Please login to merge, or discard this patch.
lib/org/openpsa/projects/project.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -249,7 +249,7 @@
 block discarded – undo
249 249
             $new_status = $this->_find_status($this->_status_map[$this->status_type], $status_types);
250 250
         }
251 251
 
252
-        if (   $new_status !== null
252
+        if ($new_status !== null
253 253
             && $this->status != $new_status) {
254 254
             $this->status = $new_status;
255 255
             $update_required = true;
Please login to merge, or discard this patch.
lib/midcom/baseclasses/components/handler/dataexport.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
         foreach ($this->_datamanagers as $type => $datamanager) {
128 128
             foreach ($datamanager->get_schema($this->schemas[$type])->get('fields') as $name => $config) {
129 129
                 $title = $config['title'];
130
-                if (   $this->include_totals
130
+                if ($this->include_totals
131 131
                     && $config['type'] == 'number') {
132 132
                     $this->_totals[$type . '-' . $name] = 0;
133 133
                 }
@@ -194,18 +194,18 @@  discard block
 block discarded – undo
194 194
                     $data = array_pad($data, $target_size, '');
195 195
                     continue;
196 196
                 }
197
-                $object =& $row[$type];
197
+                $object = & $row[$type];
198 198
 
199 199
                 $datamanager->set_storage($object, $this->schemas[$type]);
200 200
 
201
-                if (   $this->include_guid
201
+                if ($this->include_guid
202 202
                     && $type == $first_type) {
203 203
                     $data[] = $object->guid;
204 204
                 }
205 205
 
206 206
                 $csvdata = $datamanager->get_content_csv();
207 207
                 foreach ($datamanager->get_schema()->get('fields') as $fieldname => $config) {
208
-                    if (   $this->include_totals
208
+                    if ($this->include_totals
209 209
                         && $config['type'] == 'number') {
210 210
                         $this->_totals[$type . '-' . $fieldname] += $csvdata[$fieldname];
211 211
                     }
@@ -233,7 +233,7 @@  discard block
 block discarded – undo
233 233
         if (empty($this->csv['charset'])) {
234 234
             // Default to ISO-LATIN-15 (Latin-1 with EURO sign etc)
235 235
             $this->csv['charset'] = 'ISO-8859-15';
236
-            if (   isset($_SERVER['HTTP_USER_AGENT'])
236
+            if (isset($_SERVER['HTTP_USER_AGENT'])
237 237
                 && !preg_match('/Windows/i', $_SERVER['HTTP_USER_AGENT'])) {
238 238
                 // Except when not on windows, then default to UTF-8
239 239
                 $this->csv['charset'] = 'UTF-8';
Please login to merge, or discard this patch.
lib/midcom/connection.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -261,7 +261,7 @@
 block discarded – undo
261 261
             if ($part === '') {
262 262
                 continue;
263 263
             }
264
-            if (    midcom::get()->config->get('theme')
264
+            if (midcom::get()->config->get('theme')
265 265
                  && !$args_started
266 266
                  && self::check_page_exists($part)) {
267 267
                 $page_style .= '/' . $part;
Please login to merge, or discard this patch.