flack /
openpsa
| Total Complexity | 40 |
| Total Lines | 238 |
| Duplicated Lines | 0 % |
| Coverage | 58.12% |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Complex classes like net_nehmer_comments_handler_view often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use net_nehmer_comments_handler_view, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 23 | class net_nehmer_comments_handler_view extends midcom_baseclasses_components_handler |
||
| 24 | { |
||
| 25 | use net_nehmer_comments_handler; |
||
|
introduced
by
|
|||
| 26 | |||
| 27 | private ?schemadb $_schemadb = null; |
||
| 28 | |||
| 29 | /** |
||
| 30 | * @var net_nehmer_comments_comment[] |
||
| 31 | */ |
||
| 32 | private array $_comments = []; |
||
| 33 | |||
| 34 | private net_nehmer_comments_comment $_new_comment; |
||
| 35 | |||
| 36 | private string $_objectguid; |
||
| 37 | |||
| 38 | private controller $_post_controller; |
||
| 39 | |||
| 40 | private datamanager $_display_datamanager; |
||
| 41 | |||
| 42 | /** |
||
| 43 | * Prepares the request data |
||
| 44 | */ |
||
| 45 | 2 | private function _prepare_request_data() |
|
| 49 | } |
||
| 50 | |||
| 51 | /** |
||
| 52 | * Prepares the _display_datamanager member. |
||
| 53 | */ |
||
| 54 | private function _init_display_datamanager() |
||
| 59 | } |
||
| 60 | |||
| 61 | /** |
||
| 62 | * Loads the schemadb (unless it has already been loaded). |
||
| 63 | */ |
||
| 64 | 2 | private function _load_schemadb() |
|
| 86 | } |
||
| 87 | } |
||
| 88 | } |
||
| 89 | |||
| 90 | /** |
||
| 91 | * Initializes a DM for posting. |
||
| 92 | */ |
||
| 93 | 2 | private function _init_post_controller(Request $request) |
|
| 94 | { |
||
| 95 | 2 | $this->_load_schemadb(); |
|
| 96 | |||
| 97 | 2 | $this->_new_comment = new net_nehmer_comments_comment(); |
|
| 98 | 2 | $this->_new_comment->objectguid = $this->_objectguid; |
|
| 99 | 2 | $this->_new_comment->ip = $request->getClientIp(); |
|
| 100 | |||
| 101 | 2 | if (midcom::get()->auth->user) { |
|
| 102 | 2 | $this->_new_comment->status = net_nehmer_comments_comment::NEW_USER; |
|
| 103 | 2 | $this->_new_comment->author = midcom::get()->auth->user->name; |
|
| 104 | } else { |
||
| 105 | $this->_new_comment->status = net_nehmer_comments_comment::NEW_ANONYMOUS; |
||
| 106 | } |
||
| 107 | |||
| 108 | 2 | if ($this->_config->get('enable_notify')) { |
|
| 109 | 2 | $this->_new_comment->_send_notification = true; |
|
| 110 | } |
||
| 111 | |||
| 112 | 2 | $dm = new datamanager($this->_schemadb); |
|
| 113 | 2 | $this->_post_controller = $dm |
|
| 114 | 2 | ->set_storage($this->_new_comment) |
|
| 115 | 2 | ->get_controller(); |
|
| 116 | } |
||
| 117 | |||
| 118 | /** |
||
| 119 | * Loads the comments, does any processing according to the state of the GET list. |
||
| 120 | * On successful processing we relocate once to ourself. |
||
| 121 | */ |
||
| 122 | 2 | public function _handler_comments(Request $request, string $handler_id, array &$data, string $guid, ?string $view = null) |
|
| 123 | { |
||
| 124 | 2 | $this->_objectguid = $guid; |
|
| 125 | 2 | midcom::get()->cache->content->register($this->_objectguid); |
|
| 126 | |||
| 127 | 2 | if ($handler_id == 'view-comments-nonempty') { |
|
| 128 | 1 | $this->_comments = net_nehmer_comments_comment::list_by_objectguid_filter_anonymous( |
|
| 129 | 1 | $this->_objectguid, |
|
| 130 | 1 | $this->_config->get('items_to_show'), |
|
| 131 | 1 | $this->_config->get('item_ordering'), |
|
| 132 | 1 | $this->_config->get('paging') |
|
| 133 | 1 | ); |
|
| 134 | } else { |
||
| 135 | 1 | $this->_comments = net_nehmer_comments_comment::list_by_objectguid( |
|
| 136 | 1 | $this->_objectguid, |
|
| 137 | 1 | $this->_config->get('items_to_show'), |
|
| 138 | 1 | $this->_config->get('item_ordering'), |
|
| 139 | 1 | $this->_config->get('paging') |
|
| 140 | 1 | ); |
|
| 141 | } |
||
| 142 | |||
| 143 | 2 | if ($this->_config->get('paging') !== false) { |
|
| 144 | $data['qb_pager'] = $this->_comments; |
||
| 145 | $this->_comments = $this->_comments->execute(); |
||
| 146 | } |
||
| 147 | |||
| 148 | 2 | if ( midcom::get()->auth->user |
|
| 149 | 2 | || $this->_config->get('allow_anonymous')) { |
|
| 150 | 2 | $this->_init_post_controller($request); |
|
| 151 | 2 | if ($response = $this->_process_post($request)) { |
|
| 152 | return $response; |
||
| 153 | } |
||
| 154 | } |
||
| 155 | 2 | if ($this->_comments) { |
|
| 156 | $this->_init_display_datamanager(); |
||
| 157 | } |
||
| 158 | |||
| 159 | 2 | if ($handler_id == 'view-comments-custom') { |
|
| 160 | midcom::get()->skip_page_style = true; |
||
| 161 | $data['custom_view'] = $view; |
||
| 162 | } |
||
| 163 | |||
| 164 | 2 | $this->_prepare_request_data(); |
|
| 165 | 2 | midcom::get()->metadata->set_request_metadata($this->_get_last_modified(), $this->_objectguid); |
|
| 166 | |||
| 167 | 2 | if ($request->isXmlHttpRequest()) { |
|
| 168 | midcom::get()->skip_page_style = true; |
||
| 169 | } |
||
| 170 | } |
||
| 171 | |||
| 172 | /** |
||
| 173 | * Checks if a new post has been submitted. |
||
| 174 | */ |
||
| 175 | 2 | private function _process_post(Request $request) |
|
| 176 | { |
||
| 177 | 2 | if ( !midcom::get()->auth->user |
|
| 178 | 2 | && !midcom::get()->auth->request_sudo('net.nehmer.comments')) { |
|
| 179 | throw new midcom_error('We were anonymous but could not acquire SUDO privileges, aborting'); |
||
| 180 | } |
||
| 181 | |||
| 182 | 2 | switch ($this->_post_controller->handle($request)) { |
|
| 183 | 2 | case 'save': |
|
| 184 | // Check against comment spam |
||
| 185 | if ($this->_config->get('enable_spam_check')) { |
||
| 186 | net_nehmer_comments_spamchecker::check($this->_new_comment); |
||
| 187 | } |
||
| 188 | |||
| 189 | $formdata = $this->_post_controller->get_form_values(); |
||
| 190 | if ( $formdata['subscribe'] |
||
| 191 | && midcom::get()->auth->user) { |
||
| 192 | // User wants to subscribe to receive notifications about this comments thread |
||
| 193 | |||
| 194 | // Get the object we're commenting |
||
| 195 | $parent = midcom::get()->dbfactory->get_object_by_guid($this->_objectguid); |
||
| 196 | |||
| 197 | // Sudo so we can update the parent object |
||
| 198 | if (midcom::get()->auth->request_sudo($this->_component)) { |
||
| 199 | // Save the subscription |
||
| 200 | $parent->set_parameter('net.nehmer.comments:subscription', midcom::get()->auth->user->guid, time()); |
||
| 201 | |||
| 202 | // Return back from the sudo state |
||
| 203 | midcom::get()->auth->drop_sudo(); |
||
| 204 | } |
||
| 205 | } |
||
| 206 | |||
| 207 | midcom::get()->cache->invalidate($this->_objectguid); |
||
| 208 | // Fall-through intentional |
||
| 209 | |||
| 210 | 2 | case 'cancel': |
|
| 211 | if (!midcom::get()->auth->user) { |
||
| 212 | midcom::get()->auth->drop_sudo(); |
||
| 213 | } |
||
| 214 | return new midcom_response_relocate($request->getRequestUri()); |
||
| 215 | } |
||
| 216 | } |
||
| 217 | |||
| 218 | /** |
||
| 219 | * Determines the last modified timestamp. It is the max out of all revised timestamps |
||
| 220 | * of the comments (or 0 in case nothing was found). |
||
| 221 | */ |
||
| 222 | 2 | private function _get_last_modified() : int |
|
| 223 | { |
||
| 224 | 2 | return array_reduce($this->_comments, function ($carry, net_nehmer_comments_comment $item) { |
|
| 225 | return max($item->metadata->revised, $carry); |
||
| 226 | 2 | }, 0); |
|
| 227 | } |
||
| 228 | |||
| 229 | /** |
||
| 230 | * Display the comment list and the submit-comment form. |
||
| 231 | */ |
||
| 232 | 2 | public function _show_comments(string $handler_id, array &$data) |
|
| 261 | } |
||
| 262 | } |
||
| 263 |
Loading history...