@@ -246,7 +246,7 @@ discard block |
||
| 246 | 246 | */ |
| 247 | 247 | public function set_assignee($assignee) : bool |
| 248 | 248 | { |
| 249 | - if ( is_a($assignee, midcom_core_user::class) |
|
| 249 | + if (is_a($assignee, midcom_core_user::class) |
|
| 250 | 250 | || is_a($assignee, midcom_core_group::class)) { |
| 251 | 251 | $this->assignee = $assignee->id; |
| 252 | 252 | } elseif (is_string($assignee)) { |
@@ -305,12 +305,12 @@ discard block |
||
| 305 | 305 | } |
| 306 | 306 | } |
| 307 | 307 | |
| 308 | - if ( !$this->is_magic_assignee() |
|
| 308 | + if (!$this->is_magic_assignee() |
|
| 309 | 309 | && !$this->get_assignee()) { |
| 310 | 310 | debug_add("The assignee identifier '{$this->assignee}' is invalid.", MIDCOM_LOG_INFO); |
| 311 | 311 | return false; |
| 312 | 312 | } |
| 313 | - if ( $this->assignee == 'OWNER' |
|
| 313 | + if ($this->assignee == 'OWNER' |
|
| 314 | 314 | && $this->privilegename == 'midgard:owner') { |
| 315 | 315 | debug_add("Tried to assign midgard:owner to the OWNER magic assignee, this is invalid.", MIDCOM_LOG_INFO); |
| 316 | 316 | return false; |
@@ -322,7 +322,7 @@ discard block |
||
| 322 | 322 | MIDCOM_LOG_INFO); |
| 323 | 323 | return false; |
| 324 | 324 | } |
| 325 | - if ( !$object->can_do('midgard:update') |
|
| 325 | + if (!$object->can_do('midgard:update') |
|
| 326 | 326 | || !$object->can_do('midgard:privileges')) { |
| 327 | 327 | debug_add("Insufficient privileges on the content object with the GUID '{$this->__guid}', midgard:update and midgard:privileges required.", |
| 328 | 328 | MIDCOM_LOG_INFO); |
@@ -239,7 +239,7 @@ discard block |
||
| 239 | 239 | |
| 240 | 240 | private function _convert_to_localdata() : string |
| 241 | 241 | { |
| 242 | - return "var " . $this->_grid->get_identifier() . '_entries = ' . json_encode($this->get_rows()) . ";\n"; |
|
| 242 | + return "var " . $this->_grid->get_identifier() . '_entries = ' . json_encode($this->get_rows()) . ";\n"; |
|
| 243 | 243 | } |
| 244 | 244 | |
| 245 | 245 | private function _render_json() |
@@ -272,7 +272,7 @@ discard block |
||
| 272 | 272 | $this->_sort_field = $query['sidx']; |
| 273 | 273 | $this->_sort_direction = strtoupper($query['sord']); |
| 274 | 274 | } |
| 275 | - if ( !empty($query['_search']) |
|
| 275 | + if (!empty($query['_search']) |
|
| 276 | 276 | && $query['_search'] === 'true') { |
| 277 | 277 | foreach ($query as $field => $value) { |
| 278 | 278 | if (in_array($field, ['_search', 'nd', 'page', 'rows', 'sidx', 'sord'])) { |
@@ -297,7 +297,7 @@ discard block |
||
| 297 | 297 | |
| 298 | 298 | $this->_total_rows = $qb->count(); |
| 299 | 299 | |
| 300 | - if ( $this->_datatype == 'json' |
|
| 300 | + if ($this->_datatype == 'json' |
|
| 301 | 301 | && !empty($this->_results_per_page)) { |
| 302 | 302 | $qb->set_limit($this->_results_per_page); |
| 303 | 303 | if (!empty($this->_offset)) { |
@@ -143,7 +143,7 @@ |
||
| 143 | 143 | protected function save_attachment_list() : bool |
| 144 | 144 | { |
| 145 | 145 | if (!empty($this->config['widget_config']['sortable'])) { |
| 146 | - uasort($this->map, function ($a, $b) { |
|
| 146 | + uasort($this->map, function($a, $b) { |
|
| 147 | 147 | if ($a->metadata->score == $b->metadata->score) { |
| 148 | 148 | return strnatcasecmp($a->name, $b->name); |
| 149 | 149 | } |
@@ -147,7 +147,7 @@ discard block |
||
| 147 | 147 | ]; |
| 148 | 148 | } |
| 149 | 149 | |
| 150 | - if ( midcom::get()->config->get('midcom_services_rcs_enable') |
|
| 150 | + if (midcom::get()->config->get('midcom_services_rcs_enable') |
|
| 151 | 151 | && $object->can_do('midgard:update') |
| 152 | 152 | && $object->_use_rcs) { |
| 153 | 153 | $buttons[] = [ |
@@ -208,7 +208,7 @@ discard block |
||
| 208 | 208 | private function get_toolbar_update_items($object) : array |
| 209 | 209 | { |
| 210 | 210 | $buttons = []; |
| 211 | - if ( is_a($object, midcom_db_topic::class) |
|
| 211 | + if (is_a($object, midcom_db_topic::class) |
|
| 212 | 212 | && $object->component |
| 213 | 213 | && $object->can_do('midcom:component_config')) { |
| 214 | 214 | $buttons[] = [ |
@@ -246,7 +246,7 @@ discard block |
||
| 246 | 246 | MIDCOM_TOOLBAR_ENABLED => $object->can_do('midgard:privileges'), |
| 247 | 247 | ]; |
| 248 | 248 | |
| 249 | - if ( midcom::get()->componentloader->is_installed('midcom.helper.replicator') |
|
| 249 | + if (midcom::get()->componentloader->is_installed('midcom.helper.replicator') |
|
| 250 | 250 | && midcom::get()->auth->admin) { |
| 251 | 251 | $buttons[] = [ |
| 252 | 252 | MIDCOM_TOOLBAR_URL => "__mfa/asgard_midcom.helper.replicator/object/{$object->guid}/", |
@@ -84,7 +84,7 @@ discard block |
||
| 84 | 84 | net_nemein_rss_manage::add_toolbar_buttons($this->_node_toolbar, $this->_topic->can_do('midgard:create')); |
| 85 | 85 | } |
| 86 | 86 | |
| 87 | - if ( $this->_topic->can_do('midgard:update') |
|
| 87 | + if ($this->_topic->can_do('midgard:update') |
|
| 88 | 88 | && $this->_topic->can_do('midcom:component_config')) { |
| 89 | 89 | $buttons[] = $workflow->get_button('config/', [ |
| 90 | 90 | MIDCOM_TOOLBAR_LABEL => $this->_l10n_midcom->get('component configuration'), |
@@ -114,7 +114,7 @@ discard block |
||
| 114 | 114 | $this->_request_data['categories'] = explode(',', $this->_config->get('categories')); |
| 115 | 115 | |
| 116 | 116 | foreach ($this->_request_data['schemadb']->all() as $schema) { |
| 117 | - if ( $schema->has_field('categories') |
|
| 117 | + if ($schema->has_field('categories') |
|
| 118 | 118 | && $schema->get_field('categories')['type'] == 'select') { |
| 119 | 119 | // TODO: Merge schema local and component config categories? |
| 120 | 120 | $options = array_combine($this->_request_data['categories'], $this->_request_data['categories']); |
@@ -62,7 +62,7 @@ |
||
| 62 | 62 | |
| 63 | 63 | private function get_units($units = false) : float |
| 64 | 64 | { |
| 65 | - if ( $this->_deliverable->invoiceByActualUnits |
|
| 65 | + if ($this->_deliverable->invoiceByActualUnits |
|
| 66 | 66 | || $this->_deliverable->plannedUnits == 0) { |
| 67 | 67 | // In most cases we calculate the price based on the actual units entered |
| 68 | 68 | return $units ?: $this->_deliverable->units; |
@@ -60,7 +60,7 @@ |
||
| 60 | 60 | */ |
| 61 | 61 | public static function get_by_object(org_openpsa_invoices_interfaces_customer $object) : self |
| 62 | 62 | { |
| 63 | - if ( !($bd = self::get_billing_data(org_openpsa_contacts_group_dba::class, $object->customer)) |
|
| 63 | + if (!($bd = self::get_billing_data(org_openpsa_contacts_group_dba::class, $object->customer)) |
|
| 64 | 64 | // check if the customerContact is set and has invoice_data |
| 65 | 65 | && !($bd = self::get_billing_data(org_openpsa_contacts_person_dba::class, $object->customerContact))) { |
| 66 | 66 | $bd = new self(); |
@@ -26,7 +26,7 @@ |
||
| 26 | 26 | |
| 27 | 27 | private function load_controller() : controller |
| 28 | 28 | { |
| 29 | - if ( $this->_config->get('simple_name_handling') |
|
| 29 | + if ($this->_config->get('simple_name_handling') |
|
| 30 | 30 | && !midcom::get()->auth->admin) { |
| 31 | 31 | foreach ($this->_request_data['schemadb']->all() as $schema) { |
| 32 | 32 | $schema->get_field('name')['readonly'] = true; |
@@ -314,7 +314,7 @@ |
||
| 314 | 314 | |
| 315 | 315 | private function add_head_elements(bool $centralized = false) : bool |
| 316 | 316 | { |
| 317 | - if ( !midcom::get()->auth->user |
|
| 317 | + if (!midcom::get()->auth->user |
|
| 318 | 318 | || !midcom::get()->config->get('toolbars_enable_centralized') |
| 319 | 319 | || !midcom::get()->auth->can_user_do('midcom:centralized_toolbar', null, __CLASS__)) { |
| 320 | 320 | return false; |