net_nehmer_blog_handler_feed

Complexity

Total Complexity

14

Size/Duplication

Total Lines	120
Duplicated Lines	0 %

Test Coverage

Coverage

75.47%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	_create_feed()	0	12	2
A	_handler_feed()	0	35	4
B	_show_feed()	0	34	7
A	_handler_index()	0	6	1

<?php
/**
 * @package net.nehmer.blog
 * @author The Midgard Project, http://www.midgard-project.org
 * @copyright The Midgard Project, http://www.midgard-project.org
 * @license http://www.gnu.org/licenses/lgpl.html GNU Lesser General Public License
 */

use midcom\datamanager\datamanager;

/**
 * Blog Feed handler
 *
 * Prints the various supported feeds using the FeedCreator library.
 *
 * @package net.nehmer.blog
 */
class net_nehmer_blog_handler_feed extends midcom_baseclasses_components_handler
{
    use net_nehmer_blog_handler;

The trait net_nehmer_blog_handler requires some properties which are not provided by net_nehmer_blog_handler_feed: $name, $url, $guid, $revised, $metadata

    /**
     * @var midcom_db_article[]
     */
    private array $_articles;

    private UniversalFeedCreator $_feed;

    private string $category;

    /**
     * Shows the autoindex list. Nothing to do in the handle phase except setting last modified
     * dates.
     */
    public function _handler_feed(array &$data, ?string $category = null)
    {
        midcom::get()->cache->content->content_type("text/xml; charset=UTF-8");
        midcom::get()->skip_page_style = true;

        // Prepare control structures
        $data['datamanager'] = new datamanager($data['schemadb']);

        // Get the articles,
        $qb = midcom_db_article::new_query_builder();
        $this->article_qb_constraints($qb);

        $qb->add_order('metadata.published', 'DESC');

        if ($category) {
            // This is not a predefined category from configuration, check if site maintainer allows us to show it
            if (   !in_array($category, $data['categories'])
                && !$this->_config->get('categories_custom_enable')) {
                throw new midcom_error('Custom category support is disabled');
            }

            // TODO: Check for ".xml" suffix
            $this->category = trim(strip_tags($category));

            $this->apply_category_constraint($qb, $this->category);
        }

        $qb->set_limit($this->_config->get('rss_count'));

It seems like $this->_config->get('rss_count') can also be of type false; however, parameter $limit of midcom_core_query::set_limit() does only seem to accept integer, maybe add an additional type check?

        $this->_articles = $qb->execute();

        // Prepare the feed
        $this->_create_feed();

        midcom::get()->metadata->set_request_metadata($this->get_last_modified(), $this->_topic->guid);
    }

    /**
     * Creates the Feedcreator instance.
     */
    private function _create_feed()
    {
        $this->_feed = new UniversalFeedCreator();
        if ($this->_config->get('rss_title')) {
            $this->_feed->title = $this->_config->get('rss_title');
        } else {
            $this->_feed->title = $this->_topic->extra;
        }
        $this->_feed->description = $this->_config->get('rss_description');
        $this->_feed->language = $this->_config->get('rss_language');
        $this->_feed->editor = $this->_config->get('rss_webmaster');
        $this->_feed->link = midcom::get()->get_host_name() . midcom_core_context::get()->get_key(MIDCOM_CONTEXT_ANCHORPREFIX);

Are you sure midcom_core_context::get()->get_key(MIDCOM_CONTEXT_ANCHORPREFIX) of type false|mixed can be used in concatenation?

    }

    /**
     * Displays the feed
     */
    public function _show_feed(string $handler_id, array &$data)
    {
        $data['feedcreator'] = $this->_feed;

        // Add each article now.
        foreach ($this->_articles as $article) {
            $data['datamanager']->set_storage($article);
            $data['article'] = $article;
            midcom_show_style('feeds-item');
        }

        switch ($handler_id) {
            case 'feed-category-rss2':
                $this->_feed->title = sprintf($this->_l10n->get('%s category %s'), $this->_feed->title, $this->category);
                $this->_feed->syndicationURL = "{$this->_feed->link}feeds/category/{$this->category}";
                // Fall-through

            case 'feed-rss2':
                echo $this->_feed->createFeed('RSS2.0');
                break;

            case 'feed-rss1':
                $this->_feed->syndicationURL = $this->_feed->link . 'rss1.xml';
                echo $this->_feed->createFeed('RSS1.0');
                break;

            case 'feed-rss091':
                echo $this->_feed->createFeed('RSS0.91');
                break;

            case 'feed-atom':
                $this->_feed->syndicationURL = $this->_feed->link . 'atom.xml';
                echo $this->_feed->createFeed('ATOM');
                break;
        }
    }

    /**
     * Shows a simple available-feeds page.
     */
    public function _handler_index()
    {
        $this->set_active_leaf(net_nehmer_blog_navigation::LEAFID_FEEDS);
        midcom::get()->metadata->set_request_metadata($this->_topic->metadata->revised, $this->_topic->guid);

        return $this->show('feeds');
    }
}