flack / openpsa

lib/org/openpsa/invoices/handler/action.php

Spacing +8 added lines, -13 removed lines

@@ -29,7 +29,7 @@ 
     {
         midcom::get()->auth->require_valid_user();
 
-        if (   empty($_POST['id'])
+        if (empty($_POST['id'])
             || empty($_POST['action']))
         {
             throw new midcom_error('Incomplete POST data');
@@ -40,8 +40,7 @@ 
 
         midcom::get()->skip_page_style = true;
 
-        $data['message'] = array
-        (
+        $data['message'] = array(
             'title' => $this->_l10n->get($this->_component),
             'type' => 'error'
         );
@@ -199,8 +198,7 @@ 
         $mail = new org_openpsa_mail();
 
         // define replacements for subject / body
-        $mail->parameters = array
-        (
+        $mail->parameters = array(
             "INVOICE_LABEL" => $invoice_label,
             "INVOICE_DATE" => $invoice_date,
             "FIRSTNAME" => $contactDetails["firstname"],
@@ -327,7 +325,7 @@ 
         $invoice_sum = 0;
         foreach ($this->_request_data['invoice_items'] as $item)
         {
-            $entry =  array();
+            $entry = array();
             $entry['id'] = $item->id;
             try
             {
@@ -419,8 +417,7 @@ 
             default:
                 throw new midcom_error('Invalid operation "' . $_POST['oper'] . '"');
         }
-        $data['saved_values'] = array
-        (
+        $data['saved_values'] = array(
             'id' => $item->id,
             'quantity' => $item->units,
             'price' => $item->pricePerUnit,
@@ -432,7 +429,7 @@ 
 
     private function _verify_post_data()
     {
-        if (   empty($_POST['oper'])
+        if (empty($_POST['oper'])
             || !isset($_POST['id'])
             || !isset($_POST['description'])
             || !isset($_POST['price'])
@@ -490,10 +487,8 @@ 
         $this->add_breadcrumb("invoice/" . $this->_object->guid . "/", $this->_l10n->get('edit invoice items') . ': ' . $title);
 
         midcom::get()->head->set_pagetitle($this->_l10n->get('edit invoice items') . ': ' . $title);
-        $this->_view_toolbar->add_item
-        (
-            array
-            (
+        $this->_view_toolbar->add_item(
+            array(
                 MIDCOM_TOOLBAR_URL => "invoice/recalculation/{$this->_object->guid}/",
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n->get('recalculate_by_reports'),
                 MIDCOM_TOOLBAR_ICON => 'stock-icons/16x16/edit.png',

lib/org/openpsa/invoices/invoice/item.php

Spacing +6 added lines, -6 removed lines

@@ -18,7 +18,7 @@ 
 
     public function _on_creating()
     {
-        if (   $this->invoice
+        if ($this->invoice
             && $this->position == 0)
         {
             $invoice = org_openpsa_invoices_invoice_dba::get_cached($this->invoice);
@@ -71,9 +71,9 @@ 
                 $task = org_openpsa_projects_task_dba::get_cached($this->task);
                 $url = $projects_url . 'task/' . $task->guid . '/';
             }
-            catch (midcom_error $e){}
+            catch (midcom_error $e) {}
         }
-        if (   $url == ''
+        if ($url == ''
             && $sales_url)
         {
             try
@@ -81,7 +81,7 @@ 
                 $deliverable = org_openpsa_sales_salesproject_deliverable_dba::get_cached($this->deliverable);
                 $url = $sales_url . 'deliverable/' . $deliverable->guid . '/';
             }
-            catch (midcom_error $e){}
+            catch (midcom_error $e) {}
         }
         if ($url != '')
         {
@@ -100,7 +100,7 @@ 
                 $invoice = new org_openpsa_invoices_invoice_dba($this->invoice);
                 $old_sum = $invoice->sum;
                 self::update_invoice($invoice);
-                if (   $old_sum != $invoice->sum
+                if ($old_sum != $invoice->sum
                     && !empty($this->deliverable))
                 {
                     $deliverable = new org_openpsa_sales_salesproject_deliverable_dba($this->deliverable);
@@ -152,7 +152,7 @@ 
         if ($invoiced != $deliverable->invoiced)
         {
             $deliverable->invoiced = $invoiced;
-            if (   $deliverable->orgOpenpsaObtype !== org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
+            if ($deliverable->orgOpenpsaObtype !== org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
                 && $deliverable->state < org_openpsa_sales_salesproject_deliverable_dba::STATE_INVOICED)
             {
                 $deliverable->state = org_openpsa_sales_salesproject_deliverable_dba::STATE_INVOICED;

lib/org/openpsa/mypage/viewer.php

Spacing +2 added lines, -2 removed lines

@@ -69,8 +69,8 @@
         $query = '__TOPIC_URL:"' . midcom::get()->get_host_name() . '*"';
         $filter = new midcom_services_indexer_filter_date('__EDITED', $start, 0);
         $this->_request_data['today'] = $indexer->query($query, $filter);
-        $start = mktime(0, 0, 0, date('m'), date('d')-1, date('Y'));
-        $end = mktime(23, 59, 59, date('m'), date('d')-1, date('Y'));
+        $start = mktime(0, 0, 0, date('m'), date('d') - 1, date('Y'));
+        $end = mktime(23, 59, 59, date('m'), date('d') - 1, date('Y'));
         $query = '__TOPIC_URL:"' . midcom::get()->get_host_name() . '*"';
         $filter = new midcom_services_indexer_filter_date('__EDITED', $start, $end);
         $this->_request_data['yesterday'] = $indexer->query($query, $filter);

lib/org/openpsa/mypage/workingon.php

Spacing +1 added lines, -2 removed lines

@@ -125,8 +125,7 @@
         }
 
         // Mark the new task work session as started
-        $workingon = array
-        (
+        $workingon = array(
             'task' => $task_guid,
             'description' => $description,
             'invoiceable' => $invoiceable,

lib/org/openpsa/mypage/handler/today.php

Spacing +6 added lines, -11 removed lines

@@ -15,22 +15,18 @@ 
 {
     private function _populate_toolbar()
     {
-        $buttons = array
-        (
-            array
-            (
+        $buttons = array(
+            array(
                 MIDCOM_TOOLBAR_URL => 'weekreview/' . $this->_request_data['this_day'] . '/',
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n->get('week review'),
                 MIDCOM_TOOLBAR_ICON => 'stock-icons/16x16/properties.png',
             ),
-            array
-            (
+            array(
                 MIDCOM_TOOLBAR_URL => 'day/' . $this->_request_data['prev_day'] . '/',
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n_midcom->get('previous'),
                 MIDCOM_TOOLBAR_ICON => 'stock-icons/16x16/back.png',
             ),
-            array
-            (
+            array(
                 MIDCOM_TOOLBAR_URL => 'day/' . $this->_request_data['next_day'] . '/',
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n_midcom->get('next'),
                 MIDCOM_TOOLBAR_ICON => 'stock-icons/16x16/next.png',
@@ -77,10 +73,9 @@ 
         org_openpsa_widgets_calendar::add_head_elements();
 
         //set the start-constraints for journal-entries
-        $time_span = 7 * 24 * 60 * 60 ; //7 days
+        $time_span = 7 * 24 * 60 * 60; //7 days
 
-        $this->_request_data['journal_constraints'] = array
-        (
+        $this->_request_data['journal_constraints'] = array(
             //just show entries of current_user
             array(
                 'property' => 'metadata.creator',

lib/org/openpsa/mypage/handler/workingon.php

Spacing +4 added lines, -6 removed lines

@@ -30,8 +30,7 @@ 
         $task_conf = midcom_helper_datamanager2_widget_autocomplete::get_widget_config('task');
         $task_conf['id_field'] = 'guid';
 
-        $task_conf['constraints'][] = array
-        (
+        $task_conf['constraints'][] = array(
             'field' => 'status',
             'op'    => '<',
             'value' => org_openpsa_projects_task_status_dba::COMPLETED,
@@ -65,8 +64,7 @@ 
         $hours = $hours_mc->list_keys();
 
         $this->_request_data['customers'] = array();
-        $this->_request_data['hours'] = array
-        (
+        $this->_request_data['hours'] = array(
             'invoiceable' => array(),
             'uninvoiceable' => array(),
             'total_invoiceable' => 0,
@@ -106,7 +104,7 @@ 
                         $customer_label = $customer->official;
                         $customer = $customer_id;
                     }
-                    catch (midcom_error $e){}
+                    catch (midcom_error $e) {}
                }
             }
             $customer_cache[$array['task']] = $customer;
@@ -173,7 +171,7 @@ 
         $workingon = new org_openpsa_mypage_workingon();
         if (!$workingon->set($_POST['task']))
         {
-            midcom::get()->uimessages->add($this->_l10n->get('org.openpsa.mypage'),  'Failed to set "working on" parameter to "' . $_POST['task'] . '", reason ' . midcom_connection::get_error_string(), 'error');
+            midcom::get()->uimessages->add($this->_l10n->get('org.openpsa.mypage'), 'Failed to set "working on" parameter to "' . $_POST['task'] . '", reason ' . midcom_connection::get_error_string(), 'error');
         }
 
         return new midcom_response_relocate($relocate . "workingon/");

lib/org/openpsa/documents/elFinderVolumeOpenpsa.php

Spacing +8 added lines, -9 removed lines

@@ -18,7 +18,7 @@ 
         // elfinder tmp detection doesn't work on OS X
         $this->tmpPath = midcom::get()->config->get('midcom_tempdir');
         // elfinder calls exit(), so we need to make sure we write caches
-        register_shutdown_function(function(){midcom::get()->finish();});
+        register_shutdown_function(function() {midcom::get()->finish(); });
     }
 
 	/**
@@ -40,7 +40,7 @@ 
 		}
 
 		if (($dir = $this->dir($dst)) == false) {
-			return $this->setError(elFinder::ERROR_TRGDIR_NOT_FOUND, '#'.$dst);
+			return $this->setError(elFinder::ERROR_TRGDIR_NOT_FOUND, '#' . $dst);
 		}
 
 		if (!$dir['write']) {
@@ -81,7 +81,7 @@ 
 
 		if ($file && $file['name'] === $name) { // file exists and check filename for item ID based filesystem
 			// check POST data `overwrite` for 3rd party uploader
-			$overwrite = isset($_POST['overwrite'])? (bool)$_POST['overwrite'] : $this->options['uploadOverwrite'];
+			$overwrite = isset($_POST['overwrite']) ? (bool) $_POST['overwrite'] : $this->options['uploadOverwrite'];
 			if ($overwrite) {
 				if (!$file['write']) {
 					return $this->setError(elFinder::ERROR_PERM_DENIED);
@@ -280,7 +280,7 @@ 
             $output[] = $object->extra;
         }
         $parent = $object->get_parent();
-        while (   $parent
+        while ($parent
                && $parent->component == 'org.openpsa.documents')
         {
             $output[] = $parent->extra;
@@ -354,8 +354,7 @@ 
         }
         $object = midcom::get()->dbfactory->get_object_by_guid($path);
 
-        $data = array
-        (
+        $data = array(
             'ts' => $object->metadata->revised,
             'read' => true,
             'write' => $object->can_do('midgard:update'),
@@ -465,7 +464,7 @@ 
      * @param  string $mode open mode
      * @return resource|false
      */
-    protected function _fopen($path, $mode="rb")
+    protected function _fopen($path, $mode = "rb")
     {
         $document = new org_openpsa_documents_document_dba($path);
         $attachments = org_openpsa_helpers::get_dm2_attachments($document, 'document');
@@ -484,7 +483,7 @@ 
      * @param  string    $path  file path
      * @return bool
      */
-    protected function _fclose($fp, $path='')
+    protected function _fclose($fp, $path = '')
     {
         fclose($fp);
         return true;
@@ -688,7 +687,7 @@ 
     {
         $filename = midcom_db_attachment::safe_filename($name, true);
         $att = $doc->create_attachment($filename, $name, $mimetype);
-        if (   !$att
+        if (!$att
             || !$att->copy_from_handle($fp))
         {
             return false;

lib/org/openpsa/documents/document.php

Spacing +7 added lines, -8 removed lines

@@ -18,8 +18,7 @@ 
     public $__midcom_class_name__ = __CLASS__;
     public $__mgdschema_class_name__ = 'org_openpsa_document';
 
-    public $autodelete_dependents = array
-    (
+    public $autodelete_dependents = array(
         'org_openpsa_documents_document_dba' => 'nextVersion'
     );
 
@@ -79,7 +78,7 @@ 
             return;
         }
         $parent = $this->get_parent();
-        if (   $parent
+        if ($parent
             && $parent->component == 'org.openpsa.documents')
         {
             midcom::get()->auth->request_sudo('org.openpsa.documents');
@@ -95,7 +94,7 @@ 
 
     public function get_class()
     {
-        if (   !midcom::get()->auth->user
+        if (!midcom::get()->auth->user
             || empty($this->guid))
         {
             return '';
@@ -103,7 +102,7 @@ 
         $person = midcom::get()->auth->user->get_storage();
         $lastvisited = $person->get_parameter('org.openpsa.documents_visited', $this->guid);
 
-        if (   $lastvisited
+        if ($lastvisited
             && $lastvisited > $this->metadata->revised)
         {
             return 'visited';
@@ -201,7 +200,7 @@ 
          * if nothing matched so far and the subtype is alphanumeric, uppercase it on the theory
          * that it's probably a file extension
          */
-        if (   $parts[1] == $subtype
+        if ($parts[1] == $subtype
             && preg_match('/^[a-z0-9]+$/', $subtype))
         {
             $subtype = strtoupper($subtype);
@@ -218,7 +217,7 @@ 
         // Copy current properties
         foreach ($properties as $key)
         {
-            if (   $key != 'guid'
+            if ($key != 'guid'
                 && $key != 'id'
                 && $key != 'metadata')
             {
@@ -263,7 +262,7 @@ 
             $backup_attachment = $backup->create_attachment($original_attachment->name, $original_attachment->title, $original_attachment->mimetype);
 
             $original_handle = $original_attachment->open('r');
-            if (   !$backup_attachment
+            if (!$backup_attachment
                 || !$original_handle)
             {
                 // Failed to copy the attachment, abort

lib/org/openpsa/documents/handler/document/view.php

Spacing +6 added lines, -11 removed lines

@@ -98,7 +98,7 @@ 
             $entry['mimetype'] = org_openpsa_documents_document_dba::get_file_type($att->mimetype);
         }
 
-        $title = '<a class="tab_escape" href="' .$prefix . 'document/' . $document->guid .'/"><img src="' . $icon . '"';
+        $title = '<a class="tab_escape" href="' . $prefix . 'document/' . $document->guid . '/"><img src="' . $icon . '"';
         $title .= 'alt="' . $alt . '" style="border: 0px; height: 16px; vertical-align: middle" /> ' . $document->title . '</a>';
 
         $entry['title'] = $title;
@@ -226,8 +226,7 @@ 
         if ($this->_document->can_do('midgard:update'))
         {
             $workflow = $this->get_workflow('datamanager2');
-            $this->_view_toolbar->add_item($workflow->get_button("document/edit/{$this->_document->guid}/", array
-            (
+            $this->_view_toolbar->add_item($workflow->get_button("document/edit/{$this->_document->guid}/", array(
                 MIDCOM_TOOLBAR_ACCESSKEY => 'e',
             )));
         }
@@ -291,10 +290,8 @@ 
 
         if ($next_version)
         {
-            $this->_view_toolbar->add_item
-            (
-                array
-                (
+            $this->_view_toolbar->add_item(
+                array(
                     MIDCOM_TOOLBAR_URL => "document/{$next_version->guid}/",
                     MIDCOM_TOOLBAR_LABEL => $this->_l10n->get('next version'),
                     MIDCOM_TOOLBAR_ICON => 'stock-icons/16x16/up.png',
@@ -303,10 +300,8 @@ 
         }
         if ($previous_version)
         {
-            $this->_view_toolbar->add_item
-            (
-                array
-                (
+            $this->_view_toolbar->add_item(
+                array(
                     MIDCOM_TOOLBAR_URL => "document/{$previous_version->guid}/",
                     MIDCOM_TOOLBAR_LABEL => $this->_l10n->get('previous version'),
                     MIDCOM_TOOLBAR_ICON => 'stock-icons/16x16/down.png',