flack / openpsa

lib/org/openpsa/calendar/midcom/interfaces.php

Spacing +2 added lines, -3 removed lines

@@ -103,7 +103,7 @@ 
         $root_event = self::find_root_event();
 
         $qb = org_openpsa_calendar_event_dba::new_query_builder();
-        $qb->add_constraint('up', '=',  $root_event->id);
+        $qb->add_constraint('up', '=', $root_event->id);
         $schemadb = midcom_helper_datamanager2_schema::load_database($config->get('schemadb'));
 
         $indexer = new org_openpsa_calendar_midcom_indexer($topic, $indexer);
@@ -123,8 +123,7 @@ 
         }
 
         $workflow = new midcom\workflow\datamanager2;
-        return $workflow->get_button("new/" . $url, array
-        (
+        return $workflow->get_button("new/" . $url, array(
             MIDCOM_TOOLBAR_LABEL => midcom::get()->i18n->get_string('create event', 'org.openpsa.calendar'),
             MIDCOM_TOOLBAR_ICON => 'stock-icons/16x16/stock_new-event.png',
         ));

lib/org/openpsa/slideshow/handler/index.php

Spacing +3 added lines, -6 removed lines

@@ -42,16 +42,13 @@
             $head->enable_jquery();
             $head->add_jsfile(MIDCOM_STATIC_URL . '/' . $this->_component . '/galleria/galleria-1.3.5.min.js');
         }
-        $buttons = array
-        (
-            array
-            (
+        $buttons = array(
+            array(
                 MIDCOM_TOOLBAR_URL => "edit/",
                 MIDCOM_TOOLBAR_LABEL => sprintf($this->_l10n_midcom->get('edit %s'), $this->_l10n->get('slideshow')),
                 MIDCOM_TOOLBAR_ICON => 'stock-icons/16x16/configuration.png',
             ),
-            array
-            (
+            array(
                 MIDCOM_TOOLBAR_URL => "recreate_folder_thumbnails/",
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n->get('recreate subfolder thumbnails'),
                 MIDCOM_TOOLBAR_ICON => 'stock-icons/16x16/stock_refresh.png',

lib/org/openpsa/slideshow/handler/edit.php

Spacing +7 added lines, -11 removed lines

@@ -66,7 +66,7 @@ 
         $failed = 0;
         foreach ($images as $image)
         {
-            if (   !$image->generate_image('thumbnail', $this->_config->get('thumbnail_filter'))
+            if (!$image->generate_image('thumbnail', $this->_config->get('thumbnail_filter'))
                 || !$image->generate_image('image', $this->_config->get('image_filter')))
             {
                 $failed++;
@@ -102,8 +102,7 @@ 
         $data['images'] = $qb->execute();
 
         $head = midcom::get()->head;
-        $head->enable_jquery_ui(array
-        (
+        $head->enable_jquery_ui(array(
             'mouse', 'draggable', 'droppable', 'sortable',
             'progressbar', 'button', 'position', 'dialog',
             'effect', 'effect-pulsate'
@@ -113,16 +112,13 @@ 
         $head->add_jsfile(MIDCOM_STATIC_URL . '/' . $this->_component . '/edit.js');
         $head->add_stylesheet(MIDCOM_STATIC_URL . '/' . $this->_component . '/edit.css');
 
-        $buttons = array
-        (
-            array
-            (
+        $buttons = array(
+            array(
                 MIDCOM_TOOLBAR_URL => "",
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n_midcom->get('view'),
                 MIDCOM_TOOLBAR_ICON => 'stock-icons/16x16/view.png',
             ),
-            array
-            (
+            array(
                 MIDCOM_TOOLBAR_URL => "recreate/",
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n->get('recreate derived images'),
                 MIDCOM_TOOLBAR_ICON => 'stock-icons/16x16/stock_refresh.png',
@@ -272,7 +268,7 @@ 
                 }
                 //Fall-through
             case 'create':
-                if (   !isset($_POST['title'])
+                if (!isset($_POST['title'])
                     || !isset($_POST['description'])
                     || !isset($_POST['position']))
                 {
@@ -297,7 +293,7 @@ 
         $attachment->title = $_POST['title'];
         $attachment->mimetype = $file['type'];
         $attachment->parentguid = $image->guid;
-        if (   !$attachment->create()
+        if (!$attachment->create()
             || !$attachment->copy_from_file($file['tmp_name']))
         {
             throw new midcom_error('Failed to create attachment: ' . midcom_connection::get_error_string());

lib/org/openpsa/invoices/viewer.php

Spacing +8 added lines, -15 removed lines

@@ -56,7 +56,7 @@ 
         }
 
         // generate next action buttons
-        if (   $invoice->can_do('midgard:update')
+        if ($invoice->can_do('midgard:update')
             && count($next_marker) > 0)
         {
             foreach ($next_marker as $mark)
@@ -73,10 +73,8 @@ 
     {
         if ($mode !== 'dashboard')
         {
-            $this->_view_toolbar->add_item
-            (
-                array
-                (
+            $this->_view_toolbar->add_item(
+                array(
                     MIDCOM_TOOLBAR_URL => '',
                     MIDCOM_TOOLBAR_LABEL => $this->_l10n->get('dashboard'),
                     MIDCOM_TOOLBAR_ICON => 'stock-icons/16x16/stock_left.png',
@@ -86,8 +84,7 @@ 
         if (midcom::get()->auth->can_user_do('midgard:create', null, 'org_openpsa_invoices_invoice_dba'))
         {
             $workflow = $this->get_workflow('datamanager2');
-            $this->_view_toolbar->add_item($workflow->get_button('invoice/new/', array
-            (
+            $this->_view_toolbar->add_item($workflow->get_button('invoice/new/', array(
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n->get('create invoice'),
                 MIDCOM_TOOLBAR_ICON => 'stock-icons/16x16/printer.png',
             )));
@@ -106,10 +103,8 @@ 
 
             if (sizeof($results) == 1)
             {
-                $toolbar->add_item
-                (
-                    array
-                    (
+                $toolbar->add_item(
+                    array(
                         MIDCOM_TOOLBAR_URL => $urlprefix . key($results) . '/',
                         MIDCOM_TOOLBAR_LABEL => $this->_l10n_midcom->get('previous'),
                         MIDCOM_TOOLBAR_ICON => 'stock-icons/16x16/back.png',
@@ -129,10 +124,8 @@ 
 
             if (sizeof($results) == 1)
             {
-                $toolbar->add_item
-                (
-                    array
-                    (
+                $toolbar->add_item(
+                    array(
                         MIDCOM_TOOLBAR_URL => $urlprefix . key($results) . '/',
                         MIDCOM_TOOLBAR_LABEL => $this->_l10n_midcom->get('next'),
                         MIDCOM_TOOLBAR_ICON => 'stock-icons/16x16/next.png',

lib/org/openpsa/invoices/status.php

Spacing +9 added lines, -16 removed lines

@@ -115,8 +115,7 @@ 
             $cancelation_invoice = new org_openpsa_invoices_invoice_dba($this->invoice->cancelationInvoice);
             $cancelation_invoice_link = $prefix . 'invoice/' . $cancelation_invoice->guid . '/';
             $cancelation_invoice_link = "<a href=\"" . $cancelation_invoice_link . "\">" . $this->l10n->get('invoice') . " " . $cancelation_invoice->get_label() . "</a>";
-            $entries[] = array
-            (
+            $entries[] = array(
                 'timestamp' => $cancelation_invoice->metadata->created,
                 'message' => sprintf($this->l10n->get('invoice got canceled by %s'), $cancelation_invoice_link),
                 'order' => 4
@@ -124,20 +123,18 @@ 
         }
         else if ($this->invoice->paid)
         {
-            $entries[] = array
-            (
+            $entries[] = array(
                 'timestamp' => $this->invoice->paid,
                 'message' => sprintf($this->l10n->get('marked invoice %s paid'), ''),
                 'order' => 3
             );
         }
-        if (   $this->invoice->due
-            && (   (   $this->invoice->due < time()
+        if ($this->invoice->due
+            && (($this->invoice->due < time()
                     && $this->invoice->paid == 0)
                 || $this->invoice->due < $this->invoice->paid))
         {
-            $entries[] = array
-            (
+            $entries[] = array(
                 'timestamp' => $this->invoice->due,
                 'message' => $this->l10n->get('overdue'),
                 'order' => 2
@@ -148,8 +145,7 @@ 
         {
             if ($mail_time = $this->invoice->get_parameter('org.openpsa.invoices', 'sent_by_mail'))
             {
-                $entries[] = array
-                (
+                $entries[] = array(
                     'timestamp' => $mail_time,
                     'message' => sprintf($this->l10n->get('marked invoice %s sent per mail'), ''),
                     'order' => 1
@@ -157,16 +153,14 @@ 
             }
             else
             {
-                $entries[] = array
-                (
+                $entries[] = array(
                     'timestamp' => $this->invoice->sent,
                     'message' => sprintf($this->l10n->get('marked invoice %s sent'), ''),
                     'order' => 1
                 );
             }
         }
-        $entries[] = array
-        (
+        $entries[] = array(
             'timestamp' => $this->invoice->metadata->created,
             'message' => sprintf($this->l10n->get('invoice %s created'), ''),
             'order' => 0
@@ -183,8 +177,7 @@ 
 
         foreach ($rows as $row)
         {
-            $entries[] = array
-            (
+            $entries[] = array(
                 'timestamp' => strtotime((string) $row['created']),
                 'message' => $row['title']
             );

lib/org/openpsa/invoices/scheduler.php

Spacing +5 added lines, -6 removed lines

@@ -92,7 +92,7 @@ 
         }
 
         // TODO: Warehouse management: create new order
-        if (   $this->_deliverable->end < $next_cycle_start
+        if ($this->_deliverable->end < $next_cycle_start
             && $this->_deliverable->end != 0)
         {
             debug_add('Do not register next cycle, the contract ends before');
@@ -112,8 +112,7 @@ 
 
     private function _create_at_entry($cycle_number, $start)
     {
-        $args = array
-        (
+        $args = array(
             'deliverable' => $this->_deliverable->guid,
             'cycle'       => $cycle_number,
         );
@@ -344,7 +343,7 @@ 
         {
             //If previous cycle was run at the end of the month, the new one should be at the end of the month as well
             $date = new DateTime(gmdate('Y-m-d', $time), new DateTimeZone('GMT'));
-            if (   $date->format('t') == $date->format('j')
+            if ($date->format('t') == $date->format('j')
                 && $new_date->format('t') != $new_date->format('j'))
             {
                 $new_date->setDate((int) $new_date->format('Y'), (int) $new_date->format('m'), (int) $new_date->format('t'));
@@ -415,11 +414,11 @@ 
                 break;
             case 'q':
                 // Quarterly recurring subscription
-                $identifier = ceil(((int)$date->format('n')) / 4) . 'Q' . $date->format('y');
+                $identifier = ceil(((int) $date->format('n')) / 4) . 'Q' . $date->format('y');
                 break;
             case 'hy':
                 // Half-yearly recurring subscription
-                $identifier = ceil(((int)$date->format('n')) / 6) . '/' . $date->format('Y');
+                $identifier = ceil(((int) $date->format('n')) / 6) . '/' . $date->format('Y');
                 break;
             case 'y':
                 // Yearly recurring subscription

lib/org/openpsa/invoices/handler/scheduled.php

Spacing +1 added lines, -2 removed lines

@@ -50,8 +50,7 @@
 
     public function get_row(midcom_core_dbaobject $at_entry)
     {
-        $invoice = array
-        (
+        $invoice = array(
             'time' => strftime('%Y-%m-%d %H:%M:%S', $at_entry->start),
             'month' => strftime('%B %Y', $at_entry->start),
             'index_month' => strftime('%Y-%m', $at_entry->start),

lib/org/openpsa/invoices/handler/crud.php

Spacing +18 added lines, -29 removed lines

@@ -18,7 +18,7 @@ 
     public function _load_schemadb()
     {
         $this->_schemadb = midcom_helper_datamanager2_schema::load_database($this->_config->get('schemadb'));
-        if (   $this->_mode == 'create'
+        if ($this->_mode == 'create'
             && count($this->_master->_handler['args']) == 1)
         {
             // We're creating invoice for chosen customer
@@ -39,7 +39,7 @@ 
      */
     private function _modify_schema()
     {
-        $fields =& $this->_schemadb['default']->fields;
+        $fields = & $this->_schemadb['default']->fields;
         // Fill VAT select
         $vat_array = explode(',', $this->_config->get('vat_percentages'));
         if (!empty($vat_array))
@@ -100,7 +100,7 @@ 
      */
     private function _populate_schema_customers_for_contact($contact_id)
     {
-        $fields =& $this->_schemadb['default']->fields;
+        $fields = & $this->_schemadb['default']->fields;
         $organizations = array(0 => '');
         $member_mc = org_openpsa_contacts_member_dba::new_collector('uid', $contact_id);
         $member_mc->add_constraint('gid.orgOpenpsaObtype', '>', org_openpsa_contacts_group_dba::MYCONTACTS);
@@ -123,7 +123,7 @@ 
 
     private function _populate_schema_contacts_for_customer($customer)
     {
-        $fields =& $this->_schemadb['default']->fields;
+        $fields = & $this->_schemadb['default']->fields;
         // We know the customer company, present contact as a select widget
         $persons_array = array();
         $member_mc = midcom_db_member::new_collector('gid', $customer->id);
@@ -135,7 +135,7 @@ 
                 $person = org_openpsa_contacts_person_dba::get_cached($member);
                 $persons_array[$person->id] = $person->rname;
             }
-            catch (midcom_error $e){}
+            catch (midcom_error $e) {}
         }
         asort($persons_array);
         $fields['customerContact']['widget'] = 'select';
@@ -156,7 +156,7 @@ 
     {
         $this->_object = new org_openpsa_invoices_invoice_dba();
 
-        if (! $this->_object->create())
+        if (!$this->_object->create())
         {
             debug_print_r('We operated on this object:', $this->_object);
             throw new midcom_error("Failed to create a new invoice. Error: " . midcom_connection::get_error_string());
@@ -233,8 +233,7 @@ 
         if ($this->_object->can_do('midgard:update'))
         {
             $workflow = $this->get_workflow('datamanager2');
-            $buttons[] = $workflow->get_button("invoice/edit/{$this->_object->guid}/", array
-            (
+            $buttons[] = $workflow->get_button("invoice/edit/{$this->_object->guid}/", array(
                 MIDCOM_TOOLBAR_ACCESSKEY => 'e',
             ));
         }
@@ -245,8 +244,7 @@ 
             $buttons[] = $workflow->get_button("invoice/delete/{$this->_object->guid}/");
         }
 
-        $buttons[] = array
-        (
+        $buttons[] = array(
             MIDCOM_TOOLBAR_URL => "invoice/items/{$this->_object->guid}/",
             MIDCOM_TOOLBAR_LABEL => $this->_l10n->get('edit invoice items'),
             MIDCOM_TOOLBAR_ICON => 'stock-icons/16x16/edit.png',
@@ -255,14 +253,12 @@ 
 
         if (!$this->_object->sent)
         {
-            $buttons[] = array
-            (
+            $buttons[] = array(
                 MIDCOM_TOOLBAR_URL => "invoice/process/",
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n->get('mark sent'),
                 MIDCOM_TOOLBAR_ICON => 'stock-icons/16x16/stock_mail-reply.png',
                 MIDCOM_TOOLBAR_POST => true,
-                MIDCOM_TOOLBAR_POST_HIDDENARGS => array
-                (
+                MIDCOM_TOOLBAR_POST_HIDDENARGS => array(
                     'action' => 'mark_sent',
                     'id' => $this->_object->id,
                     'relocate' => true
@@ -272,14 +268,12 @@ 
         }
         else if (!$this->_object->paid)
         {
-            $buttons[] = array
-            (
+            $buttons[] = array(
                 MIDCOM_TOOLBAR_URL => "invoice/process/",
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n->get('mark paid'),
                 MIDCOM_TOOLBAR_ICON => 'stock-icons/16x16/ok.png',
                 MIDCOM_TOOLBAR_POST => true,
-                MIDCOM_TOOLBAR_POST_HIDDENARGS => array
-                (
+                MIDCOM_TOOLBAR_POST_HIDDENARGS => array(
                     'action' => 'mark_paid',
                     'id' => $this->_object->id,
                     'relocate' => true
@@ -288,11 +282,10 @@ 
             );
         }
 
-        if (   !$this->_object->paid
+        if (!$this->_object->paid
             && $this->_config->get('invoice_pdfbuilder_class'))
         {
-            $buttons[] = array
-            (
+            $buttons[] = array(
                 MIDCOM_TOOLBAR_URL => "invoice/pdf/{$this->_object->guid}/",
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n->get('create pdf'),
                 MIDCOM_TOOLBAR_ICON => 'stock-icons/16x16/printer.png',
@@ -301,14 +294,12 @@ 
             $billing_data = $this->_object->get_billing_data();
             if (intval($billing_data->sendingoption) == 2)
             {
-                $buttons[] = array
-                (
+                $buttons[] = array(
                     MIDCOM_TOOLBAR_URL => "invoice/process/",
                     MIDCOM_TOOLBAR_LABEL => $this->_l10n->get('mark sent_per_mail'),
                     MIDCOM_TOOLBAR_ICON => 'stock-icons/16x16/stock_mail-reply.png',
                     MIDCOM_TOOLBAR_POST => true,
-                    MIDCOM_TOOLBAR_POST_HIDDENARGS => array
-                    (
+                    MIDCOM_TOOLBAR_POST_HIDDENARGS => array(
                         'action' => 'send_by_mail',
                         'id' => $this->_object->id,
                         'relocate' => true
@@ -320,14 +311,12 @@ 
 
         if ($this->_object->is_cancelable())
         {
-            $buttons[] = array
-            (
+            $buttons[] = array(
                 MIDCOM_TOOLBAR_URL => "invoice/process/",
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n->get('create cancelation'),
                 MIDCOM_TOOLBAR_ICON => 'stock-icons/16x16/cancel.png',
                 MIDCOM_TOOLBAR_POST => true,
-                MIDCOM_TOOLBAR_POST_HIDDENARGS => array
-                (
+                MIDCOM_TOOLBAR_POST_HIDDENARGS => array(
                     'action' => 'create_cancelation',
                     'id' => $this->_object->id,
                     'relocate' => true

lib/org/openpsa/invoices/handler/billingdata.php

Spacing +5 added lines, -7 removed lines

@@ -25,7 +25,7 @@ 
     {
         $schemadb = midcom_helper_datamanager2_schema::load_database($this->_config->get('schemadb_billing_data'));
 
-        $fields =& $schemadb[$this->get_schema_name()]->fields;
+        $fields = & $schemadb[$this->get_schema_name()]->fields;
         // Fill VAT select
         $vat_array = explode(',', $this->_config->get('vat_percentages'));
         if (!empty($vat_array))
@@ -53,7 +53,7 @@ 
     {
         $billing_data = new org_openpsa_invoices_billing_data_dba();
         $billing_data->linkGuid = $this->_linked_object->guid;
-        if (! $billing_data->create())
+        if (!$billing_data->create())
         {
             debug_print_r('We operated on this object:', $billing_data);
             throw new midcom_error("Failed to create a new billing_data. Error: " . midcom_connection::get_error_string());
@@ -82,11 +82,10 @@ 
         }
 
         $workflow = $this->get_workflow('datamanager2', array('controller' => $data['controller']));
-        if (   $mode == 'edit'
+        if ($mode == 'edit'
             && $billing_data[0]->can_do('midgard:delete'))
         {
-            $delete = $this->get_workflow('delete', array
-            (
+            $delete = $this->get_workflow('delete', array(
                 'object' => $billing_data[0],
                 'label' => $this->_l10n->get('billing data')
             ));
@@ -109,8 +108,7 @@ 
         $billing_data->require_do('midgard:delete');
         $this->_linked_object = midcom::get()->dbfactory->get_object_by_guid($billing_data->linkGuid);
 
-        $workflow = $this->get_workflow('delete', array
-        (
+        $workflow = $this->get_workflow('delete', array(
             'object' => $billing_data,
             'success_url' => $this->get_relocate_url()
         ));