flack / openpsa

lib/org/openpsa/directmarketing/handler/logger.php

Spacing +2 added lines, -2 removed lines

@@ -88,7 +88,7 @@ 
         $qb = org_openpsa_directmarketing_campaign_messagereceipt_dba::new_query_builder();
         $qb->add_constraint('token', '=', $token);
         $qb->add_constraint('orgOpenpsaObtype', '=', $type);
-        $ret =  $qb->execute();
+        $ret = $qb->execute();
         debug_print_r("_qb_token_receipts({$token}) returned", $ret);
         if (empty($ret))
         {
@@ -182,7 +182,7 @@ 
         }
         $this->_request_data['token'] = $args[0];
 
-        if (   count($args) == 2
+        if (count($args) == 2
             && !empty($args[1]))
         {
             //Due to the way browsers handle the URLs this form only works for root pages

Braces +2 added lines, -4 removed lines

@@ -187,12 +187,10 @@
         {
             //Due to the way browsers handle the URLs this form only works for root pages
             $this->_request_data['target'] = $args[1];
-        }
-        else if (!empty($_GET['link']))
+        } else if (!empty($_GET['link']))
         {
             $this->_request_data['target'] = $_GET['link'];
-        }
-        else
+        } else
         {
             throw new midcom_error('Target not present in address or GET, or is empty');
         }

lib/org/openpsa/directmarketing/handler/message/message.php

Spacing +9 added lines, -16 removed lines

@@ -42,7 +42,7 @@ 
     /**
      * Looks up an message to display.
      */
-    public function _handler_view ($handler_id, array $args, array &$data)
+    public function _handler_view($handler_id, array $args, array &$data)
     {
         midcom::get()->auth->require_valid_user();
         $this->_message = new org_openpsa_directmarketing_campaign_message_dba($args[0]);
@@ -71,8 +71,7 @@ 
         $buttons = array();
         if ($this->_message->can_do('midgard:update'))
         {
-            $buttons[] = $workflow->get_button("message/edit/{$this->_message->guid}/", array
-            (
+            $buttons[] = $workflow->get_button("message/edit/{$this->_message->guid}/", array(
                 MIDCOM_TOOLBAR_ACCESSKEY => 'e',
             ));
         }
@@ -83,8 +82,7 @@ 
         }
         if ($this->_message->can_do('midgard:update'))
         {
-            $buttons[] = $workflow->get_button("message/copy/{$this->_message->guid}/", array
-            (
+            $buttons[] = $workflow->get_button("message/copy/{$this->_message->guid}/", array(
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n->get('copy message'),
                 MIDCOM_TOOLBAR_ICON => 'stock-icons/16x16/editcopy.png',
             ));
@@ -95,16 +93,14 @@ 
         {
             $preview_url .= midcom::get()->auth->user->guid . '/';
         }
-        $buttons[] = array
-        (
+        $buttons[] = array(
             MIDCOM_TOOLBAR_URL => $preview_url,
             MIDCOM_TOOLBAR_LABEL => $this->_l10n->get('preview message'),
             MIDCOM_TOOLBAR_ICON => 'stock-icons/16x16/view.png',
             MIDCOM_TOOLBAR_ACCESSKEY => 'p',
             MIDCOM_TOOLBAR_OPTIONS => array('target' => '_BLANK'),
         );
-        $buttons[] = array
-        (
+        $buttons[] = array(
             MIDCOM_TOOLBAR_URL => "message/report/{$this->_message->guid}/",
             MIDCOM_TOOLBAR_LABEL => $this->_l10n->get("message report"),
             MIDCOM_TOOLBAR_ACCESSKEY => 'r',
@@ -112,8 +108,7 @@ 
         );
 
         $this->_campaign->get_testers();
-        $buttons[] = array
-        (
+        $buttons[] = array(
             MIDCOM_TOOLBAR_URL => "message/send_test/{$this->_message->guid}/",
             MIDCOM_TOOLBAR_LABEL => $this->_l10n->get("send message to testers"),
             MIDCOM_TOOLBAR_ICON => 'stock-icons/16x16/stock_mail-send.png',
@@ -126,14 +121,12 @@ 
         $keys = $mc->list_keys();
 
         // Show the message send if there are recipients
-        $buttons[] = array
-        (
+        $buttons[] = array(
             MIDCOM_TOOLBAR_URL => "message/send/{$this->_message->guid}/",
             MIDCOM_TOOLBAR_LABEL => $this->_l10n->get("send message to whole campaign"),
             MIDCOM_TOOLBAR_ICON => 'stock-icons/16x16/stock_mail-send.png',
             MIDCOM_TOOLBAR_ENABLED => (count($keys) > 0 && $this->_message->can_do('midgard:update')),
-            MIDCOM_TOOLBAR_OPTIONS => array
-            (
+            MIDCOM_TOOLBAR_OPTIONS => array(
                 'onclick' => "return confirm('" . $this->_l10n->get('are you sure you wish to send this to the whole campaign') . "')",
             )
         );
@@ -143,7 +136,7 @@ 
     /**
      * Shows the loaded message.
      */
-    public function _show_view ($handler_id, array &$data)
+    public function _show_view($handler_id, array &$data)
     {
         $data['view_message'] = $this->_datamanager->get_content_html();
         midcom_show_style('show-message');

lib/org/openpsa/directmarketing/handler/message/compose.php

Spacing +2 added lines, -2 removed lines

@@ -80,7 +80,7 @@ 
             throw new midcom_error('"content" not defined in schema');
         }
         //Substyle handling
-        if (   !empty($data['message_array']['substyle'])
+        if (!empty($data['message_array']['substyle'])
             && !preg_match('/^builtin:/', $data['message_array']['substyle']))
         {
             debug_add("Appending substyle {$data['message_array']['substyle']}");
@@ -126,7 +126,7 @@ 
     private function _real_show_compose($handler_id, array &$data)
     {
         $prefix = '';
-        if (   !empty($data['message_array']['substyle'])
+        if (!empty($data['message_array']['substyle'])
             && preg_match('/^builtin:(.*)/', $data['message_array']['substyle'], $matches_style))
         {
             $prefix = $matches_style[1] . '-';

Braces +1 added lines, -2 removed lines

@@ -246,8 +246,7 @@
             {
                 $result = array();
                 $size = 0;
-            }
-            else
+            } else
             {
                 $result = array_slice($result, $this->_offset);
                 $size = $size - $this->_offset;

lib/org/openpsa/directmarketing/handler/message/list.php

Spacing +2 added lines, -2 removed lines

@@ -27,7 +27,7 @@ 
     /**
      * Looks up an message to display.
      */
-    public function _handler_list ($handler_id, array $args, array &$data)
+    public function _handler_list($handler_id, array $args, array &$data)
     {
         midcom::get()->auth->require_valid_user();
         $this->_campaign = $this->_master->load_campaign($args[1]);
@@ -39,7 +39,7 @@ 
     /**
      * Shows the loaded message.
      */
-    public function _show_list ($handler_id, array &$data)
+    public function _show_list($handler_id, array &$data)
     {
         $qb = new org_openpsa_qbpager('org_openpsa_directmarketing_campaign_message_dba', 'campaign_messages');
         $qb->results_per_page = 10;

lib/org/openpsa/directmarketing/handler/message/send.php

Spacing +2 added lines, -3 removed lines

@@ -122,14 +122,13 @@
     private function _get_sender(array &$data)
     {
         $data['message_array'] = $this->_datamanager->get_content_raw();
-        $data['message_array']['dm_types'] =& $this->_datamanager->types;
+        $data['message_array']['dm_types'] = & $this->_datamanager->types;
         if (!array_key_exists('content', $data['message_array']))
         {
             throw new midcom_error('"content" not defined in schema');
         }
 
-        $settings = array
-        (
+        $settings = array(
             'mail_send_backend' => 'mail_send_backend',
             'bouncer_address' => 'bounce_detector_address',
             'linkdetector_address' => 'link_detector_address',

Braces +1 added lines, -2 removed lines

@@ -81,8 +81,7 @@
             {
                 throw new midcom_error(midcom_connection::get_error_string());
             }
-        }
-        else
+        } else
         {
             $nodes = $object_qb->execute();
             $node = $nodes[0];

lib/org/openpsa/directmarketing/handler/message/report.php

Spacing +36 added lines, -55 removed lines

@@ -43,8 +43,7 @@ 
      */
     private function _analyze_message_report(array $data)
     {
-        $this->_request_data['report'] = array
-        (
+        $this->_request_data['report'] = array(
             'campaign_data' => array(),
             'receipt_data' => array()
         );
@@ -52,7 +51,7 @@ 
         $qb_receipts->add_constraint('message', '=', $this->_message->id);
         $qb_receipts->add_constraint('orgOpenpsaObtype', '=', org_openpsa_directmarketing_campaign_messagereceipt_dba::SENT);
         $receipts = $qb_receipts->execute_unchecked();
-        $receipt_data =& $this->_request_data['report']['receipt_data'];
+        $receipt_data = & $this->_request_data['report']['receipt_data'];
         $receipt_data['first_send'] = time();
         $receipt_data['last_send'] = 0;
         $receipt_data['sent'] = count($receipts);
@@ -90,7 +89,7 @@ 
 
     private function _get_campaign_data($first_send)
     {
-        $campaign_data =& $this->_request_data['report']['campaign_data'];
+        $campaign_data = & $this->_request_data['report']['campaign_data'];
         $qb_unsub = org_openpsa_directmarketing_campaign_member_dba::new_query_builder();
         $qb_unsub->add_constraint('campaign', '=', $this->_message->campaign);
         $qb_unsub->add_constraint('orgOpenpsaObtype', '=', org_openpsa_directmarketing_campaign_member_dba::UNSUBSCRIBED);
@@ -98,8 +97,8 @@ 
         $campaign_data['next_message'] = false;
         // Find "next message" and if present use its sendStarted as constraint for this query
         $qb_messages = org_openpsa_directmarketing_campaign_message_dba::new_query_builder();
-        $qb_messages->add_constraint('campaign', '=',  $this->_message->campaign);
-        $qb_messages->add_constraint('id', '<>',  $this->_message->id);
+        $qb_messages->add_constraint('campaign', '=', $this->_message->campaign);
+        $qb_messages->add_constraint('id', '<>', $this->_message->id);
         $qb_messages->add_constraint('sendStarted', '>', $first_send);
         $qb_messages->add_order('sendStarted', 'DESC');
         $qb_messages->set_limit(1);
@@ -115,7 +114,7 @@ 
     private function _get_link_data($segmentation_param)
     {
         $this->_request_data['report']['link_data'] = array();
-        $link_data =& $this->_request_data['report']['link_data'];
+        $link_data = & $this->_request_data['report']['link_data'];
 
         $link_data['counts'] = array();
         $link_data['percentages'] = array('of_links' => array(), 'of_recipients' => array());
@@ -142,7 +141,7 @@ 
         {
             $segment = '';
             $segment_notfound = false;
-            if (   $segmentation_param
+            if ($segmentation_param
                 && !empty($link->person))
             {
                 try
@@ -150,7 +149,7 @@ 
                     $person = org_openpsa_contacts_person_dba::get_cached($link->person);
                     $segment = $person->get_parameter('org.openpsa.directmarketing.segments', $segmentation_param);
                 }
-                catch (midcom_error $e){}
+                catch (midcom_error $e) {}
                 if (empty($segment))
                 {
                     $segment = $this->_l10n->get('no segment');
@@ -160,7 +159,7 @@ 
                 {
                     $link_data['segments'][$segment] = $segment_prototype;
                 }
-                $segment_data =& $link_data['segments'][$segment];
+                $segment_data = & $link_data['segments'][$segment];
             }
             else
             {
@@ -182,27 +181,22 @@ 
 
                 if (!$segment_notfound)
                 {
-                    $segmentrule = array
-                    (
+                    $segmentrule = array(
                         'comment' => $this->_l10n->get('segment limits'),
                         'type' => 'AND',
                         'class' => 'org_openpsa_contacts_person_dba',
-                        'rules' => array
-                        (
-                            array
-                            (
+                        'rules' => array(
+                            array(
                                 'property' => 'parameter.domain',
                                 'match' => '=',
                                 'value' => 'org.openpsa.directmarketing.segments',
                             ),
-                            array
-                            (
+                            array(
                                 'property' => 'parameter.name',
                                 'match' => '=',
                                 'value' => $segmentation_param,
                             ),
-                            array
-                            (
+                            array(
                                 'property' => 'parameter.value',
                                 'match' => '=',
                                 'value' => $segment,
@@ -233,28 +227,22 @@ 
 
     private function _generate_link_rules(org_openpsa_directmarketing_link_log_dba $link)
     {
-        return array
-        (
+        return array(
             'comment' => sprintf($this->_l10n->get('all persons who have clicked on link "%s" in message #%d and have not unsubscribed from campaign #%d'), $link->target, $link->message, $this->_message->campaign),
             'type' => 'AND',
-            'classes' => array
-            (
-                array
-                (
+            'classes' => array(
+                array(
                     'comment' => $this->_l10n->get('link and message limits'),
                     'type' => 'AND',
                     'class' => 'org_openpsa_directmarketing_link_log_dba',
-                    'rules' => array
-                    (
-                        array
-                        (
+                    'rules' => array(
+                        array(
                             'property' => 'target',
                             'match' => '=',
                             'value' => $link->target,
                         ),
                         // PONDER: do we want to limit to this message only ??
-                        array
-                        (
+                        array(
                             'property' => 'message',
                             'match' => '=',
                             'value' => $link->message,
@@ -262,21 +250,17 @@ 
                     ),
                 ),
                 // Add rule that prevents unsubscribed persons from ending up to the smart-campaign ??
-                array
-                (
+                array(
                     'comment' => $this->_l10n->get('not-unsubscribed -limits'),
                     'type' => 'AND',
                     'class' => 'org_openpsa_directmarketing_campaign_member_dba',
-                    'rules' => array
-                    (
-                        array
-                        (
+                    'rules' => array(
+                        array(
                             'property' => 'orgOpenpsaObtype',
                             'match' => '<>',
                             'value' => org_openpsa_directmarketing_campaign_member_dba::UNSUBSCRIBED,
                         ),
-                        array
-                        (
+                        array(
                             'property' => 'campaign',
                             'match' => '=',
                             'value' => $this->_message->campaign,
@@ -292,15 +276,15 @@ 
         $this->_initialize_field($array['percentages']['of_links'], $link);
         $this->_initialize_field($array['percentages']['of_recipients'], $link);
 
-        $link_data =& $this->_request_data['report']['link_data'];
-        $array['percentages']['of_links'][$link->target]['total'] = ($array['counts'][$link->target]['total']/$link_data['total'])*100;
-        $array['percentages']['of_links'][$link->target][$link->token] = ($array['counts'][$link->target][$link->token]/$link_data['total'])*100;
+        $link_data = & $this->_request_data['report']['link_data'];
+        $array['percentages']['of_links'][$link->target]['total'] = ($array['counts'][$link->target]['total'] / $link_data['total']) * 100;
+        $array['percentages']['of_links'][$link->target][$link->token] = ($array['counts'][$link->target][$link->token] / $link_data['total']) * 100;
 
-        $receipt_data =& $this->_request_data['report']['receipt_data'];
-        $array['percentages']['of_recipients'][$link->target]['total'] = ((count($array['counts'][$link->target])-1)/($receipt_data['sent']-$receipt_data['bounced']))*100;
-        $array['percentages']['of_recipients'][$link->target][$link->token] = ($array['counts'][$link->target][$link->token]/($receipt_data['sent']-$receipt_data['bounced']))*100;
+        $receipt_data = & $this->_request_data['report']['receipt_data'];
+        $array['percentages']['of_recipients'][$link->target]['total'] = ((count($array['counts'][$link->target]) - 1) / ($receipt_data['sent'] - $receipt_data['bounced'])) * 100;
+        $array['percentages']['of_recipients'][$link->target][$link->token] = ($array['counts'][$link->target][$link->token] / ($receipt_data['sent'] - $receipt_data['bounced'])) * 100;
 
-        if (   !isset($array['percentages']['of_recipients']['total'])
+        if (!isset($array['percentages']['of_recipients']['total'])
             || $array['percentages']['of_recipients'][$link->target]['total'] > $array['percentages']['of_recipients']['total'])
         {
             $array['percentages']['of_recipients']['total'] = $array['percentages']['of_recipients'][$link->target]['total'];
@@ -371,7 +355,7 @@ 
         $this->_campaign = $this->_master->load_campaign($this->_message->campaign);
         $data['campaign'] = $this->_campaign;
 
-        if (   isset($_POST['oo_dirmar_userule'])
+        if (isset($_POST['oo_dirmar_userule'])
             && !empty($_POST['oo_dirmar_rule_' . $_POST['oo_dirmar_userule']]))
         {
             return $this->_create_campaign_from_link($_POST['oo_dirmar_userule']);
@@ -385,19 +369,16 @@ 
         $preview_url = "message/compose/{$this->_message->guid}/";
         if (!empty(midcom::get()->auth->user->guid))
         {
-            $preview_url .= midcom::get()->auth->user->guid .'/';
+            $preview_url .= midcom::get()->auth->user->guid . '/';
         }
 
-        $buttons = array
-        (
-            array
-            (
+        $buttons = array(
+            array(
                 MIDCOM_TOOLBAR_URL => "message/{$this->_message->guid}/",
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n_midcom->get("back"),
                 MIDCOM_TOOLBAR_ICON => 'stock-icons/16x16/stock_left.png',
             ),
-            array
-            (
+            array(
                 MIDCOM_TOOLBAR_URL => $preview_url,
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n->get('preview message'),
                 MIDCOM_TOOLBAR_ICON => 'stock-icons/16x16/view.png',

Braces +2 added lines, -4 removed lines

@@ -149,8 +149,7 @@ 
                 {
                     $person = org_openpsa_contacts_person_dba::get_cached($link->person);
                     $segment = $person->get_parameter('org.openpsa.directmarketing.segments', $segmentation_param);
-                }
-                catch (midcom_error $e){}
+                } catch (midcom_error $e){}
                 if (empty($segment))
                 {
                     $segment = $this->_l10n->get('no segment');
@@ -161,8 +160,7 @@ 
                     $link_data['segments'][$segment] = $segment_prototype;
                 }
                 $segment_data =& $link_data['segments'][$segment];
-            }
-            else
+            } else
             {
                 $segment_data = $segment_prototype;
             }

lib/org/openpsa/directmarketing/handler/message/create.php

Spacing +2 added lines, -3 removed lines

@@ -56,7 +56,7 @@ 
     /**
      * DM2 creation callback, binds to the current content topic.
      */
-    public function & dm2_create_callback (&$controller)
+    public function & dm2_create_callback(&$controller)
     {
         $this->_message = new org_openpsa_directmarketing_campaign_message_dba();
         //  duh ? (copy-paste artefact ??)
@@ -88,8 +88,7 @@ 
         $data['controller'] = $this->get_controller('create');
         midcom::get()->head->set_pagetitle(sprintf($this->_l10n_midcom->get('create %s'), $this->_l10n->get($this->_schemadb[$this->_schema]->description)));
 
-        $workflow = $this->get_workflow('datamanager2', array
-        (
+        $workflow = $this->get_workflow('datamanager2', array(
             'controller' => $data['controller'],
             'save_callback' => array($this, 'save_callback')
         ));

lib/org/openpsa/directmarketing/handler/message/admin.php

Spacing +6 added lines, -9 removed lines

@@ -51,9 +51,9 @@ 
     {
         $this->_load_schemadb();
         $this->_controller = midcom_helper_datamanager2_controller::create('simple');
-        $this->_controller->schemadb =& $this->_schemadb;
+        $this->_controller->schemadb = & $this->_schemadb;
         $this->_controller->set_storage($this->_message);
-        if (! $this->_controller->initialize())
+        if (!$this->_controller->initialize())
         {
             throw new midcom_error("Failed to initialize a DM2 controller instance for message {$this->_message->id}.");
         }
@@ -90,8 +90,7 @@ 
     {
         $message = new org_openpsa_directmarketing_campaign_message_dba($args[0]);
         $campaign = new org_openpsa_directmarketing_campaign_dba($message->campaign);
-        $workflow = $this->get_workflow('delete', array
-        (
+        $workflow = $this->get_workflow('delete', array(
             'object' => $message,
             'success_url' => "campaign/{$campaign->guid}/"
         ));
@@ -114,13 +113,12 @@ 
 
         $this->_schemadb = midcom_helper_datamanager2_schema::load_database($this->_config->get('schemadb_message_copy'));
         $this->_controller = midcom_helper_datamanager2_controller::create('nullstorage');
-        $this->_controller->schemadb =& $this->_schemadb;
+        $this->_controller->schemadb = & $this->_schemadb;
         $this->_controller->initialize();
 
         midcom::get()->head->set_pagetitle($this->_l10n->get('copy message'));
 
-        $workflow = $this->get_workflow('datamanager2', array
-        (
+        $workflow = $this->get_workflow('datamanager2', array(
             'controller' => $this->_controller,
             'save_callback' => array($this, 'copy_callback')
         ));
@@ -142,8 +140,7 @@ 
             $new_object = $copy->copy_object($original, $campaign, array('sendStarted' => 0, 'sendCompleted' => 0));
 
             // Store for later use
-            $copy_data[] = array
-            (
+            $copy_data[] = array(
                 'message' => $new_object,
                 'campaign' => $campaign
             );

lib/org/openpsa/directmarketing/handler/campaign/campaign.php

Spacing +8 added lines, -14 removed lines

@@ -60,8 +60,7 @@ 
         $siteconfig = org_openpsa_core_siteconfig::get_instance();
         $url = $siteconfig->get_node_full_url('org.openpsa.contacts') . 'person/';
 
-        $row = array
-        (
+        $row = array(
             'id' => $person->id,
             'index_firstname' => $person->firstname,
             'firstname' => '<a target="_blank" href="' . $url . $person->guid . '/">' . $person->firstname . '</a>',
@@ -95,7 +94,7 @@ 
     /**
      * Looks up an campaign to display.
      */
-    public function _handler_view ($handler_id, array $args, array &$data)
+    public function _handler_view($handler_id, array $args, array &$data)
     {
         $this->_campaign = $this->_master->load_campaign($args[0]);
 
@@ -123,8 +122,7 @@ 
         $buttons = array();
         if ($this->_campaign->can_do('midgard:update'))
         {
-            $buttons[] = $workflow->get_button("campaign/edit/{$this->_campaign->guid}/", array
-            (
+            $buttons[] = $workflow->get_button("campaign/edit/{$this->_campaign->guid}/", array(
                 MIDCOM_TOOLBAR_ACCESSKEY => 'e',
             ));
         }
@@ -138,8 +136,7 @@ 
         if ($this->_campaign->orgOpenpsaObtype == org_openpsa_directmarketing_campaign_dba::TYPE_SMART)
         {
             //Edit query parameters button in case 1) not in edit mode 2) is smart campaign 3) can edit
-            $buttons[] = array
-            (
+            $buttons[] = array(
                 MIDCOM_TOOLBAR_URL => "campaign/edit_query/{$this->_campaign->guid}/",
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n->get('edit rules'),
                 MIDCOM_TOOLBAR_ICON => 'stock-icons/16x16/repair.png',
@@ -149,16 +146,14 @@ 
         else
         {
             // Import button if we have permissions to create users
-            $buttons[] = array
-            (
+            $buttons[] = array(
                 MIDCOM_TOOLBAR_URL => "campaign/import/{$this->_campaign->guid}/",
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n->get('import subscribers'),
                 MIDCOM_TOOLBAR_ICON => 'stock-icons/16x16/stock_people.png',
                 MIDCOM_TOOLBAR_ENABLED => midcom::get()->auth->can_user_do('midgard:create', null, 'org_openpsa_contacts_person_dba'),
             );
         }
-        $buttons[] = array
-        (
+        $buttons[] = array(
             MIDCOM_TOOLBAR_URL => "campaign/export/csv/{$this->_campaign->guid}/",
             MIDCOM_TOOLBAR_LABEL => $this->_l10n->get('export as csv'),
             MIDCOM_TOOLBAR_ICON => 'stock-icons/16x16/stock_data-edit-table.png',
@@ -169,8 +164,7 @@ 
             $schemadb_message = midcom_helper_datamanager2_schema::load_database($this->_config->get('schemadb_message'));
             foreach ($schemadb_message as $name => $schema)
             {
-                $buttons[] = $workflow->get_button("message/create/{$this->_campaign->guid}/{$name}/", array
-                (
+                $buttons[] = $workflow->get_button("message/create/{$this->_campaign->guid}/{$name}/", array(
                     MIDCOM_TOOLBAR_LABEL => sprintf($this->_l10n->get('new %s'), $this->_l10n->get($schema->description)),
                     MIDCOM_TOOLBAR_ICON => 'stock-icons/16x16/' . org_openpsa_directmarketing_viewer::get_messagetype_icon($schema->customdata['org_openpsa_directmarketing_messagetype']),
                 ));
@@ -182,7 +176,7 @@ 
     /**
      * Shows the loaded campaign.
      */
-    public function _show_view ($handler_id, array &$data)
+    public function _show_view($handler_id, array &$data)
     {
         $data['view_campaign'] = $this->_datamanager->get_content_html();
         midcom_show_style('show-campaign');

Braces +1 added lines, -2 removed lines

@@ -81,8 +81,7 @@
             {
                 throw new midcom_error(midcom_connection::get_error_string());
             }
-        }
-        else
+        } else
         {
             $nodes = $object_qb->execute();
             $node = $nodes[0];