flack / openpsa

lib/org/openpsa/calendar/event/resource.php

Braces +2 added lines, -1 removed lines

@@ -43,7 +43,8 @@
         }
         try {
             $resource = org_openpsa_calendar_resource_dba::get_cached($this->resource);
-        } catch (midcom_error) {
+        }
+        catch (midcom_error) {
             debug_add("Cannot fetch resource #{$this->resource} returning false", MIDCOM_LOG_INFO);
             return false;
         }

lib/org/openpsa/invoices/invoice/item.php

Spacing +4 added lines, -4 removed lines

@@ -25,7 +25,7 @@ 
 
     public function _on_creating() : bool
     {
-        if (   $this->invoice
+        if ($this->invoice
             && $this->position == 0) {
             $invoice = org_openpsa_invoices_invoice_dba::get_cached($this->invoice);
             $this->position = count($invoice->get_invoice_items()) + 1;
@@ -75,7 +75,7 @@ 
             } catch (midcom_error) {
             }
         }
-        if (   $url == ''
+        if ($url == ''
             && $sales_url) {
             try {
                 $deliverable = org_openpsa_sales_salesproject_deliverable_dba::get_cached($this->deliverable);
@@ -97,7 +97,7 @@ 
                 $invoice = new org_openpsa_invoices_invoice_dba($this->invoice);
                 $old_sum = $invoice->sum;
                 self::update_invoice($invoice);
-                if (   $old_sum != $invoice->sum
+                if ($old_sum != $invoice->sum
                     && !empty($this->deliverable)) {
                     $deliverable = new org_openpsa_sales_salesproject_deliverable_dba($this->deliverable);
                     self::update_deliverable($deliverable);
@@ -135,7 +135,7 @@ 
 
         if ($invoiced != $deliverable->invoiced) {
             $deliverable->invoiced = $invoiced;
-            if (   $deliverable->orgOpenpsaObtype !== org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
+            if ($deliverable->orgOpenpsaObtype !== org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
                 && $deliverable->state < org_openpsa_sales_salesproject_deliverable_dba::STATE_INVOICED) {
                 $deliverable->state = org_openpsa_sales_salesproject_deliverable_dba::STATE_INVOICED;
             }

Braces +6 added lines, -3 removed lines

@@ -72,7 +72,8 @@ 
             try {
                 $task = org_openpsa_projects_task_dba::get_cached($this->task);
                 $url = $projects_url . 'task/' . $task->guid . '/';
-            } catch (midcom_error) {
+            }
+            catch (midcom_error) {
             }
         }
         if (   $url == ''
@@ -80,7 +81,8 @@ 
             try {
                 $deliverable = org_openpsa_sales_salesproject_deliverable_dba::get_cached($this->deliverable);
                 $url = $sales_url . 'deliverable/' . $deliverable->guid . '/';
-            } catch (midcom_error) {
+            }
+            catch (midcom_error) {
             }
         }
         if ($url != '') {
@@ -102,7 +104,8 @@ 
                     $deliverable = new org_openpsa_sales_salesproject_deliverable_dba($this->deliverable);
                     self::update_deliverable($deliverable);
                 }
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
         }

lib/org/openpsa/invoices/billing/data.php

Braces +6 added lines, -3 removed lines

@@ -86,7 +86,8 @@ 
             // if the property useContactAddress is set
             $billing_data[0]->set_address();
             return $billing_data[0];
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
             return null;
         }
@@ -131,10 +132,12 @@ 
     {
         try {
             return new org_openpsa_contacts_person_dba($this->linkGuid);
-        } catch (midcom_error) {
+        }
+        catch (midcom_error) {
             try {
                 return new org_openpsa_contacts_group_dba($this->linkGuid);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 debug_add("Failed to load contact with GUID: " . $this->linkGuid . " - last error:" . $e->getMessage(), MIDCOM_LOG_ERROR);
                 return false;
             }

Spacing +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
     /**
      * Get the billing data for given contact if any.
      */
-    private static function get_billing_data(string $dba_class, string|int $contact_id) : ?self
+    private static function get_billing_data(string $dba_class, string | int $contact_id) : ?self
     {
         if ($contact_id == 0) {
             return null;

lib/org/openpsa/invoices/handler/invoice/items.php

Braces +4 added lines, -2 removed lines

@@ -40,7 +40,8 @@ 
                 if ($sales_url) {
                     $entry['deliverable'] = '<a href="' . $sales_url . 'deliverable/' . $deliverable->guid . '/">' . $entry['deliverable'] . '</a>';
                 }
-            } catch (midcom_error) {
+            }
+            catch (midcom_error) {
                 $entry['deliverable'] = '';
             }
             try {
@@ -49,7 +50,8 @@ 
                 if ($projects_url) {
                     $entry['task'] = '<a href="' . $projects_url . 'task/' . $task->guid . '/">' . $entry['task'] . '</a>';
                 }
-            } catch (midcom_error) {
+            }
+            catch (midcom_error) {
                 $entry['task'] = '';
             }
 

lib/org/openpsa/invoices/handler/projects.php

Braces +6 added lines, -3 removed lines

@@ -49,7 +49,8 @@ 
             try {
                 $deliverable = org_openpsa_sales_salesproject_deliverable_dba::get_cached($task->get_agreement());
                 $item->deliverable = $deliverable->id;
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
             $item->invoice = $invoice->id;
@@ -121,7 +122,8 @@ 
                 $customer = org_openpsa_contacts_group_dba::get_cached($customer_id);
                 $data['customer_label'] = $customer->official;
                 $data['disabled'] = '';
-            } catch (midcom_error) {
+            }
+            catch (midcom_error) {
                 $data['customer_label'] = $this->_l10n->get('no customer');
                 $data['disabled'] = ' disabled="disabled"';
             }
@@ -144,7 +146,8 @@ 
                     } else {
                         $data['invoiceable_units'] = $task->plannedHours;
                     }
-                } catch (midcom_error $e) {
+                }
+                catch (midcom_error $e) {
                     $e->log();
                     if ($this->_config->get('default_hourly_price')) {
                         $data['default_price'] = $this->_config->get('default_hourly_price');

lib/org/openpsa/slideshow/style/edit.php

Braces +2 added lines, -1 removed lines

@@ -21,7 +21,8 @@
         $original = new midcom_db_attachment($image->attachment);
         $original_url = midcom_db_attachment::get_url($original);
         $name = $original->name;
-    } catch (midcom_error) {
+    }
+    catch (midcom_error) {
         $url = MIDCOM_STATIC_URL . '/stock-icons/mime/gnome-text-blank.png';
         $name = $data['l10n']->get('attachment missing');
         $original_url = '';

lib/org/openpsa/reports/viewer.php

Braces +2 added lines, -1 removed lines

@@ -98,7 +98,8 @@
             $node_guid = $siteconfig->get_node_guid($component);
             try {
                 $available_generators[$component] = midcom_db_topic::get_cached($node_guid)->get_label();
-            } catch (midcom_error) {
+            }
+            catch (midcom_error) {
                 debug_add("topic for component '{$component}' not found or accessible");
             }
         }

lib/org/openpsa/relatedto/exec/delete_dangling_links.php

Braces +2 added lines, -1 removed lines

@@ -25,7 +25,8 @@
     try {
         midcom::get()->dbfactory->get_object_by_guid($result->fromGuid);
         midcom::get()->dbfactory->get_object_by_guid($result->toGuid);
-    } catch (midcom_error) {
+    }
+    catch (midcom_error) {
         echo $i . "/" . $total . ": Deleting relatedto #" . $result->id . "\n";
         $result->delete();
     }

lib/org/openpsa/relatedto/handler/relatedto.php

Braces +6 added lines, -3 removed lines

@@ -107,7 +107,8 @@ 
             //TODO: check for duplicates ?
             try {
                 $result = ['other_obj' => midcom::get()->dbfactory->get_object_by_guid($link[$other . 'Guid'])];
-            } catch (midcom_error) {
+            }
+            catch (midcom_error) {
                 continue;
             }
             $result['link'] = [
@@ -378,7 +379,8 @@ 
             if (!($this->_object instanceof org_openpsa_relatedto_dba)) {
                 $response['status'] = "method requires guid of a link object as an argument";
             }
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $response['status'] = "error: " . $e->getMessage();
         }
 
@@ -399,7 +401,8 @@ 
             $relation = new org_openpsa_relatedto_dba($guid);
             $result = $relation->delete();
             $status = 'Last message: ' . midcom_connection::get_error_string();
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $result = false;
             $status = "Object '{$guid}' could not be loaded, error:" . $e->getMessage();
         }

Spacing +2 added lines, -2 removed lines

@@ -185,10 +185,10 @@
      *
      * @param array $link The necessary link information
      */
-    private function _render_line(array $link, midcom_core_dbaobject &$other_obj)
+    private function _render_line(array $link, midcom_core_dbaobject & $other_obj)
     {
         $this->_request_data['link'] = $link;
-        $this->_request_data['other_obj'] =& $other_obj;
+        $this->_request_data['other_obj'] = & $other_obj;
         $this->_request_data['icon'] = midcom_helper_reflector::get_object_icon($other_obj);
 
         if ($other_obj::class != $link['class']) {