flack / openpsa

src/midcom/console/command/reindex.php

Braces +2 added lines, -1 removed lines

@@ -73,7 +73,8 @@
             if (is_a($stat, midcom_services_indexer_client::class)) {
                 try {
                     $stat->reindex();
-                } catch (RequestException $e) {
+                }
+                catch (RequestException $e) {
                     if ($e->hasResponse()) {
                         $crawler = new Crawler($e->getResponse()->getBody()->getContents());
                         $body = $crawler->filterXPath('//body')->html();

lib/org/openpsa/directmarketing/sender/backend/email.php

Spacing +1 added lines, -1 removed lines

@@ -166,7 +166,7 @@
         $address = addslashes($address);
         return preg_replace_callback(
             '/href="(http:\/\/.*?)"/i',
-            function ($match) use ($address) {
+            function($match) use ($address) {
                 return 'href="' . str_replace("URL", rawurlencode($match[1]), $address) . '"';
             },
             $html);

Indentation +7 added lines, -7 removed lines

@@ -148,13 +148,13 @@
     }
 
     /**
-    * Inserts a link detector to the given HTML source. All outgoing
-    * HTTP links in the source HTML are replaced with the given
-    * link detector address so that the token "URL" is replaced with
-    * encoded form of the original link. It is expected that the link detector
-    * address points to a script that records the passed link and
-    * forwards the client to the real link target.
-    */
+     * Inserts a link detector to the given HTML source. All outgoing
+     * HTTP links in the source HTML are replaced with the given
+     * link detector address so that the token "URL" is replaced with
+     * encoded form of the original link. It is expected that the link detector
+     * address points to a script that records the passed link and
+     * forwards the client to the real link target.
+     */
     private function _insert_link_detector(string $html, string $address) : string
     {
         $address = addslashes($address);

lib/midgard/admin/asgard/style/ASGARD_ROOT.php

Braces +4 added lines, -2 removed lines

@@ -122,7 +122,8 @@ 
                             try {
                                 $creator = new midcom_db_person($view_metadata->get('creator'));
                                 $creator_string = "<a href=\"" . midcom_connection::get_url('self') . "__mfa/asgard/object/view/{$creator->guid}/\">$creator->name</a>";
-                            } catch (midcom_error $e) {
+                            }
+                            catch (midcom_error $e) {
                                 $creator_string = $l10n->get('unknown person');
                             }
                             $created = (int) $view_metadata->get('created');
@@ -135,7 +136,8 @@ 
                                 try {
                                     $editor = new midcom_db_person($view_metadata->get('revisor'));
                                     $editor_string = "<a href=\"" . midcom_connection::get_url('self') . "__mfa/asgard/object/view/{$editor->guid}/\">$editor->name</a>";
-                                } catch (midcom_error $e) {
+                                }
+                                catch (midcom_error $e) {
                                     $editor_string = $l10n->get('unknown person');
                                 }
 

Spacing +1 added lines, -1 removed lines

@@ -127,7 +127,7 @@
 
                             $edited = (int) $view_metadata->get('revised');
                             $revision = $view_metadata->get('revision');
-                            if (   $revision > 0
+                            if ($revision > 0
                                 && $edited != $created) {
                                 try {
                                     $editor = new midcom_db_person($view_metadata->get('revisor'));

lib/midcom/services/auth/main.php

Braces +2 added lines, -1 removed lines

@@ -575,7 +575,8 @@
                     $param = $param->__object;
                 }
                 $this->_group_cache[$id] = new midcom_core_group($param);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 debug_add("Group with identifier {$id} could not be loaded: " . $e->getMessage(), MIDCOM_LOG_WARN);
                 $this->_group_cache[$id] = null;
             }

Spacing +1 added lines, -1 removed lines

@@ -221,7 +221,7 @@
             return true;
         }
         if ($user === null) {
-            $user =& $this->user;
+            $user = & $this->user;
         }
 
         if ($user == 'EVERYONE') {

lib/midcom/services/auth/backend.php

Braces +2 added lines, -1 removed lines

@@ -87,7 +87,8 @@
                     $param = $param->__object;
                 }
                 $this->_user_cache[$id] = new midcom_core_user($param);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 // Keep it silent while missing user object can mess here
                 $this->_user_cache[$id] = null;
             }

Spacing +2 added lines, -2 removed lines

@@ -100,7 +100,7 @@ 
             return null;
         }
 
-        if (   midcom::get()->config->get('auth_check_client_ip')
+        if (midcom::get()->config->get('auth_check_client_ip')
             && $data['clientip'] != $request->getClientIp()) {
             debug_add("The session had mismatching client IP.", MIDCOM_LOG_INFO);
             debug_add("Expected {$data['clientip']}, got {$request->getClientIp()}.");
@@ -114,7 +114,7 @@ 
             return null;
         }
 
-        if (   !$this->check_timestamp($data['timestamp'], $user)
+        if (!$this->check_timestamp($data['timestamp'], $user)
             || !$this->authenticate($user->username, '', true)) {
             $this->logout($user);
             return null;

lib/midgard/admin/asgard/plugin.php

Spacing +2 added lines, -2 removed lines

@@ -164,7 +164,7 @@ 
 
         $parent = $object->get_parent();
 
-        if (   is_a($object, midcom_db_parameter::class)
+        if (is_a($object, midcom_db_parameter::class)
             && !empty($parent->guid)) {
             // Add "parameters" list to breadcrumb if we're in a param
             $breadcrumb[] = [
@@ -174,7 +174,7 @@ 
         }
 
         $i = 0;
-        while (   !empty($parent->guid)
+        while (!empty($parent->guid)
                && $i < 10) {
             $i++;
             $parent_reflector = midcom_helper_reflector::get($parent);

lib/midgard/admin/asgard/schemadb.php

Spacing +4 added lines, -4 removed lines

@@ -64,7 +64,7 @@ 
 
     protected function add_string_field(string $key, string $type)
     {
-        if (   $key == 'component'
+        if ($key == 'component'
             && $type == midcom_db_topic::class) {
             $this->_add_component_dropdown($key);
             return;
@@ -134,12 +134,12 @@ 
         parent::add_longtext_field($key);
 
         // Check the user preference and configuration
-        if (   in_array($key, ['content', 'description'])
+        if (in_array($key, ['content', 'description'])
             && midgard_admin_asgard_plugin::get_preference('tinymce_enabled')) {
             $this->schema['fields'][$key]['widget'] = 'tinymce';
         }
 
-        if (   in_array($key, ['value', 'code'])
+        if (in_array($key, ['value', 'code'])
             && midgard_admin_asgard_plugin::get_preference('codemirror_enabled')) {
             $this->schema['fields'][$key]['widget'] = 'codemirror';
         }
@@ -257,7 +257,7 @@ 
         if ($score1 > $score2) {
             return 1;
         }
-        if (   $score1 < 3
+        if ($score1 < 3
             || $score1 > 6) {
             return strnatcmp($first, $second);
         }

lib/midgard/admin/asgard/handler/component/configuration.php

Spacing +2 added lines, -2 removed lines

@@ -277,7 +277,7 @@ 
     {
         $success = true;
         foreach ($this->_request_data['config']->_global as $global_key => $global_value) {
-            if (   isset($config[$global_key])
+            if (isset($config[$global_key])
                 && $config[$global_key] != $global_value) {
                 continue;
                 // Skip the ones we will set next
@@ -290,7 +290,7 @@ 
         }
 
         foreach ($config as $key => $value) {
-            if (   is_array($value)
+            if (is_array($value)
                 || is_object($value)) {
                 /**
                  * See http://trac.midgard-project.org/ticket/1442

lib/midgard/admin/asgard/schemadb/config.php

Spacing +2 added lines, -2 removed lines

@@ -61,11 +61,11 @@
                 $fields[$key] = $this->detect_schema($key, $value);
             }
 
-            if (   !isset($this->config->_local[$key])
+            if (!isset($this->config->_local[$key])
                 || $this->config->_local[$key] == $this->config->_global[$key]) {
                 // No local configuration setting, note to user that this is the global value
                 $fields[$key]['title'] = $schema->get_l10n()->get($fields[$key]['title']);
-                $fields[$key]['title'] .= " <span class=\"global\">(" . midcom::get()->i18n->get_string('global value', 'midgard.admin.asgard') .")</span>";
+                $fields[$key]['title'] .= " <span class=\"global\">(" . midcom::get()->i18n->get_string('global value', 'midgard.admin.asgard') . ")</span>";
             }
         }