flack / openpsa

lib/org/openpsa/products/handler/product/view.php

Braces +2 added lines, -1 removed lines

@@ -83,7 +83,8 @@
                 $productgroup = new org_openpsa_products_product_group_dba($this->_product->productGroup);
                 $replacements['<PRODUCTGROUP_TITLE>'] = $productgroup->title;
                 $replacements['<PRODUCTGROUP_CODE>'] = $productgroup->code;
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $replacements['<PRODUCTGROUP_TITLE>'] = '';
                 $replacements['<PRODUCTGROUP_CODE>'] = '';
             }

lib/midcom/baseclasses/components/handler/dataexport.php

Spacing +5 added lines, -5 removed lines

@@ -127,7 +127,7 @@ 
         foreach ($this->_datamanagers as $type => $datamanager) {
             foreach ($datamanager->get_schema($this->schemas[$type])->get('fields') as $name => $config) {
                 $title = $config['title'];
-                if (   $this->include_totals
+                if ($this->include_totals
                     && $config['type'] == 'number') {
                     $this->_totals[$type . '-' . $name] = 0;
                 }
@@ -194,18 +194,18 @@ 
                     $data = array_pad($data, $target_size, '');
                     continue;
                 }
-                $object =& $row[$type];
+                $object = & $row[$type];
 
                 $datamanager->set_storage($object, $this->schemas[$type]);
 
-                if (   $this->include_guid
+                if ($this->include_guid
                     && $type == $first_type) {
                     $data[] = $object->guid;
                 }
 
                 $csvdata = $datamanager->get_content_csv();
                 foreach ($datamanager->get_schema()->get('fields') as $fieldname => $config) {
-                    if (   $this->include_totals
+                    if ($this->include_totals
                         && $config['type'] == 'number') {
                         $this->_totals[$type . '-' . $fieldname] += $csvdata[$fieldname];
                     }
@@ -233,7 +233,7 @@ 
         if (empty($this->csv['charset'])) {
             // Default to ISO-LATIN-15 (Latin-1 with EURO sign etc)
             $this->csv['charset'] = 'ISO-8859-15';
-            if (   isset($_SERVER['HTTP_USER_AGENT'])
+            if (isset($_SERVER['HTTP_USER_AGENT'])
                 && !preg_match('/Windows/i', $_SERVER['HTTP_USER_AGENT'])) {
                 // Except when not on windows, then default to UTF-8
                 $this->csv['charset'] = 'UTF-8';

src/midcom/httpkernel/subscriber.php

Spacing +1 added lines, -1 removed lines

@@ -100,7 +100,7 @@
         foreach ($arguments as $i => $argument) {
             if ($argument === '__request_data__') {
                 $context = $event->getRequest()->attributes->get('context');
-                $arguments[$i] =& $context->get_custom_key('request_data');
+                $arguments[$i] = & $context->get_custom_key('request_data');
             }
         }
         $event->setArguments($arguments);

lib/midcom/connection.php

Spacing +1 added lines, -1 removed lines

@@ -261,7 +261,7 @@
             if ($part === '') {
                 continue;
             }
-            if (    midcom::get()->config->get('theme')
+            if (midcom::get()->config->get('theme')
                  && !$args_started
                  && self::check_page_exists($part)) {
                 $page_style .= '/' . $part;

Braces +2 added lines, -1 removed lines

@@ -93,7 +93,8 @@
 
         try {
             $user = new midgard_user($login_tokens);
-        } catch (mgd_exception $e) {
+        }
+        catch (mgd_exception $e) {
             return null;
         }
         if (!$trusted && !self::verify_password($password, $user->password)) {

lib/midcom/services/uimessages.php

Spacing +1 added lines, -1 removed lines

@@ -162,7 +162,7 @@
         if (!$this->_message_stack) {
             return;
         }
-        if (   $show_simple
+        if ($show_simple
             || !midcom::get()->auth->can_user_do('midcom:ajax', null, static::class)) {
             $this->show_simple();
             return;

lib/midcom/admin/help/style/midcom_admin_help_mgdschemas.php

Spacing +1 added lines, -1 removed lines

@@ -15,7 +15,7 @@
 
         foreach ($properties as $propname => $val) {
             $description = preg_replace('/ *\n */', "\n", $val['value']);
-            if (   $val['link']
+            if ($val['link']
                 && $linked_component = midcom::get()->dbclassloader->get_component_for_class($val['link_name'])) {
                 $proplink = $data['router']->generate('help', ['component' => $linked_component, 'help_id' => 'mgdschemas']);
                 $proplink = "<a href='{$proplink}#{$val['link_name']}' title='{$linked_component}/{$val['link_name']}::{$val['link_target']}'>{$val['link_name']}:{$val['link_target']}</a>";

lib/org/openpsa/projects/task.php

Spacing +1 added lines, -1 removed lines

@@ -110,7 +110,7 @@
     public function _on_updated()
     {
         // Sync the object's ACL properties into MidCOM ACL system
-        if (   !$this->_skip_acl_refresh) {
+        if (!$this->_skip_acl_refresh) {
             if ($this->orgOpenpsaAccesstype && $this->orgOpenpsaOwnerWg) {
                 debug_add("Synchronizing task ACLs to MidCOM");
                 $sync = new org_openpsa_core_acl_synchronizer();

Braces +4 added lines, -2 removed lines

@@ -238,7 +238,8 @@ 
                     $salesproject = org_openpsa_sales_salesproject_dba::get_cached($agreement->salesproject);
                     $this->customer = $salesproject->customer;
                 }
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
             }
         } else {
             // No agreement, we can't be invoiceable
@@ -283,7 +284,8 @@ 
         try {
             $agreement = new org_openpsa_sales_salesproject_deliverable_dba($this->get_agreement());
             $agreement->update_units($this->id, $hours);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
         }
 
         if ($update) {

lib/org/openpsa/sales/handler/view.php

Spacing +3 added lines, -3 removed lines

@@ -91,7 +91,7 @@ 
         }
 
         if ($this->_config->get('sales_pdfbuilder_class')) {
-            if (   $this->_salesproject->can_do('midgard:update')
+            if ($this->_salesproject->can_do('midgard:update')
                 && $this->is_pdf_creatable()) {
                 $workflow = $this->get_workflow('datamanager');
                 $buttons[] = $workflow->get_button($this->router->generate('create_offer', ['guid' => $this->_salesproject->guid]), [
@@ -218,7 +218,7 @@ 
             case 'ordered':
                 if ($deliverable->orgOpenpsaObtype == org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION) {
                     $entries = $deliverable->get_at_entries();
-                    if (   $entries
+                    if ($entries
                         && $entries[0]->status == midcom_services_at_entry_dba::SCHEDULED
                         && midcom::get()->auth->can_user_do('midgard:create', null, org_openpsa_invoices_invoice_dba::class)) {
                         return '<button class="run_cycle"><i class="fa fa-refresh"></i>' . $this->_l10n->get('generate now') . '</button>';
@@ -228,7 +228,7 @@ 
                 }
                 break;
             case 'delivered':
-                if (   $deliverable->orgOpenpsaObtype != org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
+                if ($deliverable->orgOpenpsaObtype != org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
                     && midcom::get()->auth->can_user_do('midgard:create', null, org_openpsa_invoices_invoice_dba::class)) {
                     $client_class = $this->_config->get('calculator');
                     $client = new $client_class();

lib/org/openpsa/sales/style/show-deliverable-subscription.php

Spacing +4 added lines, -4 removed lines

@@ -3,7 +3,7 @@ 
 $state = $data['deliverable']->get_state();
 $formatter = $data['l10n']->get_formatter();
 $per_unit = $data['l10n']->get('per unit');
-if (   $data['product']
+if ($data['product']
     && $unit_option = org_openpsa_sales_viewer::get_unit_option($data['product']->unit)) {
     $per_unit = sprintf($data['l10n']->get('per %s'), $unit_option);
 }
@@ -124,7 +124,7 @@ 
         </div>
         <?php
         $tabs = [];
-        if (   $data['invoices_url']
+        if ($data['invoices_url']
             && $data['deliverable']->invoiced > 0) {
             $tabs[] = [
                 'url' => $data['invoices_url'] . "list/deliverable/{$data['deliverable']->guid}/",
@@ -132,7 +132,7 @@ 
             ];
         }
 
-        if (   $data['projects_url']
+        if ($data['projects_url']
             && $data['deliverable']->state >= org_openpsa_sales_salesproject_deliverable_dba::STATE_ORDERED
             && $data['product']
             && $data['product']->orgOpenpsaObtype == org_openpsa_products_product_dba::TYPE_SERVICE) {
@@ -191,7 +191,7 @@ 
             }
             echo "    </tbody>\n";
             echo "</table>\n";
-            if (   $at_entries[0]->status == midcom_services_at_entry_dba::SCHEDULED
+            if ($at_entries[0]->status == midcom_services_at_entry_dba::SCHEDULED
                 && midcom::get()->auth->can_user_do('midgard:create', null, org_openpsa_invoices_invoice_dba::class)) {
                 $label = $data['l10n']->get('generate now');
                 $process_link = $data['router']->generate('deliverable_run_cycle', ['guid' => $data['deliverable']->guid]);

Indentation +2 added lines, -2 removed lines

@@ -74,12 +74,12 @@
                         <tr>
                           <td class="title"><?php echo $data['l10n']->get('cost'); ?></td>
                           <?php
-                          if ($data['deliverable']->costType == '%') { ?>
+                            if ($data['deliverable']->costType == '%') { ?>
                               <td class="numeric"><?php echo $view['costPerUnit']; ?> %</td>
                               <td class="numeric">&nbsp;</td>
                               <td class="numeric">&nbsp;</td>
                           <?php
-                          } else { ?>
+                            } else { ?>
                               <td class="numeric"><?php echo $formatter->number($data['deliverable']->costPerUnit); ?></td>
                               <td class="numeric"><?php echo $view['plannedUnits']; ?></td>
                               <td class="numeric"><?php echo $view['units']; ?></td>