flack / openpsa

lib/org/openpsa/slideshow/handler/edit.php

Braces +2 added lines, -1 removed lines

@@ -134,7 +134,8 @@
         try {
             $this->$function($request->request);
             $this->_response->success = true;
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $this->_response->success = false;
             $this->_response->error = $e->getMessage();
         }

Spacing +2 added lines, -2 removed lines

@@ -61,7 +61,7 @@ 
         $images = $qb->execute();
         $failed = 0;
         foreach ($images as $image) {
-            if (   !$image->generate_image('thumbnail', $this->_config->get('thumbnail_filter'))
+            if (!$image->generate_image('thumbnail', $this->_config->get('thumbnail_filter'))
                 || !$image->generate_image('image', $this->_config->get('image_filter'))) {
                 $failed++;
             }
@@ -241,7 +241,7 @@ 
         $attachment->title = $title;
         $attachment->mimetype = $file['type'];
         $attachment->parentguid = $image->guid;
-        if (   !$attachment->create()
+        if (!$attachment->create()
             || !$attachment->copy_from_file($file['tmp_name'])) {
             throw new midcom_error('Failed to create attachment: ' . midcom_connection::get_error_string());
         }

lib/org/openpsa/projects/handler/task/crud.php

Braces +2 added lines, -1 removed lines

@@ -138,7 +138,8 @@
         try {
             $parent = new org_openpsa_projects_project($task->project);
             $options['success_url'] = $this->router->generate('project', ['guid' => $parent->guid]);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
         }
 

lib/org/openpsa/projects/handler/task/resourcing.php

Spacing +2 added lines, -2 removed lines

@@ -64,7 +64,7 @@ 
             return new midcom_response_relocate($this->router->generate('task_view', ['guid' => $guid]));
         }
 
-        if (   $request->request->has('save')
+        if ($request->request->has('save')
             && $prospects = $request->request->get('org_openpsa_projects_prospects')) {
             $qb = org_openpsa_projects_task_resource_dba::new_query_builder();
             $qb->add_constraint('guid', 'IN', array_keys($prospects));
@@ -95,7 +95,7 @@ 
                     // create relatedto
                     org_openpsa_relatedto_plugin::create($event, 'org.openpsa.calendar', $this->_task, 'org.openpsa.projects');
                 }
-                if (   $update_prospect
+                if ($update_prospect
                     && !$prospect->update()) {
                     debug_add('Failed to update prospect: ' . midcom_connection::get_error_string(), MIDCOM_LOG_ERROR);
                 }

lib/org/openpsa/directmarketing/handler/subscriber.php

Braces +4 added lines, -2 removed lines

@@ -36,7 +36,8 @@ 
             // Add person to campaign
             try {
                 $campaign = new org_openpsa_directmarketing_campaign_dba($add_to);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 // FIXME: More informative error message
                 $this->notify('Failed adding person %s to campaign %s', $add_to, 'error');
                 return;
@@ -86,7 +87,8 @@ 
             try {
                 $campaigns[$membership->campaign] = new org_openpsa_directmarketing_campaign_dba($membership->campaign);
                 $campaign_membership_map[$membership->campaign] = $membership;
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 debug_add('Failed to load campaign ' . $membership->campaign . ', reason: ' . $e->getMessage());
             }
         }

lib/org/openpsa/invoices/handler/invoice/crud.php

Braces +4 added lines, -2 removed lines

@@ -48,7 +48,8 @@ 
             // We're creating invoice for chosen customer
             try {
                 $this->customer = new org_openpsa_contacts_group_dba($company);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $contact = new org_openpsa_contacts_person_dba($company);
                 $this->contact_id = $contact->id;
             }
@@ -155,7 +156,8 @@ 
             if (!empty($this->invoice->customer)) {
                 try {
                     $this->customer = org_openpsa_contacts_group_dba::get_cached($this->invoice->customer);
-                } catch (midcom_error $e) {
+                }
+                catch (midcom_error $e) {
                     $customer_field['hidden'] = true;
                     $e->log();
                 }

Spacing +2 added lines, -2 removed lines

@@ -141,8 +141,8 @@
         $schema->get_field('paid')['hidden'] = empty($this->invoice->paid);
 
         $contact = $this->invoice->customerContact ?: $this->contact_id;
-        $customer_field =& $schema->get_field('customer');
-        $contact_field =& $schema->get_field('customerContact');
+        $customer_field = & $schema->get_field('customer');
+        $contact_field = & $schema->get_field('customerContact');
 
         if (!empty($contact)) {
             $customer_field['type_config']['options'] = $this->get_customers_for_contact($contact);

lib/org/openpsa/products/handler/product/create.php

Braces +2 added lines, -1 removed lines

@@ -89,7 +89,8 @@
         } elseif ((int) $group > 0) {
             try {
                 $this->parent = new org_openpsa_products_product_group_dba((int) $group);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
         }

lib/org/openpsa/contacts/handler/group/action.php

Braces +2 added lines, -1 removed lines

@@ -29,7 +29,8 @@
                 $member->require_do('midgard:update');
                 $member->extra = $request->request->get('title');
                 $response->status = $member->update();
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
             $response->message = midcom_connection::get_error_string();

lib/midcom/helper/imagepopup/handler/list.php

Spacing +1 added lines, -1 removed lines

@@ -33,7 +33,7 @@
         midcom::get()->auth->require_valid_user();
         midcom::get()->skip_page_style = true;
 
-        $this->add_stylesheet(MIDCOM_STATIC_URL ."/midcom.helper.imagepopup/styling.css", 'screen');
+        $this->add_stylesheet(MIDCOM_STATIC_URL . "/midcom.helper.imagepopup/styling.css", 'screen');
 
         $data['filetype'] = $filetype;
         $data['object'] = null;

lib/org/openpsa/user/handler/person/account.php

Spacing +2 added lines, -2 removed lines

@@ -58,7 +58,7 @@ 
         $workflow = $this->get_workflow('datamanager', ['controller' => $data['controller']]);
         $response = $workflow->run($request);
 
-        if (   $workflow->get_state() == 'save'
+        if ($workflow->get_state() == 'save'
             && $this->create_account($this->person, $data["controller"]->get_form_values())) {
             midcom::get()->uimessages->add($this->_l10n->get('org.openpsa.user'), sprintf($this->_l10n->get('person %s created'), $this->person->name));
         }
@@ -148,7 +148,7 @@ 
         $accounthelper = new org_openpsa_user_accounthelper($this->person);
 
         // Update account
-        if (   !$accounthelper->set_account($controller->get_form_values()["username"], $password)
+        if (!$accounthelper->set_account($controller->get_form_values()["username"], $password)
             && midcom_connection::get_error() != MGD_ERR_OK) {
             // Failure, give a message
             midcom::get()->uimessages->add($this->_l10n->get('org.openpsa.user'), $this->_l10n->get("failed to update the user account, reason") . ': ' . midcom_connection::get_error_string(), 'error');