Passed
Push — master ( 87de88...fdfb7f )
by Andreas
11:09
created
lib/org/openpsa/sales/handler/edit.php 1 patch
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -54,7 +54,8 @@  discard block
 block discarded – undo
54 54
                 $field['type_config']['options'] = [0 => '', $customer->id => $customer->official];
55 55
 
56 56
                 $defaults['customer'] = $customer->id;
57
-            } catch (midcom_error) {
57
+            }
58
+            catch (midcom_error) {
58 59
                 $customer = new org_openpsa_contacts_person_dba($guid);
59 60
                 $defaults['customerContact'] = $customer->id;
60 61
                 $field['type_config']['options'] = $this->list_groups([$customer->id => true]);
@@ -126,7 +127,8 @@  discard block
 block discarded – undo
126 127
             try {
127 128
                 $company = new org_openpsa_contacts_group_dba($company_id);
128 129
                 $ret[$company->id] = $company->get_label();
129
-            } catch (midcom_error $e) {
130
+            }
131
+            catch (midcom_error $e) {
130 132
                 $e->log();
131 133
             }
132 134
         }
Please login to merge, or discard this patch.
lib/org/openpsa/sales/handler/list.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -95,7 +95,8 @@
 block discarded – undo
95 95
         try {
96 96
             $this->_request_data['customer'] = new org_openpsa_contacts_group_dba($guid);
97 97
             $qb->add_constraint('customer', '=', $this->_request_data['customer']->id);
98
-        } catch (midcom_error) {
98
+        }
99
+        catch (midcom_error) {
99 100
             $this->_request_data['customer'] = new org_openpsa_contacts_person_dba($guid);
100 101
             $qb->add_constraint('customerContact', '=', $this->_request_data['customer']->id);
101 102
         }
Please login to merge, or discard this patch.
lib/org/openpsa/sales/handler/deliverable/view.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,8 @@
 block discarded – undo
45 45
         }
46 46
         try {
47 47
             $this->_request_data['product'] = org_openpsa_products_product_dba::get_cached($this->_deliverable->product);
48
-        } catch (midcom_error) {
48
+        }
49
+        catch (midcom_error) {
49 50
             $this->_request_data['product'] = false;
50 51
         }
51 52
     }
Please login to merge, or discard this patch.
lib/org/openpsa/calendar/event/member.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -141,7 +141,8 @@
 block discarded – undo
141 141
                 debug_add('person #' . $person->id . 'has no email address, aborting');
142 142
                 return null;
143 143
             }
144
-        } catch (midcom_error) {
144
+        }
145
+        catch (midcom_error) {
145 146
             return null;
146 147
         }
147 148
 
Please login to merge, or discard this patch.
lib/org/openpsa/calendar/event/resource.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,8 @@
 block discarded – undo
43 43
         }
44 44
         try {
45 45
             $resource = org_openpsa_calendar_resource_dba::get_cached($this->resource);
46
-        } catch (midcom_error) {
46
+        }
47
+        catch (midcom_error) {
47 48
             debug_add("Cannot fetch resource #{$this->resource} returning false", MIDCOM_LOG_INFO);
48 49
             return false;
49 50
         }
Please login to merge, or discard this patch.
lib/org/openpsa/calendar/conflictmanager.php 1 patch
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -142,7 +142,8 @@  discard block
 block discarded – undo
142 142
             try {
143 143
                 $event = new org_openpsa_calendar_event_dba($member->event);
144 144
                 $set_as_modified = true;
145
-            } catch (midcom_error) {
145
+            }
146
+            catch (midcom_error) {
146 147
                 debug_add("event_resource #{$member->id} links to bogus event #{$member->event}, skipping and removing", MIDCOM_LOG_WARN);
147 148
                 $member->delete();
148 149
                 return;
@@ -170,7 +171,8 @@  discard block
 block discarded – undo
170 171
 
171 172
         try {
172 173
             $event = new org_openpsa_calendar_event_dba($member->eid);
173
-        } catch (midcom_error) {
174
+        }
175
+        catch (midcom_error) {
174 176
             debug_add("eventmember #{$member->id} links to bogus event #{$member->eid}, skipping and removing", MIDCOM_LOG_WARN);
175 177
             $member->delete();
176 178
             return;
Please login to merge, or discard this patch.
lib/org/openpsa/invoices/invoice/item.php 1 patch
Braces   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -72,7 +72,8 @@  discard block
 block discarded – undo
72 72
             try {
73 73
                 $task = org_openpsa_projects_task_dba::get_cached($this->task);
74 74
                 $url = $projects_url . 'task/' . $task->guid . '/';
75
-            } catch (midcom_error) {
75
+            }
76
+            catch (midcom_error) {
76 77
             }
77 78
         }
78 79
         if (   $url == ''
@@ -80,7 +81,8 @@  discard block
 block discarded – undo
80 81
             try {
81 82
                 $deliverable = org_openpsa_sales_salesproject_deliverable_dba::get_cached($this->deliverable);
82 83
                 $url = $sales_url . 'deliverable/' . $deliverable->guid . '/';
83
-            } catch (midcom_error) {
84
+            }
85
+            catch (midcom_error) {
84 86
             }
85 87
         }
86 88
         if ($url != '') {
@@ -102,7 +104,8 @@  discard block
 block discarded – undo
102 104
                     $deliverable = new org_openpsa_sales_salesproject_deliverable_dba($this->deliverable);
103 105
                     self::update_deliverable($deliverable);
104 106
                 }
105
-            } catch (midcom_error $e) {
107
+            }
108
+            catch (midcom_error $e) {
106 109
                 $e->log();
107 110
             }
108 111
         }
Please login to merge, or discard this patch.
lib/org/openpsa/invoices/style/admin-read.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -8,7 +8,8 @@
 block discarded – undo
8 8
     if ($customer->orgOpenpsaObtype < org_openpsa_contacts_group_dba::ORGANIZATION) {
9 9
         $customer = false;
10 10
     }
11
-} catch (midcom_error) {
11
+}
12
+catch (midcom_error) {
12 13
     $customer = false;
13 14
 }
14 15
 
Please login to merge, or discard this patch.
lib/org/openpsa/invoices/billing/data.php 1 patch
Braces   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -86,7 +86,8 @@  discard block
 block discarded – undo
86 86
             // if the property useContactAddress is set
87 87
             $billing_data[0]->set_address();
88 88
             return $billing_data[0];
89
-        } catch (midcom_error $e) {
89
+        }
90
+        catch (midcom_error $e) {
90 91
             $e->log();
91 92
             return null;
92 93
         }
@@ -131,10 +132,12 @@  discard block
 block discarded – undo
131 132
     {
132 133
         try {
133 134
             return new org_openpsa_contacts_person_dba($this->linkGuid);
134
-        } catch (midcom_error) {
135
+        }
136
+        catch (midcom_error) {
135 137
             try {
136 138
                 return new org_openpsa_contacts_group_dba($this->linkGuid);
137
-            } catch (midcom_error $e) {
139
+            }
140
+            catch (midcom_error $e) {
138 141
                 debug_add("Failed to load contact with GUID: " . $this->linkGuid . " - last error:" . $e->getMessage(), MIDCOM_LOG_ERROR);
139 142
                 return false;
140 143
             }
Please login to merge, or discard this patch.