@@ -68,7 +68,7 @@ discard block |
||
| 68 | 68 | $event = new org_openpsa_calendar_event_dba($this->eid); |
| 69 | 69 | } |
| 70 | 70 | |
| 71 | - if ( $recipient->id == midcom_connection::get_user() |
|
| 71 | + if ($recipient->id == midcom_connection::get_user() |
|
| 72 | 72 | && !$event->send_notify_me) { |
| 73 | 73 | //Do not send notification to current user |
| 74 | 74 | debug_add('event->send_notify_me is false and recipient is current user, aborting notify'); |
@@ -194,7 +194,7 @@ discard block |
||
| 194 | 194 | |
| 195 | 195 | if (isset($events_by_date[$ymd])) { |
| 196 | 196 | foreach ($events_by_date[$ymd] as $event) { |
| 197 | - if ( $event->end <= $workday_starts_ts |
|
| 197 | + if ($event->end <= $workday_starts_ts |
|
| 198 | 198 | || $event->start >= $workday_ends_ts) { |
| 199 | 199 | // We need not consider this event, it is outside the defined workday |
| 200 | 200 | continue; |
@@ -212,7 +212,7 @@ discard block |
||
| 212 | 212 | } |
| 213 | 213 | } |
| 214 | 214 | // End of day slot |
| 215 | - if ( $last_end_time < $workday_ends_ts |
|
| 215 | + if ($last_end_time < $workday_ends_ts |
|
| 216 | 216 | && (($workday_ends_ts - $last_end_time) >= $amount)) { |
| 217 | 217 | $slots[] = self::_create_slot($last_end_time, $workday_ends_ts, $last_event); |
| 218 | 218 | } |
@@ -30,7 +30,7 @@ discard block |
||
| 30 | 30 | private function load_controller(org_openpsa_invoices_billing_data_dba $bd) : controller |
| 31 | 31 | { |
| 32 | 32 | $schemadb = schemadb::from_path($this->_config->get('schemadb_billing_data')); |
| 33 | - $vat =& $schemadb->get('default')->get_field('vat'); |
|
| 33 | + $vat = & $schemadb->get('default')->get_field('vat'); |
|
| 34 | 34 | // Fill VAT select |
| 35 | 35 | if ($options = $this->get_vat_options($this->_config->get('vat_percentages'))) { |
| 36 | 36 | $vat['type_config']['options'] = $options; |
@@ -68,7 +68,7 @@ discard block |
||
| 68 | 68 | $data['controller'] = $this->load_controller($bd); |
| 69 | 69 | |
| 70 | 70 | $workflow = $this->get_workflow('datamanager', ['controller' => $data['controller']]); |
| 71 | - if ( $mode == 'edit' |
|
| 71 | + if ($mode == 'edit' |
|
| 72 | 72 | && $bd->can_do('midgard:delete')) { |
| 73 | 73 | $delete = $this->get_workflow('delete', [ |
| 74 | 74 | 'object' => $bd, |
@@ -38,7 +38,7 @@ |
||
| 38 | 38 | $mail->from = $config->get('default_sender') ?: '"OpenPSA Notifier" <noreply@' . $_SERVER['SERVER_NAME'] . '>'; |
| 39 | 39 | } |
| 40 | 40 | |
| 41 | - $mail->subject = $message['title'] ?? 'org.openpsa.notifications message (no title provided)'; |
|
| 41 | + $mail->subject = $message['title'] ?? 'org.openpsa.notifications message (no title provided)'; |
|
| 42 | 42 | if (array_key_exists('attachments', $message)) { |
| 43 | 43 | $mail->attachments = $message['attachments']; |
| 44 | 44 | } |
@@ -292,7 +292,7 @@ discard block |
||
| 292 | 292 | { |
| 293 | 293 | if (in_array($key, $this->field_config['timebased'])) { |
| 294 | 294 | // This is ugly, but seems the only possible way... |
| 295 | - if ( isset($this->__metadata->$key) |
|
| 295 | + if (isset($this->__metadata->$key) |
|
| 296 | 296 | && (string) $this->__metadata->$key !== "0001-01-01T00:00:00+00:00") { |
| 297 | 297 | return (int) $this->__metadata->$key->format('U'); |
| 298 | 298 | } |
@@ -354,11 +354,11 @@ discard block |
||
| 354 | 354 | } |
| 355 | 355 | |
| 356 | 356 | $now = time(); |
| 357 | - if ( $this->get('schedulestart') |
|
| 357 | + if ($this->get('schedulestart') |
|
| 358 | 358 | && $this->get('schedulestart') > $now) { |
| 359 | 359 | return false; |
| 360 | 360 | } |
| 361 | - if ( $this->get('scheduleend') |
|
| 361 | + if ($this->get('scheduleend') |
|
| 362 | 362 | && $this->get('scheduleend') < $now) { |
| 363 | 363 | return false; |
| 364 | 364 | } |
@@ -374,9 +374,9 @@ discard block |
||
| 374 | 374 | public function is_object_visible_onsite() : bool |
| 375 | 375 | { |
| 376 | 376 | return |
| 377 | - ( ( midcom::get()->config->get('show_hidden_objects') |
|
| 377 | + ((midcom::get()->config->get('show_hidden_objects') |
|
| 378 | 378 | || $this->is_visible()) |
| 379 | - && ( midcom::get()->config->get('show_unapproved_objects') |
|
| 379 | + && (midcom::get()->config->get('show_unapproved_objects') |
|
| 380 | 380 | || $this->is_approved()) |
| 381 | 381 | ); |
| 382 | 382 | } |
@@ -434,7 +434,7 @@ discard block |
||
| 434 | 434 | $guid = $source; |
| 435 | 435 | } |
| 436 | 436 | |
| 437 | - if ( $object === null |
|
| 437 | + if ($object === null |
|
| 438 | 438 | && mgd_is_guid($guid)) { |
| 439 | 439 | try { |
| 440 | 440 | $object = midcom::get()->dbfactory->get_object_by_guid($guid); |
@@ -467,7 +467,7 @@ discard block |
||
| 467 | 467 | } |
| 468 | 468 | |
| 469 | 469 | // Lock was created by the user, return "not locked" |
| 470 | - if ( !empty(midcom::get()->auth->user->guid) |
|
| 470 | + if (!empty(midcom::get()->auth->user->guid) |
|
| 471 | 471 | && $this->get('locker') === midcom::get()->auth->user->guid) { |
| 472 | 472 | return false; |
| 473 | 473 | } |
@@ -500,7 +500,7 @@ discard block |
||
| 500 | 500 | */ |
| 501 | 501 | public function can_unlock() : bool |
| 502 | 502 | { |
| 503 | - return ( $this->__object->can_do('midcom:unlock') |
|
| 503 | + return ($this->__object->can_do('midcom:unlock') |
|
| 504 | 504 | || midcom::get()->auth->can_user_do('midcom:unlock', null, midcom_services_auth::class)); |
| 505 | 505 | } |
| 506 | 506 | |
@@ -511,7 +511,7 @@ discard block |
||
| 511 | 511 | */ |
| 512 | 512 | public function unlock() : bool |
| 513 | 513 | { |
| 514 | - if ( $this->can_unlock() |
|
| 514 | + if ($this->can_unlock() |
|
| 515 | 515 | && $this->__object->unlock()) { |
| 516 | 516 | $this->_cache = []; |
| 517 | 517 | return true; |
@@ -40,7 +40,7 @@ discard block |
||
| 40 | 40 | */ |
| 41 | 41 | public function read_login_data(Request $request) : ?array |
| 42 | 42 | { |
| 43 | - if ( !$request->request->has('midcom_services_auth_frontend_form_submit') |
|
| 43 | + if (!$request->request->has('midcom_services_auth_frontend_form_submit') |
|
| 44 | 44 | || !$request->request->has('username') |
| 45 | 45 | || !$request->request->has('password')) { |
| 46 | 46 | return null; |
@@ -76,7 +76,7 @@ discard block |
||
| 76 | 76 | { |
| 77 | 77 | // Store the submitted form if the session expired, but user wants to save the data |
| 78 | 78 | if (!empty($_POST)) { |
| 79 | - $data =& midcom_core_context::get()->get_custom_key('request_data'); |
|
| 79 | + $data = & midcom_core_context::get()->get_custom_key('request_data'); |
|
| 80 | 80 | |
| 81 | 81 | $data['restored_form_data'] = []; |
| 82 | 82 | |
@@ -44,7 +44,7 @@ |
||
| 44 | 44 | |
| 45 | 45 | public function resolve_object_link(midcom_db_topic $topic, midcom_core_dbaobject $object) : ?string |
| 46 | 46 | { |
| 47 | - if ( $object instanceof midcom_db_article |
|
| 47 | + if ($object instanceof midcom_db_article |
|
| 48 | 48 | && $topic->id == $object->topic) { |
| 49 | 49 | if ($object->name == 'index') { |
| 50 | 50 | return ''; |
@@ -40,7 +40,7 @@ |
||
| 40 | 40 | |
| 41 | 41 | public function resolve_object_link(midcom_db_topic $topic, midcom_core_dbaobject $object) : ?string |
| 42 | 42 | { |
| 43 | - if ( $object instanceof org_openpsa_documents_document_dba |
|
| 43 | + if ($object instanceof org_openpsa_documents_document_dba |
|
| 44 | 44 | && $object->topic == $topic->id) { |
| 45 | 45 | return "document/{$object->guid}/"; |
| 46 | 46 | } |
@@ -77,11 +77,11 @@ discard block |
||
| 77 | 77 | |
| 78 | 78 | public function resolve_object_link(midcom_db_topic $topic, midcom_core_dbaobject $object) : ?string |
| 79 | 79 | { |
| 80 | - if ( $object instanceof org_openpsa_contacts_group_dba |
|
| 80 | + if ($object instanceof org_openpsa_contacts_group_dba |
|
| 81 | 81 | || $object instanceof midcom_db_group) { |
| 82 | 82 | return "group/{$object->guid}/"; |
| 83 | 83 | } |
| 84 | - if ( $object instanceof org_openpsa_contacts_person_dba |
|
| 84 | + if ($object instanceof org_openpsa_contacts_person_dba |
|
| 85 | 85 | || $object instanceof midcom_db_person) { |
| 86 | 86 | return "person/{$object->guid}/"; |
| 87 | 87 | } |
@@ -110,8 +110,8 @@ discard block |
||
| 110 | 110 | // We have a feed URL, but we should check if it is GeoRSS as well |
| 111 | 111 | $items = net_nemein_rss_fetch::raw_fetch($data['rss_url'])->get_items(); |
| 112 | 112 | |
| 113 | - if ( !empty($items) |
|
| 114 | - && ( $items[0]->get_latitude() |
|
| 113 | + if (!empty($items) |
|
| 114 | + && ($items[0]->get_latitude() |
|
| 115 | 115 | || $items[0]->get_longitude())) { |
| 116 | 116 | // This is a GeoRSS feed |
| 117 | 117 | $data['georss_url'] = $data['rss_url']; |
@@ -36,7 +36,7 @@ |
||
| 36 | 36 | echo " <td>" . strftime('%x %X Z', $revision['date']) . "</td>\n"; |
| 37 | 37 | echo " <td>"; |
| 38 | 38 | |
| 39 | - if ( $revision['user'] |
|
| 39 | + if ($revision['user'] |
|
| 40 | 40 | && $user = midcom::get()->auth->get_user($revision['user'])) { |
| 41 | 41 | echo $user->get_storage()->name; |
| 42 | 42 | } elseif ($revision['ip']) { |