@@ -9,7 +9,7 @@ |
||
| 9 | 9 | continue; |
| 10 | 10 | } |
| 11 | 11 | |
| 12 | - if ( !$object->can_do('midgard:update') |
|
| 12 | + if (!$object->can_do('midgard:update') |
|
| 13 | 13 | || !$object->can_do('midgard:attachments')) { |
| 14 | 14 | echo sprintf(midcom::get()->i18n->get_string('not recreating object %s %s, reason %s', 'midcom'), $type, $object->guid, 'Insufficient privileges') . "\n"; |
| 15 | 15 | continue; |
@@ -30,7 +30,7 @@ discard block |
||
| 30 | 30 | <?php |
| 31 | 31 | foreach ($type_choices as $value => $label) { |
| 32 | 32 | $selected = ''; |
| 33 | - if ( isset($data['type_filter']) |
|
| 33 | + if (isset($data['type_filter']) |
|
| 34 | 34 | && $data['type_filter'] == $value) { |
| 35 | 35 | $selected = ' selected="selected"'; |
| 36 | 36 | } |
@@ -45,7 +45,7 @@ discard block |
||
| 45 | 45 | <?php |
| 46 | 46 | foreach ($revised_after_choices as $value => $label) { |
| 47 | 47 | $selected = ''; |
| 48 | - if ( isset($data['revised_after']) |
|
| 48 | + if (isset($data['revised_after']) |
|
| 49 | 49 | && $data['revised_after'] == date('Y-m-d', $value)) { |
| 50 | 50 | $selected = ' selected="selected"'; |
| 51 | 51 | } |
@@ -18,7 +18,7 @@ |
||
| 18 | 18 | public function initialize(midcom_baseclasses_components_viewer $master, Router $router) |
| 19 | 19 | { |
| 20 | 20 | $this->router = $router; |
| 21 | - $this->_request_data =& $master->_request_data; |
|
| 21 | + $this->_request_data = & $master->_request_data; |
|
| 22 | 22 | $this->_topic = $master->_topic; |
| 23 | 23 | $this->_request_data['l10n'] = $this->_l10n; |
| 24 | 24 | |
@@ -64,7 +64,7 @@ discard block |
||
| 64 | 64 | return new midcom_response_relocate($this->router->generate('task_view', ['guid' => $guid])); |
| 65 | 65 | } |
| 66 | 66 | |
| 67 | - if ( $request->request->has('save') |
|
| 67 | + if ($request->request->has('save') |
|
| 68 | 68 | && $prospects = $request->request->get('org_openpsa_projects_prospects')) { |
| 69 | 69 | $qb = org_openpsa_projects_task_resource_dba::new_query_builder(); |
| 70 | 70 | $qb->add_constraint('guid', 'IN', array_keys($prospects)); |
@@ -95,7 +95,7 @@ discard block |
||
| 95 | 95 | // create relatedto |
| 96 | 96 | org_openpsa_relatedto_plugin::create($event, 'org.openpsa.calendar', $this->_task, 'org.openpsa.projects'); |
| 97 | 97 | } |
| 98 | - if ( $update_prospect |
|
| 98 | + if ($update_prospect |
|
| 99 | 99 | && !$prospect->update()) { |
| 100 | 100 | debug_add('Failed to update prospect: ' . midcom_connection::get_error_string(), MIDCOM_LOG_ERROR); |
| 101 | 101 | } |
@@ -33,7 +33,7 @@ |
||
| 33 | 33 | midcom::get()->auth->require_valid_user(); |
| 34 | 34 | midcom::get()->skip_page_style = true; |
| 35 | 35 | |
| 36 | - $this->add_stylesheet(MIDCOM_STATIC_URL ."/midcom.helper.imagepopup/styling.css", 'screen'); |
|
| 36 | + $this->add_stylesheet(MIDCOM_STATIC_URL . "/midcom.helper.imagepopup/styling.css", 'screen'); |
|
| 37 | 37 | |
| 38 | 38 | $data['filetype'] = $filetype; |
| 39 | 39 | $data['object'] = null; |
@@ -58,7 +58,7 @@ discard block |
||
| 58 | 58 | $workflow = $this->get_workflow('datamanager', ['controller' => $data['controller']]); |
| 59 | 59 | $response = $workflow->run($request); |
| 60 | 60 | |
| 61 | - if ( $workflow->get_state() == 'save' |
|
| 61 | + if ($workflow->get_state() == 'save' |
|
| 62 | 62 | && $this->create_account($this->person, $data["controller"]->get_form_values())) { |
| 63 | 63 | midcom::get()->uimessages->add($this->_l10n->get('org.openpsa.user'), sprintf($this->_l10n->get('person %s created'), $this->person->name)); |
| 64 | 64 | } |
@@ -148,7 +148,7 @@ discard block |
||
| 148 | 148 | $accounthelper = new org_openpsa_user_accounthelper($this->person); |
| 149 | 149 | |
| 150 | 150 | // Update account |
| 151 | - if ( !$accounthelper->set_account($controller->get_form_values()["username"], $password) |
|
| 151 | + if (!$accounthelper->set_account($controller->get_form_values()["username"], $password) |
|
| 152 | 152 | && midcom_connection::get_error() != MGD_ERR_OK) { |
| 153 | 153 | // Failure, give a message |
| 154 | 154 | midcom::get()->uimessages->add($this->_l10n->get('org.openpsa.user'), $this->_l10n->get("failed to update the user account, reason") . ': ' . midcom_connection::get_error_string(), 'error'); |
@@ -70,13 +70,13 @@ discard block |
||
| 70 | 70 | } |
| 71 | 71 | } elseif (!$this->form->isSubmitted()) { |
| 72 | 72 | $this->form->handleRequest($request); |
| 73 | - if ( $this->form->isSubmitted() |
|
| 73 | + if ($this->form->isSubmitted() |
|
| 74 | 74 | && $button = $this->form->getClickedButton()) { |
| 75 | 75 | $operation = $button->getConfig()->getOption('operation'); |
| 76 | 76 | } |
| 77 | 77 | } |
| 78 | 78 | |
| 79 | - if ( in_array($operation, [self::SAVE, self::NEXT]) |
|
| 79 | + if (in_array($operation, [self::SAVE, self::NEXT]) |
|
| 80 | 80 | && !$this->form->isValid()) { |
| 81 | 81 | $operation = self::EDIT; |
| 82 | 82 | } |
@@ -159,7 +159,7 @@ discard block |
||
| 159 | 159 | if ($storage->get_last_operation() === self::SAVE) { |
| 160 | 160 | // Get GUIDs and such for new-created dependent objects |
| 161 | 161 | $this->dm->set_storage($storage->get_value(), $this->dm->get_schema()->get_name()); |
| 162 | - } elseif ( !$this->form->isValid() |
|
| 162 | + } elseif (!$this->form->isValid() |
|
| 163 | 163 | && $storage->move_uploaded_files() > 0) { |
| 164 | 164 | $form = $this->dm->get_form($this->form->getName(), true); |
| 165 | 165 | $this->copy_errors($this->form, $form); |
@@ -18,7 +18,7 @@ discard block |
||
| 18 | 18 | $item->title = $data['article']->title; |
| 19 | 19 | $arg = $data['article']->name ?: $data['article']->guid; |
| 20 | 20 | |
| 21 | -if ( $data['config']->get('link_to_external_url') |
|
| 21 | +if ($data['config']->get('link_to_external_url') |
|
| 22 | 22 | && !empty($data['article']->url)) { |
| 23 | 23 | $item->link = $data['article']->url; |
| 24 | 24 | } else { |
@@ -37,7 +37,7 @@ discard block |
||
| 37 | 37 | $item->description .= '<div class="abstract">' . $view['abstract'] . '</div>'; |
| 38 | 38 | } |
| 39 | 39 | |
| 40 | -if ( array_key_exists('image', $view) |
|
| 40 | +if (array_key_exists('image', $view) |
|
| 41 | 41 | && $data['config']->get('rss_use_image')) { |
| 42 | 42 | $item->description .= "\n<div class=\"image\">" . $view['image'] . '</div>'; |
| 43 | 43 | } |
@@ -68,7 +68,7 @@ |
||
| 68 | 68 | echo " <td class=\"numeric\"><span title=\"" . $data['l10n']->get('ongoing') . "\">{$task_count['ongoing']}</span></td>\n"; |
| 69 | 69 | echo " <td class=\"numeric\"><span title=\"" . $data['l10n']->get('on_hold') . "\">{$task_count['on_hold']}</span></td>\n"; |
| 70 | 70 | echo " <td class=\"numeric\"><span title=\"" . $data['l10n']->get('closed') . "\">{$task_count['closed']}</span></td>\n"; |
| 71 | - echo " <td class=\"numeric\"> " ; |
|
| 71 | + echo " <td class=\"numeric\"> "; |
|
| 72 | 72 | echo " <span title=\"" . $data['l10n']->get('reported') . "\">" . round($hours['reportedHours'], 2) . "</span>"; |
| 73 | 73 | if ($hours['plannedHours'] > 0) { |
| 74 | 74 | echo " / <span title=\"" . $data['l10n']->get('planned hours') . "\">" . round($hours['plannedHours'], 2) . "</span>"; |