Passed
Push — master ( eb3d65...8de60e )
by Andreas
18:09
created
lib/midgard/admin/asgard/style/ASGARD_ROOT.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -127,7 +127,7 @@
 block discarded – undo
127 127
 
128 128
                             $edited = (int) $view_metadata->get('revised');
129 129
                             $revision = $view_metadata->get('revision');
130
-                            if (   $revision > 0
130
+                            if ($revision > 0
131 131
                                 && $edited != $created) {
132 132
                                 try {
133 133
                                     $editor = new midcom_db_person($view_metadata->get('revisor'));
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/navigation.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
         $this->_component = 'midgard.admin.asgard';
42 42
 
43 43
         $this->_object = $object;
44
-        $this->_request_data =& $request_data;
44
+        $this->_request_data = & $request_data;
45 45
 
46 46
         $this->root_types = midcom_helper_reflector_tree::get_root_classes();
47 47
 
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
             // we go through the path bottom up and show the first root type we find
58 58
             foreach (array_reverse($this->_object_path) as $node) {
59 59
                 foreach ($this->root_types as $root_type) {
60
-                    if (   is_a($node, $root_type)
60
+                    if (is_a($node, $root_type)
61 61
                         || midcom_helper_reflector::is_same_class($root_type, $node->__midcom_class_name__)) {
62 62
                         $this->expanded_root_types[] = $root_type;
63 63
                         break;
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
 
70 70
     protected function _is_collapsed(string $type, int $total) : bool
71 71
     {
72
-        return (   $total > $this->_config->get('max_navigation_entries')
72
+        return ($total > $this->_config->get('max_navigation_entries')
73 73
                 && empty($_GET['show_all_' . $type]));
74 74
     }
75 75
 
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
         foreach ($ref->get_child_classes() as $class) {
86 86
             $qb = $ref->_child_objects_type_qb($class, $object, false);
87 87
 
88
-            if (   !$qb
88
+            if (!$qb
89 89
                 || !($count = $qb->count_unchecked())) {
90 90
                 continue;
91 91
             }
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
     {
132 132
         $qb = $ref->_root_objects_qb();
133 133
 
134
-        if (   !$qb
134
+        if (!$qb
135 135
             || !($total = $qb->count_unchecked())) {
136 136
             return;
137 137
         }
@@ -209,7 +209,7 @@  discard block
 block discarded – undo
209 209
         }
210 210
 
211 211
         echo "<a href=\"" . midcom_connection::get_url('self') . "__mfa/asgard/object/{$mode}/{$object->guid}/\" title=\"GUID: {$object->guid}, ID: {$object->id}\">{$icon}{$label}</a>\n";
212
-        if (   $selected
212
+        if ($selected
213 213
             || $autoexpand) {
214 214
             $this->_list_child_elements($object, $level + 1);
215 215
         }
@@ -229,7 +229,7 @@  discard block
 block discarded – undo
229 229
                 continue;
230 230
             }
231 231
 
232
-            if (   method_exists($class, 'navigation')
232
+            if (method_exists($class, 'navigation')
233 233
                 && ($this->_request_data['plugin_name'] == "asgard_{$component}")) {
234 234
                 $this->_request_data['expanded'] = true;
235 235
                 midcom_show_style('midgard_admin_asgard_navigation_section_header');
@@ -263,13 +263,13 @@  discard block
 block discarded – undo
263 263
         if ($this->_is_selected($object)) {
264 264
             $css_class .= ' selected';
265 265
         }
266
-        if (   is_object($this->_object)
267
-            && (   $object->guid == $this->_object->guid
268
-                || (   is_a($this->_object, midcom_db_parameter::class)
266
+        if (is_object($this->_object)
267
+            && ($object->guid == $this->_object->guid
268
+                || (is_a($this->_object, midcom_db_parameter::class)
269 269
                     && $object->guid == $this->_object->parentguid))) {
270 270
             $css_class .= ' current';
271 271
         }
272
-        if ( !$object->can_do('midgard:update')) {
272
+        if (!$object->can_do('midgard:update')) {
273 273
             $css_class .= ' readonly';
274 274
         }
275 275
         return $css_class;
@@ -312,7 +312,7 @@  discard block
 block discarded – undo
312 312
 
313 313
         // If the regular expression has been set, check which types should be shown
314 314
         if ($regexp !== '//') {
315
-            $label_mapping = array_filter($label_mapping, function ($root_type) use ($regexp, $exclude) {
315
+            $label_mapping = array_filter($label_mapping, function($root_type) use ($regexp, $exclude) {
316 316
                 return preg_match($regexp, $root_type) == $exclude;
317 317
             }, ARRAY_FILTER_USE_KEY);
318 318
         }
@@ -342,7 +342,7 @@  discard block
 block discarded – undo
342 342
          * click if nothing is expanded
343 343
          */
344 344
         $types_shown = false;
345
-        if (    !empty($expanded_types)
345
+        if (!empty($expanded_types)
346 346
              && midgard_admin_asgard_plugin::get_preference('navigation_type') === 'dropdown') {
347 347
             $this->_draw_select_navigation();
348 348
             $types_shown = true;
Please login to merge, or discard this patch.
lib/midcom/helper/reflector/main.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -304,7 +304,7 @@  discard block
 block discarded – undo
304 304
 
305 305
         $label_prop = $this->get_label_property();
306 306
 
307
-        if (    $label_prop != 'guid'
307
+        if ($label_prop != 'guid'
308 308
              && $this->property_exists($label_prop)) {
309 309
             $search_properties[$label_prop] = true;
310 310
         }
@@ -354,7 +354,7 @@  discard block
 block discarded – undo
354 354
                 continue;
355 355
             }
356 356
 
357
-            if (   !$this->is_link($property)
357
+            if (!$this->is_link($property)
358 358
                 && $this->get_midgard_type($property) != MGD_TYPE_GUID) {
359 359
                 continue;
360 360
             }
@@ -388,7 +388,7 @@  discard block
 block discarded – undo
388 388
     protected static function class_rewrite(string $schema_type) : string
389 389
     {
390 390
         $extends = midcom_baseclasses_components_configuration::get('midcom.helper.reflector', 'config')->get_array('class_extends');
391
-        if (   isset($extends[$schema_type])
391
+        if (isset($extends[$schema_type])
392 392
             && class_exists($extends[$schema_type])) {
393 393
             return $extends[$schema_type];
394 394
         }
Please login to merge, or discard this patch.
lib/org/openpsa/mail/main.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@
 block discarded – undo
39 39
  */
40 40
 class org_openpsa_mail
41 41
 {
42
-    use midcom_baseclasses_components_base {__get as base__get;}
42
+    use midcom_baseclasses_components_base {__get as base__get; }
43 43
 
44 44
     /**
45 45
      * Text body
Please login to merge, or discard this patch.
lib/net/nehmer/blog/handler.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@  discard block
 block discarded – undo
15 15
 {
16 16
     public function get_url(midcom_db_article $article, bool $allow_external = false) : string
17 17
     {
18
-        if (   $allow_external
18
+        if ($allow_external
19 19
             && $this->_config->get('link_to_external_url')
20 20
             && !empty($article->url)) {
21 21
             return $article->url;
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
 
68 68
         $qb->add_constraint('topic.guid', 'IN', $topic_guids);
69 69
 
70
-        if (   count($topic_guids) > 1
70
+        if (count($topic_guids) > 1
71 71
             && $list_from_folders_categories = $this->_config->get('list_from_folders_categories')) {
72 72
             $list_from_folders_categories = explode(',', $list_from_folders_categories);
73 73
 
Please login to merge, or discard this patch.
lib/net/nehmer/blog/navigation.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -64,14 +64,14 @@  discard block
 block discarded – undo
64 64
 
65 65
     private function _add_pseudo_leaves(array &$leaves)
66 66
     {
67
-        if (   $this->_config->get('archive_enable')
67
+        if ($this->_config->get('archive_enable')
68 68
             && $this->_config->get('archive_in_navigation')) {
69 69
             $leaves["{$this->_topic->id}_ARCHIVE"] = [
70 70
                 MIDCOM_NAV_URL => "archive/",
71 71
                 MIDCOM_NAV_NAME => $this->_l10n->get('archive'),
72 72
             ];
73 73
         }
74
-        if (   $this->_config->get('rss_enable')
74
+        if ($this->_config->get('rss_enable')
75 75
             && $this->_config->get('feeds_in_navigation')) {
76 76
             $leaves[self::LEAFID_FEEDS] = [
77 77
                 MIDCOM_NAV_URL => "feeds/",
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
             ];
80 80
         }
81 81
 
82
-        if (   $this->_config->get('categories_in_navigation')
82
+        if ($this->_config->get('categories_in_navigation')
83 83
             && $this->_config->get('categories') != '') {
84 84
             $categories = explode(',', $this->_config->get('categories'));
85 85
             foreach ($categories as $category) {
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
             }
91 91
         }
92 92
 
93
-        if (   $this->_config->get('archive_years_in_navigation')
93
+        if ($this->_config->get('archive_years_in_navigation')
94 94
             && $this->_config->get('archive_years_enable')) {
95 95
             $qb = midcom_db_article::new_query_builder();
96 96
             $qb->add_constraint('topic', '=', $this->_topic->id);
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
      */
122 122
     public static function add_scheduling_constraints(midcom_core_querybuilder $qb, midcom_helper_configuration $config)
123 123
     {
124
-        if (   $config->get('enable_scheduled_publishing')
124
+        if ($config->get('enable_scheduled_publishing')
125 125
             && !midcom::get()->auth->admin) {
126 126
             // Show the article only if the publishing time has passed or the viewer
127 127
             // is the author
Please login to merge, or discard this patch.
lib/org/openpsa/directmarketing/campaign/ruleresolver.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -279,7 +279,7 @@  discard block
 block discarded – undo
279 279
      */
280 280
     private function add_misc_rule(array $rule, string $class, string $person_property) : bool
281 281
     {
282
-        $persons = [ 0 => -1];
282
+        $persons = [0 => -1];
283 283
         $match = $rule['match'];
284 284
         $constraint_match = "IN";
285 285
         if ($rule['match'] == '<>') {
@@ -351,7 +351,7 @@  discard block
 block discarded – undo
351 351
         $ret = [];
352 352
 
353 353
         foreach ($object->get_properties() as $property) {
354
-            if (   $property[0] == '_'
354
+            if ($property[0] == '_'
355 355
                 || in_array($property, $skip_properties)) {
356 356
                 // Skip private or otherwise invalid properties
357 357
                 continue;
Please login to merge, or discard this patch.
lib/midcom/helper/formatter.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -50,12 +50,12 @@
 block discarded – undo
50 50
      */
51 51
     public static function compile(string $content) : string
52 52
     {
53
-        return preg_replace_callback("%&\(([^)]*)\);%i", function ($variable)
53
+        return preg_replace_callback("%&\(([^)]*)\);%i", function($variable)
54 54
         {
55 55
             $parts = explode(':', $variable[1]);
56 56
             $variable = '$' . str_replace('.', '->', $parts[0]);
57 57
 
58
-            if (   isset($parts[1])
58
+            if (isset($parts[1])
59 59
                 && array_key_exists($parts[1], self::$_filters)) {
60 60
                 if ($parts[1] == 'p') {
61 61
                     $command = 'eval(\'?>\' . ' . $variable . ')';
Please login to merge, or discard this patch.
lib/midcom/admin/folder/style/midcom-admin-folder-order-type.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@  discard block
 block discarded – undo
4 4
 $count = count($data['navigation_items']);
5 5
 
6 6
 foreach ($data['navigation_items'] as $i => $item) {
7
-    if (   isset($item[MIDCOM_NAV_SORTABLE])
7
+    if (isset($item[MIDCOM_NAV_SORTABLE])
8 8
         && !$item[MIDCOM_NAV_SORTABLE]) {
9 9
         continue;
10 10
     }
@@ -15,7 +15,7 @@  discard block
 block discarded – undo
15 15
     $style = '';
16 16
 
17 17
     // Skip all components that return the default icon
18
-    if (   isset($item[MIDCOM_NAV_COMPONENT])
18
+    if (isset($item[MIDCOM_NAV_COMPONENT])
19 19
         && ($tmp = midcom::get()->componentloader->get_component_icon($item[MIDCOM_NAV_COMPONENT], false))) {
20 20
         $icon = '<i class="fa fa-' . $tmp . '"></i>';
21 21
     } elseif (!$item[MIDCOM_NAV_GUID]) {
Please login to merge, or discard this patch.