Passed
Push — master ( eb3d65...8de60e )
by Andreas
18:09
created
lib/midcom/helper/_dbfactory.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
             throw new midcom_error_midgard($e, $guid);
50 50
         }
51 51
         $person_class = midcom::get()->config->get('person_class');
52
-        if (   get_class($tmp) == 'midgard_person'
52
+        if (get_class($tmp) == 'midgard_person'
53 53
             && $person_class != 'midgard_person') {
54 54
             $tmp = new $person_class($guid);
55 55
         }
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
         }
80 80
         $object = new $classname($src);
81 81
         $cache[$classname][$object->guid] = $object;
82
-        $cache[$classname][$object->id] =& $cache[$classname][$object->guid];
82
+        $cache[$classname][$object->id] = & $cache[$classname][$object->guid];
83 83
         return $cache[$classname][$object->guid];
84 84
     }
85 85
 
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
             return true;
128 128
         }
129 129
 
130
-        if (   isset($object->__object)
130
+        if (isset($object->__object)
131 131
             && is_object($object->__object)
132 132
             && $object->__object instanceof $class) {
133 133
             // Decorator whose MgdSchema object matches
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
             return $this->get_parent_data_uncached($object);
151 151
         });
152 152
 
153
-        if (   empty($parent_guid)
153
+        if (empty($parent_guid)
154 154
             || $parent_guid === $object->guid) {
155 155
             return null;
156 156
         }
Please login to merge, or discard this patch.
lib/midcom/admin/folder/handler/move.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
     {
36 36
         $this->_object = midcom::get()->dbfactory->get_object_by_guid($guid);
37 37
 
38
-        if (   !is_a($this->_object, midcom_db_topic::class)
38
+        if (!is_a($this->_object, midcom_db_topic::class)
39 39
             && !is_a($this->_object, midcom_db_article::class)) {
40 40
             throw new midcom_error_notfound("Moving only topics and articles is supported.");
41 41
         }
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
             $folder = midcom_core_context::get()->get_key(MIDCOM_CONTEXT_ROOTTOPIC);
77 77
         }
78 78
 
79
-        if (   is_a($this->_object, midcom_db_topic::class)
79
+        if (is_a($this->_object, midcom_db_topic::class)
80 80
             && $folder->up == $this->_object->id) {
81 81
             $tree_disabled = true;
82 82
         }
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
             $selected = ' checked="checked"';
90 90
         }
91 91
 
92
-        if (   !is_a($this->_object, midcom_db_topic::class)
92
+        if (!is_a($this->_object, midcom_db_topic::class)
93 93
             && $folder->component !== $this->current_folder->component) {
94 94
             // Non-topic objects may only be moved under folders of same component
95 95
             $class = 'wrong_component';
Please login to merge, or discard this patch.
lib/net/nemein/wiki/handler/view.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -202,9 +202,9 @@
 block discarded – undo
202 202
         $toc .= "\n<ol class=\"midcom_helper_toc_formatter level_{$current_list_level}\">\n";
203 203
         foreach ($headings[4] as $key => $heading) {
204 204
             $anchor = 'heading-' . md5($heading);
205
-            $tag_level =& $headings[3][$key];
206
-            $heading_code =& $headings[0][$key];
207
-            $heading_tag =& $headings[2][$key];
205
+            $tag_level = & $headings[3][$key];
206
+            $heading_code = & $headings[0][$key];
207
+            $heading_tag = & $headings[2][$key];
208 208
             $heading_new_code = "<a id='{$anchor}'></a>{$heading_code}";
209 209
             $content = str_replace($heading_code, $heading_new_code, $content);
210 210
             if ($current_tag_level === false) {
Please login to merge, or discard this patch.
lib/org/openpsa/directmarketing/handler/message/send.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -114,7 +114,7 @@
 block discarded – undo
114 114
     {
115 115
         $nap = new midcom_helper_nav();
116 116
         $node = $nap->get_node($nap->get_current_node());
117
-        $compose_url = $node[MIDCOM_NAV_RELATIVEURL] . 'message/compose/' . $data['message']->guid .'/';
117
+        $compose_url = $node[MIDCOM_NAV_RELATIVEURL] . 'message/compose/' . $data['message']->guid . '/';
118 118
         $this->batch_url_base_full = $node[MIDCOM_NAV_RELATIVEURL] . 'message/send_bg/' . $data['message']->guid . '/';
119 119
         debug_add("compose_url: {$compose_url}");
120 120
         debug_add("batch_url base: {$this->batch_url_base_full}");
Please login to merge, or discard this patch.
lib/org/openpsa/products/handler/product/csv.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@
 block discarded – undo
50 50
 
51 51
     public function _load_data(string $handler_id, array &$args, array &$data) : array
52 52
     {
53
-        if (   empty($_POST)
53
+        if (empty($_POST)
54 54
             && $this->session->exists('POST_data')) {
55 55
             $_POST = $this->session->get('POST_data');
56 56
             $this->session->remove('POST_data');
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/handler/object/manage.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -223,10 +223,10 @@
 block discarded – undo
223 223
             $new_type_reflector = midcom_helper_reflector::get($new_type);
224 224
             $link_properties = $new_type_reflector->get_link_properties();
225 225
             foreach ($link_properties as $property => $link) {
226
-                if (   ($link['class'] && midcom_helper_reflector::is_same_class($link['class'], $this->_object->__mgdschema_class_name__))
226
+                if (($link['class'] && midcom_helper_reflector::is_same_class($link['class'], $this->_object->__mgdschema_class_name__))
227 227
                     || $link['type'] == MGD_TYPE_GUID) {
228 228
                     $defaults[$property] = $this->_object->{$link['target']};
229
-                } elseif (   $property == $parent_property
229
+                } elseif ($property == $parent_property
230 230
                           && midcom_helper_reflector::is_same_class($new_type, $this->_object->__mgdschema_class_name__)) {
231 231
                     $defaults[$property] = $this->_object->$parent_property;
232 232
                 }
Please login to merge, or discard this patch.
lib/midcom/services/auth/main.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -221,7 +221,7 @@
 block discarded – undo
221 221
             return true;
222 222
         }
223 223
         if ($user === null) {
224
-            $user =& $this->user;
224
+            $user = & $this->user;
225 225
         }
226 226
 
227 227
         if ($user == 'EVERYONE') {
Please login to merge, or discard this patch.
lib/org/openpsa/contacts/person.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@
 block discarded – undo
59 59
 
60 60
     public function __set($name, $value)
61 61
     {
62
-        if (   $name == 'homepage'
62
+        if ($name == 'homepage'
63 63
             && !empty($value)
64 64
             && $value != $this->homepage) {
65 65
             $this->_register_prober = true;
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/stylehelper.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
 
23 23
     public function __construct(array &$data)
24 24
     {
25
-        $this->_data =& $data;
25
+        $this->_data = & $data;
26 26
         midcom::get()->head->enable_jquery_ui(['accordion']);
27 27
     }
28 28
 
@@ -32,14 +32,14 @@  discard block
 block discarded – undo
32 32
             return;
33 33
         }
34 34
 
35
-        if (   midcom::get()->dbfactory->is_a($this->_data['object'], 'midgard_style')
36
-            && (   $this->_data['handler_id'] !== 'object_create'
35
+        if (midcom::get()->dbfactory->is_a($this->_data['object'], 'midgard_style')
36
+            && ($this->_data['handler_id'] !== 'object_create'
37 37
                 || $this->_data['current_type'] == 'midgard_element')) {
38 38
             // Suggest element names to create under a style
39 39
             $this->_data['help_style_elementnames'] = $this->_get_style_elements_and_nodes($this->_data['object']->id);
40 40
             midcom_show_style('midgard_admin_asgard_stylehelper_elementnames');
41 41
 
42
-        } elseif (   midcom::get()->dbfactory->is_a($this->_data['object'], 'midgard_element')
42
+        } elseif (midcom::get()->dbfactory->is_a($this->_data['object'], 'midgard_element')
43 43
                   && $this->_get_help_element()) {
44 44
             midcom_show_style('midgard_admin_asgard_stylehelper_element');
45 45
         }
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
 
48 48
     private function _get_help_element() : bool
49 49
     {
50
-        if (   empty($this->_data['object']->name)
50
+        if (empty($this->_data['object']->name)
51 51
             || empty($this->_data['object']->style)) {
52 52
             // We cannot help with empty elements
53 53
             return false;
Please login to merge, or discard this patch.