Passed
Push — master ( eb3d65...8de60e )
by Andreas
18:09
created
lib/midcom/helper/metadata.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -292,7 +292,7 @@  discard block
 block discarded – undo
292 292
     {
293 293
         if (in_array($key, $this->field_config['timebased'])) {
294 294
             // This is ugly, but seems the only possible way...
295
-            if (   isset($this->__metadata->$key)
295
+            if (isset($this->__metadata->$key)
296 296
                 && (string) $this->__metadata->$key !== "0001-01-01T00:00:00+00:00") {
297 297
                 return (int) $this->__metadata->$key->format('U');
298 298
             }
@@ -354,11 +354,11 @@  discard block
 block discarded – undo
354 354
         }
355 355
 
356 356
         $now = time();
357
-        if (   $this->get('schedulestart')
357
+        if ($this->get('schedulestart')
358 358
             && $this->get('schedulestart') > $now) {
359 359
             return false;
360 360
         }
361
-        if (   $this->get('scheduleend')
361
+        if ($this->get('scheduleend')
362 362
             && $this->get('scheduleend') < $now) {
363 363
             return false;
364 364
         }
@@ -374,9 +374,9 @@  discard block
 block discarded – undo
374 374
     public function is_object_visible_onsite() : bool
375 375
     {
376 376
         return
377
-        (   (   midcom::get()->config->get('show_hidden_objects')
377
+        ((midcom::get()->config->get('show_hidden_objects')
378 378
              || $this->is_visible())
379
-         && (   midcom::get()->config->get('show_unapproved_objects')
379
+         && (midcom::get()->config->get('show_unapproved_objects')
380 380
              || $this->is_approved())
381 381
         );
382 382
     }
@@ -434,7 +434,7 @@  discard block
 block discarded – undo
434 434
             $guid = $source;
435 435
         }
436 436
 
437
-        if (   $object === null
437
+        if ($object === null
438 438
             && mgd_is_guid($guid)) {
439 439
             try {
440 440
                 $object = midcom::get()->dbfactory->get_object_by_guid($guid);
@@ -467,7 +467,7 @@  discard block
 block discarded – undo
467 467
         }
468 468
 
469 469
         // Lock was created by the user, return "not locked"
470
-        if (   !empty(midcom::get()->auth->user->guid)
470
+        if (!empty(midcom::get()->auth->user->guid)
471 471
             && $this->get('locker') === midcom::get()->auth->user->guid) {
472 472
             return false;
473 473
         }
@@ -500,7 +500,7 @@  discard block
 block discarded – undo
500 500
      */
501 501
     public function can_unlock() : bool
502 502
     {
503
-        return (   $this->__object->can_do('midcom:unlock')
503
+        return ($this->__object->can_do('midcom:unlock')
504 504
                 || midcom::get()->auth->can_user_do('midcom:unlock', null, midcom_services_auth::class));
505 505
     }
506 506
 
@@ -511,7 +511,7 @@  discard block
 block discarded – undo
511 511
      */
512 512
     public function unlock() : bool
513 513
     {
514
-        if (   $this->can_unlock()
514
+        if ($this->can_unlock()
515 515
             && $this->__object->unlock()) {
516 516
             $this->_cache = [];
517 517
             return true;
Please login to merge, or discard this patch.
lib/midcom/services/auth/frontend/form.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
      */
41 41
     public function read_login_data(Request $request) : ?array
42 42
     {
43
-        if (   !$request->request->has('midcom_services_auth_frontend_form_submit')
43
+        if (!$request->request->has('midcom_services_auth_frontend_form_submit')
44 44
             || !$request->request->has('username')
45 45
             || !$request->request->has('password')) {
46 46
             return null;
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
     {
77 77
         // Store the submitted form if the session expired, but user wants to save the data
78 78
         if (!empty($_POST)) {
79
-            $data =& midcom_core_context::get()->get_custom_key('request_data');
79
+            $data = & midcom_core_context::get()->get_custom_key('request_data');
80 80
 
81 81
             $data['restored_form_data'] = [];
82 82
 
Please login to merge, or discard this patch.
lib/net/nemein/wiki/midcom/interfaces.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@
 block discarded – undo
44 44
 
45 45
     public function resolve_object_link(midcom_db_topic $topic, midcom_core_dbaobject $object) : ?string
46 46
     {
47
-        if (   $object instanceof midcom_db_article
47
+        if ($object instanceof midcom_db_article
48 48
             && $topic->id == $object->topic) {
49 49
             if ($object->name == 'index') {
50 50
                 return '';
Please login to merge, or discard this patch.
lib/org/openpsa/documents/midcom/interfaces.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@
 block discarded – undo
40 40
 
41 41
     public function resolve_object_link(midcom_db_topic $topic, midcom_core_dbaobject $object) : ?string
42 42
     {
43
-        if (   $object instanceof org_openpsa_documents_document_dba
43
+        if ($object instanceof org_openpsa_documents_document_dba
44 44
             && $object->topic == $topic->id) {
45 45
             return "document/{$object->guid}/";
46 46
         }
Please login to merge, or discard this patch.
lib/org/openpsa/contacts/midcom/interfaces.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -77,11 +77,11 @@  discard block
 block discarded – undo
77 77
 
78 78
     public function resolve_object_link(midcom_db_topic $topic, midcom_core_dbaobject $object) : ?string
79 79
     {
80
-        if (   $object instanceof org_openpsa_contacts_group_dba
80
+        if ($object instanceof org_openpsa_contacts_group_dba
81 81
             || $object instanceof midcom_db_group) {
82 82
             return "group/{$object->guid}/";
83 83
         }
84
-        if (   $object instanceof org_openpsa_contacts_person_dba
84
+        if ($object instanceof org_openpsa_contacts_person_dba
85 85
             || $object instanceof midcom_db_person) {
86 86
             return "person/{$object->guid}/";
87 87
         }
@@ -110,8 +110,8 @@  discard block
 block discarded – undo
110 110
             // We have a feed URL, but we should check if it is GeoRSS as well
111 111
             $items = net_nemein_rss_fetch::raw_fetch($data['rss_url'])->get_items();
112 112
 
113
-            if (   !empty($items)
114
-                && (   $items[0]->get_latitude()
113
+            if (!empty($items)
114
+                && ($items[0]->get_latitude()
115 115
                     || $items[0]->get_longitude())) {
116 116
                 // This is a GeoRSS feed
117 117
                 $data['georss_url'] = $data['rss_url'];
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/style/midgard_admin_asgard_rcs_history.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@
 block discarded – undo
36 36
                 echo "                    <td>" . strftime('%x %X Z', $revision['date']) . "</td>\n";
37 37
                 echo "                    <td>";
38 38
 
39
-                if (   $revision['user']
39
+                if ($revision['user']
40 40
                     && $user = midcom::get()->auth->get_user($revision['user'])) {
41 41
                     echo $user->get_storage()->name;
42 42
                 } elseif ($revision['ip']) {
Please login to merge, or discard this patch.
lib/net/nemein/wiki/style/view-wikipage-raw.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -6,6 +6,6 @@
 block discarded – undo
6 6
     &(view["content"]:h);
7 7
     <?php
8 8
 } else {
9
-    echo "<p class=\"stub\">" . $data['l10n']->get('this page is stub')."</p>";
9
+    echo "<p class=\"stub\">" . $data['l10n']->get('this page is stub') . "</p>";
10 10
 }
11 11
 ?>
12 12
\ No newline at end of file
Please login to merge, or discard this patch.
lib/org/openpsa/invoices/style/admin-read.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
         <div class="value"><?php echo $formatter->date($invoice->deliverydate); ?></div></div>
35 35
     <?php } ?>
36 36
 
37
-    <div class="field"><div class="title"><?php echo $data['l10n_midcom']->get('description');?>: </div>
37
+    <div class="field"><div class="title"><?php echo $data['l10n_midcom']->get('description'); ?>: </div>
38 38
     <div class="description value">&(view['description']:h);</div></div>
39 39
 
40 40
     <?php
Please login to merge, or discard this patch.
lib/org/openpsa/relatedto/style/show_entries_html.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
             <?php
47 47
             //index is needed for sorting
48 48
             echo "'index_name',";
49
-            echo "'" . $data['l10n']->get('entry title') ."',";
49
+            echo "'" . $data['l10n']->get('entry title') . "',";
50 50
             echo "'" . $data['l10n']->get('entry text') . "',";
51 51
             echo "'" . $data['l10n']->get('entry created') . "',";
52 52
             echo "'index_creator', '" . $data['l10n_midcom']->get('creator') . "',";
Please login to merge, or discard this patch.