@@ -240,7 +240,8 @@ discard block |
||
| 240 | 240 | $salesproject = org_openpsa_sales_salesproject_dba::get_cached($agreement->salesproject); |
| 241 | 241 | $this->customer = $salesproject->customer; |
| 242 | 242 | } |
| 243 | - } catch (midcom_error $e) { |
|
| 243 | + } |
|
| 244 | + catch (midcom_error $e) { |
|
| 244 | 245 | } |
| 245 | 246 | } else { |
| 246 | 247 | // No agreement, we can't be invoiceable |
@@ -275,7 +276,8 @@ discard block |
||
| 275 | 276 | try { |
| 276 | 277 | $agreement = new org_openpsa_sales_salesproject_deliverable_dba($this->agreement); |
| 277 | 278 | $agreement->update_units($this->id, $hours); |
| 278 | - } catch (midcom_error $e) { |
|
| 279 | + } |
|
| 280 | + catch (midcom_error $e) { |
|
| 279 | 281 | } |
| 280 | 282 | |
| 281 | 283 | if ($update) { |
@@ -302,7 +304,8 @@ discard block |
||
| 302 | 304 | try { |
| 303 | 305 | $agreement = new org_openpsa_sales_salesproject_deliverable_dba($this->agreement); |
| 304 | 306 | $invoice_approved_only = $agreement->invoiceApprovedOnly; |
| 305 | - } catch (midcom_error $e) { |
|
| 307 | + } |
|
| 308 | + catch (midcom_error $e) { |
|
| 306 | 309 | $invoice_approved_only = false; |
| 307 | 310 | } |
| 308 | 311 | |
@@ -171,7 +171,8 @@ |
||
| 171 | 171 | //create reflector with linked object to get the right label |
| 172 | 172 | try { |
| 173 | 173 | $linked_object = midcom::get()->dbfactory->get_object_by_guid($entry->linkGuid); |
| 174 | - } catch (midcom_error $e) { |
|
| 174 | + } |
|
| 175 | + catch (midcom_error $e) { |
|
| 175 | 176 | unset($data['entries'][$i]); |
| 176 | 177 | $e->log(); |
| 177 | 178 | continue; |
@@ -92,7 +92,8 @@ |
||
| 92 | 92 | $customer = new org_openpsa_contacts_group_dba($customer_id); |
| 93 | 93 | $customer_label = $customer->official; |
| 94 | 94 | $customer = $customer_id; |
| 95 | - } catch (midcom_error $e) { |
|
| 95 | + } |
|
| 96 | + catch (midcom_error $e) { |
|
| 96 | 97 | } |
| 97 | 98 | } |
| 98 | 99 | } |
@@ -129,7 +129,8 @@ |
||
| 129 | 129 | |
| 130 | 130 | try { |
| 131 | 131 | $response = $browser->send($request); |
| 132 | - } catch (Exception $e) { |
|
| 132 | + } |
|
| 133 | + catch (Exception $e) { |
|
| 133 | 134 | $this->error = $e->getMessage(); |
| 134 | 135 | debug_add("Got error '{$this->error}' from HTTP request", MIDCOM_LOG_INFO); |
| 135 | 136 | return false; |
@@ -148,7 +148,8 @@ |
||
| 148 | 148 | try { |
| 149 | 149 | $this->$function(); |
| 150 | 150 | $this->_response->success = true; |
| 151 | - } catch (midcom_error $e) { |
|
| 151 | + } |
|
| 152 | + catch (midcom_error $e) { |
|
| 152 | 153 | $this->_response->success = false; |
| 153 | 154 | $this->_response->error = $e->getMessage(); |
| 154 | 155 | } |
@@ -52,7 +52,8 @@ |
||
| 52 | 52 | // TODO: Should we sudo here to ensure getting correct prefs regardless of ACLs? |
| 53 | 53 | try { |
| 54 | 54 | $recipient = midcom_db_person::get_cached($recipient); |
| 55 | - } catch (midcom_error $e) { |
|
| 55 | + } |
|
| 56 | + catch (midcom_error $e) { |
|
| 56 | 57 | return false; |
| 57 | 58 | } |
| 58 | 59 | |
@@ -126,7 +126,8 @@ |
||
| 126 | 126 | $salesproject = org_openpsa_sales_salesproject_dba::get_cached($this->_deliverable->salesproject); |
| 127 | 127 | try { |
| 128 | 128 | $owner = midcom_db_person::get_cached($salesproject->owner); |
| 129 | - } catch (midcom_error $e) { |
|
| 129 | + } |
|
| 130 | + catch (midcom_error $e) { |
|
| 130 | 131 | $e->log(); |
| 131 | 132 | return; |
| 132 | 133 | } |
@@ -57,7 +57,8 @@ discard block |
||
| 57 | 57 | try { |
| 58 | 58 | $deliverable = org_openpsa_sales_salesproject_deliverable_dba::get_cached($at_entry->arguments['deliverable']); |
| 59 | 59 | $salesproject = org_openpsa_sales_salesproject_dba::get_cached($deliverable->salesproject); |
| 60 | - } catch (midcom_error $e) { |
|
| 60 | + } |
|
| 61 | + catch (midcom_error $e) { |
|
| 61 | 62 | $e->log(); |
| 62 | 63 | return $invoice; |
| 63 | 64 | } |
@@ -95,7 +96,8 @@ discard block |
||
| 95 | 96 | $object = $classname::get_cached($id); |
| 96 | 97 | $invoice[$fieldname] = $object->render_link(); |
| 97 | 98 | $invoice['index_' . $fieldname] = $object->get_label(); |
| 98 | - } catch (midcom_error $e) { |
|
| 99 | + } |
|
| 100 | + catch (midcom_error $e) { |
|
| 99 | 101 | $e->log(); |
| 100 | 102 | } |
| 101 | 103 | } |
@@ -134,7 +134,8 @@ discard block |
||
| 134 | 134 | |
| 135 | 135 | try { |
| 136 | 136 | $deliverable = new org_openpsa_sales_salesproject_deliverable_dba($args['deliverable']); |
| 137 | - } catch (midcom_error $e) { |
|
| 137 | + } |
|
| 138 | + catch (midcom_error $e) { |
|
| 138 | 139 | $handler->print_error("Deliverable {$args['deliverable']} not found: " . midcom_connection::get_error_string()); |
| 139 | 140 | return false; |
| 140 | 141 | } |
@@ -158,7 +159,8 @@ discard block |
||
| 158 | 159 | } |
| 159 | 160 | try { |
| 160 | 161 | $deliverable = new org_openpsa_sales_salesproject_deliverable_dba($args['deliverable']); |
| 161 | - } catch (midcom_error $e) { |
|
| 162 | + } |
|
| 163 | + catch (midcom_error $e) { |
|
| 162 | 164 | $handler->print_error('no deliverable with passed GUID: ' . $args['deliverable'] . ', aborting'); |
| 163 | 165 | return false; |
| 164 | 166 | } |
@@ -166,7 +168,8 @@ discard block |
||
| 166 | 168 | //get the owner of the salesproject the deliverable belongs to |
| 167 | 169 | try { |
| 168 | 170 | $project = new org_openpsa_sales_salesproject_dba($deliverable->salesproject); |
| 169 | - } catch (midcom_error $e) { |
|
| 171 | + } |
|
| 172 | + catch (midcom_error $e) { |
|
| 170 | 173 | $handler->print_error('Failed to load salesproject: ' . $e->getMessage()); |
| 171 | 174 | return false; |
| 172 | 175 | } |