flack /
openpsa
| Conditions | 12 |
| Paths | 40 |
| Total Lines | 70 |
| Code Lines | 52 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 16 |
| CRAP Score | 68.7814 |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 67 | 1 | private function get_status_entries() : array |
|
| 68 | { |
||
| 69 | 1 | $entries = []; |
|
| 70 | 1 | if ($this->invoice->defaultdate) { |
|
| 71 | $entries[] = [ |
||
| 72 | 'timestamp' => $this->invoice->defaultdate, |
||
| 73 | 'message' => $this->l10n->get('default'), |
||
| 74 | 'order' => 5 |
||
| 75 | ]; |
||
| 76 | 1 | } elseif ($this->invoice->cancelationInvoice) { |
|
| 77 | $prefix = midcom_core_context::get()->get_key(MIDCOM_CONTEXT_ANCHORPREFIX); |
||
| 78 | $cancelation_invoice = new org_openpsa_invoices_invoice_dba($this->invoice->cancelationInvoice); |
||
| 79 | $cancelation_invoice_link = $prefix . 'invoice/' . $cancelation_invoice->guid . '/'; |
||
|
Bug
introduced
by
|
|||
| 80 | $cancelation_invoice_link = "<a href=\"" . $cancelation_invoice_link . "\">" . $this->l10n->get('invoice') . " " . $cancelation_invoice->get_label() . "</a>"; |
||
| 81 | $entries[] = [ |
||
| 82 | 'timestamp' => $cancelation_invoice->metadata->created, |
||
| 83 | 'message' => sprintf($this->l10n->get('invoice got canceled by %s'), $cancelation_invoice_link), |
||
| 84 | 'order' => 4 |
||
| 85 | ]; |
||
| 86 | 1 | } elseif ($this->invoice->paid) { |
|
| 87 | $entries[] = [ |
||
| 88 | 'timestamp' => $this->invoice->paid, |
||
| 89 | 'message' => sprintf($this->l10n->get('marked invoice %s paid'), ''), |
||
| 90 | 'order' => 3 |
||
| 91 | ]; |
||
| 92 | } |
||
| 93 | 1 | if ( $this->invoice->due |
|
| 94 | 1 | && ( ( $this->invoice->due < time() |
|
| 95 | 1 | && $this->invoice->paid == 0) |
|
| 96 | 1 | || $this->invoice->due < $this->invoice->paid)) { |
|
| 97 | $entries[] = [ |
||
| 98 | 'timestamp' => $this->invoice->due, |
||
| 99 | 'message' => $this->l10n->get('overdue'), |
||
| 100 | 'order' => 2 |
||
| 101 | ]; |
||
| 102 | } |
||
| 103 | |||
| 104 | 1 | if ($this->invoice->sent) { |
|
| 105 | if ($mail_time = $this->invoice->get_parameter('org.openpsa.invoices', 'sent_by_mail')) { |
||
| 106 | $entries[] = [ |
||
| 107 | 'timestamp' => $mail_time, |
||
| 108 | 'message' => sprintf($this->l10n->get('marked invoice %s sent per mail'), ''), |
||
| 109 | 'order' => 1 |
||
| 110 | ]; |
||
| 111 | } else { |
||
| 112 | $entries[] = [ |
||
| 113 | 'timestamp' => $this->invoice->sent, |
||
| 114 | 'message' => sprintf($this->l10n->get('marked invoice %s sent'), ''), |
||
| 115 | 'order' => 1 |
||
| 116 | ]; |
||
| 117 | } |
||
| 118 | |||
| 119 | $reminders = $this->invoice->get_parameter('org.openpsa.invoices', 'sent_payment_reminder'); |
||
| 120 | if ($reminders) { |
||
| 121 | $reminder_times = json_decode($reminders, true); |
||
| 122 | foreach ($reminder_times as $reminder_time) { |
||
| 123 | $entries[] = [ |
||
| 124 | 'timestamp' => $reminder_time, |
||
| 125 | 'message' => sprintf($this->l10n->get('marked invoice %s payment reminder sent'), ''), |
||
| 126 | 'order' => 1 |
||
| 127 | ]; |
||
| 128 | } |
||
| 129 | } |
||
| 130 | } |
||
| 131 | 1 | $entries[] = [ |
|
| 132 | 1 | 'timestamp' => $this->invoice->metadata->created, |
|
| 133 | 1 | 'message' => sprintf($this->l10n->get('invoice %s created'), ''), |
|
| 134 | 1 | 'order' => 0 |
|
| 135 | 1 | ]; |
|
| 136 | 1 | return $entries; |
|
| 137 | } |
||
| 156 |
Loading history...