midcom\bundle\dependencyInjection\componentPass

Complexity

Total Complexity

13

Size/Duplication

Total Lines	80
Duplicated Lines	0 %

Test Coverage

Coverage

97.3%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	add_watches()	0	9	4
A	find_builtin_components()	0	11	2
A	process()	0	27	5
A	process_manifest()	0	6	2

<?php
namespace midcom\bundle\dependencyInjection;

use Symfony\Component\DependencyInjection\ContainerBuilder;
use midcom_core_manifest;
use midcom_error;
use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
use Symfony\Component\Finder\Finder;

class componentPass implements CompilerPassInterface
{
    /**
     * @var array
     */
    private $watches = [
        \MIDCOM_OPERATION_DBA_CREATE => [],
        \MIDCOM_OPERATION_DBA_UPDATE => [],
        \MIDCOM_OPERATION_DBA_DELETE => [],
        \MIDCOM_OPERATION_DBA_IMPORT => []
    ];

    public function process(ContainerBuilder $container)
    {
        $paths = $this->find_builtin_components();

        // now we look for extra components the user may have registered
        foreach ($container->getParameter('midcom.midcom_components') as $path) {
            if (!file_exists($path . '/config/manifest.inc')) {
                throw new midcom_error('No manifest found in path ' . $path);
            }
            $paths[] = $path . '/config/manifest.inc';
        }

        foreach ($paths as $path) {
            $manifest = new midcom_core_manifest($path);
            $components[$manifest->name] = $path;
            if ($manifest->watches !== null) {
                $this->add_watches($manifest->name, $manifest->watches);
            }

            $this->process_manifest($manifest, $container);
        }

        $cl = $container->getDefinition('componentloader');
        $cl->addArgument($components);

The variable $components seems to be defined by a foreach iteration on line 34. Are you sure the iterator is never empty, otherwise this variable is not defined?

        $watcher = $container->getDefinition('watcher');
        $watcher->addArgument($this->watches);
    }

    private function find_builtin_components() : array
    {
        $components = [];
        $finder = (new Finder())
            ->files()
            ->in([MIDCOM_ROOT, dirname(MIDCOM_ROOT) . '/src'])
            ->name('manifest.inc');
        foreach ($finder as $file) {
            $components[] = $file->getPathname();
        }
        return $components;
    }

    private function add_watches(string $component, array $watches)
    {
        foreach ($watches as $watch) {
            foreach (array_keys($this->watches) as $operation_id) {
                // Check whether the operations flag list from the component
                // contains the operation_id we're checking a watch for.
                if ($watch['operations'] & $operation_id) {
                    $this->watches[$operation_id][] = [
                        $component => $watch['classes']
                    ];
                }
            }
        }
    }

    /**
     * Register manifest data.
     *
     * All default privileges are made known to ACL, the watches are registered
     */
    private function process_manifest(midcom_core_manifest $manifest, ContainerBuilder $container)
    {
        // Register Privileges
        if ($manifest->privileges) {

The expression $manifest->privileges of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $acl = $container->getDefinition('auth.acl');
            $acl->addMethodCall('register_default_privileges', [$manifest->privileges]);
        }
    }
}