flack / openpsa

lib/midcom/helper/reflector/tree.php

Spacing +5 added lines, -5 removed lines

@@ -158,7 +158,7 @@ 
     private static function _check_permissions($deleted)
     {
         // PONDER: Check for some generic user privilege instead  ??
-        if (   $deleted
+        if ($deleted
             && !midcom_connection::is_admin()
             && !midcom::get()->auth->is_component_sudo()) {
             debug_add('Non-admins are not allowed to list deleted objects', MIDCOM_LOG_ERROR);
@@ -248,7 +248,7 @@ 
                     'target' => $ref->get_link_target($field)
                 ];
                 $linked_class = $ref->get_link_name($field);
-                if (   empty($linked_class)
+                if (empty($linked_class)
                     && $info['type'] === MGD_TYPE_GUID) {
                     // Guid link without class specification, valid for all classes
                     if (empty($info['target'])) {
@@ -298,7 +298,7 @@ 
             $field_type = $field_data['type'];
             $field = $field_data['name'];
 
-            if (   !$field_target
+            if (!$field_target
                 || !isset($for_object->$field_target)) {
                 // Why return false ???
                 return false;
@@ -414,7 +414,7 @@ 
             $parent_property = midgard_object_class::get_property_parent($schema_type);
             $up_property = midgard_object_class::get_property_up($schema_type);
 
-            if (   !$this->_resolve_child_classes_links_back($parent_property, $schema_type, $this->mgdschema_class)
+            if (!$this->_resolve_child_classes_links_back($parent_property, $schema_type, $this->mgdschema_class)
                 && !$this->_resolve_child_classes_links_back($up_property, $schema_type, $this->mgdschema_class)) {
                 continue;
             }
@@ -439,7 +439,7 @@ 
 
         $ref = new midgard_reflection_property($prospect_type);
         $link_class = $ref->get_link_name($property);
-        if (   empty($link_class)
+        if (empty($link_class)
             && $ref->get_midgard_type($property) === MGD_TYPE_GUID) {
             return true;
         }

lib/midcom/helper/misc.php

Spacing +4 added lines, -4 removed lines

@@ -252,7 +252,7 @@ 
             return $data;
         }
 
-        $preg='/s:([0-9]+):"(.*?)";/ms';
+        $preg = '/s:([0-9]+):"(.*?)";/ms';
         preg_match_all($preg, $data, $matches);
         $cache = [];
 
@@ -348,13 +348,13 @@ 
             $theme_path = implode('/', $path_array);
             $candidates = [];
             if ($substyle) {
-                $candidates[] =  $theme_root . $theme_path .  "/style/{$substyle}/{$element_name}.php";
+                $candidates[] = $theme_root . $theme_path . "/style/{$substyle}/{$element_name}.php";
             }
             if ($page) {
-                $candidates[] =  $theme_root . $theme_path .  "/style{$page}/{$element_name}.php";
+                $candidates[] = $theme_root . $theme_path . "/style{$page}/{$element_name}.php";
             }
 
-            $candidates[] = $theme_root . $theme_path .  "/style/{$element_name}.php";
+            $candidates[] = $theme_root . $theme_path . "/style/{$element_name}.php";
 
             foreach (array_filter($candidates, 'file_exists') as $candidate) {
                 return file_get_contents($candidate);

lib/midcom/helper/toolbar/view.php

Spacing +2 added lines, -2 removed lines

@@ -54,7 +54,7 @@ 
             ]);
         }
 
-        if (   midcom::get()->config->get('midcom_services_rcs_enable')
+        if (midcom::get()->config->get('midcom_services_rcs_enable')
             && $object->can_do('midgard:update')
             && $object->_use_rcs) {
             $buttons[] = [
@@ -84,7 +84,7 @@ 
             }
 
             $icon = 'stock-icons/16x16/page-' . $icontype . '.png';
-            if (   !midcom::get()->config->get('show_hidden_objects')
+            if (!midcom::get()->config->get('show_hidden_objects')
                 && !$object->metadata->is_visible()) {
                 // Take scheduling into account
                 $icon = 'stock-icons/16x16/page-' . $icontype . '-notpublished.png';

lib/fi/protie/navigation/main.php

Spacing +7 added lines, -7 removed lines

@@ -338,8 +338,8 @@ 
         $classes = [];
 
         if ($child[MIDCOM_NAV_TYPE] === 'node') {
-            if (   $item[MIDCOM_NAV_ID] === $this->_nap->get_current_node()
-                && (   !$this->_nap->get_current_leaf()
+            if ($item[MIDCOM_NAV_ID] === $this->_nap->get_current_node()
+                && (!$this->_nap->get_current_leaf()
                     || !$this->_nap->get_leaf($this->_nap->get_current_leaf()))) {
                 $classes[] = $this->css_active;
             }
@@ -386,7 +386,7 @@ 
         }
 
         // Add information about the object's status
-        if (   $this->object_status_to_class
+        if ($this->object_status_to_class
             && isset($item[MIDCOM_NAV_OBJECT])
             && $css_status_class = midcom::get()->metadata->get_object_classes($item[MIDCOM_NAV_OBJECT])) {
             $classes[] = $css_status_class;
@@ -405,12 +405,12 @@ 
         echo "<a href=\"{$item[MIDCOM_NAV_ABSOLUTEURL]}\"{$link_class}>{$item[MIDCOM_NAV_NAME]}</a>";
         // If either of the follow nodes switches is on, follow all the nodes
 
-        if (   $item[MIDCOM_NAV_TYPE] === 'node'
+        if ($item[MIDCOM_NAV_TYPE] === 'node'
             && !$this->show_only_current
-            && (   $this->list_levels === 0
+            && ($this->list_levels === 0
                 || $this->_level < $this->list_levels)) {
-            if (   $this->follow_all
-                || (   $this->follow_selected
+            if ($this->follow_all
+                || ($this->follow_selected
                     && in_array($item[MIDCOM_NAV_ID], $this->node_path, true))) {
                 $this->_level++;
                 $this->_list_child_elements($item[MIDCOM_NAV_ID]);

lib/org/openpsa/invoices/status.php

Spacing +3 added lines, -3 removed lines

@@ -85,7 +85,7 @@ 
     {
         $entries = array_merge($this->get_status_entries(), $this->get_journal_entries());
 
-        usort($entries, function ($a, $b) {
+        usort($entries, function($a, $b) {
             if ($a['timestamp'] == $b['timestamp']) {
                 if ($a['order'] == $b['order']) {
                     return 0;
@@ -122,8 +122,8 @@ 
                 'order' => 3
             ];
         }
-        if (   $this->invoice->due
-            && (   (   $this->invoice->due < time()
+        if ($this->invoice->due
+            && (($this->invoice->due < time()
                     && $this->invoice->paid == 0)
                 || $this->invoice->due < $this->invoice->paid)) {
             $entries[] = [

lib/org/openpsa/products/product/group.php

Spacing +3 added lines, -3 removed lines

@@ -74,7 +74,7 @@ 
         }
 
         $result_cache[$cache_key] = [];
-        $ret =& $result_cache[$cache_key];
+        $ret = & $result_cache[$cache_key];
 
         if (empty($up)) {
             // TODO: use reflection to see what kind of property this is ?
@@ -94,14 +94,14 @@ 
             $value_properties[] = $keyproperty;
         }
         foreach ($label_fields as $fieldname) {
-            if (   $fieldname != 'id'
+            if ($fieldname != 'id'
                 && $fieldname != $keyproperty) {
                 $value_properties[] = $fieldname;
                 continue;
             }
         }
 
-        $mc = org_openpsa_products_product_group_dba::new_collector('up', (int)$up);
+        $mc = org_openpsa_products_product_group_dba::new_collector('up', (int) $up);
         if ($order_by_score) {
             $mc->add_order('metadata.score', 'DESC');
         }

lib/org/openpsa/relatedto/suspect.php

Spacing +3 added lines, -3 removed lines

@@ -91,7 +91,7 @@ 
     {
         $properties = ['fromClass', 'toClass', 'fromGuid', 'toGuid', 'fromComponent', 'toComponent', 'status', 'toExtra', 'toExtra'];
         foreach ($properties as $property) {
-            if (   !empty($defaults->$property)
+            if (!empty($defaults->$property)
                 && empty($link->$property)) {
                 debug_add("Copying property '{$property}' ('{$defaults->$property}') from defaults");
                 $link->$property = $defaults->$property;
@@ -99,7 +99,7 @@ 
         }
         if ($component) {
             debug_add('$component given, guessing direction');
-            if (   empty($link->toComponent)
+            if (empty($link->toComponent)
                 && !empty($link->fromComponent)) {
                 debug_add("Setting property 'toComponent' to '{$component}'");
                 $link->toComponent = $component;
@@ -110,7 +110,7 @@ 
         }
         if (is_object($obj)) {
             debug_add('$obj given, guessing direction');
-            if (   empty($link->toGuid)
+            if (empty($link->toGuid)
                 && !empty($link->fromGuid)) {
                 $link->toClass = get_class($obj);
                 $link->toGuid = $obj->guid;

lib/org/openpsa/slideshow/image.php

Spacing +1 added lines, -1 removed lines

@@ -150,7 +150,7 @@
         $rows = $mc->get_rows(['id', 'name', 'guid'], 'id');
 
         foreach ($images as $image) {
-            if (   !isset($rows[$image->attachment])
+            if (!isset($rows[$image->attachment])
                 || !isset($rows[$image->image])
                 || !isset($rows[$image->thumbnail])) {
                 continue;

lib/org/openpsa/documents/elFinderVolumeOpenpsa.php

Spacing +9 added lines, -9 removed lines

@@ -18,7 +18,7 @@ 
         // elfinder tmp detection doesn't work on OS X
         $this->tmpPath = midcom::get()->config->get('midcom_tempdir');
         // elfinder calls exit(), so we need to make sure we write caches
-        register_shutdown_function(function () {
+        register_shutdown_function(function() {
             midcom::get()->finish();
         });
     }
@@ -43,7 +43,7 @@ 
         }
 
         if (($dir = $this->dir($dst)) == false) {
-            return $this->setError(elFinder::ERROR_TRGDIR_NOT_FOUND, '#'.$dst);
+            return $this->setError(elFinder::ERROR_TRGDIR_NOT_FOUND, '#' . $dst);
         }
 
         if (!$dir['write']) {
@@ -84,7 +84,7 @@ 
 
         if ($file && $file['name'] === $name) { // file exists and check filename for item ID based filesystem
             // check POST data `overwrite` for 3rd party uploader
-            $overwrite = isset($_POST['overwrite'])? (bool)$_POST['overwrite'] : $this->options['uploadOverwrite'];
+            $overwrite = isset($_POST['overwrite']) ? (bool) $_POST['overwrite'] : $this->options['uploadOverwrite'];
             if ($overwrite) {
                 if (!$file['write']) {
                     return $this->setError(elFinder::ERROR_PERM_DENIED);
@@ -250,7 +250,7 @@ 
         $output = [$object->get_label()];
 
         $parent = $object->get_parent();
-        while (   $parent
+        while ($parent
                && $parent->component == 'org.openpsa.documents') {
             $output[] = $parent->extra;
             $parent = $parent->get_parent();
@@ -347,12 +347,12 @@ 
             $data['mime'] = 'directory';
         }
 
-        if (   $owner
+        if ($owner
             && $group = midcom::get()->auth->get_assignee($owner)) {
             $data['group'] = $group->name;
         }
 
-        if (   $this->root !== $path
+        if ($this->root !== $path
             && $parent = $object->get_parent()) {
             $data['phash'] = $this->encode($parent->guid);
         }
@@ -411,7 +411,7 @@ 
      * @param  string $mode open mode
      * @return resource|false
      */
-    protected function _fopen($path, $mode="rb")
+    protected function _fopen($path, $mode = "rb")
     {
         $document = org_openpsa_documents_document_dba::get_cached($path);
         $attachments = org_openpsa_helpers::get_dm2_attachments($document, 'document');
@@ -429,7 +429,7 @@ 
      * @param  string    $path  file path
      * @return bool
      */
-    protected function _fclose($fp, $path='')
+    protected function _fclose($fp, $path = '')
     {
         fclose($fp);
         return true;
@@ -613,7 +613,7 @@ 
     {
         $filename = midcom_db_attachment::safe_filename($name, true);
         $att = $doc->create_attachment($filename, $name, $mimetype);
-        if (   !$att
+        if (!$att
             || !$att->copy_from_handle($fp)) {
             return false;
         }