flack / openpsa

lib/org/openpsa/documents/document.php

Spacing +4 added lines, -4 removed lines

@@ -74,7 +74,7 @@ 
             return;
         }
         $parent = $this->get_parent();
-        if (   $parent
+        if ($parent
             && $parent->component == 'org.openpsa.documents') {
             midcom::get()->auth->request_sudo('org.openpsa.documents');
 
@@ -170,7 +170,7 @@ 
          * if nothing matched so far and the subtype is alphanumeric, uppercase it on the theory
          * that it's probably a file extension
          */
-        if (   $st_orig == $subtype
+        if ($st_orig == $subtype
             && preg_match('/^[a-z0-9]+$/', $subtype)) {
             $subtype = strtoupper($subtype);
         }
@@ -185,7 +185,7 @@ 
         $properties = $this->get_properties();
         // Copy current properties
         foreach ($properties as $key) {
-            if (   $key != 'guid'
+            if ($key != 'guid'
                 && $key != 'id'
                 && $key != 'metadata') {
                 $backup->$key = $this->{$key};
@@ -217,7 +217,7 @@ 
             $backup_attachment = $backup->create_attachment($original_attachment->name, $original_attachment->title, $original_attachment->mimetype);
 
             $original_handle = $original_attachment->open('r');
-            if (   !$backup_attachment
+            if (!$backup_attachment
                 || !$original_handle) {
                 // Failed to copy the attachment, abort
                 return $backup->delete();

src/midcom/workflow/datamanager.php

Spacing +2 added lines, -2 removed lines

@@ -93,8 +93,8 @@
 
     private function prepare_url($url)
     {
-        if (   substr($url, 0, 1) != '/'
-            && ! preg_match('|^https?://|', $url)) {
+        if (substr($url, 0, 1) != '/'
+            && !preg_match('|^https?://|', $url)) {
             $url = midcom_core_context::get()->get_key(MIDCOM_CONTEXT_ANCHORPREFIX) . $url;
         }
         return '"' . $url . '"';

lib/org/openpsa/sales/handler/edit.php

Spacing +2 added lines, -2 removed lines

@@ -34,7 +34,7 @@ 
         $this->_salesproject->require_do('midgard:update');
 
         $schemadb = schemadb::from_path($this->_config->get('schemadb_salesproject'));
-        $field =& $schemadb->get('default')->get_field('customer');
+        $field = & $schemadb->get('default')->get_field('customer');
         $field['type_config']['options'] = org_openpsa_helpers_list::task_groups($this->_salesproject);
         $dm = new datamanager($schemadb);
         $dm->set_storage($this->_salesproject);
@@ -63,7 +63,7 @@ 
         $schemadb = schemadb::from_path($this->_config->get('schemadb_salesproject'));
 
         if (!empty($args[0])) {
-            $field =& $schemadb->get('default')->get_field('customer');
+            $field = & $schemadb->get('default')->get_field('customer');
             try {
                 $customer = new org_openpsa_contacts_group_dba($args[0]);
                 $field['type_config']['options'] = [0 => '', $customer->id => $customer->official];

Braces +2 added lines, -1 removed lines

@@ -69,7 +69,8 @@
                 $field['type_config']['options'] = [0 => '', $customer->id => $customer->official];
 
                 $defaults['customer'] = $customer->id;
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $customer = new org_openpsa_contacts_person_dba($args[0]);
                 $defaults['customerContact'] = $customer->id;
                 $field['type_config']['options'] = org_openpsa_helpers_list::task_groups(new org_openpsa_sales_salesproject_dba, 'id', [$customer->id => true]);

lib/org/openpsa/sales/handler/deliverable/admin.php

Spacing +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
         $at_entries = $mc->get_related_objects();
 
         if (sizeof($at_entries) != 1) {
-            if (   (   $this->_deliverable->continuous
+            if (($this->_deliverable->continuous
                     || $this->_deliverable->end > time())
                 && $this->_deliverable->state == org_openpsa_sales_salesproject_deliverable_dba::STATE_STARTED) {
                 $schema->get_field('next_cycle')['hidden'] = false;

lib/org/openpsa/sales/handler/deliverable/add.php

Spacing +4 added lines, -4 removed lines

@@ -48,13 +48,13 @@ 
 
         if ($this->_product->delivery == org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION) {
             $schema = 'subscription';
-            $field =& $schemadb->get('subscription')->get_field('start');
+            $field = & $schemadb->get('subscription')->get_field('start');
             $field['type_config']['min_date'] = strftime('%Y-%m-%d');
         } else {
-            $end =& $schemadb->get('default')->get_field('end');
+            $end = & $schemadb->get('default')->get_field('end');
             $end['type_config']['min_date'] = strftime('%Y-%m-%d');
             if ($this->_product->costType == "%") {
-                $costPerUnit =& $schemadb->get('default')->get_field('costPerUnit');
+                $costPerUnit = & $schemadb->get('default')->get_field('costPerUnit');
                 $costPerUnit['title'] = $this->_l10n->get("cost per unit (percentage)");
             }
         }
@@ -93,7 +93,7 @@ 
      */
     public function _handler_add($handler_id, array $args, array &$data)
     {
-        if (   !array_key_exists('product', $_POST)
+        if (!array_key_exists('product', $_POST)
             && !array_key_exists('org_openpsa_sales', $_POST)) {
             throw new midcom_error('No product specified, aborting.');
         }

lib/org/openpsa/invoices/handler/billingdata.php

Spacing +3 added lines, -3 removed lines

@@ -30,8 +30,8 @@ 
     private function load_controller(org_openpsa_invoices_billing_data_dba $bd)
     {
         $schemadb = schemadb::from_path($this->_config->get('schemadb_billing_data'));
-        $vat =& $schemadb->get('default')->get_field('vat');
-        $due =& $schemadb->get('default')->get_field('due');
+        $vat = & $schemadb->get('default')->get_field('vat');
+        $due = & $schemadb->get('default')->get_field('due');
         // Fill VAT select
         $vat_array = explode(',', $this->_config->get('vat_percentages'));
         if (!empty($vat_array)) {
@@ -74,7 +74,7 @@ 
         $data['controller'] = $this->load_controller($bd);
 
         $workflow = $this->get_workflow('datamanager', ['controller' => $data['controller']]);
-        if (   $mode == 'edit'
+        if ($mode == 'edit'
             && $bd->can_do('midgard:delete')) {
             $delete = $this->get_workflow('delete', [
                 'object' => $bd,

lib/net/nemein/rss/handler/admin.php

Spacing +1 added lines, -1 removed lines

@@ -82,7 +82,7 @@
         }
 
         // OPML subscription list import support
-        if (   array_key_exists('net_nemein_rss_manage_opml', $_FILES)
+        if (array_key_exists('net_nemein_rss_manage_opml', $_FILES)
             && is_uploaded_file($_FILES['net_nemein_rss_manage_opml']['tmp_name'])) {
             $opml_file = $_FILES['net_nemein_rss_manage_opml']['tmp_name'];
 

src/midcom/datamanager/datamanager.php

Braces +1 added lines, -2 removed lines

@@ -210,8 +210,7 @@
     {
         $ret = [];
 
-        foreach ($this->storage as $field => $value)
-        {
+        foreach ($this->storage as $field => $value) {
             $ret[$field] = $value->get_value();
             $config = $this->schema->get_field($field);
             if (!empty($config['type_config']['allow_multiple'])) {

Spacing +3 added lines, -3 removed lines

@@ -128,7 +128,7 @@ 
      */
     public function set_storage(midcom_core_dbaobject $storage = null, $schema = null)
     {
-        if (   $schema === null
+        if ($schema === null
             && !empty($storage->id)) {
             $schema = $storage->get_parameter('midcom.helper.datamanager2', 'schema_name');
         }
@@ -215,7 +215,7 @@ 
             $name = 'midcom_helper_datamanager2';
         }
 
-        if (   $this->form === null
+        if ($this->form === null
             || $this->form->getName() != $name) {
             $this->get_storage();
             $this->form = $this->schema->build_form(self::get_factory(), $this->storage, $name);
@@ -287,7 +287,7 @@ 
     {
         $ret = true;
         foreach ($this->storage as $field) {
-            if (   $field instanceof recreateable
+            if ($field instanceof recreateable
                 && !$field->recreate()) {
                 $ret = false;
             }

src/midcom/datamanager/extension/transformer/multiple.php

Spacing +2 added lines, -2 removed lines

@@ -41,7 +41,7 @@ 
 
     public function transform($input)
     {
-        if (   $input === false
+        if ($input === false
             || $input === null) {
             return [];
         }
@@ -74,7 +74,7 @@ 
 
     public function reverseTransform($array)
     {
-        if (!is_array($array) ) {
+        if (!is_array($array)) {
             throw new TransformationFailedException('Expected an array.');
         }