flack / openpsa

lib/org/openpsa/relatedto/suspect.php

Spacing +3 added lines, -3 removed lines

@@ -91,7 +91,7 @@ 
     {
         $properties = ['fromClass', 'toClass', 'fromGuid', 'toGuid', 'fromComponent', 'toComponent', 'status', 'toExtra', 'toExtra'];
         foreach ($properties as $property) {
-            if (   !empty($defaults->$property)
+            if (!empty($defaults->$property)
                 && empty($link->$property)) {
                 debug_add("Copying property '{$property}' ('{$defaults->$property}') from defaults");
                 $link->$property = $defaults->$property;
@@ -99,7 +99,7 @@ 
         }
         if ($component) {
             debug_add('$component given, guessing direction');
-            if (   empty($link->toComponent)
+            if (empty($link->toComponent)
                 && !empty($link->fromComponent)) {
                 debug_add("Setting property 'toComponent' to '{$component}'");
                 $link->toComponent = $component;
@@ -110,7 +110,7 @@ 
         }
         if (is_object($obj)) {
             debug_add('$obj given, guessing direction');
-            if (   empty($link->toGuid)
+            if (empty($link->toGuid)
                 && !empty($link->fromGuid)) {
                 $link->toClass = get_class($obj);
                 $link->toGuid = $obj->guid;

lib/org/openpsa/reports/handler/projects/report.php

Braces +2 added lines, -1 removed lines

@@ -123,7 +123,8 @@
             $row = [];
             try {
                 $row['person'] = org_openpsa_contacts_person_dba::get_cached($hour->person);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
                 continue;
             }

Spacing +3 added lines, -3 removed lines

@@ -43,7 +43,7 @@ 
         $qb_hr = org_openpsa_expenses_hour_report_dba::new_query_builder();
         $qb_hr->add_constraint('date', '<=', (int) $this->_request_data['query_data']['end']);
         $qb_hr->add_constraint('date', '>=', (int) $this->_request_data['query_data']['start']);
-        if (   array_key_exists('invoiceable_filter', $this->_request_data['query_data'])
+        if (array_key_exists('invoiceable_filter', $this->_request_data['query_data'])
             && $this->_request_data['query_data']['invoiceable_filter'] != -1) {
             $qb_hr->add_constraint('invoiceable', '=', (bool) $this->_request_data['query_data']['invoiceable_filter']);
         }
@@ -59,7 +59,7 @@ 
             $tasks = $this->_expand_task($this->_request_data['query_data']['task']);
             $qb_hr->add_constraint('task', 'IN', $tasks);
         }
-        if (   array_key_exists('hour_type_filter', $this->_request_data['query_data'])
+        if (array_key_exists('hour_type_filter', $this->_request_data['query_data'])
             && $this->_request_data['query_data']['hour_type_filter'] != 'builtin:all') {
             $qb_hr->add_constraint('reportType', '=', $this->_request_data['query_data']['hour_type_filter']);
         }
@@ -150,7 +150,7 @@ 
 
     private function add_to_group($new_row, $matching, $sort, $title)
     {
-        $rows =& $this->_request_data['report']['rows'];
+        $rows = & $this->_request_data['report']['rows'];
         if (array_key_exists($matching, $rows)) {
             $rows[$matching]['rows'][] = $new_row;
             $rows[$matching]['total_hours'] += $new_row['hour']->hours;

lib/org/openpsa/widgets/ui.php

Indentation +4 added lines, -4 removed lines

@@ -102,12 +102,12 @@
         if (null !== $guid) {
             //pass the urls & titles for the tabs
             $tabdata[] = [
-               'url' => '__mfa/org.openpsa.relatedto/journalentry/' . $guid . '/',
-               'title' => midcom::get()->i18n->get_string('journal entries', 'org.openpsa.relatedto'),
+                'url' => '__mfa/org.openpsa.relatedto/journalentry/' . $guid . '/',
+                'title' => midcom::get()->i18n->get_string('journal entries', 'org.openpsa.relatedto'),
             ];
             $tabdata[] = [
-               'url' => '__mfa/org.openpsa.relatedto/render/' . $guid . '/both/',
-               'title' => midcom::get()->i18n->get_string('related objects', 'org.openpsa.relatedto'),
+                'url' => '__mfa/org.openpsa.relatedto/render/' . $guid . '/both/',
+                'title' => midcom::get()->i18n->get_string('related objects', 'org.openpsa.relatedto'),
             ];
         }
 

Spacing +3 added lines, -3 removed lines

@@ -39,8 +39,8 @@ 
             $config = array_merge($defaults, $config);
 
             $node_url = $siteconfig->get_node_full_url($component);
-            if (   $node_url
-                && (   !$user_id
+            if ($node_url
+                && (!$user_id
                     || midcom::get()->auth->acl->can_do_byguid('midgard:read', $siteconfig->get_node_guid($component), midcom_db_topic::class, $user_id))) {
                 $providers[] = [
                     'placeholder' => midcom::get()->i18n->get_string('search title', $component),
@@ -115,7 +115,7 @@ 
         echo '<div id="tabs">';
         echo "\n<ul>\n";
         foreach ($tabdata as $key => $tab) {
-            echo "<li><a id='key_" . $key ."' class='tabs_link' href='" . $prefix . $tab['url'] . "' ><span> " . $tab['title'] . "</span></a></li>";
+            echo "<li><a id='key_" . $key . "' class='tabs_link' href='" . $prefix . $tab['url'] . "' ><span> " . $tab['title'] . "</span></a></li>";
         }
         echo "\n</ul>\n";
         echo "</div>\n";

lib/org/openpsa/widgets/grid/provider.php

Spacing +3 added lines, -3 removed lines

@@ -232,7 +232,7 @@ 
 
     private function _convert_to_localdata()
     {
-        return "var " . $this->_grid->get_identifier() . '_entries = ' .  json_encode($this->get_rows()) . ";\n";
+        return "var " . $this->_grid->get_identifier() . '_entries = ' . json_encode($this->get_rows()) . ";\n";
     }
 
     private function _render_json()
@@ -266,7 +266,7 @@ 
             $this->_sort_field = $query['sidx'];
             $this->_sort_direction = strtoupper($query['sord']);
         }
-        if (   !empty($query['_search'])
+        if (!empty($query['_search'])
             && $query['_search'] === 'true') {
             foreach ($query as $field => $value) {
                 if (in_array($field, ['_search', 'nd', 'page', 'rows', 'sidx', 'sord'])) {
@@ -291,7 +291,7 @@ 
 
         $this->_total_rows = $qb->count();
 
-        if (   $this->_datatype == 'json'
+        if ($this->_datatype == 'json'
             && !empty($this->_results_per_page)) {
             $qb->set_limit($this->_results_per_page);
             if (!empty($this->_offset)) {

lib/org/openpsa/directmarketing/support/bounce_detector.php

Spacing +2 added lines, -2 removed lines

@@ -45,7 +45,7 @@ 
 }
 $recipient = $_ENV["RECIPIENT"];
 $token_length = strlen($recipient) - strlen($prefix) - strlen($suffix);
-if (   $token_length <= 0
+if ($token_length <= 0
     || substr($recipient, 0, strlen($prefix)) != $prefix
     || substr($recipient, strlen($prefix) + $token_length) != $suffix) {
     error_log("Recipient address does not match address template: $recipient");
@@ -61,7 +61,7 @@ 
         fclose($fh);
         exit(0);
     }
-} elseif (   substr($BOUNCE_LOGGER, 0, strlen("http://")) == "http://"
+} elseif (substr($BOUNCE_LOGGER, 0, strlen("http://")) == "http://"
           || substr($BOUNCE_LOGGER, 0, strlen("https://")) == "https://") {
     $client = new org_openpsa_httplib();
     $client->post($BOUNCE_LOGGER, ["token" => $token]);

lib/org/openpsa/directmarketing/sender.php

Braces +4 added lines, -2 removed lines

@@ -222,7 +222,8 @@ 
             $this->_backend->send($person, $member, $token, $subject, $content, $from);
             self::$_messages_sent++;
             $status = org_openpsa_directmarketing_campaign_messagereceipt_dba::SENT;
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $status = org_openpsa_directmarketing_campaign_messagereceipt_dba::FAILURE;
             if (!$this->test_mode) {
                 $params[] = [
@@ -279,7 +280,8 @@ 
     {
         try {
             $person = org_openpsa_contacts_person_dba::get_cached($member->person);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             debug_add("Person #{$member->person} deleted or missing, removing member (member #{$member->id})");
             $member->orgOpenpsaObtype = org_openpsa_directmarketing_campaign_member_dba::UNSUBSCRIBED;
             $member->delete();

Spacing +3 added lines, -3 removed lines

@@ -260,7 +260,7 @@ 
         $token .= midcom_helper_misc::random_string($this->token_size - 1, 'abcdefghijklmnopqrstuvwxyz0123456789');
 
         //If token is not free or (very, very unlikely) matches our dummy token, recurse.
-        if (   $token === 'dummy'
+        if ($token === 'dummy'
             || !org_openpsa_directmarketing_campaign_messagereceipt_dba::token_is_free($token)) {
             return $this->_create_token();
         }
@@ -284,7 +284,7 @@ 
             return false;
         }
         $type = $this->_backend->get_type();
-        if (   $person->get_parameter('org.openpsa.directmarketing', "send_all_denied")
+        if ($person->get_parameter('org.openpsa.directmarketing', "send_all_denied")
             || $person->get_parameter('org.openpsa.directmarketing', "send_{$type}_denied")) {
             debug_add("Sending {$type} messages to person {$person->rname} is denied, unsubscribing member (member #{$member->id})");
             $member->orgOpenpsaObtype = org_openpsa_directmarketing_campaign_member_dba::UNSUBSCRIBED;
@@ -331,7 +331,7 @@ 
         debug_add("Recursion level is {$level}, limit is {$this->_chunk_max_recurse}");
         /* Make sure we still have results left, if not just recurse...
          (basically this is to avoid returning an empty array when everything is otherwise ok) */
-        if (   count($results) == 0
+        if (count($results) == 0
             && ($level < $this->_chunk_max_recurse)) {
             debug_add('All our results got filtered, recursing for another round');
             //Trivial rate limiting.

lib/org/openpsa/contacts/handler/frontpage.php

Spacing +1 added lines, -1 removed lines

@@ -54,7 +54,7 @@
         }
         $this->_view_toolbar->add_items($buttons);
 
-        if (   $this->_topic->can_do('midgard:update')
+        if ($this->_topic->can_do('midgard:update')
             && $this->_topic->can_do('midcom:component_config')) {
             $this->_node_toolbar->add_item($workflow->get_button('config/', [
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n_midcom->get('component configuration'),

src/midcom/datamanager/extension/type/images.php

Spacing +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
      */
     public function configureOptions(OptionsResolver $resolver)
     {
-        $resolver->setNormalizer('widget_config', function (Options $options, $value) {
+        $resolver->setNormalizer('widget_config', function(Options $options, $value) {
             $widget_defaults = [
                 'map_action_elements' => false,
                 'show_title' => true,

src/midcom/workflow/delete.php

Spacing +1 added lines, -1 removed lines

@@ -88,7 +88,7 @@
             ])
             ->setRequired('object')
             ->setAllowedTypes('object', 'midcom_core_dbaobject')
-            ->setNormalizer('label', function ($options, $value) {
+            ->setNormalizer('label', function($options, $value) {
                 if ($value === null) {
                     return midcom_helper_reflector::get_object_title($options['object']);
                 }