flack / openpsa

lib/midgard/admin/asgard/stylehelper.php

Spacing +5 added lines, -5 removed lines

@@ -22,7 +22,7 @@ 
 
     public function __construct(array &$data)
     {
-        $this->_data =& $data;
+        $this->_data = & $data;
         midcom::get()->head->enable_jquery_ui(['accordion']);
     }
 
@@ -32,14 +32,14 @@ 
             return;
         }
 
-        if (   midcom::get()->dbfactory->is_a($this->_data['object'], 'midgard_style')
-            && (   $this->_data['handler_id'] !== 'object_create'
+        if (midcom::get()->dbfactory->is_a($this->_data['object'], 'midgard_style')
+            && ($this->_data['handler_id'] !== 'object_create'
                 || $this->_data['current_type'] == 'midgard_element')) {
             // Suggest element names to create under a style
             $this->_data['help_style_elementnames'] = $this->_get_style_elements_and_nodes($this->_data['object']->id);
             midcom_show_style('midgard_admin_asgard_stylehelper_elementnames');
 
-        } elseif (   midcom::get()->dbfactory->is_a($this->_data['object'], 'midgard_element')
+        } elseif (midcom::get()->dbfactory->is_a($this->_data['object'], 'midgard_element')
                   && $this->_get_help_element()) {
             midcom_show_style('midgard_admin_asgard_stylehelper_element');
         }
@@ -47,7 +47,7 @@ 
 
     private function _get_help_element() : bool
     {
-        if (   empty($this->_data['object']->name)
+        if (empty($this->_data['object']->name)
             || empty($this->_data['object']->style)) {
             // We cannot help with empty elements
             return false;

lib/net/nehmer/blog/handler/view.php

Spacing +2 added lines, -2 removed lines

@@ -48,7 +48,7 @@ 
             ]);
         }
 
-        if (   $this->_article->topic === $this->_topic->id
+        if ($this->_article->topic === $this->_topic->id
             && $this->_article->can_do('midgard:delete')) {
             $delete = $this->get_workflow('delete', ['object' => $this->_article]);
             $buttons[] = $delete->get_button("delete/{$this->_article->guid}/");
@@ -83,7 +83,7 @@ 
         if ($this->_config->get('comments_enable')) {
             if ($node = net_nehmer_comments_interface::get_node($this->_topic, $this->_config->get('comments_topic'))) {
                 $data['comments_url'] = $node[MIDCOM_NAV_RELATIVEURL] . "comment/{$this->_article->guid}";
-                if (   $this->_topic->can_do('midgard:update')
+                if ($this->_topic->can_do('midgard:update')
                     && $this->_topic->can_do('net.nehmer.comments:moderation')) {
                     net_nehmer_comments_viewer::add_head_elements();
                 }

lib/org/openpsa/sales/midcom/interfaces.php

Spacing +1 added lines, -1 removed lines

@@ -52,7 +52,7 @@
      */
     private function _find_suspects_event(midcom_core_dbaobject $object, org_openpsa_relatedto_dba $defaults, array &$links_array)
     {
-        if (   !is_array($object->participants)
+        if (!is_array($object->participants)
             || count($object->participants) < 2) {
             //We have invalid list or less than two participants, abort
             return;

lib/org/openpsa/directmarketing/midcom/interfaces.php

Spacing +1 added lines, -1 removed lines

@@ -17,7 +17,7 @@
     public function _on_watched_dba_delete(midcom_core_dbaobject $object)
     {
         $qb = org_openpsa_directmarketing_campaign_member_dba::new_query_builder();
-        if (   $object instanceof midcom_db_person
+        if ($object instanceof midcom_db_person
             || $object instanceof org_openpsa_contacts_person_dba) {
             $qb->add_constraint('person', '=', $object->id);
         } elseif ($object instanceof org_openpsa_directmarketing_campaign_dba) {

lib/org/openpsa/directmarketing/handler/message/compose.php

Spacing +2 added lines, -2 removed lines

@@ -69,7 +69,7 @@ 
         }
 
         //Substyle handling
-        if (   !empty($data['message_array']['substyle'])
+        if (!empty($data['message_array']['substyle'])
             && !preg_match('/^builtin:/', $data['message_array']['substyle'])) {
             debug_add("Appending substyle {$data['message_array']['substyle']}");
             midcom::get()->style->append_substyle($data['message_array']['substyle']);
@@ -120,7 +120,7 @@ 
     private function _real_show_compose(array $data)
     {
         $prefix = '';
-        if (   !empty($data['message_array']['substyle'])
+        if (!empty($data['message_array']['substyle'])
             && preg_match('/^builtin:(.*)/', $data['message_array']['substyle'], $matches_style)) {
             $prefix = $matches_style[1] . '-';
         }

lib/errors.php

Spacing +1 added lines, -1 removed lines

@@ -140,7 +140,7 @@
             return;
         }
 
-        if (   !is_writable($config['filename'])
+        if (!is_writable($config['filename'])
             && !is_writable(dirname($config['filename']))) {
             debug_add("Error logging file {$config['filename']} is not writable", MIDCOM_LOG_WARN);
             return;

lib/org/openpsa/relatedto/handler/relatedto.php

Spacing +1 added lines, -1 removed lines

@@ -199,7 +199,7 @@
     private function _render_line(array $link, midcom_core_dbaobject &$other_obj)
     {
         $this->_request_data['link'] = $link;
-        $this->_request_data['other_obj'] =& $other_obj;
+        $this->_request_data['other_obj'] = & $other_obj;
         $this->_request_data['icon'] = midcom_helper_reflector::get_object_icon($other_obj);
 
         if (get_class($other_obj) != $link['class']) {

lib/net/nehmer/blog/handler/archive.php

Spacing +4 added lines, -4 removed lines

@@ -131,8 +131,8 @@ 
         $year_data = [];
         $first_post = $this->_compute_welcome_first_post();
         $this->_request_data['first_post'] = $first_post;
-        $this->_request_data['total_count'] =& $total_count;
-        $this->_request_data['year_data'] =& $year_data;
+        $this->_request_data['total_count'] = & $total_count;
+        $this->_request_data['year_data'] = & $year_data;
         if (!$first_post) {
             return;
         }
@@ -261,7 +261,7 @@ 
         switch ($handler_id) {
             case 'archive-year-category':
                 $category = trim(strip_tags($args[1]));
-                if (   $data['datamanager']->get_schema('default')->has_field('categories')
+                if ($data['datamanager']->get_schema('default')->has_field('categories')
                     && !$data['datamanager']->get_schema('default')->get_field('categories')['type_config']['allow_multiple']) {
                     $qb->add_constraint('extra1', '=', $category);
                 } else {
@@ -345,7 +345,7 @@ 
             throw new midcom_error_notfound("The year '{$year}' is not valid.");
         }
 
-        if (   $month < 1
+        if ($month < 1
             || $month > 12) {
             throw new midcom_error_notfound("The month {$month} is not valid.");
         }

lib/org/openpsa/user/validator.php

Spacing +3 added lines, -3 removed lines

@@ -47,7 +47,7 @@ 
         $result = $this->is_username_available($fields);
 
         $accounthelper = new org_openpsa_user_accounthelper();
-        if ($fields['password']['switch'] && !$accounthelper->check_password_strength($fields['password']['password'])){
+        if ($fields['password']['switch'] && !$accounthelper->check_password_strength($fields['password']['password'])) {
             $result = ['password' => midcom::get()->i18n->get_string('password weak', 'org.openpsa.user')];
         }
 
@@ -149,10 +149,10 @@ 
         $user = new midcom_db_person($fields["person"]);
 
         $accounthelper = new org_openpsa_user_accounthelper($user);
-        if (!$accounthelper->check_password_reuse($fields['new_password'])){
+        if (!$accounthelper->check_password_reuse($fields['new_password'])) {
             $result['password'] = midcom::get()->i18n->get_string('password was already used', 'org.openpsa.user');
         }
-        if (!$accounthelper->check_password_strength($fields['new_password'])){
+        if (!$accounthelper->check_password_strength($fields['new_password'])) {
             $result['password'] = midcom::get()->i18n->get_string('password weak', 'org.openpsa.user');
         }
         return $result ?: true;