Passed
Push — master ( 3d7bf1...5b7834 )
by Andreas
19:51
created
src/midcom/datamanager/template/plaintext.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@
 block discarded – undo
17 17
 
18 18
     public function form_widget_simple(FormView $view, array $data)
19 19
     {
20
-        if (   !empty($data['value'])
20
+        if (!empty($data['value'])
21 21
             || is_numeric($data['value'])) {
22 22
             return $data['value'];
23 23
         }
Please login to merge, or discard this patch.
src/midcom/datamanager/template/view.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -143,7 +143,7 @@
 block discarded – undo
143 143
 
144 144
     public function form_widget_simple(FormView $view, array $data)
145 145
     {
146
-        if (   !empty($data['value'])
146
+        if (!empty($data['value'])
147 147
             || is_numeric($data['value'])) {
148 148
             return $this->escape($data['value']);
149 149
         }
Please login to merge, or discard this patch.
lib/midcom/helper/toolbar/node.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
         }
58 58
         $buttons = [];
59 59
         $workflow = new midcom\workflow\datamanager;
60
-        if (   $this->topic->can_do('midgard:update')
60
+        if ($this->topic->can_do('midgard:update')
61 61
             && $this->topic->can_do('midcom.admin.folder:topic_management')) {
62 62
             $buttons[] = $workflow->get_button("__ais/folder/edit/", [
63 63
                 MIDCOM_TOOLBAR_LABEL => midcom::get()->i18n->get_string('edit folder', 'midcom.admin.folder'),
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
             ];
92 92
         }
93 93
         $buttons = array_merge($buttons, $this->get_approval_controls($this->topic, false));
94
-        if (   $this->topic->can_do('midcom.admin.folder:template_management')
94
+        if ($this->topic->can_do('midcom.admin.folder:template_management')
95 95
             && midcom::get()->auth->can_user_do('midgard.admin.asgard:manage_objects', null, 'midgard_admin_asgard_plugin')) {
96 96
             $enabled = false;
97 97
             $styleeditor_url = '';
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
                     MIDCOM_TOOLBAR_ACCESSKEY => 'f',
125 125
                 ]);
126 126
             }
127
-            if (   $this->topic->guid !== midcom::get()->config->get('midcom_root_topic_guid')
127
+            if ($this->topic->guid !== midcom::get()->config->get('midcom_root_topic_guid')
128 128
                 && $this->topic->can_do('midgard:delete')) {
129 129
                 $workflow = new midcom\workflow\delete(['object' => $this->topic, 'recursive' => true]);
130 130
                 $buttons[] = $workflow->get_button("__ais/folder/delete/", [
Please login to merge, or discard this patch.
lib/org/openpsa/directmarketing/sender/backend/email.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -166,7 +166,7 @@
 block discarded – undo
166 166
         $address = addslashes($address);
167 167
         return preg_replace_callback(
168 168
             '/href="(http:\/\/.*?)"/i',
169
-            function ($match) use ($address) {
169
+            function($match) use ($address) {
170 170
                 return 'href="' . str_replace("URL", rawurlencode($match[1]), $address) . '"';
171 171
             },
172 172
             $html);
Please login to merge, or discard this patch.
lib/org/openpsa/sales/salesproject/deliverable.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
     {
82 82
         $this->calculate_price(false);
83 83
 
84
-        if (   $this->orgOpenpsaObtype == org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
84
+        if ($this->orgOpenpsaObtype == org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
85 85
             && $this->continuous) {
86 86
             $this->end = 0;
87 87
         } elseif ($this->end < $this->start) {
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
         $calculator->run($this);
170 170
         $cost = $calculator->get_cost();
171 171
         $price = $calculator->get_price();
172
-        if (   $price != $this->price
172
+        if ($price != $this->price
173 173
             || $cost != $this->cost) {
174 174
             $this->price = $price;
175 175
             $this->cost = $cost;
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
         $units = $agreement_hours['invoiceable'];
217 217
         $uninvoiceableUnits = $agreement_hours['reported'] - ($agreement_hours['invoiceable'] + $agreement_hours['invoiced']);
218 218
 
219
-        if (   $units != $this->units
219
+        if ($units != $this->units
220 220
             || $uninvoiceableUnits != $this->uninvoiceableUnits) {
221 221
             debug_add("agreement values have changed, setting units to " . $units . ", uninvoiceable: " . $uninvoiceableUnits);
222 222
             $this->units = $units;
@@ -270,7 +270,7 @@  discard block
 block discarded – undo
270 270
 
271 271
     public function invoice() : bool
272 272
     {
273
-        if (   $this->state >= self::STATE_INVOICED
273
+        if ($this->state >= self::STATE_INVOICED
274 274
             || $this->orgOpenpsaObtype == org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION) {
275 275
             return false;
276 276
         }
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/plugin.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
 
165 165
         $parent = $object->get_parent();
166 166
 
167
-        if (   is_a($object, midcom_db_parameter::class)
167
+        if (is_a($object, midcom_db_parameter::class)
168 168
             && !empty($parent->guid)) {
169 169
             // Add "parameters" list to breadcrumb if we're in a param
170 170
             $breadcrumb[] = [
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
174 174
         }
175 175
 
176 176
         $i = 0;
177
-        while (   !empty($parent->guid)
177
+        while (!empty($parent->guid)
178 178
                && $i < 10) {
179 179
             $i++;
180 180
             $parent_reflector = midcom_helper_reflector::get($parent);
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/schemadb.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
 
65 65
     protected function add_string_field(string $key, string $type)
66 66
     {
67
-        if (   $key == 'component'
67
+        if ($key == 'component'
68 68
             && $type == midcom_db_topic::class) {
69 69
             $this->_add_component_dropdown($key);
70 70
             return;
@@ -134,12 +134,12 @@  discard block
 block discarded – undo
134 134
         parent::add_longtext_field($key);
135 135
 
136 136
         // Check the user preference and configuration
137
-        if (   in_array($key, ['content', 'description'])
137
+        if (in_array($key, ['content', 'description'])
138 138
             && midgard_admin_asgard_plugin::get_preference('tinymce_enabled')) {
139 139
             $this->schema['fields'][$key]['widget'] = 'tinymce';
140 140
         }
141 141
 
142
-        if (   in_array($key, ['value', 'code'])
142
+        if (in_array($key, ['value', 'code'])
143 143
             && midgard_admin_asgard_plugin::get_preference('codemirror_enabled')) {
144 144
             $this->schema['fields'][$key]['widget'] = 'codemirror';
145 145
         }
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
         if ($score1 > $score2) {
258 258
             return 1;
259 259
         }
260
-        if (   $score1 < 3
260
+        if ($score1 < 3
261 261
             || $score1 > 6) {
262 262
             return strnatcmp($first, $second);
263 263
         }
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/handler/component/configuration.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -277,7 +277,7 @@  discard block
 block discarded – undo
277 277
     {
278 278
         $success = true;
279 279
         foreach ($this->_request_data['config']->_global as $global_key => $global_value) {
280
-            if (   isset($config[$global_key])
280
+            if (isset($config[$global_key])
281 281
                 && $config[$global_key] != $global_value) {
282 282
                 continue;
283 283
                 // Skip the ones we will set next
@@ -290,7 +290,7 @@  discard block
 block discarded – undo
290 290
         }
291 291
 
292 292
         foreach ($config as $key => $value) {
293
-            if (   is_array($value)
293
+            if (is_array($value)
294 294
                 || is_object($value)) {
295 295
                 /**
296 296
                  * See http://trac.midgard-project.org/ticket/1442
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/schemadb/config.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -61,11 +61,11 @@
 block discarded – undo
61 61
                 $fields[$key] = $this->detect_schema($key, $value);
62 62
             }
63 63
 
64
-            if (   !isset($this->config->_local[$key])
64
+            if (!isset($this->config->_local[$key])
65 65
                 || $this->config->_local[$key] == $this->config->_global[$key]) {
66 66
                 // No local configuration setting, note to user that this is the global value
67 67
                 $fields[$key]['title'] = $schema->get_l10n()->get($fields[$key]['title']);
68
-                $fields[$key]['title'] .= " <span class=\"global\">(" . midcom::get()->i18n->get_string('global value', 'midgard.admin.asgard') .")</span>";
68
+                $fields[$key]['title'] .= " <span class=\"global\">(" . midcom::get()->i18n->get_string('global value', 'midgard.admin.asgard') . ")</span>";
69 69
             }
70 70
         }
71 71
 
Please login to merge, or discard this patch.