flack / openpsa

lib/org/openpsa/reports/handler/projects/report.php

Spacing +3 added lines, -3 removed lines

@@ -44,7 +44,7 @@ 
         $qb_hr = org_openpsa_projects_hour_report_dba::new_query_builder();
         $qb_hr->add_constraint('date', '<=', (int) $this->_request_data['query_data']['end']);
         $qb_hr->add_constraint('date', '>=', (int) $this->_request_data['query_data']['start']);
-        if (   array_key_exists('invoiceable_filter', $this->_request_data['query_data'])
+        if (array_key_exists('invoiceable_filter', $this->_request_data['query_data'])
             && $this->_request_data['query_data']['invoiceable_filter'] != -1) {
             $qb_hr->add_constraint('invoiceable', '=', (bool) $this->_request_data['query_data']['invoiceable_filter']);
         }
@@ -60,7 +60,7 @@ 
             $tasks = $this->_expand_task($this->_request_data['query_data']['task']);
             $qb_hr->add_constraint('task', 'IN', $tasks);
         }
-        if (   array_key_exists('hour_type_filter', $this->_request_data['query_data'])
+        if (array_key_exists('hour_type_filter', $this->_request_data['query_data'])
             && $this->_request_data['query_data']['hour_type_filter'] != 'builtin:all') {
             $qb_hr->add_constraint('reportType', '=', $this->_request_data['query_data']['hour_type_filter']);
         }
@@ -151,7 +151,7 @@ 
 
     private function add_to_group($new_row, $matching, $sort, $title)
     {
-        $rows =& $this->_request_data['report']['rows'];
+        $rows = & $this->_request_data['report']['rows'];
         if (array_key_exists($matching, $rows)) {
             $rows[$matching]['rows'][] = $new_row;
             $rows[$matching]['total_hours'] += $new_row['hour']->hours;

Braces +2 added lines, -1 removed lines

@@ -123,7 +123,8 @@
             $row = array();
             try {
                 $row['person'] = org_openpsa_contacts_person_dba::get_cached($hour->person);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
                 continue;
             }

lib/org/openpsa/sales/calculator/default.php

Spacing +1 added lines, -1 removed lines

@@ -59,7 +59,7 @@
 
     private function get_units()
     {
-        if (   $this->_deliverable->invoiceByActualUnits
+        if ($this->_deliverable->invoiceByActualUnits
             || $this->_deliverable->plannedUnits == 0) {
             // In most cases we calculate the price based on the actual units entered
             return $this->_deliverable->units;

lib/org/openpsa/widgets/contact.php

Spacing +8 added lines, -8 removed lines

@@ -132,7 +132,7 @@ 
      */
     function read_object($person)
     {
-        if (   !is_object($person)
+        if (!is_object($person)
             || !midcom::get()->dbfactory->is_a($person, 'midcom_db_person')) {
             // Given $person is not one
             return false;
@@ -156,12 +156,12 @@ 
             }
         }
 
-        if (   $this->_config->get('jabber_enable_presence')
+        if ($this->_config->get('jabber_enable_presence')
             && $person->get_parameter('org.openpsa.jabber', 'jid')) {
             $this->contact_details['jid'] = $person->get_parameter('org.openpsa.jabber', 'jid');
         }
 
-        if (   $this->_config->get('skype_enable_presence')
+        if ($this->_config->get('skype_enable_presence')
             && $person->get_parameter('org.openpsa.skype', 'name')) {
             $this->contact_details['skype'] = $person->get_parameter('org.openpsa.skype', 'name');
         }
@@ -236,7 +236,7 @@ 
 
         // Show picture
         // TODO: Implement photo also in local way
-        if (   $this->_config->get('gravatar_enable')
+        if ($this->_config->get('gravatar_enable')
             && !empty($this->contact_details['email'])) {
             $size = $this->_config->get('gravatar_size');
             $gravatar_url = "http://www.gravatar.com/avatar.php?gravatar_id=" . md5($this->contact_details['email']) . "&size=" . $size;
@@ -315,7 +315,7 @@ 
 
     private function _show_groups()
     {
-        if (   !$this->show_groups
+        if (!$this->show_groups
             || empty($this->contact_details['id'])) {
             return;
         }
@@ -381,7 +381,7 @@ 
                     $cards_to_show[] = $cardname;
                 }
             } else {
-                if (    $customer->$property
+                if ($customer->$property
                     || ($customer->street && !$inherited_cards_only && !$default_shown)) {
                     $inherited_cards_only = false;
                     $multiple_addresses = true;
@@ -403,8 +403,8 @@ 
 
         foreach ($cards_to_show as $cardname) {
             echo '<div class="vcard">';
-            if (   $multiple_addresses
-                || (   $cardname != 'visiting'
+            if ($multiple_addresses
+                || ($cardname != 'visiting'
                     && !$inherited_cards_only)) {
                 echo '<div style="text-align:center"><em>' . midcom::get()->i18n->get_string($cardname . ' address', 'org.openpsa.contacts') . "</em></div>\n";
             }

Braces +4 added lines, -2 removed lines

@@ -114,7 +114,8 @@ 
 
         try {
             $person = org_openpsa_contacts_person_dba::get_cached($src);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $widget = new self();
             $cache[$src] = $widget;
             return $widget;
@@ -323,7 +324,8 @@ 
         foreach ($memberships as $data) {
             try {
                 $group = org_openpsa_contacts_group_dba::get_cached($data['gid']);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
                 continue;
             }

lib/org/openpsa/user/handler/person/account.php

Spacing +2 added lines, -2 removed lines

@@ -55,7 +55,7 @@ 
         $workflow = $this->get_workflow('datamanager2', array('controller' => $data['controller']));
         $response = $workflow->run();
 
-        if (   $workflow->get_state() == 'save'
+        if ($workflow->get_state() == 'save'
             && $this->_master->create_account($this->person, $data["controller"]->formmanager)) {
             midcom::get()->uimessages->add($this->_l10n->get('org.openpsa.user'), sprintf($this->_l10n->get('person %s created'), $this->person->name));
         }
@@ -154,7 +154,7 @@ 
         $accounthelper = new org_openpsa_user_accounthelper($this->person);
 
         // Update account
-        if (   !$accounthelper->set_account($formmanager->get_value("username"), $password)
+        if (!$accounthelper->set_account($formmanager->get_value("username"), $password)
             && midcom_connection::get_error() != MGD_ERR_OK) {
             // Failure, give a message
             midcom::get()->uimessages->add($this->_l10n->get('org.openpsa.user'), $this->_l10n->get("failed to update the user account, reason") . ': ' . midcom_connection::get_error_string(), 'error');

lib/org/openpsa/invoices/invoice/pdf.php

Spacing +2 added lines, -2 removed lines

@@ -87,7 +87,7 @@ 
         $filename = $generator->from_string($this->invoice->get_label()) . '.pdf';
 
         // tmp filename
-        $tmp_file = midcom::get()->config->get('midcom_tempdir') . "/". $filename;
+        $tmp_file = midcom::get()->config->get('midcom_tempdir') . "/" . $filename;
 
         // render pdf to tmp filename
         $pdf_builder->render($tmp_file);
@@ -100,7 +100,7 @@ 
             $attachment->update();
         } else {
             $attachment = $this->invoice->create_attachment($filename, $this->invoice->get_label(), "application/pdf");
-            if (   !$attachment
+            if (!$attachment
                 || !$this->invoice->set_parameter("midcom.helper.datamanager2.type.blobs", "guids_pdf_file", $attachment->guid . ":" . $attachment->guid)) {
                 throw new midcom_error("Failed to create invoice attachment for pdf");
             }

lib/org/openpsa/products/handler/product/view.php

Spacing +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
 
         if (midcom::get()->config->get('enable_ajax_editing')) {
             $data['controller'] = midcom_helper_datamanager2_controller::create('ajax');
-            $data['controller']->schemadb =& $data['schemadb_product'];
+            $data['controller']->schemadb = & $data['schemadb_product'];
             $data['controller']->set_storage($this->_product);
             $data['controller']->process_ajax();
             $data['datamanager'] = $data['controller']->datamanager;

Braces +2 added lines, -1 removed lines

@@ -85,7 +85,8 @@
                 $productgroup = new org_openpsa_products_product_group_dba($this->_product->productGroup);
                 $title = str_replace('<PRODUCTGROUP_TITLE>', $productgroup->title, $title);
                 $title = str_replace('<PRODUCTGROUP_CODE>', $productgroup->code, $title);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $title = str_replace(array('<PRODUCTGROUP_TITLE>', '<PRODUCTGROUP_CODE>'), '', $title);
             }
         }

lib/org/openpsa/user/accounthelper.php

Spacing +5 added lines, -5 removed lines

@@ -146,7 +146,7 @@ 
             $new_password_encrypted = midcom_connection::prepare_password($new_password);
 
             //check if the new encrypted password was already used
-            if (    $this->check_password_reuse($new_password_encrypted)
+            if ($this->check_password_reuse($new_password_encrypted)
                  && $this->check_password_strength($new_password)) {
                 $this->_save_old_password();
                 $account->set_password($new_password);
@@ -336,7 +336,7 @@ 
         for ($i = 0; $i < strlen($password); $i++) {
             $repeated = true;
             for ($j = 0; $j < $plen && ($j + $i + $plen) < strlen($password); $j++) {
-                if (   (substr($password, $j + $i, 1) == substr($password, $j + $i + $plen, 1))
+                if ((substr($password, $j + $i, 1) == substr($password, $j + $i + $plen, 1))
                     && $repeated) {
                     $repeated = true;
                 } else {
@@ -478,7 +478,7 @@ 
 
     public static function get_person_by_formdata($data)
     {
-        if (   empty($data['username'])
+        if (empty($data['username'])
             || empty($data['password'])) {
             return false;
         }
@@ -512,7 +512,7 @@ 
         $max_attempts = midcom_baseclasses_components_configuration::get($component, 'config')->get('max_password_attempts');
         $timeframe = midcom_baseclasses_components_configuration::get($component, 'config')->get('password_block_timeframe_min');
 
-        if (   $max_attempts == 0
+        if ($max_attempts == 0
             || $timeframe == 0) {
             return $stat;
         }
@@ -534,7 +534,7 @@ 
          * If the maximum number of attemps is reached and the oldest attempt
          * on the stack is within our defined timeframe, we block the account
          */
-        if (   count($attempts) >= $max_attempts
+        if (count($attempts) >= $max_attempts
             && $attempts[$max_attempts - 1] >= (time() - ($timeframe * 60))) {
             $this->disable_account();
             $stat = false;

lib/org/openpsa/relatedto/handler/journal/list.php

Spacing +3 added lines, -3 removed lines

@@ -121,7 +121,7 @@ 
                 }
 
                 $reflector = midcom_helper_reflector::get($linked_object);
-                $link_html = "<a href='" . midcom::get()->permalinks->create_permalink($linked_object->guid) . "'>" . $reflector->get_object_label($linked_object) ."</a>";
+                $link_html = "<a href='" . midcom::get()->permalinks->create_permalink($linked_object->guid) . "'>" . $reflector->get_object_label($linked_object) . "</a>";
                 $data['linked_objects'][$entry->linkGuid] = $link_html;
                 $data['linked_raw_objects'][$entry->linkGuid] = $reflector->get_object_label($linked_object);
             }
@@ -151,8 +151,8 @@ 
         //check if there is a page & rows - parameter passed - if add them to qb
         if (array_key_exists('page', $_POST) && array_key_exists('rows', $_POST)) {
             $this->_request_data['page'] = $_POST['page'];
-            $this->qb->set_limit((int)$_POST['rows']);
-            $offset = ((int)$_POST['page'] - 1) * (int)$_POST['rows'];
+            $this->qb->set_limit((int) $_POST['rows']);
+            $offset = ((int) $_POST['page'] - 1) * (int) $_POST['rows'];
             $this->qb->set_offset($offset);
         }
     }

Braces +2 added lines, -1 removed lines

@@ -171,7 +171,8 @@
                 //create reflector with linked object to get the right label
                 try {
                     $linked_object = midcom::get()->dbfactory->get_object_by_guid($entry->linkGuid);
-                } catch (midcom_error $e) {
+                }
+                catch (midcom_error $e) {
                     unset($data['entries'][$i]);
                     $e->log();
                     continue;

lib/midcom/cron/purgedeleted.php

Spacing +2 added lines, -2 removed lines

@@ -30,8 +30,8 @@
     {
         $classes = array();
         foreach (midcom_connection::get_schema_types() as $mgdschema) {
-            if (   substr($mgdschema, 0, 2) == '__'
-                || (   class_exists('midgard_reflector_object')
+            if (substr($mgdschema, 0, 2) == '__'
+                || (class_exists('midgard_reflector_object')
                     && !midgard_reflector_object::has_metadata_class($mgdschema))) {
                 continue;
             }