flack / openpsa

lib/net/nemein/tag/tag.php

Spacing +2 added lines, -2 removed lines

@@ -40,7 +40,7 @@ 
 
     public function _on_creating() : bool
     {
-        return (   $this->validate_tag($this->tag)
+        return ($this->validate_tag($this->tag)
                 && $this->_check_duplicates() == 0);
     }
 
@@ -69,7 +69,7 @@ 
 
     public function _on_updating() : bool
     {
-        return (   $this->validate_tag($this->tag)
+        return ($this->validate_tag($this->tag)
                 && $this->_check_duplicates() == 0);
     }
 

src/midcom/datamanager/storage/image.php

Spacing +1 added lines, -1 removed lines

@@ -56,7 +56,7 @@
             $this->save_attachment_list();
         }
 
-        if (   array_intersect_key(array_flip(['description', 'title', 'score']), $this->value)
+        if (array_intersect_key(array_flip(['description', 'title', 'score']), $this->value)
             && $main = $this->get_main()) {
             $needs_update = false;
             if (array_key_exists('description', $this->value)) {

lib/midcom/services/cache/module/content.php

Spacing +5 added lines, -5 removed lines

@@ -163,8 +163,8 @@ 
         $this->_uncached = $config->get('cache_module_content_uncached');
         $this->_headers_strategy = $this->get_strategy('cache_module_content_headers_strategy');
         $this->_headers_strategy_authenticated = $this->get_strategy('cache_module_content_headers_strategy_authenticated');
-        $this->_default_lifetime = (int)$config->get('cache_module_content_default_lifetime');
-        $this->_default_lifetime_authenticated = (int)$config->get('cache_module_content_default_lifetime_authenticated');
+        $this->_default_lifetime = (int) $config->get('cache_module_content_default_lifetime');
+        $this->_default_lifetime_authenticated = (int) $config->get('cache_module_content_default_lifetime_authenticated');
 
         if ($this->_headers_strategy == 'no-cache') {
             // we can't call no_cache() here, because it would try to call back to this class via the global getter
@@ -531,7 +531,7 @@ 
      */
     public function write_meta_cache(string $content_id, Request $request, Response $response)
     {
-        if (   $this->_uncached
+        if ($this->_uncached
             || $this->_no_cache) {
             return;
         }
@@ -593,7 +593,7 @@ 
 
     public function store_dl_content(int $context, string $dl_cache_data, Request $request)
     {
-        if (   $this->_no_cache
+        if ($this->_no_cache
             || $this->_uncached) {
             return;
         }
@@ -627,7 +627,7 @@ 
 
         /* TODO: Doublecheck the way this is handled, now we just don't send it
          * if headers_strategy implies caching */
-        if (   !$response->headers->has('Content-Length')
+        if (!$response->headers->has('Content-Length')
             && !in_array($this->_headers_strategy, ['public', 'private'])) {
             $response->headers->set("Content-Length", strlen($response->getContent()));
         }

lib/midcom/core/collector.php

Spacing +1 added lines, -1 removed lines

@@ -142,7 +142,7 @@
             if ($counter <= $this->_offset) {
                 continue;
             }
-            if (   $this->_limit
+            if ($this->_limit
                 && $counter > ($this->_offset + $this->_limit)) {
                 break;
             }

lib/midcom/exec/reindex.php

Spacing +2 added lines, -2 removed lines

@@ -47,7 +47,7 @@ 
 $reindex_topic_uri = midcom::get()->get_page_prefix() . 'midcom-exec-midcom/reindex_singlenode.php';
 
 $options = ['timeout' => 300];
-if (   !empty($_SERVER['PHP_AUTH_USER'])
+if (!empty($_SERVER['PHP_AUTH_USER'])
     && !empty($_SERVER['PHP_AUTH_PW'])) {
     $options['auth'] = ['user' => $_SERVER['PHP_AUTH_USER'], 'password' => $_SERVER['PHP_AUTH_PW']];
 }
@@ -65,7 +65,7 @@ 
             } else {
                 echo "OK.\n";
             }
-        }, function (TransferException $e) use ($uri) {
+        }, function(TransferException $e) use ($uri) {
             echo "failure.\n   Background processing failed, error: {$e->getMessage()}\n";
             echo "Url: " . $uri . "\n";
         })->wait();

lib/midcom/helper/reflector/tree.php

Spacing +1 added lines, -1 removed lines

@@ -79,7 +79,7 @@
     private static function _check_permissions(bool $deleted) : bool
     {
         // PONDER: Check for some generic user privilege instead  ??
-        if (   $deleted
+        if ($deleted
             && !midcom::get()->auth->admin
             && !midcom::get()->auth->is_component_sudo()) {
             debug_add('Non-admins are not allowed to list deleted objects', MIDCOM_LOG_ERROR);

lib/org/openpsa/user/handler/person/view.php

Spacing +2 added lines, -2 removed lines

@@ -25,7 +25,7 @@ 
         $this->add_breadcrumb('', $person->get_label());
 
         $auth = midcom::get()->auth;
-        if (   $person->guid == midcom::get()->auth->user->guid
+        if ($person->guid == midcom::get()->auth->user->guid
             || $auth->can_user_do('org.openpsa.user:manage', null, org_openpsa_user_interface::class)) {
             $buttons = [];
             $workflow = $this->get_workflow('datamanager');
@@ -38,7 +38,7 @@ 
                 $delete_workflow = $this->get_workflow('delete', ['object' => $person]);
                 $buttons[] = $delete_workflow->get_button($this->router->generate('user_delete', ['guid' => $person->guid]));
             }
-            if (   $data['account']->get_username()
+            if ($data['account']->get_username()
                 && $person->can_do('midgard:privileges')) {
                 $buttons[] = $workflow->get_button($this->router->generate('user_privileges', ['guid' => $person->guid]), [
                     MIDCOM_TOOLBAR_LABEL => $this->_l10n->get("permissions"),

lib/org/openpsa/relatedto/finder.php

Spacing +2 added lines, -2 removed lines

@@ -52,7 +52,7 @@ 
             }
         }
 
-        if (   empty($link->toComponent)
+        if (empty($link->toComponent)
             && !empty($link->fromComponent)) {
             debug_add("Setting property 'toComponent' to '{$component}'");
             $link->toComponent = $component;
@@ -61,7 +61,7 @@ 
             $link->fromComponent = $component;
         }
 
-        if (   empty($link->toGuid)
+        if (empty($link->toGuid)
             && !empty($link->fromGuid)) {
             $link->toClass = get_class($obj);
             $link->toGuid = $obj->guid;

lib/org/openpsa/sales/salesproject/deliverable.php

Spacing +5 added lines, -5 removed lines

@@ -78,7 +78,7 @@ 
     {
         $this->calculate_price(false);
 
-        if (   $this->orgOpenpsaObtype == org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
+        if ($this->orgOpenpsaObtype == org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
             && $this->continuous) {
             $this->end = 0;
         } elseif ($this->end < $this->start) {
@@ -166,7 +166,7 @@ 
         $calculator->run($this);
         $cost = $calculator->get_cost();
         $price = $calculator->get_price();
-        if (   $price != $this->price
+        if ($price != $this->price
             || $cost != $this->cost) {
             $this->price = $price;
             $this->cost = $cost;
@@ -206,7 +206,7 @@ 
         $units = $hours['invoiceable'];
         $uninvoiceableUnits = $hours['reported'] - ($hours['invoiceable'] + $hours['invoiced']);
 
-        if (   $units != $this->units
+        if ($units != $this->units
             || $uninvoiceableUnits != $this->uninvoiceableUnits) {
             debug_add("agreement values have changed, setting units to " . $units . ", uninvoiceable: " . $uninvoiceableUnits);
             $this->units = $units;
@@ -260,7 +260,7 @@ 
 
     public function invoice() : bool
     {
-        if (   $this->state >= self::STATE_INVOICED
+        if ($this->state >= self::STATE_INVOICED
             || $this->orgOpenpsaObtype == org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION) {
             return false;
         }
@@ -363,7 +363,7 @@ 
             midcom::get()->uimessages->add(midcom::get()->i18n->get_string('org.openpsa.sales', 'org.openpsa.sales'), sprintf(midcom::get()->i18n->get_string('marked deliverable "%s" delivered', 'org.openpsa.sales'), $this->title));
 
             // Check if we need to create task or ship goods
-            if (   $update_deliveries
+            if ($update_deliveries
                 && $product->orgOpenpsaObtype === org_openpsa_products_product_dba::TYPE_SERVICE) {
                 // Change status of tasks connected to the deliverable
                 $qb = org_openpsa_projects_task_dba::new_query_builder();