Passed
Push — master ( c19ae9...cb86bb )
by Andreas
18:22
created
lib/org/openpsa/relatedto/handler/journal/entry.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
     public function _handler_create(Request $request, string $guid)
34 34
     {
35 35
         $current_object = midcom::get()->dbfactory->get_object_by_guid($guid);
36
-        $entry= new org_openpsa_relatedto_journal_entry_dba();
36
+        $entry = new org_openpsa_relatedto_journal_entry_dba();
37 37
         $entry->linkGuid = $current_object->guid;
38 38
 
39 39
         midcom::get()->head->set_pagetitle($this->_l10n->get('add journal entry'));
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
         $workflow = $this->get_workflow('datamanager', ['controller' => $data['controller']]);
53 53
         if ($entry->can_do('midgard:delete')) {
54 54
             $delete = $this->get_workflow('delete', ['object' => $entry]);
55
-            $url = $this->router->generate('journal_entry_delete', ['guid' => $guid ]);
55
+            $url = $this->router->generate('journal_entry_delete', ['guid' => $guid]);
56 56
             $workflow->add_dialog_button($delete, $url);
57 57
         }
58 58
         return $workflow->run($request);
Please login to merge, or discard this patch.
src/midcom/datamanager/template/form.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
     public function form_end(FormView $view, array $data)
85 85
     {
86 86
         $string = '';
87
-        if (   !isset($data['render_rest'])
87
+        if (!isset($data['render_rest'])
88 88
             || $data['render_rest']) {
89 89
             $string .= $this->renderer->rest($view);
90 90
         }
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
             $data['attr']['class'] = 'shorttext';
224 224
         }
225 225
 
226
-        if (   !empty($data['value'])
226
+        if (!empty($data['value'])
227 227
             || is_numeric($data['value'])) {
228 228
             $data['attr']['value'] = $data['value'];
229 229
         }
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
     {
266 266
         if ($view->vars['readonly']) {
267 267
             $string = $this->get_view_renderer()->autocomplete_widget($view, $data);
268
-            return $string .  $this->renderer->widget($view['selection']);
268
+            return $string . $this->renderer->widget($view['selection']);
269 269
         }
270 270
 
271 271
         autocomplete::add_head_elements($data['handler_options']['creation_mode_enabled'], $data['handler_options']['sortable']);
@@ -275,7 +275,7 @@  discard block
 block discarded – undo
275 275
         $jsinit .= "midcom_helper_datamanager2_autocomplete.create_dm2_widget('{$element_id}_search_input', {$data['min_chars']});\n";
276 276
 
277 277
         $string = '<fieldset ' . $this->renderer->block($view, 'widget_container_attributes') . '>';
278
-        $string .=  $this->renderer->widget($view['selection']);
278
+        $string .= $this->renderer->widget($view['selection']);
279 279
         $string .= ' ' . $this->renderer->widget($view['search_input']);
280 280
         $string .= '</fieldset>';
281 281
         return $string . $this->jsinit($jsinit);
@@ -324,7 +324,7 @@  discard block
 block discarded – undo
324 324
         }
325 325
 
326 326
         $string = '<select ';
327
-        if (   $data['required']
327
+        if ($data['required']
328 328
             && null === $data['placeholder']
329 329
             && $data['placeholder_in_choices'] === false
330 330
             && $data['multiple'] === false) {
@@ -338,7 +338,7 @@  discard block
 block discarded – undo
338 338
         $string .= $this->renderer->block($view, 'widget_attributes', $data) . '>';
339 339
         if (null !== $data['placeholder']) {
340 340
             $string .= '<option value=""';
341
-            if (   $data['required']
341
+            if ($data['required']
342 342
                 && empty($data['value'])
343 343
                 && "0" !== $data['value']) {
344 344
                 $string .= ' selected="selected"';
@@ -500,7 +500,7 @@  discard block
 block discarded – undo
500 500
             $string .= '<label class="midcom_datamanager_photo_label">' . $this->renderer->humanize('delete photo') . ' ' . $this->renderer->widget($data['form']['delete']) . '</label>';
501 501
             $string .= '<ul>';
502 502
             foreach ($objects as $info) {
503
-                if (   $info['size_x']
503
+                if ($info['size_x']
504 504
                     && $info['size_y']) {
505 505
                     $size = "{$info['size_x']}&times;{$info['size_y']}";
506 506
                 } else {
@@ -525,7 +525,7 @@  discard block
 block discarded – undo
525 525
         $string .= '</td></tr></table></div>';
526 526
         $string .= $this->renderer->row($data['form']['identifier']);
527 527
 
528
-        return $string . $this->jsinit('init_image_widget("' . $view->vars['id'] .'");');
528
+        return $string . $this->jsinit('init_image_widget("' . $view->vars['id'] . '");');
529 529
     }
530 530
 
531 531
     public function subform_widget(FormView $view, array $data)
Please login to merge, or discard this patch.
lib/org/openpsa/user/style/show-person-account.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@
 block discarded – undo
23 23
             echo '<span class="toolbar_label">' . $data['l10n_midcom']->get('delete') . '</span></a></li>';
24 24
             if (    midcom::get()->config->get('auth_allow_trusted') === true
25 25
                  && $data['person']->can_do('org.openpsa.user:su')) {
26
-                 echo '<li><a class="button" href="' . $data['router']->generate('account_su', ['guid' => $data['person']->guid]) . '">' . $data['l10n']->get('switch to user') . "</a></li>\n";
26
+                    echo '<li><a class="button" href="' . $data['router']->generate('account_su', ['guid' => $data['person']->guid]) . '">' . $data['l10n']->get('switch to user') . "</a></li>\n";
27 27
             }
28 28
             echo "</ul>\n";
29 29
         }
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -11,7 +11,7 @@  discard block
 block discarded – undo
11 11
             echo '<p>' . $data['l10n']->get('last login') . ': ' . $formatter->datetime($lastlogin) . "</p>\n";
12 12
         }
13 13
 
14
-        if (   $data['person']->guid == midcom::get()->auth->user->guid
14
+        if ($data['person']->guid == midcom::get()->auth->user->guid
15 15
             || midcom::get()->auth->can_user_do('org.openpsa.user:manage', null, org_openpsa_user_interface::class)) {
16 16
             $workflow = new midcom\workflow\datamanager;
17 17
             echo '<ul class="area_toolbar">';
@@ -20,9 +20,9 @@  discard block
 block discarded – undo
20 20
                 'object' => $data['person'],
21 21
                 'label' => $data['l10n']->get('account')
22 22
             ]);
23
-            echo '<li><a href="' . $data['router']->generate('account_delete', ['guid' => $data['person']->guid]). '" ' . $workflow->render_attributes() . '"  class="button">';
23
+            echo '<li><a href="' . $data['router']->generate('account_delete', ['guid' => $data['person']->guid]) . '" ' . $workflow->render_attributes() . '"  class="button">';
24 24
             echo '<span class="toolbar_label">' . $data['l10n_midcom']->get('delete') . '</span></a></li>';
25
-            if (    midcom::get()->config->get('auth_allow_trusted') === true
25
+            if (midcom::get()->config->get('auth_allow_trusted') === true
26 26
                  && $data['person']->can_do('org.openpsa.user:su')) {
27 27
                  echo '<li><a class="button" href="' . $data['router']->generate('account_su', ['guid' => $data['person']->guid]) . '">' . $data['l10n']->get('switch to user') . "</a></li>\n";
28 28
             }
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
         }
31 31
     } else {
32 32
         echo '<p><span class="metadata">' . $data['l10n']->get("no account") . '</span></p>';
33
-        if (   $data['person']->guid == midcom::get()->auth->user->guid
33
+        if ($data['person']->guid == midcom::get()->auth->user->guid
34 34
             || midcom::get()->auth->can_user_do('org.openpsa.user:manage', null, org_openpsa_user_interface::class)) {
35 35
             $workflow = new midcom\workflow\datamanager;
36 36
             echo '<ul class="area_toolbar">';
Please login to merge, or discard this patch.
src/midcom/datamanager/extension/type/tinymceType.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -34,11 +34,11 @@
 block discarded – undo
34 34
      */
35 35
     public function configureOptions(OptionsResolver $resolver)
36 36
     {
37
-        $resolver->setDefault('config', function (Options $options) {
37
+        $resolver->setDefault('config', function(Options $options) {
38 38
             return \midcom_baseclasses_components_configuration::get('midcom.datamanager', 'config');
39 39
         });
40 40
 
41
-        $resolver->setNormalizer('widget_config', function (Options $options, $value) {
41
+        $resolver->setNormalizer('widget_config', function(Options $options, $value) {
42 42
             $widget_defaults = [
43 43
                 'height' => 25,
44 44
                 'width' => 80,
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/navigation.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
         $this->_component = 'midgard.admin.asgard';
42 42
 
43 43
         $this->_object = $object;
44
-        $this->_request_data =& $request_data;
44
+        $this->_request_data = & $request_data;
45 45
 
46 46
         $this->root_types = midcom_helper_reflector_tree::get_root_classes();
47 47
 
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
             // we go through the path bottom up and show the first root type we find
58 58
             foreach (array_reverse($this->_object_path) as $node) {
59 59
                 foreach ($this->root_types as $root_type) {
60
-                    if (   is_a($node, $root_type)
60
+                    if (is_a($node, $root_type)
61 61
                         || midcom_helper_reflector::is_same_class($root_type, $node->__midcom_class_name__)) {
62 62
                         $this->expanded_root_types[] = $root_type;
63 63
                         break;
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
 
70 70
     protected function _is_collapsed(string $type, int $total) : bool
71 71
     {
72
-        return (   $total > $this->_config->get('max_navigation_entries')
72
+        return ($total > $this->_config->get('max_navigation_entries')
73 73
                 && empty($_GET['show_all_' . $type]));
74 74
     }
75 75
 
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
         foreach ($ref->get_child_classes() as $class) {
86 86
             $qb = $ref->_child_objects_type_qb($class, $object, false);
87 87
 
88
-            if (   !$qb
88
+            if (!$qb
89 89
                 || !($count = $qb->count_unchecked())) {
90 90
                 continue;
91 91
             }
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
     {
132 132
         $qb = $ref->_root_objects_qb();
133 133
 
134
-        if (   !$qb
134
+        if (!$qb
135 135
             || !($total = $qb->count_unchecked())) {
136 136
             return;
137 137
         }
@@ -209,7 +209,7 @@  discard block
 block discarded – undo
209 209
         }
210 210
 
211 211
         echo "<a href=\"" . midcom_connection::get_url('self') . "__mfa/asgard/object/{$mode}/{$object->guid}/\" title=\"GUID: {$object->guid}, ID: {$object->id}\">{$icon}{$label}</a>\n";
212
-        if (   $selected
212
+        if ($selected
213 213
             || $autoexpand) {
214 214
             $this->_list_child_elements($object, $level + 1);
215 215
         }
@@ -229,7 +229,7 @@  discard block
 block discarded – undo
229 229
                 continue;
230 230
             }
231 231
 
232
-            if (   method_exists($class, 'navigation')
232
+            if (method_exists($class, 'navigation')
233 233
                 && ($this->_request_data['plugin_name'] == "asgard_{$component}")) {
234 234
                 $this->_request_data['expanded'] = true;
235 235
                 midcom_show_style('midgard_admin_asgard_navigation_section_header');
@@ -263,13 +263,13 @@  discard block
 block discarded – undo
263 263
         if ($this->_is_selected($object)) {
264 264
             $css_class .= ' selected';
265 265
         }
266
-        if (   is_object($this->_object)
267
-            && (   $object->guid == $this->_object->guid
268
-                || (   is_a($this->_object, midcom_db_parameter::class)
266
+        if (is_object($this->_object)
267
+            && ($object->guid == $this->_object->guid
268
+                || (is_a($this->_object, midcom_db_parameter::class)
269 269
                     && $object->guid == $this->_object->parentguid))) {
270 270
             $css_class .= ' current';
271 271
         }
272
-        if ( !$object->can_do('midgard:update')) {
272
+        if (!$object->can_do('midgard:update')) {
273 273
             $css_class .= ' readonly';
274 274
         }
275 275
         return $css_class;
@@ -312,7 +312,7 @@  discard block
 block discarded – undo
312 312
 
313 313
         // If the regular expression has been set, check which types should be shown
314 314
         if ($regexp !== '//') {
315
-            $label_mapping = array_filter($label_mapping, function ($root_type) use ($regexp, $exclude) {
315
+            $label_mapping = array_filter($label_mapping, function($root_type) use ($regexp, $exclude) {
316 316
                 return preg_match($regexp, $root_type) == $exclude;
317 317
             }, ARRAY_FILTER_USE_KEY);
318 318
         }
@@ -342,7 +342,7 @@  discard block
 block discarded – undo
342 342
          * click if nothing is expanded
343 343
          */
344 344
         $types_shown = false;
345
-        if (    !empty($expanded_types)
345
+        if (!empty($expanded_types)
346 346
              && midgard_admin_asgard_plugin::get_preference('navigation_type') === 'dropdown') {
347 347
             $this->_draw_select_navigation();
348 348
             $types_shown = true;
Please login to merge, or discard this patch.
lib/org/openpsa/mail/main.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@
 block discarded – undo
39 39
  */
40 40
 class org_openpsa_mail
41 41
 {
42
-    use midcom_baseclasses_components_base {__get as base__get;}
42
+    use midcom_baseclasses_components_base {__get as base__get; }
43 43
 
44 44
     /**
45 45
      * Text body
Please login to merge, or discard this patch.
lib/net/nehmer/blog/handler.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@  discard block
 block discarded – undo
15 15
 {
16 16
     public function get_url(midcom_db_article $article, bool $allow_external = false) : string
17 17
     {
18
-        if (   $allow_external
18
+        if ($allow_external
19 19
             && $this->_config->get('link_to_external_url')
20 20
             && !empty($article->url)) {
21 21
             return $article->url;
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
 
68 68
         $qb->add_constraint('topic.guid', 'IN', $topic_guids);
69 69
 
70
-        if (   count($topic_guids) > 1
70
+        if (count($topic_guids) > 1
71 71
             && $list_from_folders_categories = $this->_config->get('list_from_folders_categories')) {
72 72
             $list_from_folders_categories = explode(',', $list_from_folders_categories);
73 73
 
Please login to merge, or discard this patch.
lib/net/nemein/tag/handler.php 1 patch
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -381,7 +381,8 @@  discard block
 block discarded – undo
381 381
             try {
382 382
                 $tag = net_nemein_tag_tag_dba::get_cached($link->tag);
383 383
                 $link_object_map[$link->fromGuid][$tag->tag] = $link;
384
-            } catch (midcom_error $e) {
384
+            }
385
+            catch (midcom_error $e) {
385 386
                 $e->log();
386 387
             }
387 388
         }
@@ -410,7 +411,8 @@  discard block
 block discarded – undo
410 411
                     $tmpobject = midcom::get()->dbfactory->convert_midgard_to_midcom($tmpobject);
411 412
                 }
412 413
                 $return[] = $tmpobject;
413
-            } catch (midcom_error $e) {
414
+            }
415
+            catch (midcom_error $e) {
414 416
                 $e->log();
415 417
             }
416 418
         }
Please login to merge, or discard this patch.
lib/net/nehmer/blog/navigation.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -64,14 +64,14 @@  discard block
 block discarded – undo
64 64
 
65 65
     private function _add_pseudo_leaves(array &$leaves)
66 66
     {
67
-        if (   $this->_config->get('archive_enable')
67
+        if ($this->_config->get('archive_enable')
68 68
             && $this->_config->get('archive_in_navigation')) {
69 69
             $leaves["{$this->_topic->id}_ARCHIVE"] = [
70 70
                 MIDCOM_NAV_URL => "archive/",
71 71
                 MIDCOM_NAV_NAME => $this->_l10n->get('archive'),
72 72
             ];
73 73
         }
74
-        if (   $this->_config->get('rss_enable')
74
+        if ($this->_config->get('rss_enable')
75 75
             && $this->_config->get('feeds_in_navigation')) {
76 76
             $leaves[self::LEAFID_FEEDS] = [
77 77
                 MIDCOM_NAV_URL => "feeds/",
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
             ];
80 80
         }
81 81
 
82
-        if (   $this->_config->get('categories_in_navigation')
82
+        if ($this->_config->get('categories_in_navigation')
83 83
             && $this->_config->get('categories') != '') {
84 84
             $categories = explode(',', $this->_config->get('categories'));
85 85
             foreach ($categories as $category) {
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
             }
91 91
         }
92 92
 
93
-        if (   $this->_config->get('archive_years_in_navigation')
93
+        if ($this->_config->get('archive_years_in_navigation')
94 94
             && $this->_config->get('archive_years_enable')) {
95 95
             $qb = midcom_db_article::new_query_builder();
96 96
             $qb->add_constraint('topic', '=', $this->_topic->id);
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
      */
122 122
     public static function add_scheduling_constraints(midcom_core_querybuilder $qb, midcom_helper_configuration $config)
123 123
     {
124
-        if (   $config->get('enable_scheduled_publishing')
124
+        if ($config->get('enable_scheduled_publishing')
125 125
             && !midcom::get()->auth->admin) {
126 126
             // Show the article only if the publishing time has passed or the viewer
127 127
             // is the author
Please login to merge, or discard this patch.