flack / openpsa

lib/midgard/admin/user/style/midgard-admin-user-group-folders.php

Braces +2 added lines, -1 removed lines

@@ -17,7 +17,8 @@
         foreach ($data['objects'] as $guid => $privs) {
             try {
                 $object = new midcom_db_topic($guid);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 continue;
             }
             echo "<tr>\n";

lib/org/openpsa/calendar/event/member.php

Spacing +3 added lines, -3 removed lines

@@ -68,7 +68,7 @@ 
             $event = new org_openpsa_calendar_event_dba($this->eid);
         }
 
-        if (    $recipient->id == midcom_connection::get_user()
+        if ($recipient->id == midcom_connection::get_user()
              && !$event->send_notify_me) {
             //Do not send notification to current user
             debug_add('event->send_notify_me is false and recipient is current user, aborting notify');
@@ -194,7 +194,7 @@ 
 
             if (isset($events_by_date[$ymd])) {
                 foreach ($events_by_date[$ymd] as $event) {
-                    if (   $event->end <= $workday_starts_ts
+                    if ($event->end <= $workday_starts_ts
                         || $event->start >= $workday_ends_ts) {
                         // We need not consider this event, it is outside the defined workday
                         continue;
@@ -212,7 +212,7 @@ 
                 }
             }
             // End of day slot
-            if (   $last_end_time < $workday_ends_ts
+            if ($last_end_time < $workday_ends_ts
                 && (($workday_ends_ts - $last_end_time) >= $amount)) {
                 $slots[] = self::_create_slot($last_end_time, $workday_ends_ts, $last_event);
             }

Braces +2 added lines, -1 removed lines

@@ -143,7 +143,8 @@
                 debug_add('person #' . $person->id . 'has no email address, aborting');
                 return null;
             }
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             return null;
         }
 

lib/org/openpsa/invoices/handler/billingdata.php

Spacing +2 added lines, -2 removed lines

@@ -30,7 +30,7 @@ 
     private function load_controller(org_openpsa_invoices_billing_data_dba $bd) : controller
     {
         $schemadb = schemadb::from_path($this->_config->get('schemadb_billing_data'));
-        $vat =& $schemadb->get('default')->get_field('vat');
+        $vat = & $schemadb->get('default')->get_field('vat');
         // Fill VAT select
         if ($options = $this->get_vat_options($this->_config->get('vat_percentages'))) {
             $vat['type_config']['options'] = $options;
@@ -68,7 +68,7 @@ 
         $data['controller'] = $this->load_controller($bd);
 
         $workflow = $this->get_workflow('datamanager', ['controller' => $data['controller']]);
-        if (   $mode == 'edit'
+        if ($mode == 'edit'
             && $bd->can_do('midgard:delete')) {
             $delete = $this->get_workflow('delete', [
                 'object' => $bd,

lib/org/openpsa/products/midcom/interfaces.php

Braces +4 added lines, -2 removed lines

@@ -79,7 +79,8 @@ 
                 try {
                     $dms['group']->set_storage($group);
                     org_openpsa_products_viewer::index($dms['group'], $indexer, $topic, $config);
-                } catch (midcom_error $e) {
+                }
+                catch (midcom_error $e) {
                     $e->log(MIDCOM_LOG_WARN);
                 }
             }
@@ -91,7 +92,8 @@ 
                     try {
                         $dms['product']->set_storage($product);
                         org_openpsa_products_viewer::index($dms['product'], $indexer, $topic, $config);
-                    } catch (midcom_error $e) {
+                    }
+                    catch (midcom_error $e) {
                         $e->log(MIDCOM_LOG_WARN);
                     }
                 }

Spacing +1 added lines, -1 removed lines

@@ -52,7 +52,7 @@
      */
     public function _on_reindex($topic, midcom_helper_configuration $config, midcom_services_indexer $indexer)
     {
-        if (   !$config->get('index_products')
+        if (!$config->get('index_products')
             && !$config->get('index_groups')) {
             debug_add("No indexing to groups and products, skipping", MIDCOM_LOG_WARN);
             return true;

lib/org/openpsa/notifications/notifier/email.php

Spacing +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
             $mail->from = $config->get('default_sender') ?: '"OpenPSA Notifier" <noreply@' . $_SERVER['SERVER_NAME'] . '>';
         }
 
-        $mail->subject = $message['title'] ??  'org.openpsa.notifications message (no title provided)';
+        $mail->subject = $message['title'] ?? 'org.openpsa.notifications message (no title provided)';
         if (array_key_exists('attachments', $message)) {
             $mail->attachments = $message['attachments'];
         }

lib/org/openpsa/relatedto/handler/relatedto.php

Braces +6 added lines, -3 removed lines

@@ -116,7 +116,8 @@ 
             //TODO: check for duplicates ?
             try {
                 $result = ['other_obj' => midcom::get()->dbfactory->get_object_by_guid($link[$other . 'Guid'])];
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 continue;
             }
             $result['link'] = [
@@ -421,7 +422,8 @@ 
             if (!($this->_object instanceof org_openpsa_relatedto_dba)) {
                 $response->status = "method requires guid of a link object as an argument";
             }
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $response->status = "error: " . $e->getMessage();
         }
 
@@ -444,7 +446,8 @@ 
             $relation = new org_openpsa_relatedto_dba($guid);
             $response->result = $relation->delete();
             $response->status = 'Last message: ' . midcom_connection::get_error_string();
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $response->result = false;
             $response->status = "Object '{$guid}' could not be loaded, error:" . $e->getMessage();
         }

Spacing +1 added lines, -1 removed lines

@@ -199,7 +199,7 @@
     private function _render_line(array $link, midcom_core_dbaobject &$other_obj)
     {
         $this->_request_data['link'] = $link;
-        $this->_request_data['other_obj'] =& $other_obj;
+        $this->_request_data['other_obj'] = & $other_obj;
         $this->_request_data['icon'] = midcom_helper_reflector::get_object_icon($other_obj);
 
         if (get_class($other_obj) != $link['class']) {

lib/midcom/services/auth/frontend/form.php

Spacing +2 added lines, -2 removed lines

@@ -40,7 +40,7 @@ 
      */
     public function read_login_data(Request $request) : ?array
     {
-        if (   !$request->request->has('midcom_services_auth_frontend_form_submit')
+        if (!$request->request->has('midcom_services_auth_frontend_form_submit')
             || !$request->request->has('username')
             || !$request->request->has('password')) {
             return null;
@@ -76,7 +76,7 @@ 
     {
         // Store the submitted form if the session expired, but user wants to save the data
         if (!empty($_POST)) {
-            $data =& midcom_core_context::get()->get_custom_key('request_data');
+            $data = & midcom_core_context::get()->get_custom_key('request_data');
 
             $data['restored_form_data'] = [];
 

lib/org/openpsa/documents/midcom/interfaces.php

Spacing +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
 
     public function resolve_object_link(midcom_db_topic $topic, midcom_core_dbaobject $object) : ?string
     {
-        if (   $object instanceof org_openpsa_documents_document_dba
+        if ($object instanceof org_openpsa_documents_document_dba
             && $object->topic == $topic->id) {
             return "document/{$object->guid}/";
         }

lib/midgard/admin/asgard/style/midgard_admin_asgard_rcs_history.php

Spacing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
                 echo "                    <td>" . strftime('%x %X Z', $revision['date']) . "</td>\n";
                 echo "                    <td>";
 
-                if (   $revision['user']
+                if ($revision['user']
                     && $user = midcom::get()->auth->get_user($revision['user'])) {
                     echo $user->get_storage()->name;
                 } elseif ($revision['ip']) {