midcom_response_relocate::setTargetUrl() - Code Metrics - Inspection of "Small simplifications" - flack/openpsa - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( d0980f...d72487 )

by Andreas

created 2023-12-22 13:41 UTC

midcom_response_relocate::setTargetUrl() A

↳ Parent: midcom_response_relocate

Complexity

Conditions	4
Paths	2

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	4

Importance

Changes

Metric	Value
cc	4
eloc	6
c	0
b	0
f	0
nc	2
nop	1
dl	0
loc	9
ccs	7
cts	7
cp	1
crap	4
rs	10

<?php
/**
 * @package midcom
 * @author CONTENT CONTROL http://www.contentcontrol-berlin.de/
 * @copyright CONTENT CONTROL http://www.contentcontrol-berlin.de/
 * @license http://www.gnu.org/licenses/lgpl.html GNU Lesser General Public License
 */

use Symfony\Component\HttpFoundation\RedirectResponse;

/**
 * Wrapper for HTTP relocate responses
 *
 * @package midcom
 */
class midcom_response_relocate extends RedirectResponse
{
    /**
     * The helper actually can distinguish between site-local, absolute redirects and external
     * redirects. If the url does not start with http[s] or /, it is taken as a URL relative to
     * the current anchor prefix, which gets prepended automatically (no other characters
     * as the anchor prefix get inserted).
     *
     * Fully qualified urls are used as-is.
     *
     * {@inheritDoc}
     */
    public function setTargetUrl($url)
    {
        if (   !str_starts_with($url, "/")
            && !preg_match('|^https?://|', $url)) {
            $prefix = midcom_core_context::get()->get_key(MIDCOM_CONTEXT_ANCHORPREFIX) ?: '/';
            $url = $prefix . $url;
            debug_add("This is a relative URL from the local site, prepending anchor prefix: {$url}");
        }
        return parent::setTargetUrl($url);
    }

    public function send()
    {
        if (defined('OPENPSA2_UNITTEST_RUN')) {
            throw new openpsa_test_relocate($this->targetUrl, $this->getStatusCode());
filter:
    dependency_paths: ["lib/*"]
        }

        midcom::get()->cache->content->no_cache();
        debug_add("Relocating to {$this->targetUrl}");
        return parent::send();
    }
}


1		<?php
2		/**
3		* @package midcom
4		* @author CONTENT CONTROL http://www.contentcontrol-berlin.de/
5		* @copyright CONTENT CONTROL http://www.contentcontrol-berlin.de/
6		* @license http://www.gnu.org/licenses/lgpl.html GNU Lesser General Public License
7		*/
8
9		use Symfony\Component\HttpFoundation\RedirectResponse;
10
11		/**
12		* Wrapper for HTTP relocate responses
13		*
14		* @package midcom
15		*/
16		class midcom_response_relocate extends RedirectResponse
17		{
18		/**
19		* The helper actually can distinguish between site-local, absolute redirects and external
20		* redirects. If the url does not start with http[s] or /, it is taken as a URL relative to
21		* the current anchor prefix, which gets prepended automatically (no other characters
22		* as the anchor prefix get inserted).
23		*
24		* Fully qualified urls are used as-is.
25		*
26		* {@inheritDoc}
27		*/
28	56	public function setTargetUrl($url)
29		{
30	56	if ( !str_starts_with($url, "/")
31	56	&& !preg_match('\|^https?://\|', $url)) {
32	29	$prefix = midcom_core_context::get()->get_key(MIDCOM_CONTEXT_ANCHORPREFIX) ?: '/';
33	29	$url = $prefix . $url;
34	29	debug_add("This is a relative URL from the local site, prepending anchor prefix: {$url}");
35		}
36	56	return parent::setTargetUrl($url);
37		}
38
39		public function send()
40		{
41		if (defined('OPENPSA2_UNITTEST_RUN')) {
42		throw new openpsa_test_relocate($this->targetUrl, $this->getStatusCode());
		0 ignored issues – show Bug introduced 2022-06-29 14:40 UTC by Report Bug Copy Issue Report The type `openpsa_test_relocate` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
43		}
44
45		midcom::get()->cache->content->no_cache();
46		debug_add("Relocating to {$this->targetUrl}");
47		return parent::send();
48		}
49		}
50

flack / openpsa

Push — master ( d0980f...d72487 )

midcom_response_relocate::setTargetUrl() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like