flack / openpsa

lib/org/openpsa/invoices/invoice/item.php

Spacing +4 added lines, -4 removed lines

@@ -25,7 +25,7 @@ 
 
     public function _on_creating() : bool
     {
-        if (   $this->invoice
+        if ($this->invoice
             && $this->position == 0) {
             $invoice = org_openpsa_invoices_invoice_dba::get_cached($this->invoice);
             $this->position = count($invoice->get_invoice_items()) + 1;
@@ -75,7 +75,7 @@ 
             } catch (midcom_error) {
             }
         }
-        if (   $url == ''
+        if ($url == ''
             && $sales_url) {
             try {
                 $deliverable = org_openpsa_sales_salesproject_deliverable_dba::get_cached($this->deliverable);
@@ -97,7 +97,7 @@ 
                 $invoice = new org_openpsa_invoices_invoice_dba($this->invoice);
                 $old_sum = $invoice->sum;
                 self::update_invoice($invoice);
-                if (   $old_sum != $invoice->sum
+                if ($old_sum != $invoice->sum
                     && !empty($this->deliverable)) {
                     $deliverable = new org_openpsa_sales_salesproject_deliverable_dba($this->deliverable);
                     self::update_deliverable($deliverable);
@@ -135,7 +135,7 @@ 
 
         if ($invoiced != $deliverable->invoiced) {
             $deliverable->invoiced = $invoiced;
-            if (   $deliverable->orgOpenpsaObtype !== org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
+            if ($deliverable->orgOpenpsaObtype !== org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
                 && $deliverable->state < org_openpsa_sales_salesproject_deliverable_dba::STATE_INVOICED) {
                 $deliverable->state = org_openpsa_sales_salesproject_deliverable_dba::STATE_INVOICED;
             }

lib/midcom/helper/metadata.php

Spacing +7 added lines, -7 removed lines

@@ -254,7 +254,7 @@ 
     {
         if (in_array($key, $this->field_config['timebased'])) {
             // This is ugly, but seems the only possible way...
-            if (   isset($this->__metadata->$key)
+            if (isset($this->__metadata->$key)
                 && (string) $this->__metadata->$key !== "0001-01-01T00:00:00+00:00") {
                 return (int) $this->__metadata->$key->format('U');
             }
@@ -315,11 +315,11 @@ 
         }
 
         $now = time();
-        if (   $this->get('schedulestart')
+        if ($this->get('schedulestart')
             && $this->get('schedulestart') > $now) {
             return false;
         }
-        if (   $this->get('scheduleend')
+        if ($this->get('scheduleend')
             && $this->get('scheduleend') < $now) {
             return false;
         }
@@ -335,9 +335,9 @@ 
     public function is_object_visible_onsite() : bool
     {
         return
-        (   (   midcom::get()->config->get('show_hidden_objects')
+        ((midcom::get()->config->get('show_hidden_objects')
              || $this->is_visible())
-         && (   midcom::get()->config->get('show_unapproved_objects')
+         && (midcom::get()->config->get('show_unapproved_objects')
              || $this->is_approved())
         );
     }
@@ -394,7 +394,7 @@ 
             $guid = $source;
         }
 
-        if (   $object === null
+        if ($object === null
             && mgd_is_guid($guid)) {
             try {
                 $object = midcom::get()->dbfactory->get_object_by_guid($guid);
@@ -453,7 +453,7 @@ 
      */
     public function can_unlock() : bool
     {
-        return (   midcom::get()->auth->user?->guid == $this->__object->metadata->locker
+        return (midcom::get()->auth->user?->guid == $this->__object->metadata->locker
                 || $this->__object->can_do('midcom:unlock')
                 || midcom::get()->auth->can_user_do('midcom:unlock', class: midcom_services_auth::class));
     }

lib/midgard/admin/asgard/plugin.php

Spacing +3 added lines, -3 removed lines

@@ -142,7 +142,7 @@ 
 
         $parent = $object->get_parent();
 
-        if (   $object instanceof midcom_db_parameter
+        if ($object instanceof midcom_db_parameter
             && !empty($parent->guid)) {
             // Add "parameters" list to breadcrumb if we're in a param
             $breadcrumb[] = [
@@ -152,7 +152,7 @@ 
         }
 
         $i = 0;
-        while (   !empty($parent->guid)
+        while (!empty($parent->guid)
                && $i < 10) {
             $i++;
             $parent_reflector = midcom_helper_reflector::get($parent);
@@ -259,7 +259,7 @@ 
     {
         static $preferences = [];
 
-        if (   !array_key_exists($preference, $preferences)
+        if (!array_key_exists($preference, $preferences)
             && $person = midcom::get()->auth->user?->get_storage()) {
             $preferences[$preference] = $person->get_parameter('midgard.admin.asgard:preferences', $preference);
         }

lib/net/nehmer/blog/handler/feed.php

Spacing +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
 
         if ($category) {
             // This is not a predefined category from configuration, check if site maintainer allows us to show it
-            if (   !in_array($category, $data['categories'])
+            if (!in_array($category, $data['categories'])
                 && !$this->_config->get('categories_custom_enable')) {
                 throw new midcom_error('Custom category support is disabled');
             }

lib/net/nehmer/blog/handler/create.php

Spacing +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
         $this->_topic->require_do('midgard:create');
 
         $schemadb = $data['schemadb'];
-        if (   $this->_config->get('simple_name_handling')
+        if ($this->_config->get('simple_name_handling')
             && !midcom::get()->auth->can_user_do('midcom:urlname')) {
             foreach ($schemadb->all() as $schema) {
                 $schema->get_field('name')['readonly'] = true;

lib/net/nehmer/blog/style/feeds-item.php

Spacing +2 added lines, -2 removed lines

@@ -17,7 +17,7 @@ 
 
 $item->title = $data['article']->title;
 
-if (   $data['config']->get('link_to_external_url')
+if ($data['config']->get('link_to_external_url')
     && !empty($data['article']->url)) {
     $item->link = $data['article']->url;
 } else {
@@ -33,7 +33,7 @@ 
     $item->description .= '<div class="abstract">' . $view['abstract'] . '</div>';
 }
 
-if (   array_key_exists('image', $view)
+if (array_key_exists('image', $view)
     && $data['config']->get('rss_use_image')) {
     $item->description .= "\n<div class=\"image\">" . $view['image'] . '</div>';
 }

lib/org/openpsa/reports/handler/base.php

Spacing +1 added lines, -1 removed lines

@@ -75,7 +75,7 @@
             $data['query'] = new org_openpsa_reports_query_dba($guid);
             $data['query']->require_do('midgard:update');
         } else {
-            $data['query']= new org_openpsa_reports_query_dba();
+            $data['query'] = new org_openpsa_reports_query_dba();
             $data['query']->component = $this->_component;
         }
 

lib/net/nemein/redirector/handler/redirect.php

Spacing +3 added lines, -3 removed lines

@@ -34,7 +34,7 @@ 
 
         // Catch first the configuration option for showing editing interface instead
         // of redirecting administrators
-        if (   $this->_topic->can_do('net.nemein.redirector:noredirect')
+        if ($this->_topic->can_do('net.nemein.redirector:noredirect')
             && !$this->_config->get('admin_redirection')) {
             return new midcom_response_relocate($this->router->generate('edit', ['tinyurl' => $tinyurl]));
         }
@@ -68,8 +68,8 @@ 
     {
         $data['url'] = net_nemein_redirector_viewer::topic_links_to($this->_config);
 
-        if (   $this->_config->get('redirection_type') !== null
-            && (   !$this->_topic->can_do('net.nemein.redirector:noredirect')
+        if ($this->_config->get('redirection_type') !== null
+            && (!$this->_topic->can_do('net.nemein.redirector:noredirect')
                 || $this->_config->get('admin_redirection'))) {
             return $this->redirect($data['url']);
         }

lib/net/nehmer/static/viewer.php

Spacing +1 added lines, -1 removed lines

@@ -54,7 +54,7 @@
             }
         }
 
-        if (   $this->_topic->can_do('midgard:update')
+        if ($this->_topic->can_do('midgard:update')
             && $this->_topic->can_do('midcom:component_config')) {
                 $buttons[] = $workflow->get_button($this->router->generate('config'), [
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n_midcom->get('component configuration'),