@@ -6,6 +6,6 @@ |
||
| 6 | 6 | &(view["content"]:h); |
| 7 | 7 | <?php |
| 8 | 8 | } else { |
| 9 | - echo "<p class=\"stub\">" . $data['l10n']->get('this page is stub')."</p>"; |
|
| 9 | + echo "<p class=\"stub\">" . $data['l10n']->get('this page is stub') . "</p>"; |
|
| 10 | 10 | } |
| 11 | 11 | ?> |
| 12 | 12 | \ No newline at end of file |
@@ -34,7 +34,7 @@ |
||
| 34 | 34 | <div class="value"><?php echo $formatter->date($invoice->deliverydate); ?></div></div> |
| 35 | 35 | <?php } ?> |
| 36 | 36 | |
| 37 | - <div class="field"><div class="title"><?php echo $data['l10n_midcom']->get('description');?>: </div> |
|
| 37 | + <div class="field"><div class="title"><?php echo $data['l10n_midcom']->get('description'); ?>: </div> |
|
| 38 | 38 | <div class="description value">&(view['description']:h);</div></div> |
| 39 | 39 | |
| 40 | 40 | <?php |
@@ -46,7 +46,7 @@ |
||
| 46 | 46 | <?php |
| 47 | 47 | //index is needed for sorting |
| 48 | 48 | echo "'index_name',"; |
| 49 | - echo "'" . $data['l10n']->get('entry title') ."',"; |
|
| 49 | + echo "'" . $data['l10n']->get('entry title') . "',"; |
|
| 50 | 50 | echo "'" . $data['l10n']->get('entry text') . "',"; |
| 51 | 51 | echo "'" . $data['l10n']->get('entry created') . "',"; |
| 52 | 52 | echo "'index_creator', '" . $data['l10n_midcom']->get('creator') . "',"; |
@@ -98,13 +98,13 @@ discard block |
||
| 98 | 98 | } |
| 99 | 99 | |
| 100 | 100 | $mimetype = $request->request->get('midgard_admin_asgard_mimetype'); |
| 101 | - if ( !empty($mimetype) |
|
| 101 | + if (!empty($mimetype) |
|
| 102 | 102 | && $local_file->mimetype != $mimetype) { |
| 103 | 103 | $local_file->mimetype = $mimetype; |
| 104 | 104 | $needs_update = true; |
| 105 | 105 | } |
| 106 | 106 | |
| 107 | - if ( $needs_update |
|
| 107 | + if ($needs_update |
|
| 108 | 108 | && !$local_file->update()) { |
| 109 | 109 | return null; |
| 110 | 110 | } |
@@ -234,7 +234,7 @@ discard block |
||
| 234 | 234 | $this->bind_view_to_object($this->_file); |
| 235 | 235 | |
| 236 | 236 | $filename = $this->_process_form($request); |
| 237 | - if ( $filename |
|
| 237 | + if ($filename |
|
| 238 | 238 | && $filename != $data['filename']) { |
| 239 | 239 | return $this->relocate_to_file($filename); |
| 240 | 240 | } |
@@ -405,7 +405,7 @@ |
||
| 405 | 405 | { |
| 406 | 406 | // Complete fields |
| 407 | 407 | $this->indexed = time(); |
| 408 | - if ( $this->author == '' |
|
| 408 | + if ($this->author == '' |
|
| 409 | 409 | && isset($this->creator->name)) { |
| 410 | 410 | $this->author = $this->creator->name; |
| 411 | 411 | } |
@@ -88,7 +88,7 @@ discard block |
||
| 88 | 88 | $dup = $this->check_duplicate($results, $result, $conf['duplicate_check']); |
| 89 | 89 | |
| 90 | 90 | if ($dup !== true) { |
| 91 | - if ( !is_object($dup) |
|
| 91 | + if (!is_object($dup) |
|
| 92 | 92 | || !array_key_exists($dup->id, $todelete)) { |
| 93 | 93 | $todelete[$result->id] = $result; |
| 94 | 94 | } |
@@ -97,7 +97,7 @@ discard block |
||
| 97 | 97 | } |
| 98 | 98 | } |
| 99 | 99 | } |
| 100 | - if ( $needs_update |
|
| 100 | + if ($needs_update |
|
| 101 | 101 | && !$result->update()) { |
| 102 | 102 | throw new midcom_error("Failed to update {$classname} #{$result->id}, errstr: " . midcom_connection::get_error_string()); |
| 103 | 103 | } |
@@ -145,7 +145,7 @@ discard block |
||
| 145 | 145 | } |
| 146 | 146 | |
| 147 | 147 | foreach ($results as $result) { |
| 148 | - if ( $result->$field === $object->$field |
|
| 148 | + if ($result->$field === $object->$field |
|
| 149 | 149 | && $result->id !== $object->id) { |
| 150 | 150 | return $result; |
| 151 | 151 | } |
@@ -163,7 +163,7 @@ discard block |
||
| 163 | 163 | $changed = false; |
| 164 | 164 | foreach ($person2 as $property => $value) { |
| 165 | 165 | // Copy only simple properties not marked to be skipped missing from person1 |
| 166 | - if ( !empty($person2->$property) |
|
| 166 | + if (!empty($person2->$property) |
|
| 167 | 167 | && empty($person1->$property) |
| 168 | 168 | && !isset($skip_properties[$property]) |
| 169 | 169 | && is_scalar($value)) { |
@@ -28,7 +28,7 @@ |
||
| 28 | 28 | |
| 29 | 29 | public function is_readable_by(string $user_id) : bool |
| 30 | 30 | { |
| 31 | - return ( empty($this->object) |
|
| 31 | + return (empty($this->object) |
|
| 32 | 32 | || !$this->guid |
| 33 | 33 | || !$user_id |
| 34 | 34 | || midcom::get()->auth->acl->can_do_byguid('midgard:read', $this->guid, $this->object->__midcom_class_name__, $user_id)); |
@@ -28,7 +28,7 @@ |
||
| 28 | 28 | |
| 29 | 29 | public function is_readable_by(string $user_id) : bool |
| 30 | 30 | { |
| 31 | - return ( !$user_id |
|
| 31 | + return (!$user_id |
|
| 32 | 32 | || !$this->guid |
| 33 | 33 | || midcom::get()->auth->acl->can_do_byguid('midgard:read', $this->guid, midcom_db_topic::class, $user_id)); |
| 34 | 34 | } |
@@ -137,7 +137,7 @@ discard block |
||
| 137 | 137 | { |
| 138 | 138 | debug_add("task->start() called with user #" . midcom_connection::get_user()); |
| 139 | 139 | //PONDER: Check actual status objects for more accurate logic ? |
| 140 | - if ( $task->status >= org_openpsa_projects_task_status_dba::STARTED |
|
| 140 | + if ($task->status >= org_openpsa_projects_task_status_dba::STARTED |
|
| 141 | 141 | && $task->status <= org_openpsa_projects_task_status_dba::APPROVED) { |
| 142 | 142 | //We already have started status |
| 143 | 143 | debug_add('Task has already been started'); |
@@ -318,7 +318,7 @@ discard block |
||
| 318 | 318 | |
| 319 | 319 | private static function is_manager(org_openpsa_projects_task_dba $task) : bool |
| 320 | 320 | { |
| 321 | - return ( $task->manager == 0 |
|
| 321 | + return ($task->manager == 0 |
|
| 322 | 322 | || midcom_connection::get_user() == $task->manager); |
| 323 | 323 | } |
| 324 | 324 | } |