flack / openpsa

src/midcom/routing/parser.php

Spacing +2 added lines, -2 removed lines

@@ -46,7 +46,7 @@ 
         $url = $this->context->get_key(MIDCOM_CONTEXT_URI);
 
         $prefix_length = strlen(midcom_connection::get_url('prefix'));
-        if (   $prefix_length > 1
+        if ($prefix_length > 1
             && str_starts_with($url, midcom_connection::get_url('prefix'))) {
             $url = substr($url, $prefix_length);
         }
@@ -71,7 +71,7 @@ 
      */
     public function find_urlmethod() : ?string
     {
-        if (   empty($this->argv)
+        if (empty($this->argv)
             || !str_starts_with($this->argv[0], 'midcom-')) {
             return null;
         }

src/midcom/datamanager/extension/transformer/imageTransformer.php

Spacing +1 added lines, -1 removed lines

@@ -47,7 +47,7 @@
         }
 
         $result = [];
-        if (   !empty($array['file'])
+        if (!empty($array['file'])
             || !empty($array['identifier']) && str_starts_with($array['identifier'], 'tmpfile-')) {
             $result['file'] = parent::reverseTransform($array);
         } elseif (!empty($array['objects'])) {

lib/midgard/admin/asgard/handler/welcome.php

Spacing +2 added lines, -2 removed lines

@@ -33,7 +33,7 @@ 
                 $qb = new midcom_core_querybuilder($midcom_dba_classname);
                 $qb->add_constraint('metadata.revised', '>=', $since);
 
-                if (   $only_mine
+                if ($only_mine
                     && midcom::get()->auth->user) {
                     $qb->add_constraint('metadata.authors', 'LIKE', '|' . midcom::get()->auth->user->guid . '|');
                 }
@@ -198,7 +198,7 @@ 
                 continue;
             }
 
-            if (   $object->can_do('midgard:update')
+            if ($object->can_do('midgard:update')
                 && $object->can_do('midcom:approve')) {
                 $object->metadata->approve();
                 midcom::get()->uimessages->add($this->_l10n->get('midgard.admin.asgard'), sprintf($this->_l10n->get('object %s approved'), $object->guid));

lib/org/openpsa/calendar/event/member.php

Spacing +3 added lines, -3 removed lines

@@ -68,7 +68,7 @@ 
             $event = new org_openpsa_calendar_event_dba($this->eid);
         }
 
-        if (    $recipient->id == midcom_connection::get_user()
+        if ($recipient->id == midcom_connection::get_user()
              && !$event->send_notify_me) {
             //Do not send notification to current user
             debug_add('event->send_notify_me is false and recipient is current user, aborting notify');
@@ -194,7 +194,7 @@ 
 
             if (isset($events_by_date[$ymd])) {
                 foreach ($events_by_date[$ymd] as $event) {
-                    if (   $event->end <= $workday_starts_ts
+                    if ($event->end <= $workday_starts_ts
                         || $event->start >= $workday_ends_ts) {
                         // We need not consider this event, it is outside the defined workday
                         continue;
@@ -212,7 +212,7 @@ 
                 }
             }
             // End of day slot
-            if (   $last_end_time < $workday_ends_ts
+            if ($last_end_time < $workday_ends_ts
                 && (($workday_ends_ts - $last_end_time) >= $amount)) {
                 $slots[] = self::_create_slot($last_end_time, $workday_ends_ts, $last_event);
             }

lib/org/openpsa/invoices/handler/billingdata.php

Spacing +2 added lines, -2 removed lines

@@ -30,7 +30,7 @@ 
     private function load_controller(org_openpsa_invoices_billing_data_dba $bd) : controller
     {
         $schemadb = schemadb::from_path($this->_config->get('schemadb_billing_data'));
-        $vat =& $schemadb->get('default')->get_field('vat');
+        $vat = & $schemadb->get('default')->get_field('vat');
         // Fill VAT select
         if ($options = $this->get_vat_options($this->_config->get('vat_percentages'))) {
             $vat['type_config']['options'] = $options;
@@ -68,7 +68,7 @@ 
         $data['controller'] = $this->load_controller($bd);
 
         $workflow = $this->get_workflow('datamanager', ['controller' => $data['controller']]);
-        if (   $mode == 'edit'
+        if ($mode == 'edit'
             && $bd->can_do('midgard:delete')) {
             $delete = $this->get_workflow('delete', [
                 'object' => $bd,

lib/org/openpsa/notifications/notifier/email.php

Spacing +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
             $mail->from = $config->get('default_sender') ?: '"OpenPSA Notifier" <noreply@' . $_SERVER['SERVER_NAME'] . '>';
         }
 
-        $mail->subject = $message['title'] ??  'org.openpsa.notifications message (no title provided)';
+        $mail->subject = $message['title'] ?? 'org.openpsa.notifications message (no title provided)';
         if (array_key_exists('attachments', $message)) {
             $mail->attachments = $message['attachments'];
         }

lib/midcom/helper/metadata.php

Spacing +9 added lines, -9 removed lines

@@ -292,7 +292,7 @@ 
     {
         if (in_array($key, $this->field_config['timebased'])) {
             // This is ugly, but seems the only possible way...
-            if (   isset($this->__metadata->$key)
+            if (isset($this->__metadata->$key)
                 && (string) $this->__metadata->$key !== "0001-01-01T00:00:00+00:00") {
                 return (int) $this->__metadata->$key->format('U');
             }
@@ -354,11 +354,11 @@ 
         }
 
         $now = time();
-        if (   $this->get('schedulestart')
+        if ($this->get('schedulestart')
             && $this->get('schedulestart') > $now) {
             return false;
         }
-        if (   $this->get('scheduleend')
+        if ($this->get('scheduleend')
             && $this->get('scheduleend') < $now) {
             return false;
         }
@@ -374,9 +374,9 @@ 
     public function is_object_visible_onsite() : bool
     {
         return
-        (   (   midcom::get()->config->get('show_hidden_objects')
+        ((midcom::get()->config->get('show_hidden_objects')
              || $this->is_visible())
-         && (   midcom::get()->config->get('show_unapproved_objects')
+         && (midcom::get()->config->get('show_unapproved_objects')
              || $this->is_approved())
         );
     }
@@ -434,7 +434,7 @@ 
             $guid = $source;
         }
 
-        if (   $object === null
+        if ($object === null
             && mgd_is_guid($guid)) {
             try {
                 $object = midcom::get()->dbfactory->get_object_by_guid($guid);
@@ -467,7 +467,7 @@ 
         }
 
         // Lock was created by the user, return "not locked"
-        if (   !empty(midcom::get()->auth->user->guid)
+        if (!empty(midcom::get()->auth->user->guid)
             && $this->get('locker') === midcom::get()->auth->user->guid) {
             return false;
         }
@@ -500,7 +500,7 @@ 
      */
     public function can_unlock() : bool
     {
-        return (   $this->__object->can_do('midcom:unlock')
+        return ($this->__object->can_do('midcom:unlock')
                 || midcom::get()->auth->can_user_do('midcom:unlock', null, midcom_services_auth::class));
     }
 
@@ -511,7 +511,7 @@ 
      */
     public function unlock() : bool
     {
-        if (   $this->can_unlock()
+        if ($this->can_unlock()
             && $this->__object->unlock()) {
             $this->_cache = [];
             return true;

lib/midcom/services/auth/frontend/form.php

Spacing +2 added lines, -2 removed lines

@@ -40,7 +40,7 @@ 
      */
     public function read_login_data(Request $request) : ?array
     {
-        if (   !$request->request->has('midcom_services_auth_frontend_form_submit')
+        if (!$request->request->has('midcom_services_auth_frontend_form_submit')
             || !$request->request->has('username')
             || !$request->request->has('password')) {
             return null;
@@ -76,7 +76,7 @@ 
     {
         // Store the submitted form if the session expired, but user wants to save the data
         if (!empty($_POST)) {
-            $data =& midcom_core_context::get()->get_custom_key('request_data');
+            $data = & midcom_core_context::get()->get_custom_key('request_data');
 
             $data['restored_form_data'] = [];
 

lib/net/nemein/wiki/midcom/interfaces.php

Spacing +1 added lines, -1 removed lines

@@ -44,7 +44,7 @@
 
     public function resolve_object_link(midcom_db_topic $topic, midcom_core_dbaobject $object) : ?string
     {
-        if (   $object instanceof midcom_db_article
+        if ($object instanceof midcom_db_article
             && $topic->id == $object->topic) {
             if ($object->name == 'index') {
                 return '';